Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Suraj Kandpal <suraj.kandpal@intel.com>
To: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: ankit.k.nautiyal@intel.com, arun.r.murthy@intel.com,
	Suraj Kandpal <suraj.kandpal@intel.com>
Subject: [PATCH 5/8] drm/i915/backlight: Short circuit intel_dp_aux_supports_hdr_backlight
Date: Fri, 20 Feb 2026 10:32:14 +0530	[thread overview]
Message-ID: <20260220050217.2453681-6-suraj.kandpal@intel.com> (raw)
In-Reply-To: <20260220050217.2453681-1-suraj.kandpal@intel.com>

intel_dp_aux_supports_hdr_backlight() prints debug message for
intel HDR backlight version. This is fine when dealing with eDP 1.4b
and lower. When we are talking about eDP 1.5 it causes confusion in
logs since we need to use VESA AUX backlight functions but this
print causes confusion as to which path code take.
Short circuit this function with a eDP version check. Make sure this
is only called if eDP <= 1.4b

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
index a921bb4ccacf..c7143869bafd 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
@@ -701,8 +701,8 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *connector)
 	 * backlight interface at all. This means that the only sensible way for us to detect both
 	 * interfaces is to probe for Intel's first, and VESA's second.
 	 */
-	if (try_intel_interface && intel_dp_aux_supports_hdr_backlight(connector) &&
-	    intel_dp->edp_dpcd[0] <= DP_EDP_14b) {
+	if (try_intel_interface && intel_dp->edp_dpcd[0] <= DP_EDP_14b &&
+	    intel_dp_aux_supports_hdr_backlight(connector)) {
 		drm_dbg_kms(dev, "[CONNECTOR:%d:%s] Using Intel proprietary eDP backlight controls\n",
 			    connector->base.base.id, connector->base.name);
 		panel->backlight.funcs = &intel_dp_hdr_bl_funcs;
-- 
2.34.1


  parent reply	other threads:[~2026-02-20  5:02 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-20  5:02 [PATCH 0/8] Fixes and updates when using AUX backlight using Luminance Suraj Kandpal
2026-02-20  5:02 ` [PATCH 1/8] drm/i915/backlight: Avoid 0 brightness for VESA AUX backlight by default Suraj Kandpal
2026-02-24  2:50   ` Murthy, Arun R
2026-02-20  5:02 ` [PATCH 2/8] drm/i915/backlight: Use intel_panel variable instead of intel_connector Suraj Kandpal
2026-02-24  2:52   ` Murthy, Arun R
2026-02-20  5:02 ` [PATCH 3/8] drm/i915/backlight: Take luminance_set into account for VESA backlight Suraj Kandpal
2026-02-24  2:54   ` Murthy, Arun R
2026-02-20  5:02 ` [PATCH 4/8] drm/i915/backlight: Check luminance_set when disabling PWM via AUX " Suraj Kandpal
2026-02-24  2:55   ` Murthy, Arun R
2026-02-20  5:02 ` Suraj Kandpal [this message]
2026-02-24  2:57   ` [PATCH 5/8] drm/i915/backlight: Short circuit intel_dp_aux_supports_hdr_backlight Murthy, Arun R
2026-02-20  5:02 ` [PATCH 6/8] drm/i915/backlight: Update debug log during backlight setup Suraj Kandpal
2026-02-23  7:05   ` Garg, Nemesa
2026-02-23  8:11     ` Kandpal, Suraj
2026-02-23  9:29       ` Garg, Nemesa
2026-02-24  3:03   ` Murthy, Arun R
2026-02-20  5:02 ` [PATCH 7/8] drm/i915/backlight: Provide clear description on how backlight level is controlled Suraj Kandpal
2026-02-24  3:05   ` Murthy, Arun R
2026-02-24  3:20     ` Kandpal, Suraj
2026-02-24  3:22       ` Murthy, Arun R
2026-02-20  5:02 ` [PATCH 8/8] drm/i915/backlight: Avoid 0 brightness for INTEL AUX HDR backlight by default Suraj Kandpal
2026-02-24  3:06   ` Murthy, Arun R
2026-02-20  5:46 ` ✓ CI.KUnit: success for Fixes and updates when using AUX backlight using Luminance (rev2) Patchwork
2026-02-20  9:19 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-20 19:32 ` ✗ Xe.CI.FULL: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2026-02-13  9:16 [PATCH 0/8] Fixes and updates when using AUX backlight using Luminance Suraj Kandpal
2026-02-13  9:16 ` [PATCH 5/8] drm/i915/backlight: Short circuit intel_dp_aux_supports_hdr_backlight Suraj Kandpal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260220050217.2453681-6-suraj.kandpal@intel.com \
    --to=suraj.kandpal@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=arun.r.murthy@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox