Re: [PATCH] drm/xe: Properly handle alloc_guc_id() failure

[Nirmoy Das <nirmoy.das@linux.intel.com>]

On 5/21/2024 9:37 PM, Niranjana Vishwanathapura wrote:
> Release the submission_state lock if alloc_guc_id() fails.
>
> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>

Wow, this goes all the way back. Make sense to add below tags

Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")

Cc: <stable@vger.kernel.org> # v6.8+

Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>

> ---
>   drivers/gpu/drm/xe/xe_guc_submit.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index ad2b8067d071..c0b901c5565b 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -1304,6 +1304,7 @@ static int guc_exec_queue_init(struct xe_exec_queue *q)
>   	return 0;
>   
>   err_entity:
> +	mutex_unlock(&guc->submission_state.lock);
>   	xe_sched_entity_fini(&ge->entity);
>   err_sched:
>   	xe_sched_fini(&ge->sched);