* [PATCH] drm/xe: Properly handle alloc_guc_id() failure
@ 2024-05-21 19:37 Niranjana Vishwanathapura
2024-05-21 20:06 ` Matthew Brost
2024-05-21 20:07 ` Nirmoy Das
0 siblings, 2 replies; 5+ messages in thread
From: Niranjana Vishwanathapura @ 2024-05-21 19:37 UTC (permalink / raw)
To: intel-xe
Release the submission_state lock if alloc_guc_id() fails.
Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
---
drivers/gpu/drm/xe/xe_guc_submit.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index ad2b8067d071..c0b901c5565b 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -1304,6 +1304,7 @@ static int guc_exec_queue_init(struct xe_exec_queue *q)
return 0;
err_entity:
+ mutex_unlock(&guc->submission_state.lock);
xe_sched_entity_fini(&ge->entity);
err_sched:
xe_sched_fini(&ge->sched);
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/xe: Properly handle alloc_guc_id() failure
2024-05-21 19:37 [PATCH] drm/xe: Properly handle alloc_guc_id() failure Niranjana Vishwanathapura
@ 2024-05-21 20:06 ` Matthew Brost
2024-05-21 20:07 ` Nirmoy Das
1 sibling, 0 replies; 5+ messages in thread
From: Matthew Brost @ 2024-05-21 20:06 UTC (permalink / raw)
To: Niranjana Vishwanathapura; +Cc: intel-xe
On Tue, May 21, 2024 at 12:37:39PM -0700, Niranjana Vishwanathapura wrote:
> Release the submission_state lock if alloc_guc_id() fails.
>
Fixes tag and CC stable kernel?
With new tags:
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> ---
> drivers/gpu/drm/xe/xe_guc_submit.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index ad2b8067d071..c0b901c5565b 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -1304,6 +1304,7 @@ static int guc_exec_queue_init(struct xe_exec_queue *q)
> return 0;
>
> err_entity:
> + mutex_unlock(&guc->submission_state.lock);
> xe_sched_entity_fini(&ge->entity);
> err_sched:
> xe_sched_fini(&ge->sched);
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/xe: Properly handle alloc_guc_id() failure
2024-05-21 19:37 [PATCH] drm/xe: Properly handle alloc_guc_id() failure Niranjana Vishwanathapura
2024-05-21 20:06 ` Matthew Brost
@ 2024-05-21 20:07 ` Nirmoy Das
1 sibling, 0 replies; 5+ messages in thread
From: Nirmoy Das @ 2024-05-21 20:07 UTC (permalink / raw)
To: Niranjana Vishwanathapura, intel-xe
On 5/21/2024 9:37 PM, Niranjana Vishwanathapura wrote:
> Release the submission_state lock if alloc_guc_id() fails.
>
> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Wow, this goes all the way back. Make sense to add below tags
Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Cc: <stable@vger.kernel.org> # v6.8+
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> drivers/gpu/drm/xe/xe_guc_submit.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index ad2b8067d071..c0b901c5565b 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -1304,6 +1304,7 @@ static int guc_exec_queue_init(struct xe_exec_queue *q)
> return 0;
>
> err_entity:
> + mutex_unlock(&guc->submission_state.lock);
> xe_sched_entity_fini(&ge->entity);
> err_sched:
> xe_sched_fini(&ge->sched);
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] drm/xe: Properly handle alloc_guc_id() failure
@ 2024-05-21 20:12 Niranjana Vishwanathapura
2024-05-21 20:26 ` Randhawa, Jagmeet
0 siblings, 1 reply; 5+ messages in thread
From: Niranjana Vishwanathapura @ 2024-05-21 20:12 UTC (permalink / raw)
To: intel-xe
Release the submission_state lock if alloc_guc_id() fails.
Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Cc: <stable@vger.kernel.org> # v6.8+
Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
---
drivers/gpu/drm/xe/xe_guc_submit.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index ad2b8067d071..c0b901c5565b 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -1304,6 +1304,7 @@ static int guc_exec_queue_init(struct xe_exec_queue *q)
return 0;
err_entity:
+ mutex_unlock(&guc->submission_state.lock);
xe_sched_entity_fini(&ge->entity);
err_sched:
xe_sched_fini(&ge->sched);
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/xe: Properly handle alloc_guc_id() failure
2024-05-21 20:12 Niranjana Vishwanathapura
@ 2024-05-21 20:26 ` Randhawa, Jagmeet
0 siblings, 0 replies; 5+ messages in thread
From: Randhawa, Jagmeet @ 2024-05-21 20:26 UTC (permalink / raw)
To: Niranjana Vishwanathapura, intel-xe
[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]
On 5/21/2024 1:12 PM, Niranjana Vishwanathapura wrote:
> Release the submission_state lock if alloc_guc_id() fails.
>
> Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
>
> Cc:<stable@vger.kernel.org> # v6.8+
> Signed-off-by: Niranjana Vishwanathapura<niranjana.vishwanathapura@intel.com>
> Reviewed-by: Nirmoy Das<nirmoy.das@intel.com>
> Reviewed-by: Matthew Brost<matthew.brost@intel.com>
> ---
> drivers/gpu/drm/xe/xe_guc_submit.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index ad2b8067d071..c0b901c5565b 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -1304,6 +1304,7 @@ static int guc_exec_queue_init(struct xe_exec_queue *q)
> return 0;
>
> err_entity:
> + mutex_unlock(&guc->submission_state.lock);
> xe_sched_entity_fini(&ge->entity);
> err_sched:
> xe_sched_fini(&ge->sched);
Reviewed-by: Jagmeet Randhawa <jagmeet.randhawa@intel.com>
[-- Attachment #2: Type: text/html, Size: 2048 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-21 20:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-21 19:37 [PATCH] drm/xe: Properly handle alloc_guc_id() failure Niranjana Vishwanathapura
2024-05-21 20:06 ` Matthew Brost
2024-05-21 20:07 ` Nirmoy Das
-- strict thread matches above, loose matches on Subject: below --
2024-05-21 20:12 Niranjana Vishwanathapura
2024-05-21 20:26 ` Randhawa, Jagmeet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox