Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v2] drm/xe/configfs: Fix 'parameter name omitted' errors
Date: Tue, 3 Feb 2026 21:38:28 +0100	[thread overview]
Message-ID: <a887ee18-b652-422b-92c5-5faf15f09cb4@intel.com> (raw)
In-Reply-To: <aYJSCAepz3ORravX@intel.com>



On 2/3/2026 8:52 PM, Rodrigo Vivi wrote:
> On Tue, Feb 03, 2026 at 08:37:45PM +0100, Michal Wajdeczko wrote:
>> On some configs and old compilers we can get following build errors:
>>
>>   ../drivers/gpu/drm/xe/xe_configfs.h: In function 'xe_configfs_get_ctx_restore_mid_bb':
>>   ../drivers/gpu/drm/xe/xe_configfs.h:40:76: error: parameter name omitted
>>    static inline u32 xe_configfs_get_ctx_restore_mid_bb(struct pci_dev *pdev, enum xe_engine_class,
>>                                                                             ^~~~~~~~~~~~~~~~~~~~
>>   ../drivers/gpu/drm/xe/xe_configfs.h: In function 'xe_configfs_get_ctx_restore_post_bb':
>>   ../drivers/gpu/drm/xe/xe_configfs.h:42:77: error: parameter name omitted
>>    static inline u32 xe_configfs_get_ctx_restore_post_bb(struct pci_dev *pdev, enum xe_engine_class,
>>                                                                              ^~~~~~~~~~~~~~~~~~~~
>> when trying to define our configfs stub functions. Fix that.
> 
> only when trying to define the sutbs?

stubs are real fn definitions, while fn declarations have relaxed requirements

> anyway,
> 
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

thanks!



  reply	other threads:[~2026-02-03 20:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03 19:37 [PATCH v2] drm/xe/configfs: Fix 'parameter name omitted' errors Michal Wajdeczko
2026-02-03 19:43 ` ✗ CI.checkpatch: warning for " Patchwork
2026-02-03 19:45 ` ✓ CI.KUnit: success " Patchwork
2026-02-03 19:52 ` [PATCH v2] " Rodrigo Vivi
2026-02-03 20:38   ` Michal Wajdeczko [this message]
2026-02-03 20:33 ` ✗ Xe.CI.BAT: failure for " Patchwork
2026-02-03 21:42 ` [PATCH v2] " Lin, Shuicheng
2026-02-04 10:38 ` ✗ Xe.CI.FULL: failure for " Patchwork
2026-02-04 21:52 ` ✗ CI.checkpatch: warning for drm/xe/configfs: Fix 'parameter name omitted' errors (rev2) Patchwork
2026-02-04 21:53 ` ✓ CI.KUnit: success " Patchwork
2026-02-04 22:26 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-05 11:53 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a887ee18-b652-422b-92c5-5faf15f09cb4@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox