Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Do not print engine reset message on a killed queue
@ 2025-05-08 19:09 Matthew Brost
  2025-05-08 19:15 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (13 more replies)
  0 siblings, 14 replies; 19+ messages in thread
From: Matthew Brost @ 2025-05-08 19:09 UTC (permalink / raw)
  To: intel-xe

When an app is ctrl-c (killed) any queues running on the GPU have their
preemption timeout set to the minimum value and scheduling is disabled.
If the queue has something active on the GPU it is very likely for the
GuC will trigger an engine reset resulting in the engine reset message
being printed when this is fully expected. Do not print the engine reset
message on queues which have been killed.

Reported-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/4904
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_submit.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index 369be36f7dc5..efff462ddd75 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -2005,8 +2005,9 @@ int xe_guc_exec_queue_reset_handler(struct xe_guc *guc, u32 *msg, u32 len)
 	if (unlikely(!q))
 		return -EPROTO;
 
-	xe_gt_info(gt, "Engine reset: engine_class=%s, logical_mask: 0x%x, guc_id=%d",
-		   xe_hw_engine_class_to_str(q->class), q->logical_mask, guc_id);
+	if (!exec_queue_killed(q))
+		xe_gt_info(gt, "Engine reset: engine_class=%s, logical_mask: 0x%x, guc_id=%d",
+			   xe_hw_engine_class_to_str(q->class), q->logical_mask, guc_id);
 
 	trace_xe_exec_queue_reset(q);
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2025-05-26 19:18 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-08 19:09 [PATCH] drm/xe: Do not print engine reset message on a killed queue Matthew Brost
2025-05-08 19:15 ` ✓ CI.Patch_applied: success for " Patchwork
2025-05-08 19:15 ` ✓ CI.checkpatch: " Patchwork
2025-05-08 19:16 ` ✓ CI.KUnit: " Patchwork
2025-05-08 19:24 ` ✓ CI.Build: " Patchwork
2025-05-08 19:27 ` ✓ CI.Hooks: " Patchwork
2025-05-08 19:28 ` ✓ CI.checksparse: " Patchwork
2025-05-08 20:25 ` ✓ Xe.CI.BAT: " Patchwork
2025-05-08 21:36 ` [PATCH] " Cavitt, Jonathan
2025-05-08 22:00   ` Matthew Brost
2025-05-09 14:55     ` Cavitt, Jonathan
2025-05-08 23:03 ` John Harrison
2025-05-09  6:03   ` Matthew Brost
2025-05-09 19:13     ` John Harrison
2025-05-09 12:22 ` ✗ Xe.CI.Full: failure for " Patchwork
2025-05-26 19:06 ` ✓ CI.Patch_applied: success " Patchwork
2025-05-26 19:07 ` ✓ CI.checkpatch: " Patchwork
2025-05-26 19:08 ` ✓ CI.KUnit: " Patchwork
2025-05-26 19:18 ` ✓ CI.Build: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox