Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Brost <matthew.brost@intel.com>
To: Matthew Auld <matthew.auld@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, <michal.mrozek@intel.com>,
	<himal.prasad.ghimiray@intel.com>, <francois.dugast@intel.com>,
	<thomas.hellstrom@linux.intel.com>
Subject: Re: [PATCH 0/3] SVM compression fixes
Date: Tue, 15 Jul 2025 09:25:35 -0700	[thread overview]
Message-ID: <aHaA/6lGNVWpcD2M@lstrano-desk.jf.intel.com> (raw)
In-Reply-To: <8c228e08-fb2b-477a-8b8c-0bcc62f098d5@intel.com>

On Tue, Jul 15, 2025 at 01:59:16PM +0100, Matthew Auld wrote:
> On 14/07/2025 18:33, Matthew Brost wrote:
> > Compression is broken for SVM and for devcoredump when reading out BOs.
> 
> For devcoredump case is this the bo_read() call? Does that mean we would
> still run into trouble for < 16K buffers and then also igpu in general?
> 

Yes, we will need some more follow up patches I think.

Let's start here with this series and then fixup remaining devcoredump cases?

Matt

> > 
> > Marking the first two patches as fixes. One option could be to drop
> > patch 1 and proceed with just the last two patches as fixes, if we
> > decide we're confident in SVM with compression.
> > 
> > Tested with [1]. The append memory copy compression sections fail on
> > drm-tip and pass after this series.
> > 
> > Matt
> > 
> > [1] https://patchwork.freedesktop.org/series/151581/
> > 
> > Matthew Brost (3):
> >    drm/xe: Disable compression on SVM
> >    drm/xe: Update xe_migrate_vram to support compression
> >    drm/xe: Enable compressed memory for SVM
> > 
> >   drivers/gpu/drm/xe/xe_migrate.c | 37 ++++++++++++++++++++++++++-------
> >   1 file changed, 30 insertions(+), 7 deletions(-)
> > 
> 

      reply	other threads:[~2025-07-15 16:24 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-14 17:33 [PATCH 0/3] SVM compression fixes Matthew Brost
2025-07-14 17:33 ` [PATCH 1/3] drm/xe: Disable compression on SVM Matthew Brost
2025-07-15  8:15   ` Matthew Auld
2025-07-15  8:26     ` Ghimiray, Himal Prasad
2025-07-15 15:55       ` Matthew Brost
2025-07-15  8:25   ` Ghimiray, Himal Prasad
2025-07-15 15:55     ` Matthew Brost
2025-07-14 17:33 ` [PATCH 2/3] drm/xe: Update xe_migrate_vram to support compression Matthew Brost
2025-07-15  8:37   ` Matthew Auld
2025-07-15  8:49     ` Matthew Auld
2025-07-15 15:58       ` Matthew Brost
2025-07-14 17:33 ` [PATCH 3/3] drm/xe: Enable compressed memory for SVM Matthew Brost
2025-07-14 17:43 ` ✗ CI.checkpatch: warning for SVM compression fixes Patchwork
2025-07-14 17:45 ` ✓ CI.KUnit: success " Patchwork
2025-07-14 18:25 ` ✓ Xe.CI.BAT: " Patchwork
2025-07-14 20:20 ` ✗ Xe.CI.Full: failure " Patchwork
2025-07-15 12:59 ` [PATCH 0/3] " Matthew Auld
2025-07-15 16:25   ` Matthew Brost [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aHaA/6lGNVWpcD2M@lstrano-desk.jf.intel.com \
    --to=matthew.brost@intel.com \
    --cc=francois.dugast@intel.com \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.auld@intel.com \
    --cc=michal.mrozek@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox