From: Raag Jadav <raag.jadav@intel.com>
To: Riana Tauro <riana.tauro@intel.com>
Cc: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
anshuman.gupta@intel.com, rodrigo.vivi@intel.com,
lucas.demarchi@intel.com, aravind.iddamsetty@linux.intel.com,
umesh.nerlige.ramappa@intel.com, frank.scarbrough@intel.com,
sk.anirban@intel.com, simona.vetter@ffwll.ch, airlied@gmail.com
Subject: Re: [PATCH v5 3/9] drm/xe: Add a helper function to set recovery method
Date: Sun, 20 Jul 2025 15:04:42 +0300 [thread overview]
Message-ID: <aHzbWgCMjfoRA_Bu@black.fi.intel.com> (raw)
In-Reply-To: <20250715104730.2109506-4-riana.tauro@intel.com>
On Tue, Jul 15, 2025 at 04:17:23PM +0530, Riana Tauro wrote:
> Add a helper function to set recovery method. The recovery
> method has to be set before declaring the device wedged and sending the
> drm wedged uevent. If no method is set, default unbind/re-bind method
> will be set
...
> /**
> * xe_device_declare_wedged - Declare device wedged
> * @xe: xe device instance
> *
> * This is a final state that can only be cleared with the recovery method
> - * specified in the drm wedged uevent. The default recovery method is
> - * re-probe (unbind + bind).
> + * specified in the drm wedged uevent. The method needs to be set using
'can be' sounds more suitable to me since it's optional.
> + * xe_device_set_wedged_method before declaring the device as wedged or the
> + * default method of reprobe (unbind/re-bind) will be sent
And with punctuations,
Reviewed-by: Raag Jadav <raag.jadav@intel.com>
next prev parent reply other threads:[~2025-07-20 12:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 10:47 [PATCH v5 0/9] Handle Firmware reported Hardware Errors Riana Tauro
2025-07-15 10:47 ` [PATCH v5 1/9] drm: Add a vendor-specific recovery method to device wedged uevent Riana Tauro
2025-07-20 11:47 ` Raag Jadav
2025-07-15 10:47 ` [PATCH v5 2/9] drm/xe: Set GT as wedged before sending " Riana Tauro
2025-07-15 10:47 ` [PATCH v5 3/9] drm/xe: Add a helper function to set recovery method Riana Tauro
2025-07-20 12:04 ` Raag Jadav [this message]
2025-07-15 10:47 ` [PATCH v5 4/9] drm/xe/xe_survivability: Refactor survivability mode Riana Tauro
2025-07-23 14:00 ` Raag Jadav
2025-07-23 14:52 ` Riana Tauro
2025-07-15 10:47 ` [PATCH v5 5/9] drm/xe/xe_survivability: Add support for Runtime " Riana Tauro
2025-07-23 14:08 ` Raag Jadav
2025-07-23 14:41 ` Riana Tauro
2025-07-15 10:47 ` [PATCH v5 6/9] drm/xe/doc: Document device wedged and runtime survivability Riana Tauro
2025-07-23 13:34 ` Raag Jadav
2025-07-24 5:25 ` Riana Tauro
2025-07-15 10:47 ` [PATCH v5 7/9] drm/xe: Add support to handle hardware errors Riana Tauro
2025-07-15 14:08 ` Summers, Stuart
2025-07-15 16:48 ` Riana Tauro
2025-07-15 16:53 ` Summers, Stuart
2025-07-15 10:47 ` [PATCH v5 8/9] drm/xe/xe_hw_error: Handle CSC Firmware reported Hardware errors Riana Tauro
2025-07-15 10:47 ` [PATCH v5 9/9] drm/xe/xe_hw_error: Add fault injection to trigger csc error handler Riana Tauro
2025-07-15 14:10 ` Summers, Stuart
2025-07-15 16:39 ` Riana Tauro
2025-07-15 16:58 ` Summers, Stuart
2025-07-16 4:21 ` Riana Tauro
2025-07-15 12:28 ` ✗ CI.checkpatch: warning for Handle Firmware reported Hardware Errors (rev5) Patchwork
2025-07-15 12:30 ` ✓ CI.KUnit: success " Patchwork
2025-07-15 12:45 ` ✗ CI.checksparse: warning " Patchwork
2025-07-15 13:33 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-07-15 17:13 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHzbWgCMjfoRA_Bu@black.fi.intel.com \
--to=raag.jadav@intel.com \
--cc=airlied@gmail.com \
--cc=anshuman.gupta@intel.com \
--cc=aravind.iddamsetty@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=frank.scarbrough@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona.vetter@ffwll.ch \
--cc=sk.anirban@intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox