Re: [PATCH v1 1/2] drm/xe/i2c: Introduce xe_i2c_irq_present()

[Heikki Krogerus <heikki.krogerus@linux.intel.com>]

On Thu, Sep 25, 2025 at 01:38:34AM +0530, Raag Jadav wrote:
> In preparation of wider usecases which require checking for I2C IRQ
> presence, introduce xe_i2c_irq_present() helper.
> 
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>

FWIW:

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/gpu/drm/xe/xe_i2c.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_i2c.c b/drivers/gpu/drm/xe/xe_i2c.c
> index 48dfcb41fa08..25c6b8f3c0bb 100644
> --- a/drivers/gpu/drm/xe/xe_i2c.c
> +++ b/drivers/gpu/drm/xe/xe_i2c.c
> @@ -160,6 +160,11 @@ bool xe_i2c_present(struct xe_device *xe)
>  	return xe->i2c && xe->i2c->ep.cookie == XE_I2C_EP_COOKIE_DEVICE;
>  }
>  
> +static bool xe_i2c_irq_present(struct xe_device *xe)
> +{
> +	return xe->i2c && xe->i2c->adapter_irq;
> +}
> +
>  /**
>   * xe_i2c_irq_handler: Handler for I2C interrupts
>   * @xe: xe device instance
> @@ -170,7 +175,7 @@ bool xe_i2c_present(struct xe_device *xe)
>   */
>  void xe_i2c_irq_handler(struct xe_device *xe, u32 master_ctl)
>  {
> -	if (!xe->i2c || !xe->i2c->adapter_irq)
> +	if (!xe_i2c_irq_present(xe))
>  		return;
>  
>  	if (master_ctl & I2C_IRQ)
> -- 
> 2.34.1

-- 
heikki