Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] drm/xe/guc: Change outstanding assertion to error
@ 2025-10-17  0:46 Zhanjun Dong
  2025-10-17  0:53 ` ✓ CI.KUnit: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Zhanjun Dong @ 2025-10-17  0:46 UTC (permalink / raw)
  To: intel-xe; +Cc: daniele.ceraolospurio, Zhanjun Dong

GuC CT layer will check GuC to host outstanding counter when changing
state, trigger assertion if the counter is not 0. However, the failed
assertion is expected on fault injection test, change it to error to
make it works with CI system.

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/5466
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/5530
Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_ct.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_ct.c b/drivers/gpu/drm/xe/xe_guc_ct.c
index 18f6327bf552..85416db1563c 100644
--- a/drivers/gpu/drm/xe/xe_guc_ct.c
+++ b/drivers/gpu/drm/xe/xe_guc_ct.c
@@ -436,8 +436,9 @@ static void guc_ct_change_state(struct xe_guc_ct *ct,
 	mutex_lock(&ct->lock);		/* Serialise dequeue_one_g2h() */
 	spin_lock_irq(&ct->fast_lock);	/* Serialise CT fast-path */
 
-	xe_gt_assert(ct_to_gt(ct), ct->g2h_outstanding == 0 ||
-		     state == XE_GUC_CT_STATE_STOPPED);
+	if (ct->g2h_outstanding != 0 && state != XE_GUC_CT_STATE_STOPPED)
+		xe_gt_err(ct_to_gt(ct), "Unexpected outsanding counter:%d on switch state:%d\n",
+			  ct->g2h_outstanding, state);
 
 	if (ct->g2h_outstanding)
 		xe_pm_runtime_put(ct_to_xe(ct));
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-10-17 22:27 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-17  0:46 [PATCH v1] drm/xe/guc: Change outstanding assertion to error Zhanjun Dong
2025-10-17  0:53 ` ✓ CI.KUnit: success for " Patchwork
2025-10-17  1:38 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-17  5:45 ` [PATCH v1] " Matthew Brost
2025-10-17 22:27 ` ✗ Xe.CI.Full: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox