From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maxime Ripard <mripard@kernel.org>
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org,
Dan Carpenter <dan.carpenter@linaro.org>
Subject: Re: [PATCH 2/2] drm/atomic: WARN about invalid drm_foo_get_state() usage
Date: Tue, 28 Oct 2025 22:52:43 +0200 [thread overview]
Message-ID: <aQEtG0CbmPxLMiQD@intel.com> (raw)
In-Reply-To: <6bccb6ce0672f5b736bb8669060d8005@kernel.org>
On Mon, Oct 20, 2025 at 07:29:49AM +0000, Maxime Ripard wrote:
> On Fri, 17 Oct 2025 19:33:27 +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > drm_{crtc,plane,connector,private_obj}_get_state() must not
> > be called after the atomic check phase. At that point the commit
> > has been carved in stone and no new objects must be introduced
> >
> > [ ... ]
>
> Reviewed-by: Maxime Ripard <mripard@kernel.org>
Thanks. This is now in, so I guess we'll see if there are further
issues still remaining anywhere.
After any initial fires have been put out, I'm thinking we should
change the implementation from just WARN to "WARN+return an error"...
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2025-10-28 20:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 16:33 [PATCH 1/2] drm/atomic: WARN about missing acquire_ctx in drm_atomic_get_private_obj_state() Ville Syrjala
2025-10-17 16:33 ` [PATCH 2/2] drm/atomic: WARN about invalid drm_foo_get_state() usage Ville Syrjala
2025-10-20 7:29 ` Maxime Ripard
2025-10-28 20:52 ` Ville Syrjälä [this message]
2025-10-17 17:37 ` ✓ CI.KUnit: success for series starting with [1/2] drm/atomic: WARN about missing acquire_ctx in drm_atomic_get_private_obj_state() Patchwork
2025-10-17 18:29 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-18 17:34 ` ✗ Xe.CI.Full: failure " Patchwork
2025-10-20 7:29 ` [PATCH 1/2] " Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQEtG0CbmPxLMiQD@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dan.carpenter@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=mripard@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox