Re: [CI 11/32] drm/i915/display: Determine Cx0 PLL DP mode from PLL state

[Imre Deak <imre.deak@intel.com>]

On Tue, Nov 11, 2025 at 08:08:34AM +0200, Suraj Kandpal wrote:
> [...]
> > @@ -2929,10 +2958,11 @@ static void intel_c20_pll_program(struct
> > intel_display *display,
> > 
> >  static void intel_program_port_clock_ctl(struct intel_encoder *encoder,
> >  					 const struct intel_cx0pll_state *pll_state,
> > -					 bool is_dp, int port_clock,
> > +					 int port_clock,
> >  					 bool lane_reversal)
> >  {
> >  	struct intel_display *display = to_intel_display(encoder);
> > +	bool is_dp = cx0pll_state_is_dp(pll_state);
> 
> Wouldn't a simple check of drm_encoder's type tell us if it is dp or not ?

For a DDI encoder drm_encoder::encoder_type is DRM_MODE_ENCODER_TMDS,
from which you can't determine if the encoder is used for a DP or HDMI
output. This also applies to intel_encoder_is_dp(), which will return
true if for instance a DDI encoder wired to a DP++ connector is used for
an HDMI output.

> Regards,
> Suraj Kandpal