Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v5 0/8] Fix DRM scheduler layering violations in Xe
@ 2025-11-26 20:19 Matthew Brost
  2025-11-26 20:19 ` [PATCH v5 1/8] drm/sched: Add several job helpers to avoid drivers touching scheduler state Matthew Brost
                   ` (11 more replies)
  0 siblings, 12 replies; 14+ messages in thread
From: Matthew Brost @ 2025-11-26 20:19 UTC (permalink / raw)
  To: intel-xe; +Cc: dri-devel

At XDC, we discussed that drivers should avoid accessing DRM scheduler
internals, misusing DRM scheduler locks, and adopt a well-defined
pending job list iterator. This series proposes the necessary changes to
the DRM scheduler to bring Xe in line with that agreement and updates Xe
to use the new DRM scheduler API.

While here, cleanup LR queue handling and simplify GuC state machine in
Xe too.

v2:
 - Fix checkpatch / naming issues
v3:
 - Only allow pending job list iterator to be called on stopped schedulers
 - Cleanup LR queue handling / fix a few misselanous Xe scheduler issues
v4:
 - Address Niranjana's feedback
 - Add patch to avoid toggling scheduler state in the TDR
v5:
 - Rebase
 - Fixup LRC timeout check (Umesh)

Matt

Matthew Brost (8):
  drm/sched: Add several job helpers to avoid drivers touching scheduler
    state
  drm/sched: Add pending job list iterator
  drm/xe: Add dedicated message lock
  drm/xe: Stop abusing DRM scheduler internals
  drm/xe: Only toggle scheduling in TDR if GuC is running
  drm/xe: Do not deregister queues in TDR
  drm/xe: Remove special casing for LR queues in submission
  drm/xe: Avoid toggling schedule state to check LRC timestamp in TDR

 drivers/gpu/drm/scheduler/sched_main.c       |   4 +-
 drivers/gpu/drm/xe/xe_gpu_scheduler.c        |   9 +-
 drivers/gpu/drm/xe/xe_gpu_scheduler.h        |  37 +-
 drivers/gpu/drm/xe/xe_gpu_scheduler_types.h  |   2 +
 drivers/gpu/drm/xe/xe_guc_exec_queue_types.h |   2 -
 drivers/gpu/drm/xe/xe_guc_submit.c           | 362 +++----------------
 drivers/gpu/drm/xe/xe_guc_submit_types.h     |  11 -
 drivers/gpu/drm/xe/xe_hw_fence.c             |  16 -
 drivers/gpu/drm/xe/xe_hw_fence.h             |   2 -
 drivers/gpu/drm/xe/xe_lrc.c                  |  42 ++-
 drivers/gpu/drm/xe/xe_lrc.h                  |   3 +-
 drivers/gpu/drm/xe/xe_sched_job.c            |   1 +
 drivers/gpu/drm/xe/xe_sched_job_types.h      |   2 +
 drivers/gpu/drm/xe/xe_trace.h                |   5 -
 include/drm/gpu_scheduler.h                  |  82 +++++
 15 files changed, 188 insertions(+), 392 deletions(-)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2025-11-26 22:18 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-26 20:19 [PATCH v5 0/8] Fix DRM scheduler layering violations in Xe Matthew Brost
2025-11-26 20:19 ` [PATCH v5 1/8] drm/sched: Add several job helpers to avoid drivers touching scheduler state Matthew Brost
2025-11-26 20:19 ` [PATCH v5 2/8] drm/sched: Add pending job list iterator Matthew Brost
2025-11-26 20:19 ` [PATCH v5 3/8] drm/xe: Add dedicated message lock Matthew Brost
2025-11-26 20:19 ` [PATCH v5 4/8] drm/xe: Stop abusing DRM scheduler internals Matthew Brost
2025-11-26 20:19 ` [PATCH v5 5/8] drm/xe: Only toggle scheduling in TDR if GuC is running Matthew Brost
2025-11-26 20:19 ` [PATCH v5 6/8] drm/xe: Do not deregister queues in TDR Matthew Brost
2025-11-26 20:19 ` [PATCH v5 7/8] drm/xe: Remove special casing for LR queues in submission Matthew Brost
2025-11-26 20:19 ` [PATCH v5 8/8] drm/xe: Avoid toggling schedule state to check LRC timestamp in TDR Matthew Brost
2025-11-26 21:21   ` Matthew Brost
2025-11-26 20:25 ` ✗ CI.checkpatch: warning for Fix DRM scheduler layering violations in Xe (rev5) Patchwork
2025-11-26 20:26 ` ✓ CI.KUnit: success " Patchwork
2025-11-26 21:40 ` ✓ Xe.CI.BAT: " Patchwork
2025-11-26 22:18 ` ✗ Xe.CI.Full: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox