Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH next] drm/xe/vf: fix return type in vf_migration_init_late()
@ 2025-12-05 11:10 Dan Carpenter
  2025-12-05 12:19 ` Michal Wajdeczko
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Dan Carpenter @ 2025-12-05 11:10 UTC (permalink / raw)
  To: Satyanarayana K V P
  Cc: Thomas Hellström, Rodrigo Vivi, David Airlie, Simona Vetter,
	Michal Wajdeczko, intel-xe, dri-devel, linux-kernel,
	kernel-janitors

The vf_migration_init_late() function is supposed to return zero on
success and negative error codes on failure.  The error code
eventually gets propagated back to the probe() function and returned.
The problem is it's declared as type bool so it returns true on
error.  Change it to type int instead.

Fixes: 2e2dab20dd66 ("drm/xe/vf: Enable VF migration only on supported GuC versions")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/gpu/drm/xe/xe_sriov_vf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_sriov_vf.c b/drivers/gpu/drm/xe/xe_sriov_vf.c
index 86423a799d57..1b75405b8d02 100644
--- a/drivers/gpu/drm/xe/xe_sriov_vf.c
+++ b/drivers/gpu/drm/xe/xe_sriov_vf.c
@@ -226,7 +226,7 @@ void xe_sriov_vf_init_early(struct xe_device *xe)
 	vf_migration_init_early(xe);
 }
 
-static bool vf_migration_init_late(struct xe_device *xe)
+static int vf_migration_init_late(struct xe_device *xe)
 {
 	struct xe_gt *gt = xe_root_mmio_gt(xe);
 	struct xe_uc_fw_version guc_version;
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-12-05 13:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-05 11:10 [PATCH next] drm/xe/vf: fix return type in vf_migration_init_late() Dan Carpenter
2025-12-05 12:19 ` Michal Wajdeczko
2025-12-05 12:56 ` ✓ CI.KUnit: success for " Patchwork
2025-12-05 13:34 ` ✓ Xe.CI.BAT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox