From: Raag Jadav <raag.jadav@intel.com>
To: "Usyskin, Alexander" <alexander.usyskin@intel.com>
Cc: "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
"Abliyev, Reuven" <reuven.abliyev@intel.com>,
"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH] drm/xe/nvm: enable cri platform
Date: Tue, 16 Dec 2025 08:57:40 +0100 [thread overview]
Message-ID: <aUEQ9BvG4HYUciD3@black.igk.intel.com> (raw)
In-Reply-To: <CY5PR11MB636602B9B547F832F8E1B084EDADA@CY5PR11MB6366.namprd11.prod.outlook.com>
On Mon, Dec 15, 2025 at 08:41:54PM +0530, Usyskin, Alexander wrote:
> > Subject: Re: [PATCH] drm/xe/nvm: enable cri platform
...
> > > struct xe_mmio *mmio = xe_root_tile_mmio(xe);
> > >
> > > - if (xe->info.platform != XE_BATTLEMAGE)
> > > + switch (xe->info.platform) {
> > > + case XE_CRESCENTISLAND:
> > > + fallthrough;
> >
> > Is standalone fallthrough a thing?
>
> I see it in some kernel drivers and checkpatch jumps on /* fallthrough */ comment.
> Is it discouraged?
They both are same cases so there's nothing to fall from. Drop it.
Raag
next prev parent reply other threads:[~2025-12-16 7:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 12:59 [PATCH] drm/xe/nvm: enable cri platform Alexander Usyskin
2025-12-15 13:26 ` ✓ CI.KUnit: success for " Patchwork
2025-12-15 14:01 ` [PATCH] " Raag Jadav
2025-12-15 15:11 ` Usyskin, Alexander
2025-12-16 7:57 ` Raag Jadav [this message]
2025-12-15 14:48 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-12-15 17:21 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aUEQ9BvG4HYUciD3@black.igk.intel.com \
--to=raag.jadav@intel.com \
--cc=alexander.usyskin@intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=reuven.abliyev@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox