[PATCH] drm/xe: Don't use absolute path in generated header comment

[PATCH] drm/xe: Don't use absolute path in generated header comment

[Calvin Owens]

Building the XE driver through Yocto throws this QA warning:

    WARNING: mc:house:linux-stable-6.17-r0 do_package_qa: QA Issue: File /usr/src/debug/linux-stable/6.17/drivers/gpu/drm/xe/generated/xe_device_wa_oob.h in package linux-stable-src contains reference to TMPDIR [buildpaths]
    WARNING: mc:house:linux-stable-6.17-r0 do_package_qa: QA Issue: File /usr/src/debug/linux-stable/6.17/drivers/gpu/drm/xe/generated/xe_wa_oob.h in package linux-stable-src contains reference to TMPDIR [buildpaths]

...because the comment at the top of the generated header contains the
absolute path to the rules file at build time:

    * This file was generated from rules: /home/calvinow/git/meta-house/build/tmp-house/work-shared/nuc14rvhu7/kernel-source/drivers/gpu/drm/xe/xe_device_wa_oob.rules

Fix this minor annoyance by putting the basename of the rules file in
the generated comment instead of the absolute path, so the generated
header contents no longer depend on the location of the kernel source.

Signed-off-by: Calvin Owens <calvin@wbinvd.org>
---
 drivers/gpu/drm/xe/xe_gen_wa_oob.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_gen_wa_oob.c b/drivers/gpu/drm/xe/xe_gen_wa_oob.c
index 247e41c1c48d..e7a50b1348b7 100644
--- a/drivers/gpu/drm/xe/xe_gen_wa_oob.c
+++ b/drivers/gpu/drm/xe/xe_gen_wa_oob.c
@@ -195,7 +195,8 @@ int main(int argc, const char *argv[])
 		}
 	}
 
-	fprintf(args[ARGS_CHEADER].f, HEADER, args[ARGS_INPUT].fn, prefix, prefix);
+	fprintf(args[ARGS_CHEADER].f, HEADER, xbasename(args[ARGS_INPUT].fn),
+		prefix, prefix);
 
 	ret = parse(args[ARGS_INPUT].f, args[ARGS_CSOURCE].f,
 		    args[ARGS_CHEADER].f, prefix);
-- 
2.47.3

✗ LGCI.VerificationFailed: failure for drm/xe: Don't use absolute path in generated header comment

[Patchwork]

== Series Details ==

Series: drm/xe: Don't use absolute path in generated header comment
URL   : https://patchwork.freedesktop.org/series/156919/
State : failure

== Summary ==

Address 'calvin@wbinvd.org' is not on the allowlist, which prevents CI from being triggered for this patch.
If you want Intel GFX CI to accept this address, please contact the script maintainers at i915-ci-infra@lists.freedesktop.org.
Exception occurred during validation, bailing out!

Re: ✗ LGCI.VerificationFailed: failure for drm/xe: Don't use absolute path in generated header comment

[Calvin Owens]

On Monday 11/03 at 13:20 -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/xe: Don't use absolute path in generated header comment
> URL   : https://patchwork.freedesktop.org/series/156919/
> State : failure
> 
> == Summary ==
> 
> Address 'calvin@wbinvd.org' is not on the allowlist, which prevents CI from being triggered for this patch.
> If you want Intel GFX CI to accept this address, please contact the script maintainers at i915-ci-infra@lists.freedesktop.org.
> Exception occurred during validation, bailing out!

Do I need to get myself added to this allowlist and resend the patch?

Re: [PATCH] drm/xe: Don't use absolute path in generated header comment

[Calvin Owens]

On Friday 10/31 at 07:48 -0700, Calvin Owens wrote:
> Building the XE driver through Yocto throws this QA warning:
> 
>     WARNING: mc:house:linux-stable-6.17-r0 do_package_qa: QA Issue: File /usr/src/debug/linux-stable/6.17/drivers/gpu/drm/xe/generated/xe_device_wa_oob.h in package linux-stable-src contains reference to TMPDIR [buildpaths]
>     WARNING: mc:house:linux-stable-6.17-r0 do_package_qa: QA Issue: File /usr/src/debug/linux-stable/6.17/drivers/gpu/drm/xe/generated/xe_wa_oob.h in package linux-stable-src contains reference to TMPDIR [buildpaths]
> 
> ...because the comment at the top of the generated header contains the
> absolute path to the rules file at build time:
> 
>     * This file was generated from rules: /home/calvinow/git/meta-house/build/tmp-house/work-shared/nuc14rvhu7/kernel-source/drivers/gpu/drm/xe/xe_device_wa_oob.rules
> 
> Fix this minor annoyance by putting the basename of the rules file in
> the generated comment instead of the absolute path, so the generated
> header contents no longer depend on the location of the kernel source.

Hi all,

This is about as trivial as it gets: it's been a couple months, can I
get some eyes on this please?

This is the only place in the entire kernel source where the content of
a generated header depends on the absolute path to the kernel tree. It
makes kernel source packages non-reproducible.

Thanks
Calvin

> Signed-off-by: Calvin Owens <calvin@wbinvd.org>
> ---
>  drivers/gpu/drm/xe/xe_gen_wa_oob.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gen_wa_oob.c b/drivers/gpu/drm/xe/xe_gen_wa_oob.c
> index 247e41c1c48d..e7a50b1348b7 100644
> --- a/drivers/gpu/drm/xe/xe_gen_wa_oob.c
> +++ b/drivers/gpu/drm/xe/xe_gen_wa_oob.c
> @@ -195,7 +195,8 @@ int main(int argc, const char *argv[])
>  		}
>  	}
>  
> -	fprintf(args[ARGS_CHEADER].f, HEADER, args[ARGS_INPUT].fn, prefix, prefix);
> +	fprintf(args[ARGS_CHEADER].f, HEADER, xbasename(args[ARGS_INPUT].fn),
> +		prefix, prefix);
>  
>  	ret = parse(args[ARGS_INPUT].f, args[ARGS_CSOURCE].f,
>  		    args[ARGS_CHEADER].f, prefix);
> -- 
> 2.47.3
> 

Re: [PATCH] drm/xe: Don't use absolute path in generated header comment

[Vivi, Rodrigo]

On Sun, 2025-12-21 at 11:53 -0800, Calvin Owens wrote:
> On Friday 10/31 at 07:48 -0700, Calvin Owens wrote:
> > Building the XE driver through Yocto throws this QA warning:
> > 
> >     WARNING: mc:house:linux-stable-6.17-r0 do_package_qa: QA Issue:
> > File /usr/src/debug/linux-
> > stable/6.17/drivers/gpu/drm/xe/generated/xe_device_wa_oob.h in
> > package linux-stable-src contains reference to TMPDIR [buildpaths]
> >     WARNING: mc:house:linux-stable-6.17-r0 do_package_qa: QA Issue:
> > File /usr/src/debug/linux-
> > stable/6.17/drivers/gpu/drm/xe/generated/xe_wa_oob.h in package
> > linux-stable-src contains reference to TMPDIR [buildpaths]
> > 
> > ...because the comment at the top of the generated header contains
> > the
> > absolute path to the rules file at build time:
> > 
> >     * This file was generated from rules: /home/calvinow/git/meta-
> > house/build/tmp-house/work-shared/nuc14rvhu7/kernel-
> > source/drivers/gpu/drm/xe/xe_device_wa_oob.rules
> > 
> > Fix this minor annoyance by putting the basename of the rules file
> > in
> > the generated comment instead of the absolute path, so the
> > generated
> > header contents no longer depend on the location of the kernel
> > source.
> 
> Hi all,
> 
> This is about as trivial as it gets: it's been a couple months, can I
> get some eyes on this please?
> 
> This is the only place in the entire kernel source where the content
> of
> a generated header depends on the absolute path to the kernel tree.
> It
> makes kernel source packages non-reproducible.

Sorry about that and for the delay.

I just resent the patch for CI:
https://lore.kernel.org/intel-xe/20251222165441.516102-2-rodrigo.vivi@intel.com/

We can push after passing it.
Thanks,
Rodrigo.

> 
> Thanks
> Calvin
> 
> > Signed-off-by: Calvin Owens <calvin@wbinvd.org>
> > ---
> >  drivers/gpu/drm/xe/xe_gen_wa_oob.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_gen_wa_oob.c
> > b/drivers/gpu/drm/xe/xe_gen_wa_oob.c
> > index 247e41c1c48d..e7a50b1348b7 100644
> > --- a/drivers/gpu/drm/xe/xe_gen_wa_oob.c
> > +++ b/drivers/gpu/drm/xe/xe_gen_wa_oob.c
> > @@ -195,7 +195,8 @@ int main(int argc, const char *argv[])
> >  		}
> >  	}
> >  
> > -	fprintf(args[ARGS_CHEADER].f, HEADER, args[ARGS_INPUT].fn,
> > prefix, prefix);
> > +	fprintf(args[ARGS_CHEADER].f, HEADER,
> > xbasename(args[ARGS_INPUT].fn),
> > +		prefix, prefix);
> >  
> >  	ret = parse(args[ARGS_INPUT].f, args[ARGS_CSOURCE].f,
> >  		    args[ARGS_CHEADER].f, prefix);
> > -- 
> > 2.47.3
> > 

Re: [PATCH] drm/xe: Don't use absolute path in generated header comment

[Calvin Owens]

On Monday 12/22 at 16:56 +0000, Vivi, Rodrigo wrote:
> On Sun, 2025-12-21 at 11:53 -0800, Calvin Owens wrote:
> > On Friday 10/31 at 07:48 -0700, Calvin Owens wrote:
> > > Building the XE driver through Yocto throws this QA warning:
> > > 
> > >     WARNING: mc:house:linux-stable-6.17-r0 do_package_qa: QA Issue:
> > > File /usr/src/debug/linux-
> > > stable/6.17/drivers/gpu/drm/xe/generated/xe_device_wa_oob.h in
> > > package linux-stable-src contains reference to TMPDIR [buildpaths]
> > >     WARNING: mc:house:linux-stable-6.17-r0 do_package_qa: QA Issue:
> > > File /usr/src/debug/linux-
> > > stable/6.17/drivers/gpu/drm/xe/generated/xe_wa_oob.h in package
> > > linux-stable-src contains reference to TMPDIR [buildpaths]
> > > 
> > > ...because the comment at the top of the generated header contains
> > > the
> > > absolute path to the rules file at build time:
> > > 
> > >     * This file was generated from rules: /home/calvinow/git/meta-
> > > house/build/tmp-house/work-shared/nuc14rvhu7/kernel-
> > > source/drivers/gpu/drm/xe/xe_device_wa_oob.rules
> > > 
> > > Fix this minor annoyance by putting the basename of the rules file
> > > in
> > > the generated comment instead of the absolute path, so the
> > > generated
> > > header contents no longer depend on the location of the kernel
> > > source.
> > 
> > Hi all,
> > 
> > This is about as trivial as it gets: it's been a couple months, can I
> > get some eyes on this please?
> > 
> > This is the only place in the entire kernel source where the content
> > of
> > a generated header depends on the absolute path to the kernel tree.
> > It
> > makes kernel source packages non-reproducible.
> 
> Sorry about that and for the delay.
> 
> I just resent the patch for CI:
> https://lore.kernel.org/intel-xe/20251222165441.516102-2-rodrigo.vivi@intel.com/
> 
> We can push after passing it.

No apology necessary, thanks for kicking it for me :)

Calvin

> Thanks,
> Rodrigo.
> 
> > 
> > Thanks
> > Calvin
> > 
> > > Signed-off-by: Calvin Owens <calvin@wbinvd.org>
> > > ---
> > >  drivers/gpu/drm/xe/xe_gen_wa_oob.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/xe/xe_gen_wa_oob.c
> > > b/drivers/gpu/drm/xe/xe_gen_wa_oob.c
> > > index 247e41c1c48d..e7a50b1348b7 100644
> > > --- a/drivers/gpu/drm/xe/xe_gen_wa_oob.c
> > > +++ b/drivers/gpu/drm/xe/xe_gen_wa_oob.c
> > > @@ -195,7 +195,8 @@ int main(int argc, const char *argv[])
> > >  		}
> > >  	}
> > >  
> > > -	fprintf(args[ARGS_CHEADER].f, HEADER, args[ARGS_INPUT].fn,
> > > prefix, prefix);
> > > +	fprintf(args[ARGS_CHEADER].f, HEADER,
> > > xbasename(args[ARGS_INPUT].fn),
> > > +		prefix, prefix);
> > >  
> > >  	ret = parse(args[ARGS_INPUT].f, args[ARGS_CSOURCE].f,
> > >  		    args[ARGS_CHEADER].f, prefix);
> > > -- 
> > > 2.47.3
> > > 

Re: [PATCH] drm/xe: Don't use absolute path in generated header comment

[Rodrigo Vivi]

On Mon, Dec 22, 2025 at 12:26:15PM -0800, Calvin Owens wrote:
> On Monday 12/22 at 16:56 +0000, Vivi, Rodrigo wrote:
> > On Sun, 2025-12-21 at 11:53 -0800, Calvin Owens wrote:
> > > On Friday 10/31 at 07:48 -0700, Calvin Owens wrote:
> > > > Building the XE driver through Yocto throws this QA warning:
> > > > 
> > > >     WARNING: mc:house:linux-stable-6.17-r0 do_package_qa: QA Issue:
> > > > File /usr/src/debug/linux-
> > > > stable/6.17/drivers/gpu/drm/xe/generated/xe_device_wa_oob.h in
> > > > package linux-stable-src contains reference to TMPDIR [buildpaths]
> > > >     WARNING: mc:house:linux-stable-6.17-r0 do_package_qa: QA Issue:
> > > > File /usr/src/debug/linux-
> > > > stable/6.17/drivers/gpu/drm/xe/generated/xe_wa_oob.h in package
> > > > linux-stable-src contains reference to TMPDIR [buildpaths]
> > > > 
> > > > ...because the comment at the top of the generated header contains
> > > > the
> > > > absolute path to the rules file at build time:
> > > > 
> > > >     * This file was generated from rules: /home/calvinow/git/meta-
> > > > house/build/tmp-house/work-shared/nuc14rvhu7/kernel-
> > > > source/drivers/gpu/drm/xe/xe_device_wa_oob.rules
> > > > 
> > > > Fix this minor annoyance by putting the basename of the rules file
> > > > in
> > > > the generated comment instead of the absolute path, so the
> > > > generated
> > > > header contents no longer depend on the location of the kernel
> > > > source.
> > > 
> > > Hi all,
> > > 
> > > This is about as trivial as it gets: it's been a couple months, can I
> > > get some eyes on this please?
> > > 
> > > This is the only place in the entire kernel source where the content
> > > of
> > > a generated header depends on the absolute path to the kernel tree.
> > > It
> > > makes kernel source packages non-reproducible.
> > 
> > Sorry about that and for the delay.
> > 
> > I just resent the patch for CI:
> > https://lore.kernel.org/intel-xe/20251222165441.516102-2-rodrigo.vivi@intel.com/
> > 
> > We can push after passing it.
> 
> No apology necessary, thanks for kicking it for me :)

Patch pushed to drm-xe-next

> 
> Calvin
> 
> > Thanks,
> > Rodrigo.
> > 
> > > 
> > > Thanks
> > > Calvin
> > > 
> > > > Signed-off-by: Calvin Owens <calvin@wbinvd.org>
> > > > ---
> > > >  drivers/gpu/drm/xe/xe_gen_wa_oob.c | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/gpu/drm/xe/xe_gen_wa_oob.c
> > > > b/drivers/gpu/drm/xe/xe_gen_wa_oob.c
> > > > index 247e41c1c48d..e7a50b1348b7 100644
> > > > --- a/drivers/gpu/drm/xe/xe_gen_wa_oob.c
> > > > +++ b/drivers/gpu/drm/xe/xe_gen_wa_oob.c
> > > > @@ -195,7 +195,8 @@ int main(int argc, const char *argv[])
> > > >  		}
> > > >  	}
> > > >  
> > > > -	fprintf(args[ARGS_CHEADER].f, HEADER, args[ARGS_INPUT].fn,
> > > > prefix, prefix);
> > > > +	fprintf(args[ARGS_CHEADER].f, HEADER,
> > > > xbasename(args[ARGS_INPUT].fn),
> > > > +		prefix, prefix);
> > > >  
> > > >  	ret = parse(args[ARGS_INPUT].f, args[ARGS_CSOURCE].f,
> > > >  		    args[ARGS_CHEADER].f, prefix);
> > > > -- 
> > > > 2.47.3
> > > >