Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 0/2] drm/xe/guc: Prevent compiler read/write optimization breaks
@ 2025-12-22 20:19 Jonathan Cavitt
  2025-12-22 20:19 ` [PATCH v3 1/2] drm/xe/guc: READ/WRITE_ONCE g2h_fence->done Jonathan Cavitt
                   ` (4 more replies)
  0 siblings, 5 replies; 9+ messages in thread
From: Jonathan Cavitt @ 2025-12-22 20:19 UTC (permalink / raw)
  To: intel-xe
  Cc: saurabhg.gupta, alex.zuo, jonathan.cavitt, matthew.brost,
	daniele.ceraolospurio, rodrigo.vivi, michal.wajdeczko,
	stuart.summers, ashutosh.dixit

Use READ_ONCE and WRITE_ONCE when operating on ct->state and the
g2h_fence->done values to prevent the compiler from ignoring these
necessary operations.

v2: (Matt Brost)
- Add Fixes tags
- Add comments

v3:
- Split into multiple patches (Rodrigo Vivi)

v4:
- s/xe_guc_ct/guc (Michal W)
- Add comments with READ_ONCE and WRITE_ONCE updates
  (Rodrigo, Stuart, Dixit)
- Squash patches with same Fixes target
  (Rodrigo, Stuart, Dixit)
- Add partial comment justifying WRITE_ONCE in guc_ct_change_state
  before READ_ONCE in xe_guc_ct_enabled is added (Rodrigo Vivi)
  - Update above comment when adding READ_ONCE to xe_guc_ct_enabled
    (jcavitt)

v4: (Matt Brost)
- Squash patches operating on the same value together
- Remove unnecessary Fixes tags
- Add READ_ONCEs to pair with WRITE_ONCEs on g2h_fence->done

Suggested-by: Matthew Brost <matthew.brost@intel.com>
Suggested-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Stuart Summers <stuart.summers@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>

Jonathan Cavitt (2):
  drm/xe/guc: READ/WRITE_ONCE g2h_fence->done
  drm/xe/guc: READ/WRITE_ONCE ct->state

 drivers/gpu/drm/xe/xe_guc_ct.c | 21 ++++++++++++++++-----
 drivers/gpu/drm/xe/xe_guc_ct.h |  6 ++++--
 2 files changed, 20 insertions(+), 7 deletions(-)

-- 
2.43.0


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2025-12-23 21:45 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-22 20:19 [PATCH v3 0/2] drm/xe/guc: Prevent compiler read/write optimization breaks Jonathan Cavitt
2025-12-22 20:19 ` [PATCH v3 1/2] drm/xe/guc: READ/WRITE_ONCE g2h_fence->done Jonathan Cavitt
2025-12-23 21:36   ` Matthew Brost
2025-12-22 20:20 ` [PATCH v3 2/2] drm/xe/guc: READ/WRITE_ONCE ct->state Jonathan Cavitt
2025-12-23 21:36   ` Matthew Brost
2025-12-23 21:45     ` Rodrigo Vivi
2025-12-23  2:05 ` ✓ CI.KUnit: success for drm/xe/guc: Prevent compiler read/write optimization breaks (rev2) Patchwork
2025-12-23  2:43 ` ✓ Xe.CI.BAT: " Patchwork
2025-12-23 13:20 ` ✓ Xe.CI.Full: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox