Re: [PATCH v5 2/4] drm/xe/hwmon: Expose memory controller temperature

[Raag Jadav <raag.jadav@intel.com>]

On Sat, Jan 10, 2026 at 01:46:42AM +0530, Karthik Poosa wrote:
> Expose GPU memory controller average temperature and its limits under
> temp4_xxx.
> Update Xe hwmon documentation for this.

...

> @@ -718,15 +727,50 @@ static int xe_hwmon_pcode_read_thermal_info(struct xe_hwmon *hwmon)
>  {
>  	struct xe_tile *root_tile = xe_device_get_root_tile(hwmon->xe);
>  	int ret;
> +	u32 config = 0;

Use reverse xmas tree order.

>  	ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_THERMAL_INFO, READ_THERMAL_LIMITS, 0),
>  			    &hwmon->temp.data[0], &hwmon->temp.data[1]);
> +	if (ret)
> +		return ret;
> +
>  	drm_dbg(&hwmon->xe->drm, "thermal info read val 0x%x val1 0x%x\n",
>  		hwmon->temp.data[0], hwmon->temp.data[1]);
>  
> +	ret = xe_pcode_read(root_tile, PCODE_MBOX(PCODE_THERMAL_INFO, READ_THERMAL_CONFIG, 0),
> +			    &config, NULL);
> +	if (ret)
> +		return ret;
> +
> +	drm_dbg(&hwmon->xe->drm, "thermal config count %d\n", config);

If you want decimal value then I think you should print after[*] you mask
it, but if you want raw value then I think 0x%x would be more useful for
debugging.

> +	hwmon->temp.count = config & TEMP_MASK;

Use REG_FIELD_GET() for consistency.

[*]

Reviewed-by: Raag Jadav <raag.jadav@intel.com>