public inbox for intel-xe@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Suraj Kandpal <suraj.kandpal@intel.com>
Cc: <intel-xe@lists.freedesktop.org>,
	<intel-gfx@lists.freedesktop.org>, <ankit.k.nautiyal@intel.com>
Subject: Re: [PATCH v2 0/3] Fix Cx0 Suspend Resume issue
Date: Wed, 14 Jan 2026 10:10:05 -0500	[thread overview]
Message-ID: <aWexzTR221l0F-we@intel.com> (raw)
In-Reply-To: <20260114034259.466605-1-suraj.kandpal@intel.com>

On Wed, Jan 14, 2026 at 09:12:56AM +0530, Suraj Kandpal wrote:
> CX0 PHY currently has two issues which cause a hang when we try
> to suspend resume machine with a delay of 15mins and 1+ hour.
> This happens due to two reasons:
> 1) We do not follow the Enablement sequence where we need to
> enable our clock after PPS Enablement cycle
> 2) We do not make sure response ready and error bit are cleared
> in P2M_MSGBUS_STATUS before writing the transaction pending bit.
> This series aims to solve this.

Is there any Fixes: tag that we should add to any of the commits
in this series?

Also, next time, consider a fix as the first patch for easy backport
and the refactor on top.

Thanks,
Rodrigo.

> 
> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> 
> Mika Kahola (1):
>   drm/i915/cx0: Split PLL enabling/disabling in two parts
> 
> Suraj Kandpal (2):
>   drm/i915/cx0: Clear response ready & error bit
>   drm/i915/cx0: Rename intel_clear_response_ready flag
> 
>  drivers/gpu/drm/i915/display/intel_cx0_phy.c  | 134 +++++++++++-------
>  drivers/gpu/drm/i915/display/intel_cx0_phy.h  |   4 +-
>  drivers/gpu/drm/i915/display/intel_dpll_mgr.c |   7 +-
>  drivers/gpu/drm/i915/display/intel_lt_phy.c   |   2 +-
>  4 files changed, 92 insertions(+), 55 deletions(-)
> 
> -- 
> 2.34.1
> 

  parent reply	other threads:[~2026-01-14 15:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-14  3:42 [PATCH v2 0/3] Fix Cx0 Suspend Resume issue Suraj Kandpal
2026-01-14  3:42 ` [PATCH v2 1/3] drm/i915/cx0: Split PLL enabling/disabling in two parts Suraj Kandpal
2026-01-14 15:12   ` Imre Deak
2026-01-14  3:42 ` [PATCH v2 2/3] drm/i915/cx0: Clear response ready & error bit Suraj Kandpal
2026-01-14  3:42 ` [PATCH v2 3/3] drm/i915/cx0: Rename intel_clear_response_ready flag Suraj Kandpal
2026-01-14  6:03   ` Garg, Nemesa
2026-01-14  4:35 ` ✓ CI.KUnit: success for Fix Cx0 Suspend Resume issue (rev2) Patchwork
2026-01-14  5:08 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-01-14 11:50 ` ✗ Xe.CI.Full: " Patchwork
2026-01-14 15:10 ` Rodrigo Vivi [this message]
2026-01-14 15:42   ` [PATCH v2 0/3] Fix Cx0 Suspend Resume issue Saarinen, Jani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aWexzTR221l0F-we@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=suraj.kandpal@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox