public inbox for intel-xe@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH 00/79] Cleanup unused headers reported by clangd
@ 2026-01-13 23:03 Matt Roper
  2026-01-13 23:03 ` [PATCH 01/79] drm/xe: Cleanup headers in xe_bb.c Matt Roper
                   ` (82 more replies)
  0 siblings, 83 replies; 93+ messages in thread
From: Matt Roper @ 2026-01-13 23:03 UTC (permalink / raw)
  To: intel-xe; +Cc: matthew.d.roper

clangd[1] helpfully flags #include's of headers that aren't being
directly used by the file including them.  In most cases we can either
drop those #include statements or replace them with a more targeted
include (such as xe_gt.h to xe_gt_types.h).  Let's drop/simplify a bunch
of the unnecessary includes in our driver's .c files; this may help
speed up partial rebuilds for developers since the build system won't
see as many false dependencies.

There's more header-related cleanup that could be done (e.g., some of
our headers incorrectly include other headers they don't need), but that
can wait for a follow-up series; this one is already long enough.


[1] https://clangd.llvm.org/

Matt Roper (79):
  drm/xe: Cleanup headers in xe_bb.c
  drm/xe: Drop unused header in xe_bo.c
  drm/xe: Cleanup headers in xe_devcoredump.c
  drm/xe: Drop unused header in xe_device.c
  drm/xe: Drop unused header in xe_exec.c
  drm/xe: Cleanup headers in xe_execlist.c
  drm/xe: Drop unused headers in xe_exec_queue.c
  drm/xe: Simplify headers in xe_ggtt.c
  drm/xe: Cleanup headers in xe_gsc_debugfs.c
  drm/xe: Simplify header in xe_gsc_proxy.c
  drm/xe: Drop unused headers in xe_gsc_submit.c
  drm/xe: Drop unused headers in xe_gt.c
  drm/xe: Cleanup headers in xe_gt_clock.c
  drm/xe: Drop unused header in xe_gt_debugfs.c
  drm/xe: Drop unused header in xe_gt_idle.c
  drm/xe: Drop unused header in xe_gt_mcr.c
  drm/xe: Drop unused headers in xe_gt_sriov_pf_config.c
  drm/xe: Drop unused header in xe_gt_sriov_pf_debugfs.c
  drm/xe: Simplify header in xe_gt_sriov_pf_migration.c
  drm/xe: Drop unused header in xe_gt_sriov_pf_policy.c
  drm/xe: Cleanup headers in xe_gt_sriov_pf_service.c
  drm/xe: Drop unused header in xe_gt_sriov_vf.c
  drm/xe: Simplify header in xe_gt_stats.c
  drm/xe: Simplify header in xe_gt_sysfs.c
  drm/xe: Simplify header in xe_gt_throttle.c
  drm/xe: Drop unused headers in xe_guc_ads.c
  drm/xe: Drop unused header in xe_guc_buf.c
  drm/xe: Cleanup headers in xe_guc_capture.c
  drm/xe: Cleanup headers in xe_guc_debugfs.c
  drm/xe: Simplify headers in xe_guc_hwconfig.c
  drm/xe: Simplify header in xe_guc_log.c
  drm/xe: Cleanup headers in xe_guc_relay.c
  drm/xe: Drop unused headers in xe_guc_submit.c
  drm/xe: Drop unused header in xe_heci_gsc.c
  drm/xe: Drop unused header in xe_huc.c
  drm/xe: Clean up headers in xe_huc_debugfs.c
  drm/xe: Drop unused header in xe_hw_engine.c
  drm/xe: Simplify include in xe_hw_engine_class_sysfs.c
  drm/xe: Simplify include in xe_hw_engine_group.c
  drm/xe: Cleanup headers in xe_hw_fence.c
  drm/xe: Cleanup headers in xe_i2c.c
  drm/xe: Drop unused header in xe_irq.c
  drm/xe: Drop unused headers in xe_memirq.c
  drm/xe: Drop unused headers in xe_mmio.c
  drm/xe: Drop unused headers in xe_mocs.c
  drm/xe: Simplify include in xe_module.c
  drm/xe: Drop unused header in xe_nvm.c
  drm/xe: Drop unused headers in xe_page_reclaim.c
  drm/xe: Drop unused header in xe_pci.c
  drm/xe: Simplify include in xe_psmi.c
  drm/xe: Drop unused header in xe_pxp.c
  drm/xe: Simplify header in xe_pxp_debugfs.c
  drm/xe: Cleanup headers in xe_reg_sr.c
  drm/xe: Drop unused headers in xe_reg_whitelist.c
  drm/xe: Cleanup headers in xe_ring_ops.c
  drm/xe: Drop unused header in xe_rtp.c
  drm/xe: Simplify header in xe_sa.c
  drm/xe: Simplify header in xe_sched_job.c
  drm/xe: Drop unused header in xe_sriov_packet.c
  drm/xe: Drop unused header in xe_sriov_pf_debugfs.c
  drm/xe: Drop unused header in xe_sriov_vf.c
  drm/xe: Cleanup headers in xe_step.c
  drm/xe: Drop unused header in xe_survivability_mode.c
  drm/xe: Cleanup headers in xe_tile.c
  drm/xe: Cleanup headers in xe_tlb_inval.c
  drm/xe: Drop unused header in xe_ttm_stolen_mgr.c
  drm/xe: Drop unused header in xe_ttm_sys_mgr.c
  drm/xe: Drop unused header in xe_ttm_vram_mgr.c
  drm/xe: Drop unused headers in xe_uc.c
  drm/xe: Cleanup headers in xe_uc_debugfs.c
  drm/xe: Simplify header in xe_uc_fw.c
  drm/xe: Drop unused header in xe_validation.c
  drm/xe: Drop unused header in xe_vm.c
  drm/xe: Drop unused headers in xe_vram.c
  drm/xe: Drop unused header in xe_vram_freq.c
  drm/xe: Drop unused header in xe_vsec.c
  drm/xe: Simplify header in xe_wa.c
  drm/xe: Drop unused header in xe_wait_user_fence.c
  drm/xe: Simplify header in xe_wopcm.c

 drivers/gpu/drm/xe/tests/xe_bo.c              | 1 +
 drivers/gpu/drm/xe/xe_bb.c                    | 3 +--
 drivers/gpu/drm/xe/xe_bo.c                    | 1 -
 drivers/gpu/drm/xe/xe_devcoredump.c           | 3 +--
 drivers/gpu/drm/xe/xe_device.c                | 1 -
 drivers/gpu/drm/xe/xe_exec.c                  | 1 -
 drivers/gpu/drm/xe/xe_exec_queue.c            | 2 --
 drivers/gpu/drm/xe/xe_execlist.c              | 3 +--
 drivers/gpu/drm/xe/xe_ggtt.c                  | 3 +--
 drivers/gpu/drm/xe/xe_gsc_debugfs.c           | 5 ++---
 drivers/gpu/drm/xe/xe_gsc_proxy.c             | 2 +-
 drivers/gpu/drm/xe/xe_gsc_submit.c            | 2 --
 drivers/gpu/drm/xe/xe_gt.c                    | 2 --
 drivers/gpu/drm/xe/xe_gt_clock.c              | 6 +-----
 drivers/gpu/drm/xe/xe_gt_debugfs.c            | 1 -
 drivers/gpu/drm/xe/xe_gt_idle.c               | 1 -
 drivers/gpu/drm/xe/xe_gt_mcr.c                | 1 -
 drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c    | 2 --
 drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c   | 1 -
 drivers/gpu/drm/xe/xe_gt_sriov_pf_migration.c | 2 +-
 drivers/gpu/drm/xe/xe_gt_sriov_pf_policy.c    | 1 -
 drivers/gpu/drm/xe/xe_gt_sriov_pf_service.c   | 5 ++---
 drivers/gpu/drm/xe/xe_gt_sriov_vf.c           | 1 -
 drivers/gpu/drm/xe/xe_gt_stats.c              | 2 +-
 drivers/gpu/drm/xe/xe_gt_sysfs.c              | 2 +-
 drivers/gpu/drm/xe/xe_gt_throttle.c           | 2 +-
 drivers/gpu/drm/xe/xe_guc_ads.c               | 2 --
 drivers/gpu/drm/xe/xe_guc_buf.c               | 1 -
 drivers/gpu/drm/xe/xe_guc_capture.c           | 5 +----
 drivers/gpu/drm/xe/xe_guc_debugfs.c           | 5 ++---
 drivers/gpu/drm/xe/xe_guc_hwconfig.c          | 4 ++--
 drivers/gpu/drm/xe/xe_guc_log.c               | 2 +-
 drivers/gpu/drm/xe/xe_guc_relay.c             | 3 +--
 drivers/gpu/drm/xe/xe_guc_submit.c            | 2 --
 drivers/gpu/drm/xe/xe_heci_gsc.c              | 1 -
 drivers/gpu/drm/xe/xe_huc.c                   | 1 -
 drivers/gpu/drm/xe/xe_huc_debugfs.c           | 5 ++---
 drivers/gpu/drm/xe/xe_hw_engine.c             | 1 -
 drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c | 2 +-
 drivers/gpu/drm/xe/xe_hw_engine_group.c       | 2 +-
 drivers/gpu/drm/xe/xe_hw_fence.c              | 4 +---
 drivers/gpu/drm/xe/xe_i2c.c                   | 4 ++--
 drivers/gpu/drm/xe/xe_irq.c                   | 1 -
 drivers/gpu/drm/xe/xe_memirq.c                | 2 --
 drivers/gpu/drm/xe/xe_mmio.c                  | 4 ----
 drivers/gpu/drm/xe/xe_mocs.c                  | 2 --
 drivers/gpu/drm/xe/xe_module.c                | 2 +-
 drivers/gpu/drm/xe/xe_nvm.c                   | 1 -
 drivers/gpu/drm/xe/xe_page_reclaim.c          | 4 ----
 drivers/gpu/drm/xe/xe_pci.c                   | 1 -
 drivers/gpu/drm/xe/xe_psmi.c                  | 2 +-
 drivers/gpu/drm/xe/xe_pxp.c                   | 1 -
 drivers/gpu/drm/xe/xe_pxp_debugfs.c           | 2 +-
 drivers/gpu/drm/xe/xe_reg_sr.c                | 5 +----
 drivers/gpu/drm/xe/xe_reg_whitelist.c         | 1 -
 drivers/gpu/drm/xe/xe_ring_ops.c              | 4 +---
 drivers/gpu/drm/xe/xe_rtp.c                   | 1 -
 drivers/gpu/drm/xe/xe_sa.c                    | 2 +-
 drivers/gpu/drm/xe/xe_sched_job.c             | 2 +-
 drivers/gpu/drm/xe/xe_sriov_packet.c          | 1 -
 drivers/gpu/drm/xe/xe_sriov_pf_debugfs.c      | 1 -
 drivers/gpu/drm/xe/xe_sriov_vf.c              | 1 -
 drivers/gpu/drm/xe/xe_step.c                  | 3 ++-
 drivers/gpu/drm/xe/xe_survivability_mode.c    | 1 -
 drivers/gpu/drm/xe/xe_tile.c                  | 3 +--
 drivers/gpu/drm/xe/xe_tlb_inval.c             | 7 ++-----
 drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c        | 1 -
 drivers/gpu/drm/xe/xe_ttm_sys_mgr.c           | 1 -
 drivers/gpu/drm/xe/xe_ttm_vram_mgr.c          | 1 -
 drivers/gpu/drm/xe/xe_uc.c                    | 2 --
 drivers/gpu/drm/xe/xe_uc_debugfs.c            | 2 +-
 drivers/gpu/drm/xe/xe_uc_fw.c                 | 2 +-
 drivers/gpu/drm/xe/xe_validation.c            | 1 -
 drivers/gpu/drm/xe/xe_vm.c                    | 1 -
 drivers/gpu/drm/xe/xe_vram.c                  | 2 --
 drivers/gpu/drm/xe/xe_vram_freq.c             | 1 -
 drivers/gpu/drm/xe/xe_vsec.c                  | 1 -
 drivers/gpu/drm/xe/xe_wa.c                    | 2 +-
 drivers/gpu/drm/xe/xe_wait_user_fence.c       | 1 -
 drivers/gpu/drm/xe/xe_wopcm.c                 | 2 +-
 80 files changed, 45 insertions(+), 129 deletions(-)

-- 
2.52.0


^ permalink raw reply	[flat|nested] 93+ messages in thread

end of thread, other threads:[~2026-01-14 17:12 UTC | newest]

Thread overview: 93+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-13 23:03 [PATCH 00/79] Cleanup unused headers reported by clangd Matt Roper
2026-01-13 23:03 ` [PATCH 01/79] drm/xe: Cleanup headers in xe_bb.c Matt Roper
2026-01-13 23:03 ` [PATCH 02/79] drm/xe: Drop unused header in xe_bo.c Matt Roper
2026-01-13 23:03 ` [PATCH 03/79] drm/xe: Cleanup headers in xe_devcoredump.c Matt Roper
2026-01-13 23:03 ` [PATCH 04/79] drm/xe: Drop unused header in xe_device.c Matt Roper
2026-01-13 23:03 ` [PATCH 05/79] drm/xe: Drop unused header in xe_exec.c Matt Roper
2026-01-13 23:03 ` [PATCH 06/79] drm/xe: Cleanup headers in xe_execlist.c Matt Roper
2026-01-13 23:03 ` [PATCH 07/79] drm/xe: Drop unused headers in xe_exec_queue.c Matt Roper
2026-01-13 23:03 ` [PATCH 08/79] drm/xe: Simplify headers in xe_ggtt.c Matt Roper
2026-01-13 23:03 ` [PATCH 09/79] drm/xe: Cleanup headers in xe_gsc_debugfs.c Matt Roper
2026-01-13 23:03 ` [PATCH 10/79] drm/xe: Simplify header in xe_gsc_proxy.c Matt Roper
2026-01-13 23:03 ` [PATCH 11/79] drm/xe: Drop unused headers in xe_gsc_submit.c Matt Roper
2026-01-13 23:03 ` [PATCH 12/79] drm/xe: Drop unused headers in xe_gt.c Matt Roper
2026-01-13 23:03 ` [PATCH 13/79] drm/xe: Cleanup headers in xe_gt_clock.c Matt Roper
2026-01-13 23:03 ` [PATCH 14/79] drm/xe: Drop unused header in xe_gt_debugfs.c Matt Roper
2026-01-13 23:03 ` [PATCH 15/79] drm/xe: Drop unused header in xe_gt_idle.c Matt Roper
2026-01-13 23:03 ` [PATCH 16/79] drm/xe: Drop unused header in xe_gt_mcr.c Matt Roper
2026-01-13 23:03 ` [PATCH 17/79] drm/xe: Drop unused headers in xe_gt_sriov_pf_config.c Matt Roper
2026-01-13 23:03 ` [PATCH 18/79] drm/xe: Drop unused header in xe_gt_sriov_pf_debugfs.c Matt Roper
2026-01-13 23:03 ` [PATCH 19/79] drm/xe: Simplify header in xe_gt_sriov_pf_migration.c Matt Roper
2026-01-13 23:03 ` [PATCH 20/79] drm/xe: Drop unused header in xe_gt_sriov_pf_policy.c Matt Roper
2026-01-13 23:03 ` [PATCH 21/79] drm/xe: Cleanup headers in xe_gt_sriov_pf_service.c Matt Roper
2026-01-13 23:03 ` [PATCH 22/79] drm/xe: Drop unused header in xe_gt_sriov_vf.c Matt Roper
2026-01-13 23:03 ` [PATCH 23/79] drm/xe: Simplify header in xe_gt_stats.c Matt Roper
2026-01-13 23:03 ` [PATCH 24/79] drm/xe: Simplify header in xe_gt_sysfs.c Matt Roper
2026-01-13 23:03 ` [PATCH 25/79] drm/xe: Simplify header in xe_gt_throttle.c Matt Roper
2026-01-14  5:07   ` Raag Jadav
2026-01-13 23:03 ` [PATCH 26/79] drm/xe: Drop unused headers in xe_guc_ads.c Matt Roper
2026-01-13 23:03 ` [PATCH 27/79] drm/xe: Drop unused header in xe_guc_buf.c Matt Roper
2026-01-13 23:03 ` [PATCH 28/79] drm/xe: Cleanup headers in xe_guc_capture.c Matt Roper
2026-01-13 23:03 ` [PATCH 29/79] drm/xe: Cleanup headers in xe_guc_debugfs.c Matt Roper
2026-01-13 23:03 ` [PATCH 30/79] drm/xe: Simplify headers in xe_guc_hwconfig.c Matt Roper
2026-01-13 23:03 ` [PATCH 31/79] drm/xe: Simplify header in xe_guc_log.c Matt Roper
2026-01-13 23:03 ` [PATCH 32/79] drm/xe: Cleanup headers in xe_guc_relay.c Matt Roper
2026-01-13 23:03 ` [PATCH 33/79] drm/xe: Drop unused headers in xe_guc_submit.c Matt Roper
2026-01-13 23:03 ` [PATCH 34/79] drm/xe: Drop unused header in xe_heci_gsc.c Matt Roper
2026-01-13 23:03 ` [PATCH 35/79] drm/xe: Drop unused header in xe_huc.c Matt Roper
2026-01-13 23:03 ` [PATCH 36/79] drm/xe: Clean up headers in xe_huc_debugfs.c Matt Roper
2026-01-13 23:03 ` [PATCH 37/79] drm/xe: Drop unused header in xe_hw_engine.c Matt Roper
2026-01-13 23:03 ` [PATCH 38/79] drm/xe: Simplify include in xe_hw_engine_class_sysfs.c Matt Roper
2026-01-13 23:03 ` [PATCH 39/79] drm/xe: Simplify include in xe_hw_engine_group.c Matt Roper
2026-01-13 23:03 ` [PATCH 40/79] drm/xe: Cleanup headers in xe_hw_fence.c Matt Roper
2026-01-13 23:03 ` [PATCH 41/79] drm/xe: Cleanup headers in xe_i2c.c Matt Roper
2026-01-14  5:12   ` Raag Jadav
2026-01-14 16:29     ` Matt Roper
2026-01-14 17:11       ` Raag Jadav
2026-01-13 23:03 ` [PATCH 42/79] drm/xe: Drop unused header in xe_irq.c Matt Roper
2026-01-13 23:03 ` [PATCH 43/79] drm/xe: Drop unused headers in xe_memirq.c Matt Roper
2026-01-13 23:03 ` [PATCH 44/79] drm/xe: Drop unused headers in xe_mmio.c Matt Roper
2026-01-13 23:03 ` [PATCH 45/79] drm/xe: Drop unused headers in xe_mocs.c Matt Roper
2026-01-13 23:03 ` [PATCH 46/79] drm/xe: Simplify include in xe_module.c Matt Roper
2026-01-13 23:03 ` [PATCH 47/79] drm/xe: Drop unused header in xe_nvm.c Matt Roper
2026-01-13 23:03 ` [PATCH 48/79] drm/xe: Drop unused headers in xe_page_reclaim.c Matt Roper
2026-01-13 23:03 ` [PATCH 49/79] drm/xe: Drop unused header in xe_pci.c Matt Roper
2026-01-13 23:03 ` [PATCH 50/79] drm/xe: Simplify include in xe_psmi.c Matt Roper
2026-01-13 23:03 ` [PATCH 51/79] drm/xe: Drop unused header in xe_pxp.c Matt Roper
2026-01-13 23:03 ` [PATCH 52/79] drm/xe: Simplify header in xe_pxp_debugfs.c Matt Roper
2026-01-13 23:03 ` [PATCH 53/79] drm/xe: Cleanup headers in xe_reg_sr.c Matt Roper
2026-01-13 23:03 ` [PATCH 54/79] drm/xe: Drop unused headers in xe_reg_whitelist.c Matt Roper
2026-01-13 23:04 ` [PATCH 55/79] drm/xe: Cleanup headers in xe_ring_ops.c Matt Roper
2026-01-13 23:04 ` [PATCH 56/79] drm/xe: Drop unused header in xe_rtp.c Matt Roper
2026-01-13 23:04 ` [PATCH 57/79] drm/xe: Simplify header in xe_sa.c Matt Roper
2026-01-13 23:04 ` [PATCH 58/79] drm/xe: Simplify header in xe_sched_job.c Matt Roper
2026-01-13 23:04 ` [PATCH 59/79] drm/xe: Drop unused header in xe_sriov_packet.c Matt Roper
2026-01-13 23:04 ` [PATCH 60/79] drm/xe: Drop unused header in xe_sriov_pf_debugfs.c Matt Roper
2026-01-13 23:04 ` [PATCH 61/79] drm/xe: Drop unused header in xe_sriov_vf.c Matt Roper
2026-01-13 23:04 ` [PATCH 62/79] drm/xe: Cleanup headers in xe_step.c Matt Roper
2026-01-13 23:04 ` [PATCH 63/79] drm/xe: Drop unused header in xe_survivability_mode.c Matt Roper
2026-01-13 23:04 ` [PATCH 64/79] drm/xe: Cleanup headers in xe_tile.c Matt Roper
2026-01-13 23:04 ` [PATCH 65/79] drm/xe: Cleanup headers in xe_tlb_inval.c Matt Roper
2026-01-13 23:04 ` [PATCH 66/79] drm/xe: Drop unused header in xe_ttm_stolen_mgr.c Matt Roper
2026-01-13 23:04 ` [PATCH 67/79] drm/xe: Drop unused header in xe_ttm_sys_mgr.c Matt Roper
2026-01-13 23:04 ` [PATCH 68/79] drm/xe: Drop unused header in xe_ttm_vram_mgr.c Matt Roper
2026-01-13 23:04 ` [PATCH 69/79] drm/xe: Drop unused headers in xe_uc.c Matt Roper
2026-01-13 23:04 ` [PATCH 70/79] drm/xe: Cleanup headers in xe_uc_debugfs.c Matt Roper
2026-01-13 23:04 ` [PATCH 71/79] drm/xe: Simplify header in xe_uc_fw.c Matt Roper
2026-01-13 23:04 ` [PATCH 72/79] drm/xe: Drop unused header in xe_validation.c Matt Roper
2026-01-13 23:04 ` [PATCH 73/79] drm/xe: Drop unused header in xe_vm.c Matt Roper
2026-01-13 23:04 ` [PATCH 74/79] drm/xe: Drop unused headers in xe_vram.c Matt Roper
2026-01-13 23:04 ` [PATCH 75/79] drm/xe: Drop unused header in xe_vram_freq.c Matt Roper
2026-01-13 23:04 ` [PATCH 76/79] drm/xe: Drop unused header in xe_vsec.c Matt Roper
2026-01-13 23:04 ` [PATCH 77/79] drm/xe: Simplify header in xe_wa.c Matt Roper
2026-01-13 23:04 ` [PATCH 78/79] drm/xe: Drop unused header in xe_wait_user_fence.c Matt Roper
2026-01-13 23:04 ` [PATCH 79/79] drm/xe: Simplify header in xe_wopcm.c Matt Roper
2026-01-13 23:17 ` ✓ CI.KUnit: success for Cleanup unused headers reported by clangd Patchwork
2026-01-14  0:03 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-14  0:10 ` [PATCH 00/79] " Matthew Brost
2026-01-14  0:36   ` Matt Roper
2026-01-14  3:46     ` Matthew Brost
2026-01-14  5:02       ` Raag Jadav
2026-01-14  5:33         ` Matthew Brost
2026-01-14 16:22           ` Matt Roper
2026-01-14  8:29 ` ✓ Xe.CI.Full: success for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox