From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Karthik Poosa <karthik.poosa@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, <anshuman.gupta@intel.com>,
<badal.nilawar@intel.com>
Subject: Re: [PATCH] drm/xe/pm: Disable D3Cold for BMG only on specific platforms
Date: Tue, 3 Feb 2026 15:02:05 -0500 [thread overview]
Message-ID: <aYJUPUhGFMwSlajP@intel.com> (raw)
In-Reply-To: <20260123173238.1642383-1-karthik.poosa@intel.com>
On Fri, Jan 23, 2026 at 11:02:38PM +0530, Karthik Poosa wrote:
> Restrict D3Cold disablement for BMG to unsupported NUC platforms,
> instead of disabling it on all platforms.
>
> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
> Fixes: 3e331a6715ee ("drm/xe/pm: Temporarily disable D3Cold on BMG")
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
and pushing it right now...
> ---
> drivers/gpu/drm/xe/xe_pm.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> index 559cf5490ac0..01185f10a883 100644
> --- a/drivers/gpu/drm/xe/xe_pm.c
> +++ b/drivers/gpu/drm/xe/xe_pm.c
> @@ -8,6 +8,7 @@
> #include <linux/fault-inject.h>
> #include <linux/pm_runtime.h>
> #include <linux/suspend.h>
> +#include <linux/dmi.h>
>
> #include <drm/drm_managed.h>
> #include <drm/ttm/ttm_placement.h>
> @@ -366,9 +367,15 @@ ALLOW_ERROR_INJECTION(xe_pm_init_early, ERRNO); /* See xe_pci_probe() */
>
> static u32 vram_threshold_value(struct xe_device *xe)
> {
> - /* FIXME: D3Cold temporarily disabled by default on BMG */
> - if (xe->info.platform == XE_BATTLEMAGE)
> - return 0;
> + if (xe->info.platform == XE_BATTLEMAGE) {
> + const char *product_name;
> +
> + product_name = dmi_get_system_info(DMI_PRODUCT_NAME);
> + if (product_name && strstr(product_name, "NUC13RNG")) {
> + drm_warn(&xe->drm, "BMG + D3Cold not supported on this platform\n");
> + return 0;
> + }
> + }
>
> return DEFAULT_VRAM_THRESHOLD;
> }
> --
> 2.25.1
>
prev parent reply other threads:[~2026-02-03 20:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 17:32 [PATCH] drm/xe/pm: Disable D3Cold for BMG only on specific platforms Karthik Poosa
2026-01-23 22:45 ` Vivi, Rodrigo
2026-02-03 20:02 ` Rodrigo Vivi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYJUPUhGFMwSlajP@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=badal.nilawar@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=karthik.poosa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox