Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/pm: Disable D3Cold for BMG only on specific platforms
@ 2026-01-23 17:32 Karthik Poosa
  2026-01-23 22:45 ` Vivi, Rodrigo
  2026-02-03 20:02 ` Rodrigo Vivi
  0 siblings, 2 replies; 3+ messages in thread
From: Karthik Poosa @ 2026-01-23 17:32 UTC (permalink / raw)
  To: intel-xe; +Cc: anshuman.gupta, badal.nilawar, rodrigo.vivi, Karthik Poosa

Restrict D3Cold disablement for BMG to unsupported NUC platforms,
instead of disabling it on all platforms.

Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
Fixes: 3e331a6715ee ("drm/xe/pm: Temporarily disable D3Cold on BMG")
---
 drivers/gpu/drm/xe/xe_pm.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
index 559cf5490ac0..01185f10a883 100644
--- a/drivers/gpu/drm/xe/xe_pm.c
+++ b/drivers/gpu/drm/xe/xe_pm.c
@@ -8,6 +8,7 @@
 #include <linux/fault-inject.h>
 #include <linux/pm_runtime.h>
 #include <linux/suspend.h>
+#include <linux/dmi.h>
 
 #include <drm/drm_managed.h>
 #include <drm/ttm/ttm_placement.h>
@@ -366,9 +367,15 @@ ALLOW_ERROR_INJECTION(xe_pm_init_early, ERRNO); /* See xe_pci_probe() */
 
 static u32 vram_threshold_value(struct xe_device *xe)
 {
-	/* FIXME: D3Cold temporarily disabled by default on BMG */
-	if (xe->info.platform == XE_BATTLEMAGE)
-		return 0;
+	if (xe->info.platform == XE_BATTLEMAGE) {
+		const char *product_name;
+
+		product_name = dmi_get_system_info(DMI_PRODUCT_NAME);
+		if (product_name && strstr(product_name, "NUC13RNG")) {
+			drm_warn(&xe->drm, "BMG + D3Cold not supported on this platform\n");
+			return 0;
+		}
+	}
 
 	return DEFAULT_VRAM_THRESHOLD;
 }
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/xe/pm: Disable D3Cold for BMG only on specific platforms
  2026-01-23 17:32 [PATCH] drm/xe/pm: Disable D3Cold for BMG only on specific platforms Karthik Poosa
@ 2026-01-23 22:45 ` Vivi, Rodrigo
  2026-02-03 20:02 ` Rodrigo Vivi
  1 sibling, 0 replies; 3+ messages in thread
From: Vivi, Rodrigo @ 2026-01-23 22:45 UTC (permalink / raw)
  To: intel-xe@lists.freedesktop.org, Poosa,  Karthik, Dugast, Francois
  Cc: Nilawar, Badal, Gupta, Anshuman

On Fri, 2026-01-23 at 23:02 +0530, Karthik Poosa wrote:
> Restrict D3Cold disablement for BMG to unsupported NUC platforms,
> instead of disabling it on all platforms.
> 

Cc: Francois Dugast <francois.dugast@intel.com>

Francois, could you please git it a try on your NuC?

> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
> Fixes: 3e331a6715ee ("drm/xe/pm: Temporarily disable D3Cold on BMG")
> ---
>  drivers/gpu/drm/xe/xe_pm.c | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> index 559cf5490ac0..01185f10a883 100644
> --- a/drivers/gpu/drm/xe/xe_pm.c
> +++ b/drivers/gpu/drm/xe/xe_pm.c
> @@ -8,6 +8,7 @@
>  #include <linux/fault-inject.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/suspend.h>
> +#include <linux/dmi.h>
>  
>  #include <drm/drm_managed.h>
>  #include <drm/ttm/ttm_placement.h>
> @@ -366,9 +367,15 @@ ALLOW_ERROR_INJECTION(xe_pm_init_early, ERRNO);
> /* See xe_pci_probe() */
>  
>  static u32 vram_threshold_value(struct xe_device *xe)
>  {
> -	/* FIXME: D3Cold temporarily disabled by default on BMG */
> -	if (xe->info.platform == XE_BATTLEMAGE)
> -		return 0;
> +	if (xe->info.platform == XE_BATTLEMAGE) {
> +		const char *product_name;
> +
> +		product_name =
> dmi_get_system_info(DMI_PRODUCT_NAME);
> +		if (product_name && strstr(product_name,
> "NUC13RNG")) {

That is really Neat!

> +			drm_warn(&xe->drm, "BMG + D3Cold not
> supported on this platform\n");

I don't believe BMG is needed in this message... 
Probably something like
"D3Cold blocked in this host: %s\n" ,product_name 

?!

> +			return 0;
> +		}
> +	}
>  
>  	return DEFAULT_VRAM_THRESHOLD;
>  }

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/xe/pm: Disable D3Cold for BMG only on specific platforms
  2026-01-23 17:32 [PATCH] drm/xe/pm: Disable D3Cold for BMG only on specific platforms Karthik Poosa
  2026-01-23 22:45 ` Vivi, Rodrigo
@ 2026-02-03 20:02 ` Rodrigo Vivi
  1 sibling, 0 replies; 3+ messages in thread
From: Rodrigo Vivi @ 2026-02-03 20:02 UTC (permalink / raw)
  To: Karthik Poosa; +Cc: intel-xe, anshuman.gupta, badal.nilawar

On Fri, Jan 23, 2026 at 11:02:38PM +0530, Karthik Poosa wrote:
> Restrict D3Cold disablement for BMG to unsupported NUC platforms,
> instead of disabling it on all platforms.
> 
> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
> Fixes: 3e331a6715ee ("drm/xe/pm: Temporarily disable D3Cold on BMG")


Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

and pushing it right now...

> ---
>  drivers/gpu/drm/xe/xe_pm.c | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pm.c b/drivers/gpu/drm/xe/xe_pm.c
> index 559cf5490ac0..01185f10a883 100644
> --- a/drivers/gpu/drm/xe/xe_pm.c
> +++ b/drivers/gpu/drm/xe/xe_pm.c
> @@ -8,6 +8,7 @@
>  #include <linux/fault-inject.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/suspend.h>
> +#include <linux/dmi.h>
>  
>  #include <drm/drm_managed.h>
>  #include <drm/ttm/ttm_placement.h>
> @@ -366,9 +367,15 @@ ALLOW_ERROR_INJECTION(xe_pm_init_early, ERRNO); /* See xe_pci_probe() */
>  
>  static u32 vram_threshold_value(struct xe_device *xe)
>  {
> -	/* FIXME: D3Cold temporarily disabled by default on BMG */
> -	if (xe->info.platform == XE_BATTLEMAGE)
> -		return 0;
> +	if (xe->info.platform == XE_BATTLEMAGE) {
> +		const char *product_name;
> +
> +		product_name = dmi_get_system_info(DMI_PRODUCT_NAME);
> +		if (product_name && strstr(product_name, "NUC13RNG")) {
> +			drm_warn(&xe->drm, "BMG + D3Cold not supported on this platform\n");
> +			return 0;
> +		}
> +	}
>  
>  	return DEFAULT_VRAM_THRESHOLD;
>  }
> -- 
> 2.25.1
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-02-03 20:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-23 17:32 [PATCH] drm/xe/pm: Disable D3Cold for BMG only on specific platforms Karthik Poosa
2026-01-23 22:45 ` Vivi, Rodrigo
2026-02-03 20:02 ` Rodrigo Vivi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox