Re: [PATCH v5 9/9] drm/xe/madvise: Enable purgeable buffer object IOCTL support

[Matthew Brost <matthew.brost@intel.com>]

On Wed, Feb 11, 2026 at 08:56:38PM +0530, Arvind Yadav wrote:
> Hook the madvise_purgeable() handler into the madvise IOCTL now that all
> supporting infrastructure is complete:
> 
>  - Core purge implementation (patch 3)
>  - BO state tracking and helpers (patches 1-2)
>  - Per-VMA purgeable state tracking (patch 6)
>  - Shrinker integration for memory reclamation (patch 8)
> 
> This final patch enables userspace to use the DRM_XE_VMA_ATTR_PURGEABLE_STATE
> madvise type to mark buffers as WILLNEED/DONTNEED and receive the retained
> status indicating whether buffers were purged.
> 
> The feature was kept disabled in earlier patches to maintain bisectability
> and ensure all components are in place before exposing to userspace.
> 
> Suggested-by: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> Signed-off-by: Arvind Yadav <arvind.yadav@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_vm_madvise.c | 22 +++++-----------------
>  1 file changed, 5 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_vm_madvise.c b/drivers/gpu/drm/xe/xe_vm_madvise.c
> index 235fff2b654e..20b1ac7e61d6 100644
> --- a/drivers/gpu/drm/xe/xe_vm_madvise.c
> +++ b/drivers/gpu/drm/xe/xe_vm_madvise.c
> @@ -313,18 +313,11 @@ void xe_bo_recompute_purgeable_state(struct xe_bo *bo)
>   *
>   * Handles DONTNEED/WILLNEED/PURGED states. Tracks if any BO was purged
>   * in details->has_purged_bo for later copy to userspace.
> - *
> - * Note: Marked __maybe_unused until hooked into madvise_funcs[] in the
> - * final patch to maintain bisectability. The NULL placeholder in the
> - * array ensures proper -EINVAL return for userspace until all supporting
> - * infrastructure (shrinker, per-VMA tracking) is complete.
>   */
> -static void __maybe_unused madvise_purgeable(struct xe_device *xe,
> -					     struct xe_vm *vm,
> -					     struct xe_vma **vmas,
> -					     int num_vmas,
> -					     struct drm_xe_madvise *op,
> -					     struct xe_madvise_details *details)
> +static void madvise_purgeable(struct xe_device *xe, struct xe_vm *vm,
> +			      struct xe_vma **vmas, int num_vmas,
> +			      struct drm_xe_madvise *op,
> +			      struct xe_madvise_details *details)
>  {
>  	int i;
>  
> @@ -382,12 +375,7 @@ static const madvise_func madvise_funcs[] = {
>  	[DRM_XE_MEM_RANGE_ATTR_PREFERRED_LOC] = madvise_preferred_mem_loc,
>  	[DRM_XE_MEM_RANGE_ATTR_ATOMIC] = madvise_atomic,
>  	[DRM_XE_MEM_RANGE_ATTR_PAT] = madvise_pat_index,
> -	/*
> -	 * Purgeable support implemented but not enabled yet to maintain
> -	 * bisectability. Will be set to madvise_purgeable() in final patch
> -	 * when all infrastructure (shrinker, VMA tracking) is complete.
> -	 */
> -	[DRM_XE_VMA_ATTR_PURGEABLE_STATE] = NULL,
> +	[DRM_XE_VMA_ATTR_PURGEABLE_STATE] = madvise_purgeable,
>  };
>  
>  static u8 xe_zap_ptes_in_madvise_range(struct xe_vm *vm, u64 start, u64 end)
> -- 
> 2.43.0
>