Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Skip BO migration when platform supports CPU atomics on VRAM
@ 2026-02-24  9:27 Varun Gupta
  2026-02-24  9:35 ` ✓ CI.KUnit: success for " Patchwork
  2026-02-24 17:03 ` [PATCH] " Matthew Brost
  0 siblings, 2 replies; 5+ messages in thread
From: Varun Gupta @ 2026-02-24  9:27 UTC (permalink / raw)
  To: intel-xe; +Cc: matthew.brost, himal.prasad.ghimiray, oak.zeng

should_migrate_to_smem() forced any BO marked ATOMIC_GLOBAL
or ATOMIC_CPU out of VRAM on a CPU fault, regardless of whether the
platform actually requires it.

Introduce has_system_atomics_on_vram to the device capability flags.
should_migrate_to_smem() now gates migration on this flag, eliminating
redundant evictions on capable hardware.

Signed-off-by: Varun Gupta <varun.gupta@intel.com>
---
 drivers/gpu/drm/xe/xe_bo.c           | 16 +++++++++-------
 drivers/gpu/drm/xe/xe_device_types.h |  2 ++
 drivers/gpu/drm/xe/xe_pci.c          |  5 ++++-
 3 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
index d6c2cb959cdd..848467ca6700 100644
--- a/drivers/gpu/drm/xe/xe_bo.c
+++ b/drivers/gpu/drm/xe/xe_bo.c
@@ -1771,14 +1771,15 @@ static void xe_gem_object_close(struct drm_gem_object *obj,
 
 static bool should_migrate_to_smem(struct xe_bo *bo)
 {
+	struct xe_device *xe = xe_bo_device(bo);
+
 	/*
-	 * NOTE: The following atomic checks are platform-specific. For example,
-	 * if a device supports CXL atomics, these may not be necessary or
-	 * may behave differently.
+	 * Migrate to system memory only if the platform does not support
+	 * CPU atomics on VRAM.
 	 */
-
-	return bo->attr.atomic_access == DRM_XE_ATOMIC_GLOBAL ||
-	       bo->attr.atomic_access == DRM_XE_ATOMIC_CPU;
+	return (bo->attr.atomic_access == DRM_XE_ATOMIC_GLOBAL ||
+		bo->attr.atomic_access == DRM_XE_ATOMIC_CPU) &&
+	       !xe->info.has_system_atomics_on_vram;
 }
 
 static int xe_bo_wait_usage_kernel(struct xe_bo *bo, struct ttm_operation_ctx *ctx)
@@ -1804,6 +1805,7 @@ static int xe_bo_fault_migrate(struct xe_bo *bo, struct ttm_operation_ctx *ctx,
 			       struct drm_exec *exec)
 {
 	struct ttm_buffer_object *tbo = &bo->ttm;
+	struct xe_device *xe = xe_bo_device(bo);
 	int err = 0;
 
 	if (ttm_manager_type(tbo->bdev, tbo->resource->mem_type)->use_tt) {
@@ -1811,7 +1813,7 @@ static int xe_bo_fault_migrate(struct xe_bo *bo, struct ttm_operation_ctx *ctx,
 		if (!err)
 			err = ttm_bo_populate(&bo->ttm, ctx);
 	} else if (should_migrate_to_smem(bo)) {
-		xe_assert(xe_bo_device(bo), bo->flags & XE_BO_FLAG_SYSTEM);
+		xe_assert(xe, bo->flags & XE_BO_FLAG_SYSTEM);
 		err = xe_bo_migrate(bo, XE_PL_TT, ctx, exec);
 	}
 
diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h
index 8f3ef836541e..2fe643c179fe 100644
--- a/drivers/gpu/drm/xe/xe_device_types.h
+++ b/drivers/gpu/drm/xe/xe_device_types.h
@@ -205,6 +205,8 @@ struct xe_device {
 		u8 has_usm:1;
 		/** @info.has_64bit_timestamp: Device supports 64-bit timestamps */
 		u8 has_64bit_timestamp:1;
+		/** @info.has_system_atomics_on_vram: Supports CPU atomics on VRAM */
+		u8 has_system_atomics_on_vram:1;
 		/** @info.is_dgfx: is discrete device */
 		u8 is_dgfx:1;
 		/** @info.needs_scratch: needs scratch page for oob prefetch to work */
diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
index 56a768f2cfca..f2d86e08e190 100644
--- a/drivers/gpu/drm/xe/xe_pci.c
+++ b/drivers/gpu/drm/xe/xe_pci.c
@@ -925,8 +925,11 @@ static int xe_info_init(struct xe_device *xe,
 
 	xe->info.has_asid = graphics_desc->has_asid;
 	xe->info.has_atomic_enable_pte_bit = graphics_desc->has_atomic_enable_pte_bit;
-	if (xe->info.platform != XE_PVC)
+	if (xe->info.platform != XE_PVC) {
 		xe->info.has_device_atomics_on_smem = 1;
+		/* PVC doesn't support CPU atomics on VRAM, Xe2+ platforms do */
+		xe->info.has_system_atomics_on_vram = 1;
+	}
 
 	xe->info.has_range_tlb_inval = graphics_desc->has_range_tlb_inval;
 	xe->info.has_ctx_tlb_inval = graphics_desc->has_ctx_tlb_inval;
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-02-25  6:58 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-24  9:27 [PATCH] drm/xe: Skip BO migration when platform supports CPU atomics on VRAM Varun Gupta
2026-02-24  9:35 ` ✓ CI.KUnit: success for " Patchwork
2026-02-24 17:03 ` [PATCH] " Matthew Brost
2026-02-25  6:17   ` Gupta, Varun
2026-02-25  6:58     ` Matthew Brost

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox