From: Matthew Brost <matthew.brost@intel.com>
To: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH 2/3] drm/xe/pf: Don't use LMTT page size if no LMTT
Date: Fri, 20 Feb 2026 15:12:06 -0800 [thread overview]
Message-ID: <aZjqRs+U3iLLe0Ph@lstrano-desk.jf.intel.com> (raw)
In-Reply-To: <20260220201857.6113-3-michal.wajdeczko@intel.com>
On Fri, Feb 20, 2026 at 09:18:54PM +0100, Michal Wajdeczko wrote:
> While today all our DGFX platforms have LMTT, we already started
> preparation to do not rely on this assumption. Add check for the
> LMTT presence and return default page size as VRAM/LMEM alignment
> if there is no LMTT.
>
Nit: This should be the 3rd patch in the series.
Anyways LGTM:
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
> drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c b/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
> index 6383763d02ab..3ae83cffe925 100644
> --- a/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
> +++ b/drivers/gpu/drm/xe/xe_gt_sriov_pf_config.c
> @@ -1451,7 +1451,8 @@ int xe_gt_sriov_pf_config_set_fair_dbs(struct xe_gt *gt, unsigned int vfid,
>
> static u64 pf_get_lmem_alignment(struct xe_gt *gt)
> {
> - return xe_lmtt_page_size(>->tile->sriov.pf.lmtt);
> + return xe_device_has_lmtt(gt_to_xe(gt)) ?
> + xe_lmtt_page_size(>_to_tile(gt)->sriov.pf.lmtt) : XE_PAGE_SIZE;
> }
>
> static u64 pf_get_min_spare_lmem(struct xe_gt *gt)
> --
> 2.47.1
>
next prev parent reply other threads:[~2026-02-20 23:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 20:18 [PATCH 0/3] drm/xe/pf: Some VRAM flag improvements Michal Wajdeczko
2026-02-20 20:18 ` [PATCH 1/3] drm/xe/pf: Use explicit VRAM BO flag for VRAM provisioning Michal Wajdeczko
2026-02-20 23:07 ` Matthew Brost
2026-02-20 20:18 ` [PATCH 2/3] drm/xe/pf: Don't use LMTT page size if no LMTT Michal Wajdeczko
2026-02-20 23:12 ` Matthew Brost [this message]
2026-02-20 20:18 ` [PATCH 3/3] drm/xe/pf: Don't force 2MB VRAM alignment Michal Wajdeczko
2026-02-20 23:11 ` Matthew Brost
2026-02-20 20:26 ` ✓ CI.KUnit: success for drm/xe/pf: Some VRAM flag improvements Patchwork
2026-02-20 21:07 ` ✓ Xe.CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZjqRs+U3iLLe0Ph@lstrano-desk.jf.intel.com \
--to=matthew.brost@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox