Re: [PATCH 01/12] drm/xe/cri: Add CRI platform definition

[Shekhar Chauhan <shekhar.chauhan@intel.com>]

On 10/22/2025 10:47, Lucas De Marchi wrote:
> From: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
>
> Add platform definition and PCI IDs for Crescent Island.
>
> Other platforms use INTEL_VGA_DEVICE since they have a
> PCI_BASE_CLASS_DISPLAY class.  This is not the case for CRI, so just
> match on devid, which should be sufficient.
>
> Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Nitpick: Maybe include the Bspec(s) associated with it;

but other than that, LGTM,

Reviewed-by: Shekhar Chauhan <shekhar.chauhan@intel.com>

> ---
>   drivers/gpu/drm/xe/xe_pci.c            | 15 +++++++++++++++
>   drivers/gpu/drm/xe/xe_platform_types.h |  1 +
>   include/drm/intel/pciids.h             |  4 ++++
>   3 files changed, 20 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index c3136141a9536..000bb30b97712 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -396,6 +396,20 @@ static const struct xe_device_desc nvls_desc = {
>   	.vm_max_level = 4,
>   };
>   
> +static const struct xe_device_desc cri_desc = {
> +	DGFX_FEATURES,
> +	PLATFORM(CRESCENTISLAND),
> +	.dma_mask_size = 52,
> +	.has_display = false,
> +	.has_flat_ccs = false,
> +	.has_mbx_power_limits = true,
> +	.has_sriov = true,
> +	.max_gt_per_tile = 2,
> +	.require_force_probe = true,
> +	.va_bits = 57,
> +	.vm_max_level = 4,
> +};
> +
>   #undef PLATFORM
>   __diag_pop();
>   
> @@ -425,6 +439,7 @@ static const struct pci_device_id pciidlist[] = {
>   	INTEL_PTL_IDS(INTEL_VGA_DEVICE, &ptl_desc),
>   	INTEL_WCL_IDS(INTEL_VGA_DEVICE, &ptl_desc),
>   	INTEL_NVLS_IDS(INTEL_VGA_DEVICE, &nvls_desc),
> +	INTEL_CRI_IDS(INTEL_PCI_DEVICE, &cri_desc),
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(pci, pciidlist);
> diff --git a/drivers/gpu/drm/xe/xe_platform_types.h b/drivers/gpu/drm/xe/xe_platform_types.h
> index 78286285c2495..f516dbddfd882 100644
> --- a/drivers/gpu/drm/xe/xe_platform_types.h
> +++ b/drivers/gpu/drm/xe/xe_platform_types.h
> @@ -25,6 +25,7 @@ enum xe_platform {
>   	XE_BATTLEMAGE,
>   	XE_PANTHERLAKE,
>   	XE_NOVALAKE_S,
> +	XE_CRESCENTISLAND,
>   };
>   
>   enum xe_subplatform {
> diff --git a/include/drm/intel/pciids.h b/include/drm/intel/pciids.h
> index 13c592e1a28c7..b258e79b437ac 100644
> --- a/include/drm/intel/pciids.h
> +++ b/include/drm/intel/pciids.h
> @@ -896,4 +896,8 @@
>   	MACRO__(0xD744, ## __VA_ARGS__), \
>   	MACRO__(0xD745, ## __VA_ARGS__)
>   
> +/* CRI */
> +#define INTEL_CRI_IDS(MACRO__, ...) \
> +	MACRO__(0x674C, ## __VA_ARGS__)
> +
>   #endif /* __PCIIDS_H__ */
>