Re: [PATCH v2] drm/xe: Fix exec queue unwind on hw engine group add failure

[Matthew Brost <matthew.brost@intel.com>]

On Tue, Mar 03, 2026 at 11:52:20PM +0000, Shuicheng Lin wrote:
> When xe_hw_engine_group_add_exec_queue() fails in
> xe_exec_queue_create_ioctl(), to undo xe_exec_queue_group_add()
> and xe_vm_add_compute_exec_queue(), the code should unwind through
> kill_exec_queue rather than directly dropping the queue reference.
> 
> Fixes: d9ec63474648 ("drm/xe/multi_queue: Add user interface for multi queue support")
> Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>
> 
> ---
> Cc: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>

Reviewed-by: Matthew Brost <matthew.brost@intel.com>

> 
> v2: correct the jump label from delete_queue_group to kill_exec_queue (Matt)
> ---
>  drivers/gpu/drm/xe/xe_exec_queue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c b/drivers/gpu/drm/xe/xe_exec_queue.c
> index bb273ca02d28..4dc59f448f2e 100644
> --- a/drivers/gpu/drm/xe/xe_exec_queue.c
> +++ b/drivers/gpu/drm/xe/xe_exec_queue.c
> @@ -1297,7 +1297,7 @@ int xe_exec_queue_create_ioctl(struct drm_device *dev, void *data,
>  		if (q->vm && q->hwe->hw_engine_group) {
>  			err = xe_hw_engine_group_add_exec_queue(q->hwe->hw_engine_group, q);
>  			if (err)
> -				goto put_exec_queue;
> +				goto kill_exec_queue;
>  		}
>  	}
>  
> -- 
> 2.50.1
>