public inbox for intel-xe@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH v2] drm/xe: Fix exec queue unwind on hw engine group add failure
@ 2026-03-03 23:52 Shuicheng Lin
  2026-03-04  0:02 ` ✓ CI.KUnit: success for " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 10+ messages in thread
From: Shuicheng Lin @ 2026-03-03 23:52 UTC (permalink / raw)
  To: intel-xe; +Cc: Shuicheng Lin, Niranjana Vishwanathapura, Matthew Brost

When xe_hw_engine_group_add_exec_queue() fails in
xe_exec_queue_create_ioctl(), to undo xe_exec_queue_group_add()
and xe_vm_add_compute_exec_queue(), the code should unwind through
kill_exec_queue rather than directly dropping the queue reference.

Fixes: d9ec63474648 ("drm/xe/multi_queue: Add user interface for multi queue support")
Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>

---
Cc: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>

v2: correct the jump label from delete_queue_group to kill_exec_queue (Matt)
---
 drivers/gpu/drm/xe/xe_exec_queue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c b/drivers/gpu/drm/xe/xe_exec_queue.c
index bb273ca02d28..4dc59f448f2e 100644
--- a/drivers/gpu/drm/xe/xe_exec_queue.c
+++ b/drivers/gpu/drm/xe/xe_exec_queue.c
@@ -1297,7 +1297,7 @@ int xe_exec_queue_create_ioctl(struct drm_device *dev, void *data,
 		if (q->vm && q->hwe->hw_engine_group) {
 			err = xe_hw_engine_group_add_exec_queue(q->hwe->hw_engine_group, q);
 			if (err)
-				goto put_exec_queue;
+				goto kill_exec_queue;
 		}
 	}
 
-- 
2.50.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2026-03-06 13:32 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-03 23:52 [PATCH v2] drm/xe: Fix exec queue unwind on hw engine group add failure Shuicheng Lin
2026-03-04  0:02 ` ✓ CI.KUnit: success for " Patchwork
2026-03-04  0:29 ` [PATCH v2] " Matthew Brost
2026-03-04  1:13 ` ✗ Xe.CI.BAT: failure for " Patchwork
2026-03-04 19:12 ` ✗ Xe.CI.FULL: " Patchwork
2026-03-05 20:27 ` ✓ CI.KUnit: success for drm/xe: Fix exec queue unwind on hw engine group add failure (rev2) Patchwork
2026-03-05 21:23 ` [PATCH v2] drm/xe: Fix exec queue unwind on hw engine group add failure Niranjana Vishwanathapura
2026-03-05 22:49   ` Lin, Shuicheng
2026-03-05 21:39 ` ✗ Xe.CI.BAT: failure for drm/xe: Fix exec queue unwind on hw engine group add failure (rev2) Patchwork
2026-03-06 13:32 ` ✗ Xe.CI.FULL: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox