Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/ufence: Wake up waiters after setting ufence->signalled
@ 2024-11-14 15:05 Nirmoy Das
  2024-11-14 16:17 ` Matthew Brost
                   ` (8 more replies)
  0 siblings, 9 replies; 12+ messages in thread
From: Nirmoy Das @ 2024-11-14 15:05 UTC (permalink / raw)
  To: intel-xe; +Cc: Nirmoy Das, Matthew Brost

If a previous ufence is not signalled, vm_bind will return -EBUSY.
Delaying the modification of ufence->signalled can cause issues if the
UMD reuses the same ufence so update ufence->signalled before waking up
waiters.

Cc: Matthew Brost <matthew.brost@intel.com>
Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/3233
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 drivers/gpu/drm/xe/xe_sync.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_sync.c b/drivers/gpu/drm/xe/xe_sync.c
index a90480c6aecf..42f5bebd09e5 100644
--- a/drivers/gpu/drm/xe/xe_sync.c
+++ b/drivers/gpu/drm/xe/xe_sync.c
@@ -87,8 +87,12 @@ static void user_fence_worker(struct work_struct *w)
 		drm_dbg(&ufence->xe->drm, "mmget_not_zero() failed, ufence wasn't signaled\n");
 	}
 
-	wake_up_all(&ufence->xe->ufence_wq);
+	/*
+	 * Wake up waiters only after updating the ufence state, allowing the UMD
+	 * to safely reuse the same ufence without encountering -EBUSY errors.
+	 */
 	WRITE_ONCE(ufence->signalled, 1);
+	wake_up_all(&ufence->xe->ufence_wq);
 	user_fence_put(ufence);
 }
 
-- 
2.46.0


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2024-11-15 13:21 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-14 15:05 [PATCH] drm/xe/ufence: Wake up waiters after setting ufence->signalled Nirmoy Das
2024-11-14 16:17 ` Matthew Brost
2024-11-14 16:22   ` Nirmoy Das
2024-11-14 17:40 ` ✓ CI.Patch_applied: success for " Patchwork
2024-11-14 17:41 ` ✓ CI.checkpatch: " Patchwork
2024-11-14 17:42 ` ✓ CI.KUnit: " Patchwork
2024-11-14 17:53 ` ✓ CI.Build: " Patchwork
2024-11-14 17:56 ` ✓ CI.Hooks: " Patchwork
2024-11-14 17:57 ` ✓ CI.checksparse: " Patchwork
2024-11-14 18:23 ` ✓ CI.BAT: " Patchwork
2024-11-15 11:21 ` ✗ CI.FULL: failure " Patchwork
2024-11-15 13:21   ` Nirmoy Das

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox