Re: [PATCH 1/2] drm/xe/tests/pci: Convert GT count check to general device check

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 10/16/2025 7:49 PM, Gustavo Sousa wrote:
> We already have check_graphics_ip() and check_media_ip() as general
> functions to check the IP descriptors.  The check in
> check_platform_gt_count() is simple enough such that we can convert the
> function to a more general device check.  In an upcoming change, we will
> also add some checks for other members of struct xe_device_desc.
> 
> As such, rename check_platform_gt_count() to check_platform_desc().
> While at it, use inline (int) casting of max_gt_per_tile to keeps checks
> for each member localized.
> 
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
> ---
>  drivers/gpu/drm/xe/tests/xe_pci_test.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/tests/xe_pci_test.c b/drivers/gpu/drm/xe/tests/xe_pci_test.c
> index 37b344df2dc3..f09efb523b7e 100644
> --- a/drivers/gpu/drm/xe/tests/xe_pci_test.c
> +++ b/drivers/gpu/drm/xe/tests/xe_pci_test.c
> @@ -44,21 +44,20 @@ static void check_media_ip(struct kunit *test)
>  	KUNIT_ASSERT_EQ(test, mask, 0);
>  }
>  
> -static void check_platform_gt_count(struct kunit *test)
> +static void check_platform_desc(struct kunit *test)
>  {
>  	const struct pci_device_id *pci = test->param_value;
>  	const struct xe_device_desc *desc =
>  		(const struct xe_device_desc *)pci->driver_data;
> -	int max_gt = desc->max_gt_per_tile;
>  
> -	KUNIT_ASSERT_GT(test, max_gt, 0);
> -	KUNIT_ASSERT_LE(test, max_gt, XE_MAX_GT_PER_TILE);
> +	KUNIT_ASSERT_GT(test, (int)desc->max_gt_per_tile, 0);
> +	KUNIT_ASSERT_LE(test, (int)desc->max_gt_per_tile, XE_MAX_GT_PER_TILE);

nit: maybe cast to (unsigned int) or just to (u8) since this is base type for this bitfield in the struct ?
and maybe use KUNIT_EXPECT since there is no need to stop the test after finding first bad field ?

anyway, LGTM

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

>  }
>  
>  static struct kunit_case xe_pci_tests[] = {
>  	KUNIT_CASE_PARAM(check_graphics_ip, xe_pci_graphics_ip_gen_param),
>  	KUNIT_CASE_PARAM(check_media_ip, xe_pci_media_ip_gen_param),
> -	KUNIT_CASE_PARAM(check_platform_gt_count, xe_pci_id_gen_param),
> +	KUNIT_CASE_PARAM(check_platform_desc, xe_pci_id_gen_param),
>  	{}
>  };
>  
>