From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: "Suraj Kandpal" <suraj.kandpal@intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v3] drm/i915: split out display register macros to a separate file
Date: Thu, 05 Jun 2025 15:42:13 +0300 [thread overview]
Message-ID: <ae7026aee5943df7693f25a04e6b1b8185494dc6@intel.com> (raw)
In-Reply-To: <20250604110225.993638-1-jani.nikula@intel.com>
On Wed, 04 Jun 2025, Jani Nikula <jani.nikula@intel.com> wrote:
> This is a scripted split of the display related register macros from
> i915_reg.h to display/intel_display_regs.h. As a starting point, move
> all the macros that are only used in display code (or GVT). If there are
> users in core i915 code or soc/, or no users anywhere, keep the macros
> in i915_reg.h. This is done in groups of macros separated by blank
> lines, moving the comments along with the groups.
>
> Some manually picked macro groups are kept/moved regardless of the
> heuristics above.
>
> This is obviously a very crude approach. It's not perfect. But there are
> 4.2k lines in i915_reg.h, and its refactoring has ground to a halt. This
> is the big hammer that splits the file to two, and enables further
> cleanup.
Note: This is already stale. Will need to be redone.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2025-06-05 12:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 11:02 [PATCH v3] drm/i915: split out display register macros to a separate file Jani Nikula
2025-06-04 12:09 ` ✓ CI.Patch_applied: success for " Patchwork
2025-06-04 12:09 ` ✗ CI.checkpatch: warning " Patchwork
2025-06-04 12:11 ` ✓ CI.KUnit: success " Patchwork
2025-06-04 12:21 ` ✓ CI.Build: " Patchwork
2025-06-04 12:24 ` ✓ CI.Hooks: " Patchwork
2025-06-04 12:25 ` ✓ CI.checksparse: " Patchwork
2025-06-04 13:38 ` ✓ Xe.CI.BAT: " Patchwork
2025-06-05 7:59 ` ✗ Xe.CI.Full: failure " Patchwork
2025-06-05 12:42 ` Jani Nikula [this message]
2025-06-05 15:34 ` [PATCH v3] " Lucas De Marchi
2025-06-06 9:59 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae7026aee5943df7693f25a04e6b1b8185494dc6@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=suraj.kandpal@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox