Re: [PATCH v3] drm/i915: split out display register macros to a separate file

[Jani Nikula <jani.nikula@intel.com>]

On Thu, 05 Jun 2025, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> On Wed, Jun 04, 2025 at 02:02:25PM +0300, Jani Nikula wrote:
>>This is a scripted split of the display related register macros from
>>i915_reg.h to display/intel_display_regs.h. As a starting point, move
>>all the macros that are only used in display code (or GVT). If there are
>>users in core i915 code or soc/, or no users anywhere, keep the macros
>>in i915_reg.h. This is done in groups of macros separated by blank
>>lines, moving the comments along with the groups.
>
> I wonder if with this we couldn't end up moving wrong registers.
> Maybe we should double check the address range too?

I think at this point aiming for perfection in the split is already
blocking progress.

It's been almost four months since I posted this first, and I've mostly
just been polishing the 300+ lines of python/bash scripts to do
this. And that's all for a one time change, after which the scripts are
useless.

We could've merged the first version, fixed the issues in the following
months, and we would be ahead.

IMO just getting the first split done is the most important part,
because 4k lines is impossible to navigate manually.


BR,
Jani.


-- 
Jani Nikula, Intel