From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, <vinay.belgaumkar@intel.com>,
<badal.nilawar@intel.com>, <sk.anirban@intel.com>
Subject: Re: [PATCH v1 2/2] drm/xe/gt: Drop redundant forcewake
Date: Wed, 22 Apr 2026 08:46:52 -0400 [thread overview]
Message-ID: <aejDPGmswKnEluQE@intel.com> (raw)
In-Reply-To: <20260422121128.1002031-3-raag.jadav@intel.com>
On Wed, Apr 22, 2026 at 05:40:57PM +0530, Raag Jadav wrote:
> xe_gt_suspend_prepare() doesn't require forcewake in it's code path.
> Drop it.
Why? The commit message should explain why it doesn't need...
>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---
> drivers/gpu/drm/xe/xe_gt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
> index 6d6f5a10fe85..168c700af701 100644
> --- a/drivers/gpu/drm/xe/xe_gt.c
> +++ b/drivers/gpu/drm/xe/xe_gt.c
> @@ -1041,7 +1041,6 @@ void xe_gt_reset_async(struct xe_gt *gt)
>
> void xe_gt_suspend_prepare(struct xe_gt *gt)
> {
> - CLASS(xe_force_wake, fw_ref)(gt_to_fw(gt), XE_FORCEWAKE_ALL);
> xe_uc_suspend_prepare(>->uc);
> }
>
> --
> 2.43.0
>
next prev parent reply other threads:[~2026-04-22 12:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 12:10 [PATCH v1 0/2] Minor GuC PC cleanups Raag Jadav
2026-04-22 12:10 ` [PATCH v1 1/2] drm/xe/guc: Make xe_guc_pc_stop() void Raag Jadav
2026-04-22 12:46 ` Rodrigo Vivi
2026-04-22 12:10 ` [PATCH v1 2/2] drm/xe/gt: Drop redundant forcewake Raag Jadav
2026-04-22 12:46 ` Rodrigo Vivi [this message]
2026-04-22 12:21 ` ✓ CI.KUnit: success for Minor GuC PC cleanups Patchwork
2026-04-22 13:11 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-23 6:23 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aejDPGmswKnEluQE@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=badal.nilawar@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=raag.jadav@intel.com \
--cc=sk.anirban@intel.com \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox