* [PATCH] drm/xe: Remove redundant exec_queue_suspended() check in submit_exec_queue()
@ 2026-06-17 1:25 yaolu
2026-06-17 10:15 ` Rodrigo Vivi
0 siblings, 1 reply; 2+ messages in thread
From: yaolu @ 2026-06-17 1:25 UTC (permalink / raw)
To: matthew.brost, thomas.hellstrom, rodrigo.vivi
Cc: niranjana.vishwanathapura, daniele.ceraolospurio, intel-xe,
dri-devel, linux-kernel, Lu Yao
From: Lu Yao <yaolu@kylinos.cn>
There already has a check for exec_queue_suspended(q) that returns early
if suspended.
Fixes: ec4cbdd163f9 ("drm/xe/multi_queue: skip submit when primary queue is suspended")
Signed-off-by: Lu Yao <yaolu@kylinos.cn>
---
drivers/gpu/drm/xe/xe_guc_submit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index 42110e01b7d0..dce0ecb7ea35 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -1159,7 +1159,7 @@ static void submit_exec_queue(struct xe_exec_queue *q, struct xe_sched_job *job)
if (exec_queue_suspended(q))
return;
- if (!exec_queue_enabled(q) && !exec_queue_suspended(q)) {
+ if (!exec_queue_enabled(q)) {
action[len++] = XE_GUC_ACTION_SCHED_CONTEXT_MODE_SET;
action[len++] = q->guc->id;
action[len++] = GUC_CONTEXT_ENABLE;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/xe: Remove redundant exec_queue_suspended() check in submit_exec_queue()
2026-06-17 1:25 [PATCH] drm/xe: Remove redundant exec_queue_suspended() check in submit_exec_queue() yaolu
@ 2026-06-17 10:15 ` Rodrigo Vivi
0 siblings, 0 replies; 2+ messages in thread
From: Rodrigo Vivi @ 2026-06-17 10:15 UTC (permalink / raw)
To: yaolu
Cc: matthew.brost, thomas.hellstrom, niranjana.vishwanathapura,
daniele.ceraolospurio, intel-xe, dri-devel, linux-kernel
On Wed, Jun 17, 2026 at 09:25:16AM +0800, yaolu@kylinos.cn wrote:
> From: Lu Yao <yaolu@kylinos.cn>
>
> There already has a check for exec_queue_suspended(q) that returns early
> if suspended.
>
> Fixes: ec4cbdd163f9 ("drm/xe/multi_queue: skip submit when primary queue is suspended")
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
and pushed, thanks for the patch
> Signed-off-by: Lu Yao <yaolu@kylinos.cn>
> ---
> drivers/gpu/drm/xe/xe_guc_submit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index 42110e01b7d0..dce0ecb7ea35 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -1159,7 +1159,7 @@ static void submit_exec_queue(struct xe_exec_queue *q, struct xe_sched_job *job)
> if (exec_queue_suspended(q))
> return;
>
> - if (!exec_queue_enabled(q) && !exec_queue_suspended(q)) {
> + if (!exec_queue_enabled(q)) {
> action[len++] = XE_GUC_ACTION_SCHED_CONTEXT_MODE_SET;
> action[len++] = q->guc->id;
> action[len++] = GUC_CONTEXT_ENABLE;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-17 10:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-17 1:25 [PATCH] drm/xe: Remove redundant exec_queue_suspended() check in submit_exec_queue() yaolu
2026-06-17 10:15 ` Rodrigo Vivi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox