Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v1 1/2] drm/xe: Use IBC v3 on PTL
Date: Fri, 3 Jul 2026 14:31:57 -0400	[thread overview]
Message-ID: <akgAHRTrZepT1yb8@intel.com> (raw)
In-Reply-To: <20260702005614.2621735-2-vinay.belgaumkar@intel.com>

On Wed, Jul 01, 2026 at 05:56:13PM -0700, Vinay Belgaumkar wrote:
> Intelligent Bias Control (IBC) v3 algorithm in GuC has PTL specific
> optimizations. This version selection param is only available GuC 70.48.0
> onwards.
> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/abi/guc_actions_slpc_abi.h | 1 +
>  drivers/gpu/drm/xe/xe_guc_pc.c                | 9 +++++++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/abi/guc_actions_slpc_abi.h b/drivers/gpu/drm/xe/abi/guc_actions_slpc_abi.h
> index ce5c59517528..57baa68bcba4 100644
> --- a/drivers/gpu/drm/xe/abi/guc_actions_slpc_abi.h
> +++ b/drivers/gpu/drm/xe/abi/guc_actions_slpc_abi.h
> @@ -119,6 +119,7 @@ enum slpc_param_id {
>  	SLPC_PARAM_STRATEGIES = 26,
>  	SLPC_PARAM_POWER_PROFILE = 27,
>  	SLPC_PARAM_IGNORE_EFFICIENT_FREQUENCY = 28,
> +	SLPC_PARAM_SET_IBC_VERSION = 29,
>  	SLPC_MAX_PARAM = 32,
>  };
>  
> diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
> index 59f2fa79ad42..0d55d6b00cd9 100644
> --- a/drivers/gpu/drm/xe/xe_guc_pc.c
> +++ b/drivers/gpu/drm/xe/xe_guc_pc.c
> @@ -1236,6 +1236,15 @@ static int pc_modify_defaults(struct xe_guc_pc *pc)
>  		ret = pc_action_set_dcc(pc, false);
>  		if (unlikely(ret))
>  			xe_gt_err(gt, "Failed to modify DCC default: %pe\n", ERR_PTR(ret));
> +
> +		if (xe_gt_is_main_type(gt) &&
> +		    GUC_FIRMWARE_VER_AT_LEAST(&gt->uc.guc, 70, 48, 0)) {
> +			ret = pc_action_set_param(pc,
> +						  SLPC_PARAM_SET_IBC_VERSION,
> +						  3);
> +			if (unlikely(ret))
> +				xe_gt_err(gt, "Failed to modify IBC version: %pe\n", ERR_PTR(ret));
> +		}
>  	}
>  
>  	return ret;
> -- 
> 2.38.1
> 

  reply	other threads:[~2026-07-03 18:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02  0:56 [PATCH v1 0/2] drm/xe: Use IBC v3 on PTL Vinay Belgaumkar
2026-07-02  0:56 ` [PATCH v1 1/2] " Vinay Belgaumkar
2026-07-03 18:31   ` Rodrigo Vivi [this message]
2026-07-02  0:56 ` [PATCH v1 2/2] drm/xe: Add sysfs for GT/IA bias Vinay Belgaumkar
2026-07-03 18:31   ` Rodrigo Vivi
2026-07-05  8:04     ` Belgaumkar, Vinay
2026-07-02  1:09 ` ✓ CI.KUnit: success for drm/xe: Use IBC v3 on PTL Patchwork
2026-07-02  2:02 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-02 21:06 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=akgAHRTrZepT1yb8@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=vinay.belgaumkar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox