* [PATCH i-g-t v2 1/7] lib/igt_cgroup: add cgroup v2 and dmem controller helpers
2026-07-02 13:00 [PATCH i-g-t v3 0/7] add dmem_cgroups test Thadeu Lima de Souza Cascardo
@ 2026-07-02 13:00 ` Thadeu Lima de Souza Cascardo
2026-07-02 13:00 ` [PATCH i-g-t v2 2/7] tests/cgroup_dmem: add dmem cgroup controller test Thadeu Lima de Souza Cascardo
` (7 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2026-07-02 13:00 UTC (permalink / raw)
To: igt-dev
Cc: siqueira, Thomas Hellström, dri-devel, amd-gfx, intel-xe,
Christian Koenig, maarten.lankhorst, Kamil Konieczny,
Janusz Krzysztofik, Vitaly Prosyak, Natalie Vock, Tvrtko Ursulin,
kernel-dev
From: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Add igt_cgroup, a library module providing helpers to create and manage
cgroup v2 sub-cgroups from IGT tests, with support for the dmem
controller that governs device memory (e.g. GPU VRAM) limits.
The API covers:
- igt_cgroup_new() / igt_cgroup_free(): create and destroy a named
sub-cgroup under the unified cgroupv2 hierarchy, enabling the dmem
controller automatically.
- igt_cgroup_move_current(): move the calling process into a cgroup.
- igt_cgroup_dmem_set/get_max/min/low(): write and read dmem.max,
dmem.min and dmem.low for a named device memory region.
- igt_cgroup_dmem_get_current(): read current per-cgroup device memory
usage.
- igt_cgroup_dmem_get_system_current(): read system-wide device memory
usage from the root cgroup.
- igt_cgroup_dmem_get_capacity(): read total region capacity from the
root cgroup's dmem.capacity file.
- igt_cgroup_dmem_regions() / igt_cgroup_dmem_regions_free(): enumerate
all registered device memory regions.
All public API functions that can fail use igt_assert internally rather
than returning error codes, following the IGT convention.
Assisted-by: GitHub Copilot:claude-sonnet-4.6
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
lib/igt.h | 1 +
lib/igt_cgroup.c | 638 +++++++++++++++++++++++++++++++++++++++++++++++
lib/igt_cgroup.h | 56 +++++
lib/meson.build | 1 +
4 files changed, 696 insertions(+)
create mode 100644 lib/igt_cgroup.c
create mode 100644 lib/igt_cgroup.h
diff --git a/lib/igt.h b/lib/igt.h
index 173ca70bff28..d8e5de7dcd2f 100644
--- a/lib/igt.h
+++ b/lib/igt.h
@@ -27,6 +27,7 @@
#include "drmtest.h"
#include "i915_3d.h"
#include "igt_aux.h"
+#include "igt_cgroup.h"
#include "igt_configfs.h"
#include "igt_core.h"
#include "igt_debugfs.h"
diff --git a/lib/igt_cgroup.c b/lib/igt_cgroup.c
new file mode 100644
index 000000000000..60586ccc4861
--- /dev/null
+++ b/lib/igt_cgroup.c
@@ -0,0 +1,638 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2025 Intel Corporation
+ */
+
+/**
+ * SECTION:igt_cgroup
+ * @short_description: cgroup v2 helpers for IGT tests
+ * @title: cgroup
+ * @include: igt_cgroup.h
+ *
+ * This library provides helpers for creating and managing cgroup v2
+ * sub-cgroups from IGT tests, including support for the dmem controller
+ * which governs device memory (e.g. GPU VRAM) limits.
+ */
+
+#include <errno.h>
+#include <fcntl.h>
+#include <inttypes.h>
+#include <limits.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <sys/stat.h>
+#include <sys/statfs.h>
+#include <sys/types.h>
+#include <unistd.h>
+
+#include "igt_cgroup.h"
+#include "igt_core.h"
+#include "igt_fs.h"
+
+#ifndef CGROUP2_SUPER_MAGIC
+#define CGROUP2_SUPER_MAGIC 0x63677270
+#endif
+
+/**
+ * struct igt_cgroup - Opaque handle to a cgroup v2 sub-cgroup.
+ * @dirfd: File descriptor for the cgroup directory.
+ * @path: Absolute path to the cgroup directory.
+ * @parent_path: Absolute path to the parent cgroup directory.
+ *
+ * Allocated by igt_cgroup_new() and freed by igt_cgroup_free().
+ */
+struct igt_cgroup {
+ int dirfd;
+ char *path;
+ char *parent_path;
+};
+
+static const char *cgroupv2_mount(void)
+{
+ static const char *path;
+ static const char * const candidates[] = {
+ "/sys/fs/cgroup",
+ "/sys/fs/cgroup/unified",
+ NULL,
+ };
+ struct statfs st;
+ int i;
+
+ if (path)
+ return path;
+
+ for (i = 0; candidates[i]; i++) {
+ if (statfs(candidates[i], &st) == 0 &&
+ (unsigned long)st.f_type == CGROUP2_SUPER_MAGIC) {
+ path = candidates[i];
+ return path;
+ }
+ }
+
+ return NULL;
+}
+
+/*
+ * Write "+controller" to @cgroup_path/cgroup.subtree_control to enable
+ * the named controller for children of that cgroup.
+ */
+static int enable_controller(const char *cgroup_path, const char *controller)
+{
+ char path[PATH_MAX];
+ char cmd[64];
+ ssize_t ret;
+ int fd;
+
+ snprintf(path, sizeof(path), "%s/cgroup.subtree_control", cgroup_path);
+ snprintf(cmd, sizeof(cmd), "+%s", controller);
+
+ fd = open(path, O_WRONLY);
+ if (fd < 0)
+ return -errno;
+
+ ret = write(fd, cmd, strlen(cmd));
+ close(fd);
+
+ return (ret < 0) ? -errno : 0;
+}
+
+/*
+ * Move every PID listed in @cgroup_path/cgroup.procs to
+ * @parent_path/cgroup.procs. Silently ignores individual failures
+ * (a PID may have exited between reading and writing).
+ */
+static void drain_procs_to_parent(const char *cgroup_path,
+ const char *parent_path)
+{
+ char proc_path[PATH_MAX];
+ char parent_procs[PATH_MAX];
+ int parent_fd;
+ FILE *f;
+ int pid;
+
+ snprintf(proc_path, sizeof(proc_path), "%s/cgroup.procs", cgroup_path);
+ snprintf(parent_procs, sizeof(parent_procs), "%s/cgroup.procs", parent_path);
+
+ parent_fd = open(parent_procs, O_WRONLY);
+ if (parent_fd < 0)
+ return;
+
+ f = fopen(proc_path, "r");
+ if (f) {
+ while (fscanf(f, "%d", &pid) == 1) {
+ char pidbuf[32];
+ ssize_t len = snprintf(pidbuf, sizeof(pidbuf), "%d", pid);
+
+ write(parent_fd, pidbuf, len);
+ }
+ fclose(f);
+ }
+
+ close(parent_fd);
+}
+
+/**
+ * igt_cgroup_new() - Create a new cgroup v2 sub-cgroup.
+ * @name: Name for the new cgroup directory.
+ *
+ * Creates a sub-cgroup named @name under the system's unified cgroupv2
+ * hierarchy. The dmem controller is enabled in the parent's
+ * subtree_control so that igt_cgroup_dmem_set_max() and friends take effect
+ * immediately.
+ *
+ * Return: Pointer to an &struct igt_cgroup on success, %NULL on failure.
+ */
+struct igt_cgroup *igt_cgroup_new(const char *name)
+{
+ struct igt_cgroup *cg;
+ const char *mount;
+ int ret;
+
+ mount = cgroupv2_mount();
+ if (!mount) {
+ igt_debug("cgroup v2 not found\n");
+ return NULL;
+ }
+
+ cg = calloc(1, sizeof(*cg));
+ if (!cg)
+ return NULL;
+
+ cg->parent_path = strdup(mount);
+ if (!cg->parent_path)
+ goto err_free;
+
+ if (asprintf(&cg->path, "%s/%s", mount, name) < 0) {
+ cg->path = NULL;
+ goto err_parent;
+ }
+
+ /*
+ * Try to enable the dmem controller in the parent's subtree_control.
+ * Ignore EINVAL which the kernel returns when the controller is already
+ * listed (i.e. already enabled).
+ */
+ ret = enable_controller(mount, "dmem");
+ if (ret < 0 && ret != -EINVAL)
+ igt_debug("Failed to enable dmem controller in %s: %d\n",
+ mount, ret);
+
+ if (mkdir(cg->path, 0755) < 0 && errno != EEXIST) {
+ igt_debug("Failed to create cgroup %s: %m\n", cg->path);
+ goto err_path;
+ }
+
+ cg->dirfd = open(cg->path, O_RDONLY | O_DIRECTORY);
+ if (cg->dirfd < 0) {
+ igt_debug("Failed to open cgroup dir %s: %m\n", cg->path);
+ goto err_rmdir;
+ }
+
+ return cg;
+
+err_rmdir:
+ rmdir(cg->path);
+err_path:
+ free(cg->path);
+err_parent:
+ free(cg->parent_path);
+err_free:
+ free(cg);
+ return NULL;
+}
+
+/**
+ * igt_cgroup_free() - Destroy a cgroup and release its resources.
+ * @cg: The cgroup to destroy.
+ *
+ * Moves any processes still running inside @cg back to the parent cgroup,
+ * removes the cgroup directory, and frees all associated memory.
+ * After this call @cg must not be used.
+ */
+void igt_cgroup_free(struct igt_cgroup *cg)
+{
+ if (!cg)
+ return;
+
+ drain_procs_to_parent(cg->path, cg->parent_path);
+
+ close(cg->dirfd);
+
+ if (rmdir(cg->path) < 0)
+ igt_debug("Failed to remove cgroup %s: %m\n", cg->path);
+
+ free(cg->path);
+ free(cg->parent_path);
+ free(cg);
+}
+
+/**
+ * igt_cgroup_move_current() - Move the calling process into a cgroup.
+ * @cg: Target cgroup.
+ *
+ * Writes the calling process's PID to @cg's cgroup.procs file, transferring
+ * it into the cgroup. All threads of the process move together.
+ * Fails the test via igt_assert on error.
+ */
+void igt_cgroup_move_current(struct igt_cgroup *cg)
+{
+ char pidbuf[32];
+ ssize_t len;
+ int fd, ret;
+
+ len = snprintf(pidbuf, sizeof(pidbuf), "%d", (int)getpid());
+
+ fd = openat(cg->dirfd, "cgroup.procs", O_WRONLY);
+ igt_assert_f(fd >= 0, "Failed to open cgroup.procs: %m\n");
+
+ ret = write(fd, pidbuf, len);
+ close(fd);
+
+ igt_assert_f(ret == len, "Failed to write PID to cgroup.procs: %m\n");
+}
+
+/*
+ * Parse a single dmem interface file line of the form "region_name value\n"
+ * where value is either a decimal byte count or the string "max".
+ * Returns 0 and writes to *out on success, -EINVAL on parse error.
+ */
+static int dmem_parse_line(char *line, const char *region, uint64_t *out)
+{
+ char *space = strchr(line, ' ');
+
+ if (!space)
+ return -EINVAL;
+
+ *space = '\0';
+ if (strcmp(line, region) != 0)
+ return -ENOENT;
+
+ if (strcmp(space + 1, "max") == 0) {
+ *out = IGT_CGROUP_DMEM_MAX;
+ return 0;
+ }
+
+ errno = 0;
+ *out = strtoull(space + 1, &space, 10);
+ if (errno || *space != '\0')
+ return -EINVAL;
+
+ return 0;
+}
+
+/*
+ * Read a dmem interface file opened relative to @dirfd, searching for
+ * @region. On success writes the region's value to @out and returns 0.
+ * Returns -ENOENT when @region is absent, or a negative errno otherwise.
+ */
+static int dmem_read_region(int dirfd, const char *file,
+ const char *region, uint64_t *out)
+{
+ char buf[4096];
+ char *line, *saveptr;
+ ssize_t n;
+ int fd;
+
+ fd = openat(dirfd, file, O_RDONLY);
+ if (fd < 0)
+ return -errno;
+
+ n = igt_readn(fd, buf, sizeof(buf) - 1);
+ close(fd);
+ if (n < 0)
+ return (int)n;
+ buf[n] = '\0';
+
+ for (line = strtok_r(buf, "\n", &saveptr); line;
+ line = strtok_r(NULL, "\n", &saveptr)) {
+ int ret = dmem_parse_line(line, region, out);
+
+ if (ret != -ENOENT)
+ return ret;
+ }
+
+ return -ENOENT;
+}
+
+/*
+ * Write "region_name value" (or "region_name max") to the dmem interface
+ * file @file opened relative to @dirfd.
+ * If @nonblock is true the file is opened with O_NONBLOCK, causing any
+ * eviction triggered by the limit change to be skipped rather than waited
+ * for; the write still succeeds (returns 0).
+ * Returns 0 on success, negative errno on failure.
+ */
+static int dmem_write_region(int dirfd, const char *file,
+ const char *region, uint64_t bytes, bool nonblock)
+{
+ char buf[PATH_MAX + 64];
+ ssize_t len;
+ int fd, ret;
+ int flags = O_WRONLY;
+
+ if (bytes == IGT_CGROUP_DMEM_MAX)
+ len = snprintf(buf, sizeof(buf), "%s max", region);
+ else
+ len = snprintf(buf, sizeof(buf), "%s %" PRIu64, region, bytes);
+
+ if (nonblock)
+ flags |= O_NONBLOCK;
+
+ fd = openat(dirfd, file, flags);
+ if (fd < 0)
+ return -errno;
+
+ do {
+ ret = write(fd, buf, len);
+ if (ret < 0 && errno == EINTR)
+ igt_debug("dmem cgroup write interrupted by signal, retrying\n");
+ } while (ret < 0 && errno == EINTR);
+ close(fd);
+
+ return (ret < 0) ? -errno : 0;
+}
+
+/**
+ * igt_cgroup_dmem_set_max() - Set the hard device memory limit for a region.
+ * @cg: Target cgroup.
+ * @region: Device memory region name (e.g. "drm/0000:03:00.0/vram0").
+ * @bytes: Hard limit in bytes. Use %IGT_CGROUP_DMEM_MAX for no limit.
+ * @nonblock: If true, open the file with O_NONBLOCK so that eviction
+ * triggered by the limit change is skipped rather than awaited.
+ *
+ * Writes @bytes to dmem.max for @region inside @cg. Allocation attempts
+ * that would push usage past this limit fail with -EAGAIN in the kernel.
+ * Fails the test via igt_assert on error.
+ */
+void igt_cgroup_dmem_set_max(struct igt_cgroup *cg, const char *region,
+ uint64_t bytes, bool nonblock)
+{
+ igt_assert_f(dmem_write_region(cg->dirfd, "dmem.max", region, bytes,
+ nonblock) == 0,
+ "Failed to set dmem.max for region %s\n", region);
+}
+
+/**
+ * igt_cgroup_dmem_set_min() - Set the hard protection threshold for a region.
+ * @cg: Target cgroup.
+ * @region: Device memory region name.
+ * @bytes: Hard protection threshold in bytes. Pass 0 to disable.
+ *
+ * Writes @bytes to dmem.min for @region inside @cg. Device memory below
+ * this threshold is never reclaimed regardless of system pressure.
+ * Fails the test via igt_assert on error.
+ */
+void igt_cgroup_dmem_set_min(struct igt_cgroup *cg, const char *region,
+ uint64_t bytes)
+{
+ igt_assert_f(dmem_write_region(cg->dirfd, "dmem.min", region, bytes,
+ false) == 0,
+ "Failed to set dmem.min for region %s\n", region);
+}
+
+/**
+ * igt_cgroup_dmem_set_low() - Set the soft protection threshold for a region.
+ * @cg: Target cgroup.
+ * @region: Device memory region name.
+ * @bytes: Soft protection threshold in bytes. Pass 0 to disable.
+ *
+ * Writes @bytes to dmem.low for @region inside @cg. Device memory below
+ * this threshold is only reclaimed when no unprotected memory remains.
+ * Fails the test via igt_assert on error.
+ */
+void igt_cgroup_dmem_set_low(struct igt_cgroup *cg, const char *region,
+ uint64_t bytes)
+{
+ igt_assert_f(dmem_write_region(cg->dirfd, "dmem.low", region, bytes,
+ false) == 0,
+ "Failed to set dmem.low for region %s\n", region);
+}
+
+/**
+ * igt_cgroup_dmem_get_current() - Read current device memory usage for a region.
+ * @cg: Target cgroup.
+ * @region: Device memory region name.
+ * @out: Receives the current usage in bytes.
+ *
+ * Reads dmem.current from @cg and returns the usage for @region.
+ * Fails the test via igt_assert on error.
+ */
+void igt_cgroup_dmem_get_current(struct igt_cgroup *cg, const char *region,
+ uint64_t *out)
+{
+ igt_assert_f(dmem_read_region(cg->dirfd, "dmem.current", region, out) == 0,
+ "Failed to read dmem.current for region %s\n", region);
+}
+
+/**
+ * igt_cgroup_dmem_get_max() - Read the configured hard limit for a region.
+ * @cg: Target cgroup.
+ * @region: Device memory region name.
+ * @out: Receives the limit in bytes, or %IGT_CGROUP_DMEM_MAX if unset.
+ *
+ * Reads dmem.max from @cg for @region.
+ * Fails the test via igt_assert on error.
+ */
+void igt_cgroup_dmem_get_max(struct igt_cgroup *cg, const char *region,
+ uint64_t *out)
+{
+ igt_assert_f(dmem_read_region(cg->dirfd, "dmem.max", region, out) == 0,
+ "Failed to read dmem.max for region %s\n", region);
+}
+
+/**
+ * igt_cgroup_dmem_get_min() - Read the configured hard protection threshold for a region.
+ * @cg: Target cgroup.
+ * @region: Device memory region name.
+ * @out: Receives the threshold in bytes.
+ *
+ * Reads dmem.min from @cg for @region.
+ * Fails the test via igt_assert on error.
+ */
+void igt_cgroup_dmem_get_min(struct igt_cgroup *cg, const char *region,
+ uint64_t *out)
+{
+ igt_assert_f(dmem_read_region(cg->dirfd, "dmem.min", region, out) == 0,
+ "Failed to read dmem.min for region %s\n", region);
+}
+
+/**
+ * igt_cgroup_dmem_get_low() - Read the configured soft protection threshold for a region.
+ * @cg: Target cgroup.
+ * @region: Device memory region name.
+ * @out: Receives the threshold in bytes.
+ *
+ * Reads dmem.low from @cg for @region.
+ * Fails the test via igt_assert on error.
+ */
+void igt_cgroup_dmem_get_low(struct igt_cgroup *cg, const char *region,
+ uint64_t *out)
+{
+ igt_assert_f(dmem_read_region(cg->dirfd, "dmem.low", region, out) == 0,
+ "Failed to read dmem.low for region %s\n", region);
+}
+
+/**
+ * igt_cgroup_dmem_available() - Check if the dmem cgroup controller is available.
+ *
+ * Probes the cgroup v2 hierarchy for the presence of a dmem.capacity file at
+ * the root, indicating that the kernel dmem controller is compiled in and at
+ * least one device memory region has been registered.
+ *
+ * Return: %true if the dmem controller is available, %false otherwise.
+ */
+bool igt_cgroup_dmem_available(void)
+{
+ char **regions = igt_cgroup_dmem_regions();
+
+ if (!regions)
+ return false;
+
+ igt_cgroup_dmem_regions_free(regions);
+ return true;
+}
+
+/**
+ * igt_cgroup_dmem_regions() - Enumerate all registered device memory regions.
+ *
+ * Reads the root cgroup's dmem.capacity file and returns a NULL-terminated
+ * array of region name strings. Each name can be passed directly to
+ * igt_cgroup_dmem_get_capacity(), igt_cgroup_dmem_get_current(), and the
+ * igt_cgroup_dmem_set_*() / igt_cgroup_dmem_get_*() family.
+ *
+ * Free the returned array with igt_cgroup_dmem_regions_free().
+ *
+ * Return: A NULL-terminated array of strings on success, %NULL if cgroupv2
+ * is unavailable or no regions are registered.
+ */
+char **igt_cgroup_dmem_regions(void)
+{
+ char buf[4096];
+ char *line, *saveptr, *space, *name;
+ char **regions = NULL, **tmp;
+ int count = 0;
+ const char *mount;
+ ssize_t n;
+ int dirfd, fd;
+
+ mount = cgroupv2_mount();
+ if (!mount)
+ return NULL;
+
+ dirfd = open(mount, O_RDONLY | O_DIRECTORY);
+ if (dirfd < 0)
+ return NULL;
+
+ fd = openat(dirfd, "dmem.capacity", O_RDONLY);
+ close(dirfd);
+ if (fd < 0)
+ return NULL;
+
+ n = igt_readn(fd, buf, sizeof(buf) - 1);
+ close(fd);
+ if (n <= 0)
+ return NULL;
+ buf[n] = '\0';
+
+ for (line = strtok_r(buf, "\n", &saveptr); line;
+ line = strtok_r(NULL, "\n", &saveptr)) {
+ space = strchr(line, ' ');
+
+ if (!space)
+ continue;
+ *space = '\0';
+
+ name = strdup(line);
+ if (!name)
+ goto err;
+
+ tmp = realloc(regions, (count + 2) * sizeof(*regions));
+ if (!tmp) {
+ free(name);
+ goto err;
+ }
+ regions = tmp;
+ regions[count++] = name;
+ regions[count] = NULL;
+ }
+
+ return regions;
+
+err:
+ igt_cgroup_dmem_regions_free(regions);
+ return NULL;
+}
+
+/**
+ * igt_cgroup_dmem_regions_free() - Free a region list returned by igt_cgroup_dmem_regions().
+ * @regions: NULL-terminated array returned by igt_cgroup_dmem_regions().
+ *
+ * Frees each string in @regions and the array itself. Safe to call with
+ * %NULL.
+ */
+void igt_cgroup_dmem_regions_free(char **regions)
+{
+ int i;
+
+ if (!regions)
+ return;
+
+ for (i = 0; regions[i]; i++)
+ free(regions[i]);
+
+ free(regions);
+}
+
+/**
+ * igt_cgroup_dmem_get_capacity() - Read total device memory capacity for a region.
+ * @region: Device memory region name.
+ * @out: Receives the total capacity in bytes.
+ *
+ * Reads dmem.capacity from the root cgroup and returns the capacity for
+ * @region. This reflects the maximum allocatable bytes, excluding memory
+ * reserved by the kernel for internal use.
+ * Fails the test via igt_assert on error.
+ */
+void igt_cgroup_dmem_get_capacity(const char *region, uint64_t *out)
+{
+ const char *mount;
+ int dirfd, ret;
+
+ mount = cgroupv2_mount();
+ igt_assert_f(mount, "cgroup v2 not available\n");
+
+ dirfd = open(mount, O_RDONLY | O_DIRECTORY);
+ igt_assert_f(dirfd >= 0, "Failed to open cgroup root: %m\n");
+
+ ret = dmem_read_region(dirfd, "dmem.capacity", region, out);
+ close(dirfd);
+
+ igt_assert_f(ret == 0, "Failed to read dmem.capacity for region %s\n", region);
+}
+
+/**
+ * igt_cgroup_dmem_get_system_current() - Read system-wide device memory usage for a region.
+ * @region: Device memory region name.
+ * @out: Receives the total system-wide usage in bytes.
+ *
+ * Reads dmem.current from the root cgroup for @region. This reflects the
+ * aggregate device memory usage across all cgroups on the system.
+ * Fails the test via igt_assert on error.
+ */
+void igt_cgroup_dmem_get_system_current(const char *region, uint64_t *out)
+{
+ const char *mount;
+ int dirfd, ret;
+
+ mount = cgroupv2_mount();
+ igt_assert_f(mount, "cgroup v2 not available\n");
+
+ dirfd = open(mount, O_RDONLY | O_DIRECTORY);
+ igt_assert_f(dirfd >= 0, "Failed to open cgroup root: %m\n");
+
+ ret = dmem_read_region(dirfd, "dmem.current", region, out);
+ close(dirfd);
+
+ igt_assert_f(ret == 0, "Failed to read root dmem.current for region %s\n", region);
+}
diff --git a/lib/igt_cgroup.h b/lib/igt_cgroup.h
new file mode 100644
index 000000000000..379de457a54d
--- /dev/null
+++ b/lib/igt_cgroup.h
@@ -0,0 +1,56 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2025 Intel Corporation
+ */
+
+#ifndef __IGT_CGROUP_H__
+#define __IGT_CGROUP_H__
+
+#include <stdbool.h>
+#include <stdint.h>
+
+/**
+ * IGT_CGROUP_DMEM_MAX - Sentinel value meaning "no device memory limit".
+ *
+ * Pass this to igt_cgroup_dmem_set_max() to remove a previously set limit,
+ * equivalent to writing "max" to the dmem.max interface file.
+ */
+#define IGT_CGROUP_DMEM_MAX UINT64_MAX
+
+/**
+ * struct igt_cgroup - Opaque handle to a cgroup v2 sub-cgroup.
+ *
+ * Allocated by igt_cgroup_new() and freed by igt_cgroup_free().
+ * All other functions in this module take a pointer to this type.
+ */
+struct igt_cgroup;
+
+struct igt_cgroup *igt_cgroup_new(const char *name);
+void igt_cgroup_free(struct igt_cgroup *cg);
+
+void igt_cgroup_move_current(struct igt_cgroup *cg);
+
+void igt_cgroup_dmem_set_max(struct igt_cgroup *cg, const char *region,
+ uint64_t bytes, bool nonblock);
+void igt_cgroup_dmem_set_min(struct igt_cgroup *cg, const char *region,
+ uint64_t bytes);
+void igt_cgroup_dmem_set_low(struct igt_cgroup *cg, const char *region,
+ uint64_t bytes);
+
+void igt_cgroup_dmem_get_max(struct igt_cgroup *cg, const char *region,
+ uint64_t *out);
+void igt_cgroup_dmem_get_min(struct igt_cgroup *cg, const char *region,
+ uint64_t *out);
+void igt_cgroup_dmem_get_low(struct igt_cgroup *cg, const char *region,
+ uint64_t *out);
+
+void igt_cgroup_dmem_get_current(struct igt_cgroup *cg, const char *region,
+ uint64_t *out);
+void igt_cgroup_dmem_get_capacity(const char *region, uint64_t *out);
+void igt_cgroup_dmem_get_system_current(const char *region, uint64_t *out);
+
+bool igt_cgroup_dmem_available(void);
+char **igt_cgroup_dmem_regions(void);
+void igt_cgroup_dmem_regions_free(char **regions);
+
+#endif /* __IGT_CGROUP_H__ */
diff --git a/lib/meson.build b/lib/meson.build
index d1289a5e086f..e0d9c2f7475b 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -19,6 +19,7 @@ lib_sources = [
'i915/i915_dp.c',
'igt_collection.c',
'igt_color_encoding.c',
+ 'igt_cgroup.c',
'igt_configfs.c',
'igt_facts.c',
'igt_crc.c',
--
2.47.3
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH i-g-t v2 2/7] tests/cgroup_dmem: add dmem cgroup controller test
2026-07-02 13:00 [PATCH i-g-t v3 0/7] add dmem_cgroups test Thadeu Lima de Souza Cascardo
2026-07-02 13:00 ` [PATCH i-g-t v2 1/7] lib/igt_cgroup: add cgroup v2 and dmem controller helpers Thadeu Lima de Souza Cascardo
@ 2026-07-02 13:00 ` Thadeu Lima de Souza Cascardo
2026-07-02 13:00 ` [PATCH i-g-t v2 3/7] lib/xe: add xe_cgroup_region_name() helper Thadeu Lima de Souza Cascardo
` (6 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2026-07-02 13:00 UTC (permalink / raw)
To: igt-dev
Cc: siqueira, Thomas Hellström, dri-devel, amd-gfx, intel-xe,
Christian Koenig, maarten.lankhorst, Kamil Konieczny,
Janusz Krzysztofik, Vitaly Prosyak, Natalie Vock, Tvrtko Ursulin,
kernel-dev
From: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Add a test that exercises the cgroup v2 dmem controller interface using
the new igt_cgroup library.
The test uses igt_simple_main and:
- Skips if no dmem regions are registered (no cgroup v2 or no
dmem-capable device).
- Creates a sub-cgroup and moves the test process into it.
- Enumerates all registered device memory regions and prints their
capacity, system-wide current usage, per-cgroup current usage, and
configured min, low and max limits.
- Destroys the cgroup on completion.
Assisted-by: GitHub Copilot:claude-sonnet-4.6
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
tests/cgroup_dmem.c | 92 +++++++++++++++++++++++++++++++++++++++++++++
tests/meson.build | 1 +
2 files changed, 93 insertions(+)
create mode 100644 tests/cgroup_dmem.c
diff --git a/tests/cgroup_dmem.c b/tests/cgroup_dmem.c
new file mode 100644
index 000000000000..442c965f9bbf
--- /dev/null
+++ b/tests/cgroup_dmem.c
@@ -0,0 +1,92 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2025 Intel Corporation
+ */
+
+/**
+ * TEST: cgroup dmem
+ * Description: Exercises the cgroup v2 dmem controller interface. Creates a
+ * cgroup, moves the process into it, enumerates all dmem regions,
+ * prints their capacity, system-wide current usage, per-cgroup
+ * current usage and configured limits, then destroys the cgroup.
+ * Category: Core
+ * Mega feature: General Core features
+ * Sub-category: uapi
+ * Functionality: cgroup
+ * Feature: dmem
+ * Test category: uapi
+ */
+
+#include <inttypes.h>
+
+#include "igt.h"
+#include "igt_cgroup.h"
+
+IGT_TEST_DESCRIPTION("Exercises the cgroup v2 dmem controller interface.");
+
+static void fmt_bytes(uint64_t v, char *buf, size_t len)
+{
+ if (v == IGT_CGROUP_DMEM_MAX)
+ snprintf(buf, len, "max");
+ else
+ snprintf(buf, len, "%" PRIu64, v);
+}
+
+int igt_simple_main()
+{
+ struct igt_cgroup *cg;
+ const char *region;
+ char **regions;
+ uint64_t capacity, sys_current, cg_current, min, low, max;
+ char cap_s[32], sys_s[32], cg_s[32];
+ char min_s[32], low_s[32], max_s[32];
+ int i;
+
+ igt_require_f(igt_cgroup_dmem_available(),
+ "No dmem regions found; is cgroup v2 with the "
+ "dmem controller available?\n");
+
+ cg = igt_cgroup_new("igt-cgroup-dmem-test");
+ igt_assert_f(cg, "Failed to create cgroup\n");
+
+ igt_cgroup_move_current(cg);
+
+ regions = igt_cgroup_dmem_regions();
+ igt_assert_f(regions, "Failed to enumerate dmem regions\n");
+
+ igt_info("%-40s %16s %16s %16s %16s %16s %16s\n",
+ "region", "capacity", "system-current",
+ "cgroup-current", "min", "low", "max");
+ igt_info("%-40s %16s %16s %16s %16s %16s %16s\n",
+ "------", "--------", "--------------",
+ "--------------", "---", "---", "---");
+
+ for (i = 0; regions[i]; i++) {
+ region = regions[i];
+
+ igt_cgroup_dmem_get_capacity(region, &capacity);
+ fmt_bytes(capacity, cap_s, sizeof(cap_s));
+
+ igt_cgroup_dmem_get_system_current(region, &sys_current);
+ fmt_bytes(sys_current, sys_s, sizeof(sys_s));
+
+ igt_cgroup_dmem_get_current(cg, region, &cg_current);
+ fmt_bytes(cg_current, cg_s, sizeof(cg_s));
+
+ igt_cgroup_dmem_get_min(cg, region, &min);
+ fmt_bytes(min, min_s, sizeof(min_s));
+
+ igt_cgroup_dmem_get_low(cg, region, &low);
+ fmt_bytes(low, low_s, sizeof(low_s));
+
+ igt_cgroup_dmem_get_max(cg, region, &max);
+ fmt_bytes(max, max_s, sizeof(max_s));
+
+ igt_info("%-40s %16s %16s %16s %16s %16s %16s\n",
+ region, cap_s, sys_s, cg_s,
+ min_s, low_s, max_s);
+ }
+
+ igt_cgroup_dmem_regions_free(regions);
+ igt_cgroup_free(cg);
+}
diff --git a/tests/meson.build b/tests/meson.build
index 96bd6213d192..88a0ce224432 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -1,4 +1,5 @@
test_progs = [
+ 'cgroup_dmem',
'core_auth',
'core_debugfs',
'core_getclient',
--
2.47.3
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH i-g-t v2 3/7] lib/xe: add xe_cgroup_region_name() helper
2026-07-02 13:00 [PATCH i-g-t v3 0/7] add dmem_cgroups test Thadeu Lima de Souza Cascardo
2026-07-02 13:00 ` [PATCH i-g-t v2 1/7] lib/igt_cgroup: add cgroup v2 and dmem controller helpers Thadeu Lima de Souza Cascardo
2026-07-02 13:00 ` [PATCH i-g-t v2 2/7] tests/cgroup_dmem: add dmem cgroup controller test Thadeu Lima de Souza Cascardo
@ 2026-07-02 13:00 ` Thadeu Lima de Souza Cascardo
2026-07-02 13:00 ` [PATCH i-g-t v2 4/7] lib/xe: Introduce dmem driver and implement Xe support Thadeu Lima de Souza Cascardo
` (5 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2026-07-02 13:00 UTC (permalink / raw)
To: igt-dev
Cc: siqueira, Thomas Hellström, dri-devel, amd-gfx, intel-xe,
Christian Koenig, maarten.lankhorst, Kamil Konieczny,
Janusz Krzysztofik, Vitaly Prosyak, Natalie Vock, Tvrtko Ursulin,
kernel-dev
From: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Add xe_cgroup_region_name(fd, region) which constructs the dmem cgroup
region path for a given xe memory region. The returned string has the
form "drm/<pci-slot>/<region>" (e.g. "drm/0000:03:00.0/vram0"),
matching the name registered by the kernel via drmm_cgroup_register_region().
Only VRAM regions are tracked by the dmem controller; system and stolen
memory regions return NULL.
Assisted-by: GitHub Copilot:claude-sonnet-4.6
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
lib/xe/xe_query.c | 32 ++++++++++++++++++++++++++++++++
lib/xe/xe_query.h | 2 ++
2 files changed, 34 insertions(+)
diff --git a/lib/xe/xe_query.c b/lib/xe/xe_query.c
index 68e60ddc75a2..e2b25be21140 100644
--- a/lib/xe/xe_query.c
+++ b/lib/xe/xe_query.c
@@ -7,6 +7,7 @@
*/
#include <fcntl.h>
+#include <limits.h>
#include <stdlib.h>
#include <pthread.h>
@@ -21,6 +22,7 @@
#include "drmtest.h"
#include "igt_debugfs.h"
+#include "igt_device.h"
#include "ioctl_wrappers.h"
#include "igt_map.h"
#include "intel_common.h"
@@ -1304,6 +1306,36 @@ int xe_query_eu_thread_count(int fd, int gt)
xe_hwconfig_lookup_value_u32(fd, INTEL_HWCONFIG_NUM_THREADS_PER_EU);
}
+/**
+ * xe_cgroup_region_name() - Build the dmem cgroup region name for an xe memory region.
+ * @fd: xe device fd.
+ * @region: Region mask (as used by xe_mem_region(), xe_region_name(), etc.).
+ *
+ * Constructs the full dmem cgroup region path for @region on the device
+ * identified by @fd. The returned string has the form
+ * ``drm/<pci-slot>/<region>`` (e.g. ``drm/0000:03:00.0/vram0``), matching
+ * the name registered by the kernel driver via drmm_cgroup_register_region().
+ *
+ * Only VRAM regions are registered with the dmem controller; passing a
+ * system-memory region returns %NULL.
+ *
+ * Return: A newly allocated string that the caller must free(), or %NULL if
+ * @region is not tracked by the dmem cgroup controller.
+ */
+char *xe_cgroup_region_name(int fd, uint64_t region)
+{
+ char pci_slot[NAME_MAX];
+ char *name;
+
+ if (xe_region_class(fd, region) != DRM_XE_MEM_REGION_CLASS_VRAM)
+ return NULL;
+
+ igt_device_get_pci_slot_name(fd, pci_slot);
+
+ igt_assert(asprintf(&name, "drm/%s/%s", pci_slot, xe_region_name(region)) > 0);
+ return name;
+}
+
igt_constructor
{
xe_device_cache_init();
diff --git a/lib/xe/xe_query.h b/lib/xe/xe_query.h
index 59330d80fd1b..a6ef9cab9aa1 100644
--- a/lib/xe/xe_query.h
+++ b/lib/xe/xe_query.h
@@ -206,4 +206,6 @@ void xe_device_put(int fd);
int xe_query_eu_count(int fd, int gt);
int xe_query_eu_thread_count(int fd, int gt);
+char *xe_cgroup_region_name(int fd, uint64_t region);
+
#endif /* XE_QUERY_H */
--
2.47.3
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH i-g-t v2 4/7] lib/xe: Introduce dmem driver and implement Xe support
2026-07-02 13:00 [PATCH i-g-t v3 0/7] add dmem_cgroups test Thadeu Lima de Souza Cascardo
` (2 preceding siblings ...)
2026-07-02 13:00 ` [PATCH i-g-t v2 3/7] lib/xe: add xe_cgroup_region_name() helper Thadeu Lima de Souza Cascardo
@ 2026-07-02 13:00 ` Thadeu Lima de Souza Cascardo
2026-07-02 13:00 ` [PATCH i-g-t v2 5/7] lib/amdgpu: add amdgpu_cgroup_region_name Thadeu Lima de Souza Cascardo
` (4 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2026-07-02 13:00 UTC (permalink / raw)
To: igt-dev
Cc: siqueira, Thadeu Lima de Souza Cascardo, dri-devel, amd-gfx,
intel-xe, Christian Koenig, maarten.lankhorst,
Thomas Hellström, Kamil Konieczny, Janusz Krzysztofik,
Vitaly Prosyak, Natalie Vock, Tvrtko Ursulin, kernel-dev
In order to be reuse the same dmem tests with multiple drivers, we need to
abstract a few operations. That includes getting the region name, and
allocating and releasing VRAM. As there is some initialization also when
multiple allocations are done, also provide init and deinit functions.
The Xe implementation was based on the original operations from
xe_cgroups.c written by Thomas Hellström. However, instead of doing a
deferred backing, followed by a bind, it does a simple non-deferred GEM
object creation on the VRAM region.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
---
lib/igt_dmem_driver.h | 24 +++++++
lib/meson.build | 1 +
lib/xe/xe_dmem.c | 143 ++++++++++++++++++++++++++++++++++++++++++
3 files changed, 168 insertions(+)
create mode 100644 lib/igt_dmem_driver.h
create mode 100644 lib/xe/xe_dmem.c
diff --git a/lib/igt_dmem_driver.h b/lib/igt_dmem_driver.h
new file mode 100644
index 000000000000..2f4a4673ab16
--- /dev/null
+++ b/lib/igt_dmem_driver.h
@@ -0,0 +1,24 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright 2026 Valve Corporation
+ * Authors:
+ * Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
+ */
+
+#ifndef __IGT_DMEM_DRIVER_H__
+#define __IGT_DMEM_DRIVER_H__
+
+#include <stdlib.h>
+
+struct igt_dmem_driver {
+ const char *name;
+ char * (*get_region_name)(int fd);
+ int (*init)(void **ctx, int fd, int max_bo);
+ void (*deinit)(void *ctx);
+ int (*allocate_vram)(void *ctx, int n_bo, size_t len);
+ void (*free_vram)(void *ctx, int n_bo);
+};
+
+extern const struct igt_dmem_driver xe_dmem_driver;
+
+#endif
diff --git a/lib/meson.build b/lib/meson.build
index e0d9c2f7475b..04fe5755c82c 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -126,6 +126,7 @@ lib_sources = [
'igt_msm.c',
'igt_dsc.c',
'igt_hook.c',
+ 'xe/xe_dmem.c',
'xe/xe_gt.c',
'xe/xe_ioctl.c',
'xe/xe_legacy.c',
diff --git a/lib/xe/xe_dmem.c b/lib/xe/xe_dmem.c
new file mode 100644
index 000000000000..0de3a8c0b222
--- /dev/null
+++ b/lib/xe/xe_dmem.c
@@ -0,0 +1,143 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright 2026 Valve Corporation
+ * Authors:
+ * Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
+ */
+
+#include <errno.h>
+
+#include "igt.h"
+#include "igt_cgroup.h"
+#include "igt_dmem_driver.h"
+#include "xe_drm.h"
+#include "xe/xe_ioctl.h"
+#include "xe/xe_query.h"
+
+static char * xe_dmem_get_region_name(int fd)
+{
+ uint64_t vram_region = 0;
+ uint64_t region;
+ char *cg_region;
+
+ /* Find first VRAM region */
+ xe_for_each_mem_region(fd, all_memory_regions(fd), region) {
+ if (xe_region_class(fd, region) == DRM_XE_MEM_REGION_CLASS_VRAM) {
+ vram_region = region;
+ break;
+ }
+ }
+ if (!vram_region)
+ return NULL;
+
+ cg_region = xe_cgroup_region_name(fd, vram_region);
+
+ return cg_region;
+}
+
+struct xe_bo {
+ uint32_t handle;
+ size_t len;
+};
+
+struct xe_dmem_ctx {
+ int fd;
+ uint32_t vm;
+ struct xe_bo *bos;
+ uint64_t vram_region;
+ int max_bo;
+};
+
+static int xe_dmem_init(void **ctx, int fd, int max_bo)
+{
+ struct xe_dmem_ctx *xe_ctx;
+ uint64_t region;
+
+ xe_ctx = malloc(sizeof(*xe_ctx));
+ if (!xe_ctx)
+ return -ENOMEM;
+
+ xe_ctx->bos = calloc(max_bo, sizeof(xe_ctx->bos[0]));
+ if (!xe_ctx->bos)
+ goto out;
+ memset(xe_ctx->bos, 0, max_bo * sizeof(xe_ctx->bos[0]));
+ xe_ctx->max_bo = max_bo;
+
+ xe_ctx->vram_region = 0;
+ /* Find first VRAM region */
+ xe_for_each_mem_region(fd, all_memory_regions(fd), region) {
+ if (xe_region_class(fd, region) == DRM_XE_MEM_REGION_CLASS_VRAM) {
+ xe_ctx->vram_region = region;
+ break;
+ }
+ }
+ if (!xe_ctx->vram_region)
+ goto out;
+
+ xe_ctx->fd = fd;
+
+ xe_ctx->vm = xe_vm_create(fd, DRM_XE_VM_CREATE_FLAG_LR_MODE, 0);
+
+ *ctx = xe_ctx;
+
+ return 0;
+
+out:
+ if (xe_ctx->bos)
+ free(xe_ctx->bos);
+ free(xe_ctx);
+
+ return -ENOMEM;
+}
+
+static void xe_dmem_deinit(void *ctx)
+{
+ struct xe_dmem_ctx *xe_ctx = ctx;
+
+ xe_vm_destroy(xe_ctx->fd, xe_ctx->vm);
+ free(xe_ctx->bos);
+ free(xe_ctx);
+}
+
+static int xe_dmem_allocate_vram(void *ctx, int n_bo, size_t len)
+{
+ struct xe_dmem_ctx *xe_ctx = ctx;
+ uint32_t handle;
+ int err;
+
+ if (n_bo >= xe_ctx->max_bo)
+ return -ENOMEM;
+
+ err = __xe_bo_create(xe_ctx->fd, 0, len, xe_ctx->vram_region, 0,
+ NULL, &handle);
+ if (err)
+ goto out;
+
+ xe_ctx->bos[n_bo].handle = handle;
+ xe_ctx->bos[n_bo].len = len;
+
+out:
+ return err;
+}
+
+static void xe_dmem_free_vram(void *ctx, int n_bo)
+{
+ struct xe_dmem_ctx *xe_ctx = ctx;
+ size_t len;
+ if (n_bo >= xe_ctx->max_bo)
+ return;
+ len = xe_ctx->bos[n_bo].len;
+ if (len) {
+ gem_close(xe_ctx->fd, xe_ctx->bos[n_bo].handle);
+ xe_ctx->bos[n_bo].len = 0;
+ }
+}
+
+const struct igt_dmem_driver xe_dmem_driver = {
+ .name = "xe",
+ .get_region_name = xe_dmem_get_region_name,
+ .init = xe_dmem_init,
+ .deinit = xe_dmem_deinit,
+ .allocate_vram = xe_dmem_allocate_vram,
+ .free_vram = xe_dmem_free_vram,
+};
--
2.47.3
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH i-g-t v2 5/7] lib/amdgpu: add amdgpu_cgroup_region_name
2026-07-02 13:00 [PATCH i-g-t v3 0/7] add dmem_cgroups test Thadeu Lima de Souza Cascardo
` (3 preceding siblings ...)
2026-07-02 13:00 ` [PATCH i-g-t v2 4/7] lib/xe: Introduce dmem driver and implement Xe support Thadeu Lima de Souza Cascardo
@ 2026-07-02 13:00 ` Thadeu Lima de Souza Cascardo
2026-07-02 13:00 ` [PATCH i-g-t v2 6/7] lib/amdgpu: add amdgpu support to igt_dmem_driver Thadeu Lima de Souza Cascardo
` (3 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2026-07-02 13:00 UTC (permalink / raw)
To: igt-dev
Cc: siqueira, Thadeu Lima de Souza Cascardo, dri-devel, amd-gfx,
intel-xe, Christian Koenig, maarten.lankhorst,
Thomas Hellström, Kamil Konieczny, Janusz Krzysztofik,
Vitaly Prosyak, Natalie Vock, Tvrtko Ursulin, kernel-dev
The amdgpu dmem region name uses its PCI address, just like the one from
Xe, but there is only a single VRAM region.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
---
lib/amdgpu/amd_memory.c | 25 +++++++++++++++++++++++++
lib/amdgpu/amd_memory.h | 2 ++
2 files changed, 27 insertions(+)
diff --git a/lib/amdgpu/amd_memory.c b/lib/amdgpu/amd_memory.c
index 12fe23c65ab2..2da4a8a4baee 100644
--- a/lib/amdgpu/amd_memory.c
+++ b/lib/amdgpu/amd_memory.c
@@ -30,9 +30,11 @@
#include <amdgpu_drm.h>
#include <stdio.h>
#include <string.h>
+#include <limits.h>
#include <unistd.h>
#include <sys/mman.h>
#include <inttypes.h>
+#include "igt_device.h"
/**
*
@@ -679,6 +681,29 @@ bool virtual_free_memory(void *address, unsigned int size)
}
}
+/**
+ * amdgpu_cgroup_region_name() - Build the dmem cgroup region name for an amdgpu.
+ * @fd: amdgpu device fd.
+ *
+ * Constructs the full dmem cgroup region path for VRAM on the device
+ * identified by @fd. The returned string has the form
+ * ``drm/<pci-slot>/vram`` (e.g. ``drm/0000:03:00.0/vram``), matching
+ * the name registered by the kernel driver via drmm_cgroup_register_region().
+ *
+ * Return: A newly allocated string that the caller must free(), or %NULL if
+ * @region is not tracked by the dmem cgroup controller.
+ */
+char *amdgpu_cgroup_region_name(int fd)
+{
+ char pci_slot[NAME_MAX];
+ char *name;
+
+ igt_device_get_pci_slot_name(fd, pci_slot);
+
+ igt_assert(asprintf(&name, "drm/%s/vram", pci_slot) > 0);
+ return name;
+}
+
/**
* Wait for specific value in memory with timeout
*/
diff --git a/lib/amdgpu/amd_memory.h b/lib/amdgpu/amd_memory.h
index e26c85bc4b0a..de169e580c1b 100644
--- a/lib/amdgpu/amd_memory.h
+++ b/lib/amdgpu/amd_memory.h
@@ -105,6 +105,8 @@ void
bool
virtual_free_memory(void *address, unsigned int size);
+char *amdgpu_cgroup_region_name(int fd);
+
bool
wait_on_value(unsigned int *ptr, unsigned int expected);
#endif
--
2.47.3
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH i-g-t v2 6/7] lib/amdgpu: add amdgpu support to igt_dmem_driver
2026-07-02 13:00 [PATCH i-g-t v3 0/7] add dmem_cgroups test Thadeu Lima de Souza Cascardo
` (4 preceding siblings ...)
2026-07-02 13:00 ` [PATCH i-g-t v2 5/7] lib/amdgpu: add amdgpu_cgroup_region_name Thadeu Lima de Souza Cascardo
@ 2026-07-02 13:00 ` Thadeu Lima de Souza Cascardo
2026-07-02 13:00 ` [PATCH i-g-t v2 7/7] tests/dmem_cgroups: add test for dmem.current Thadeu Lima de Souza Cascardo
` (2 subsequent siblings)
8 siblings, 0 replies; 13+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2026-07-02 13:00 UTC (permalink / raw)
To: igt-dev
Cc: siqueira, Thadeu Lima de Souza Cascardo, dri-devel, amd-gfx,
intel-xe, Christian Koenig, maarten.lankhorst,
Thomas Hellström, Kamil Konieczny, Janusz Krzysztofik,
Vitaly Prosyak, Natalie Vock, Tvrtko Ursulin, kernel-dev
This allows dmem cgroups tests to run on top of amdgpu driver, adding
support to allocate and release VRAM memory.
This does this by allocating a BO from VRAM domain, which will try to
place BOs on VRAM, but may fallback to GTT.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
---
lib/amdgpu/amd_dmem.c | 99 +++++++++++++++++++++++++++++++++++++++++++
lib/igt_dmem_driver.h | 1 +
lib/meson.build | 1 +
3 files changed, 101 insertions(+)
create mode 100644 lib/amdgpu/amd_dmem.c
diff --git a/lib/amdgpu/amd_dmem.c b/lib/amdgpu/amd_dmem.c
new file mode 100644
index 000000000000..5ff6437dc78a
--- /dev/null
+++ b/lib/amdgpu/amd_dmem.c
@@ -0,0 +1,99 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright 2026 Valve Corporation
+ * Authors:
+ * Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
+ */
+
+#include <errno.h>
+
+#include "igt.h"
+#include "igt_cgroup.h"
+#include "igt_dmem_driver.h"
+#include "lib/amdgpu/amd_memory.h"
+
+struct amdgpu_dmem_ctx {
+ int fd;
+ amdgpu_device_handle device;
+ amdgpu_bo_handle *handles;
+ int max_bo;
+};
+
+static int amdgpu_dmem_init(void **ctx, int fd, int max_bo)
+{
+ struct amdgpu_dmem_ctx *actx;
+ uint32_t major, minor;
+ int err = -ENOMEM;
+
+ actx = malloc(sizeof(*actx));
+ if (!actx)
+ return -ENOMEM;
+
+ actx->handles = calloc(max_bo, sizeof(actx->handles[0]));
+ if (!actx->handles)
+ goto out;
+
+ actx->max_bo = max_bo;
+
+ err = amdgpu_device_initialize(fd, &major, &minor, &actx->device);
+ if (err)
+ goto out;
+
+ *ctx = actx;
+
+ return 0;
+
+out:
+ if (actx->handles)
+ free(actx->handles);
+ free(actx);
+
+ return err;
+}
+
+static void amdgpu_dmem_deinit(void *ctx)
+{
+ struct amdgpu_dmem_ctx *actx = ctx;
+
+ amdgpu_device_deinitialize(actx->device);
+ free(actx->handles);
+ free(actx);
+}
+
+static int amdgpu_dmem_allocate_vram(void *ctx, int n_bo, size_t len)
+{
+ struct amdgpu_dmem_ctx *actx = ctx;
+ amdgpu_bo_handle handle;
+ int err;
+
+ if (n_bo >= actx->max_bo)
+ return -ENOMEM;
+
+ err = amdgpu_bo_alloc_wrap(actx->device, len, 4096,
+ AMDGPU_GEM_DOMAIN_VRAM, 0, &handle);
+ if (err)
+ return err;
+
+ actx->handles[n_bo] = handle;
+
+ return 0;
+}
+
+static void amdgpu_dmem_free_vram(void *ctx, int n_bo)
+{
+ struct amdgpu_dmem_ctx *actx = ctx;
+ if (n_bo >= actx->max_bo)
+ return;
+ if (actx->handles[n_bo])
+ amdgpu_bo_free(actx->handles[n_bo]);
+ actx->handles[n_bo] = 0;
+}
+
+const struct igt_dmem_driver amdgpu_dmem_driver = {
+ .name = "amdgpu",
+ .get_region_name = amdgpu_cgroup_region_name,
+ .init = amdgpu_dmem_init,
+ .deinit = amdgpu_dmem_deinit,
+ .allocate_vram = amdgpu_dmem_allocate_vram,
+ .free_vram = amdgpu_dmem_free_vram,
+};
diff --git a/lib/igt_dmem_driver.h b/lib/igt_dmem_driver.h
index 2f4a4673ab16..d34c839740a5 100644
--- a/lib/igt_dmem_driver.h
+++ b/lib/igt_dmem_driver.h
@@ -20,5 +20,6 @@ struct igt_dmem_driver {
};
extern const struct igt_dmem_driver xe_dmem_driver;
+extern const struct igt_dmem_driver amdgpu_dmem_driver;
#endif
diff --git a/lib/meson.build b/lib/meson.build
index 04fe5755c82c..6bf9d0d9cb74 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -199,6 +199,7 @@ if libdrm_amdgpu.found()
'amdgpu/amd_mmd_shared.c',
'amdgpu/amd_jpeg_shared.c',
'amdgpu/amd_utils.c',
+ 'amdgpu/amd_dmem.c',
'amdgpu/amd_vcn_shared.c'
]
if libdrm_amdgpu.version().version_compare('> 2.4.99')
--
2.47.3
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH i-g-t v2 7/7] tests/dmem_cgroups: add test for dmem.current
2026-07-02 13:00 [PATCH i-g-t v3 0/7] add dmem_cgroups test Thadeu Lima de Souza Cascardo
` (5 preceding siblings ...)
2026-07-02 13:00 ` [PATCH i-g-t v2 6/7] lib/amdgpu: add amdgpu support to igt_dmem_driver Thadeu Lima de Souza Cascardo
@ 2026-07-02 13:00 ` Thadeu Lima de Souza Cascardo
2026-07-07 11:07 ` Kamil Konieczny
2026-07-03 9:54 ` [PATCH i-g-t v3 0/7] add dmem_cgroups test Sokolowski, Jan
2026-07-06 16:48 ` Rodrigo Siqueira
8 siblings, 1 reply; 13+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2026-07-02 13:00 UTC (permalink / raw)
To: igt-dev
Cc: siqueira, Thadeu Lima de Souza Cascardo, dri-devel, amd-gfx,
intel-xe, Christian Koenig, maarten.lankhorst,
Thomas Hellström, Kamil Konieczny, Janusz Krzysztofik,
Vitaly Prosyak, Natalie Vock, Tvrtko Ursulin, kernel-dev
Based on the work of Thomas Hellström to test dmem.max eviction, add a test
for dmem.current usage after allocations and setting dmem.max.
Create a dmem cgroup, allocate close to capacity (or at most 4GiB), check
current usage is within a small slack of the expected allocation. Then,
set max to a small value and check allocations and current usage are
limited to the max set. Set max to 0, then check no allocations are
allowed and current usage is also within the slack. After each allocation,
release memory and check current usage has gone down.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
---
tests/dmem_cgroups.c | 245 +++++++++++++++++++++++++++++++++++++++++++
tests/meson.build | 1 +
2 files changed, 246 insertions(+)
create mode 100644 tests/dmem_cgroups.c
diff --git a/tests/dmem_cgroups.c b/tests/dmem_cgroups.c
new file mode 100644
index 000000000000..da2475a14ff9
--- /dev/null
+++ b/tests/dmem_cgroups.c
@@ -0,0 +1,245 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2026 Intel Corporation
+ */
+
+/**
+ * TEST: dmem_cgroups
+ * DESCRIPTION: Tests exercising the dmem cgroup controller on devices.
+ * Category: Core
+ * Mega feature: General Core features
+ * Sub-category: cgroup
+ * FUNCTIONALITY: cgroup dmem controller
+ */
+
+#include <errno.h>
+#include <signal.h>
+#include <stdatomic.h>
+#include <stdint.h>
+#include <stdlib.h>
+#include <string.h>
+#include <unistd.h>
+
+#include "drmtest.h"
+#include "igt.h"
+#include "igt_aux.h"
+#include "igt_cgroup.h"
+#include "igt_dmem_driver.h"
+
+#define BO_SIZE SZ_64M
+#define MAX_LIMIT ((uint64_t)4 * SZ_1G)
+#define USAGE_SLACK SZ_4M /* tolerance above the set max */
+#define USAGE_POLL_MS 10
+#define USAGE_DROP_TIMEOUT_MS 1000
+
+/**
+ * SUBTEST: current
+ * DESCRIPTION:
+ * Create a dmem cgroup, allocate close to capacity (or at most 4GiB),
+ * check current usage is within a small slack of the expected allocation.
+ * Then, set max to a small value and check allocations and current usage
+ * are limited to the max set.
+ * Set max to 0, then check no allocations are allowed and current usage
+ * is also within the slack.
+ * After each allocation, release memory and check current usage has gone
+ * down.
+ * REQUIREMENTS: xe or amdgpu device with at least one VRAM region
+ */
+
+static uint64_t wait_for_usage_drop(struct igt_cgroup *cg, const char *region,
+ uint64_t limit)
+{
+ uint64_t current;
+ unsigned int elapsed = 0;
+
+ do {
+ igt_cgroup_dmem_get_current(cg, region, ¤t);
+ if (current <= limit)
+ return current;
+ usleep(USAGE_POLL_MS * 1000);
+ elapsed += USAGE_POLL_MS;
+ } while (elapsed < USAGE_DROP_TIMEOUT_MS);
+
+ return current;
+}
+
+static int allocate_vram(const struct igt_dmem_driver *drv, void *ctx, int fd, int max_bo, size_t len)
+{
+ int n_bo, err = 0;
+ for (n_bo = 0; n_bo < max_bo; n_bo++) {
+ err = drv->allocate_vram(ctx, n_bo, len);
+ if (err)
+ break;
+ }
+ /* These are expected failures we can ignore. */
+ if (err == -ENOMEM || err == -ENOSPC)
+ err = 0;
+ return err ?: n_bo;
+}
+
+static void free_vram(const struct igt_dmem_driver *drv, void *ctx, int max_bo)
+{
+ int i;
+ for (i = 0; i < max_bo; i++)
+ drv->free_vram(ctx, i);
+}
+
+static void test_current(int fd, char *cg_region, unsigned int flags, const struct igt_dmem_driver *drv)
+{
+ struct igt_cgroup *cg;
+ void *ctx;
+ uint64_t current, capacity, cg_max;
+ int n_bo = 0, max_bo;
+ int err;
+
+ igt_cgroup_dmem_get_capacity(cg_region, &capacity);
+ igt_require_f(capacity >= 4 * BO_SIZE,
+ "VRAM capacity (%"PRIu64" MiB) too small to test\n",
+ capacity / SZ_1M);
+
+ /*
+ * Use up to 4 GiB, or the full capacity if the device has less.
+ * Leave one BO_SIZE worth of headroom so the device isn't completely
+ * exhausted before the cgroup limit is hit.
+ */
+ cg_max = min(MAX_LIMIT, capacity - BO_SIZE - USAGE_SLACK);
+ cg_max = ALIGN_DOWN(cg_max, BO_SIZE);
+
+ /* Create cgroup and move into it */
+ cg = igt_cgroup_new("igt_cgroups_test");
+ igt_cgroup_move_current(cg);
+
+ max_bo = cg_max / BO_SIZE;
+
+ err = drv->init(&ctx, fd, max_bo);
+ igt_assert_f(!err, "Failed to initialize driver");
+
+ n_bo = allocate_vram(drv, ctx, fd, max_bo, BO_SIZE);
+ igt_assert_f(n_bo > 0, "failed to allocate VRAM\n");
+
+ igt_cgroup_dmem_get_current(cg, cg_region, ¤t);
+ igt_debug("After fill: cgroup current = %"PRIu64" MiB, "
+ "max = %"PRIu64" MiB\n",
+ current / SZ_1M, cg_max / SZ_1M);
+ igt_assert_f(current < cg_max + USAGE_SLACK && current > cg_max - USAGE_SLACK,
+ "current usage (%"PRIu64" MiB) is not within margin of allocation (%"PRIu64" MiB)\n",
+ current / SZ_1M, cg_max / SZ_1M);
+
+ free_vram(drv, ctx, n_bo);
+ wait_for_usage_drop(cg, cg_region, USAGE_SLACK);
+
+ igt_cgroup_dmem_get_current(cg, cg_region, ¤t);
+ igt_debug("After free: cgroup current = %"PRIu64" MiB, "
+ "max = %"PRIu64" MiB\n",
+ current / SZ_1M, cg_max / SZ_1M);
+ igt_assert_f(current < USAGE_SLACK,
+ "current usage (%"PRIu64" MiB) is not within margin (%d MiB)\n",
+ current / SZ_1M, USAGE_SLACK / SZ_1M);
+
+ /* Allow for a slack as there might be some extra pages allocated. */
+ igt_cgroup_dmem_set_max(cg, cg_region, 2 * BO_SIZE + USAGE_SLACK, false);
+
+ n_bo = allocate_vram(drv, ctx, fd, max_bo, BO_SIZE);
+ igt_assert_f(n_bo > 0, "failed to allocate VRAM\n");
+
+ igt_cgroup_dmem_get_current(cg, cg_region, ¤t);
+ igt_debug("After fill: cgroup current = %"PRIu64" MiB, "
+ "max = %"PRIu64" MiB\n",
+ current / SZ_1M, cg_max / SZ_1M);
+ igt_assert_f(current < 2 * BO_SIZE + USAGE_SLACK && current > 2 * BO_SIZE - USAGE_SLACK,
+ "current usage (%"PRIu64" MiB) is not within margin of allocation (%"PRIu64" MiB)\n",
+ current / SZ_1M, cg_max / SZ_1M);
+
+ free_vram(drv, ctx, n_bo);
+ wait_for_usage_drop(cg, cg_region, USAGE_SLACK);
+
+ igt_cgroup_dmem_get_current(cg, cg_region, ¤t);
+ igt_debug("After free: cgroup current = %"PRIu64" MiB, "
+ "max = %"PRIu64" MiB\n",
+ current / SZ_1M, cg_max / SZ_1M);
+ igt_assert_f(current < USAGE_SLACK,
+ "current usage (%"PRIu64" MiB) is not within margin (%d MiB)\n",
+ current / SZ_1M, USAGE_SLACK / SZ_1M);
+
+ igt_cgroup_dmem_set_max(cg, cg_region, USAGE_SLACK, false);
+
+ n_bo = allocate_vram(drv, ctx, fd, max_bo, BO_SIZE);
+ igt_assert_f(n_bo != -ENOMEM, "VRAM allocation succeeded despite max set to 0\n");
+
+ igt_cgroup_dmem_get_current(cg, cg_region, ¤t);
+ igt_debug("After fill: cgroup current = %"PRIu64" MiB, "
+ "max = %"PRIu64" MiB\n",
+ current / SZ_1M, cg_max / SZ_1M);
+ igt_assert_f(current < USAGE_SLACK,
+ "current usage (%"PRIu64" MiB) is not within margin\n",
+ current / SZ_1M);
+
+ if (n_bo > 0)
+ free_vram(drv, ctx, n_bo);
+ wait_for_usage_drop(cg, cg_region, USAGE_SLACK);
+
+ igt_cgroup_dmem_get_current(cg, cg_region, ¤t);
+ igt_debug("After free: cgroup current = %"PRIu64" MiB, "
+ "max = %"PRIu64" MiB\n",
+ current / SZ_1M, cg_max / SZ_1M);
+ igt_assert_f(current < USAGE_SLACK,
+ "current usage (%"PRIu64" MiB) is not within margin (%d MiB)\n",
+ current / SZ_1M, USAGE_SLACK / SZ_1M);
+
+ drv->deinit(ctx);
+ igt_cgroup_free(cg);
+}
+
+static const struct {
+ const char *name;
+ void (*test_fn)(int fd, char *cg_region, unsigned int flags, const struct igt_dmem_driver *drv);
+ unsigned int flags;
+} subtests[] = {
+ { "current", test_current, 0 },
+ { }
+};
+
+static const struct {
+ int driver_flag;
+ const struct igt_dmem_driver *driver;
+} drivers[] = {
+ { DRIVER_XE, &xe_dmem_driver },
+ { DRIVER_AMDGPU, &amdgpu_dmem_driver },
+ { },
+};
+
+int igt_main()
+{
+ igt_fixture() {
+ igt_require_f(getuid() == 0, "Test requires root\n");
+ /* Check dmem cgroup controller is available before doing anything else */
+ igt_require_f(igt_cgroup_dmem_available(),
+ "dmem cgroup controller not available (no cgroup v2 or no registered regions)\n");
+
+ }
+
+ for (int d = 0; drivers[d].driver; d++) {
+ igt_subtest_group() {
+ int fd = -1;
+ char *cg_region;
+ igt_fixture() {
+ fd = drm_open_driver(drivers[d].driver_flag);
+ igt_require_f(fd >= 0,
+ "No %s device found, skipping\n",
+ drivers[d].driver->name);
+ cg_region = drivers[d].driver->get_region_name(fd);
+ igt_require_f(cg_region, "Region not tracked by dmem cgroup controller\n");
+ }
+
+ for (int i = 0; subtests[i].name; i++)
+ igt_subtest_f("%s-%s", drivers[d].driver->name, subtests[i].name)
+ subtests[i].test_fn(fd, cg_region, subtests[i].flags, drivers[d].driver);
+
+ igt_fixture() {
+ if (fd >= 0)
+ drm_close_driver(fd);
+ free(cg_region);
+ }
+ }
+ }
+}
diff --git a/tests/meson.build b/tests/meson.build
index 88a0ce224432..dfdaab41825a 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -11,6 +11,7 @@ test_progs = [
'core_sysfs',
'dmabuf',
'dmabuf_sync_file',
+ 'dmem_cgroups',
'device_reset',
'dumb_buffer',
'drm_buddy',
--
2.47.3
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH i-g-t v2 7/7] tests/dmem_cgroups: add test for dmem.current
2026-07-02 13:00 ` [PATCH i-g-t v2 7/7] tests/dmem_cgroups: add test for dmem.current Thadeu Lima de Souza Cascardo
@ 2026-07-07 11:07 ` Kamil Konieczny
0 siblings, 0 replies; 13+ messages in thread
From: Kamil Konieczny @ 2026-07-07 11:07 UTC (permalink / raw)
To: Thadeu Lima de Souza Cascardo
Cc: igt-dev, siqueira, dri-devel, amd-gfx, intel-xe, Christian Koenig,
maarten.lankhorst, Thomas Hellström, Janusz Krzysztofik,
Vitaly Prosyak, Natalie Vock, Tvrtko Ursulin, kernel-dev
Hi Thadeu,
On 2026-07-02 at 10:00:58 -0300, Thadeu Lima de Souza Cascardo wrote:
> Based on the work of Thomas Hellström to test dmem.max eviction, add a test
> for dmem.current usage after allocations and setting dmem.max.
>
> Create a dmem cgroup, allocate close to capacity (or at most 4GiB), check
> current usage is within a small slack of the expected allocation. Then,
> set max to a small value and check allocations and current usage are
> limited to the max set. Set max to 0, then check no allocations are
> allowed and current usage is also within the slack. After each allocation,
> release memory and check current usage has gone down.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
> ---
> tests/dmem_cgroups.c | 245 +++++++++++++++++++++++++++++++++++++++++++
Why two tests? dmesm_cgropus and cgroups_dmem?
Why not only one? This is confusing.
Regards,
Kamil
> tests/meson.build | 1 +
> 2 files changed, 246 insertions(+)
> create mode 100644 tests/dmem_cgroups.c
>
> diff --git a/tests/dmem_cgroups.c b/tests/dmem_cgroups.c
> new file mode 100644
> index 000000000000..da2475a14ff9
> --- /dev/null
> +++ b/tests/dmem_cgroups.c
> @@ -0,0 +1,245 @@
> +// SPDX-License-Identifier: MIT
> +/*
> + * Copyright © 2026 Intel Corporation
> + */
> +
> +/**
> + * TEST: dmem_cgroups
> + * DESCRIPTION: Tests exercising the dmem cgroup controller on devices.
> + * Category: Core
> + * Mega feature: General Core features
> + * Sub-category: cgroup
> + * FUNCTIONALITY: cgroup dmem controller
> + */
> +
> +#include <errno.h>
> +#include <signal.h>
> +#include <stdatomic.h>
> +#include <stdint.h>
> +#include <stdlib.h>
> +#include <string.h>
> +#include <unistd.h>
> +
> +#include "drmtest.h"
> +#include "igt.h"
> +#include "igt_aux.h"
> +#include "igt_cgroup.h"
> +#include "igt_dmem_driver.h"
> +
> +#define BO_SIZE SZ_64M
> +#define MAX_LIMIT ((uint64_t)4 * SZ_1G)
> +#define USAGE_SLACK SZ_4M /* tolerance above the set max */
> +#define USAGE_POLL_MS 10
> +#define USAGE_DROP_TIMEOUT_MS 1000
> +
> +/**
> + * SUBTEST: current
> + * DESCRIPTION:
> + * Create a dmem cgroup, allocate close to capacity (or at most 4GiB),
> + * check current usage is within a small slack of the expected allocation.
> + * Then, set max to a small value and check allocations and current usage
> + * are limited to the max set.
> + * Set max to 0, then check no allocations are allowed and current usage
> + * is also within the slack.
> + * After each allocation, release memory and check current usage has gone
> + * down.
> + * REQUIREMENTS: xe or amdgpu device with at least one VRAM region
> + */
> +
> +static uint64_t wait_for_usage_drop(struct igt_cgroup *cg, const char *region,
> + uint64_t limit)
> +{
> + uint64_t current;
> + unsigned int elapsed = 0;
> +
> + do {
> + igt_cgroup_dmem_get_current(cg, region, ¤t);
> + if (current <= limit)
> + return current;
> + usleep(USAGE_POLL_MS * 1000);
> + elapsed += USAGE_POLL_MS;
> + } while (elapsed < USAGE_DROP_TIMEOUT_MS);
> +
> + return current;
> +}
> +
> +static int allocate_vram(const struct igt_dmem_driver *drv, void *ctx, int fd, int max_bo, size_t len)
> +{
> + int n_bo, err = 0;
> + for (n_bo = 0; n_bo < max_bo; n_bo++) {
> + err = drv->allocate_vram(ctx, n_bo, len);
> + if (err)
> + break;
> + }
> + /* These are expected failures we can ignore. */
> + if (err == -ENOMEM || err == -ENOSPC)
> + err = 0;
> + return err ?: n_bo;
> +}
> +
> +static void free_vram(const struct igt_dmem_driver *drv, void *ctx, int max_bo)
> +{
> + int i;
> + for (i = 0; i < max_bo; i++)
> + drv->free_vram(ctx, i);
> +}
> +
> +static void test_current(int fd, char *cg_region, unsigned int flags, const struct igt_dmem_driver *drv)
> +{
> + struct igt_cgroup *cg;
> + void *ctx;
> + uint64_t current, capacity, cg_max;
> + int n_bo = 0, max_bo;
> + int err;
> +
> + igt_cgroup_dmem_get_capacity(cg_region, &capacity);
> + igt_require_f(capacity >= 4 * BO_SIZE,
> + "VRAM capacity (%"PRIu64" MiB) too small to test\n",
> + capacity / SZ_1M);
> +
> + /*
> + * Use up to 4 GiB, or the full capacity if the device has less.
> + * Leave one BO_SIZE worth of headroom so the device isn't completely
> + * exhausted before the cgroup limit is hit.
> + */
> + cg_max = min(MAX_LIMIT, capacity - BO_SIZE - USAGE_SLACK);
> + cg_max = ALIGN_DOWN(cg_max, BO_SIZE);
> +
> + /* Create cgroup and move into it */
> + cg = igt_cgroup_new("igt_cgroups_test");
> + igt_cgroup_move_current(cg);
> +
> + max_bo = cg_max / BO_SIZE;
> +
> + err = drv->init(&ctx, fd, max_bo);
> + igt_assert_f(!err, "Failed to initialize driver");
> +
> + n_bo = allocate_vram(drv, ctx, fd, max_bo, BO_SIZE);
> + igt_assert_f(n_bo > 0, "failed to allocate VRAM\n");
> +
> + igt_cgroup_dmem_get_current(cg, cg_region, ¤t);
> + igt_debug("After fill: cgroup current = %"PRIu64" MiB, "
> + "max = %"PRIu64" MiB\n",
> + current / SZ_1M, cg_max / SZ_1M);
> + igt_assert_f(current < cg_max + USAGE_SLACK && current > cg_max - USAGE_SLACK,
> + "current usage (%"PRIu64" MiB) is not within margin of allocation (%"PRIu64" MiB)\n",
> + current / SZ_1M, cg_max / SZ_1M);
> +
> + free_vram(drv, ctx, n_bo);
> + wait_for_usage_drop(cg, cg_region, USAGE_SLACK);
> +
> + igt_cgroup_dmem_get_current(cg, cg_region, ¤t);
> + igt_debug("After free: cgroup current = %"PRIu64" MiB, "
> + "max = %"PRIu64" MiB\n",
> + current / SZ_1M, cg_max / SZ_1M);
> + igt_assert_f(current < USAGE_SLACK,
> + "current usage (%"PRIu64" MiB) is not within margin (%d MiB)\n",
> + current / SZ_1M, USAGE_SLACK / SZ_1M);
> +
> + /* Allow for a slack as there might be some extra pages allocated. */
> + igt_cgroup_dmem_set_max(cg, cg_region, 2 * BO_SIZE + USAGE_SLACK, false);
> +
> + n_bo = allocate_vram(drv, ctx, fd, max_bo, BO_SIZE);
> + igt_assert_f(n_bo > 0, "failed to allocate VRAM\n");
> +
> + igt_cgroup_dmem_get_current(cg, cg_region, ¤t);
> + igt_debug("After fill: cgroup current = %"PRIu64" MiB, "
> + "max = %"PRIu64" MiB\n",
> + current / SZ_1M, cg_max / SZ_1M);
> + igt_assert_f(current < 2 * BO_SIZE + USAGE_SLACK && current > 2 * BO_SIZE - USAGE_SLACK,
> + "current usage (%"PRIu64" MiB) is not within margin of allocation (%"PRIu64" MiB)\n",
> + current / SZ_1M, cg_max / SZ_1M);
> +
> + free_vram(drv, ctx, n_bo);
> + wait_for_usage_drop(cg, cg_region, USAGE_SLACK);
> +
> + igt_cgroup_dmem_get_current(cg, cg_region, ¤t);
> + igt_debug("After free: cgroup current = %"PRIu64" MiB, "
> + "max = %"PRIu64" MiB\n",
> + current / SZ_1M, cg_max / SZ_1M);
> + igt_assert_f(current < USAGE_SLACK,
> + "current usage (%"PRIu64" MiB) is not within margin (%d MiB)\n",
> + current / SZ_1M, USAGE_SLACK / SZ_1M);
> +
> + igt_cgroup_dmem_set_max(cg, cg_region, USAGE_SLACK, false);
> +
> + n_bo = allocate_vram(drv, ctx, fd, max_bo, BO_SIZE);
> + igt_assert_f(n_bo != -ENOMEM, "VRAM allocation succeeded despite max set to 0\n");
> +
> + igt_cgroup_dmem_get_current(cg, cg_region, ¤t);
> + igt_debug("After fill: cgroup current = %"PRIu64" MiB, "
> + "max = %"PRIu64" MiB\n",
> + current / SZ_1M, cg_max / SZ_1M);
> + igt_assert_f(current < USAGE_SLACK,
> + "current usage (%"PRIu64" MiB) is not within margin\n",
> + current / SZ_1M);
> +
> + if (n_bo > 0)
> + free_vram(drv, ctx, n_bo);
> + wait_for_usage_drop(cg, cg_region, USAGE_SLACK);
> +
> + igt_cgroup_dmem_get_current(cg, cg_region, ¤t);
> + igt_debug("After free: cgroup current = %"PRIu64" MiB, "
> + "max = %"PRIu64" MiB\n",
> + current / SZ_1M, cg_max / SZ_1M);
> + igt_assert_f(current < USAGE_SLACK,
> + "current usage (%"PRIu64" MiB) is not within margin (%d MiB)\n",
> + current / SZ_1M, USAGE_SLACK / SZ_1M);
> +
> + drv->deinit(ctx);
> + igt_cgroup_free(cg);
> +}
> +
> +static const struct {
> + const char *name;
> + void (*test_fn)(int fd, char *cg_region, unsigned int flags, const struct igt_dmem_driver *drv);
> + unsigned int flags;
> +} subtests[] = {
> + { "current", test_current, 0 },
> + { }
> +};
> +
> +static const struct {
> + int driver_flag;
> + const struct igt_dmem_driver *driver;
> +} drivers[] = {
> + { DRIVER_XE, &xe_dmem_driver },
> + { DRIVER_AMDGPU, &amdgpu_dmem_driver },
> + { },
> +};
> +
> +int igt_main()
> +{
> + igt_fixture() {
> + igt_require_f(getuid() == 0, "Test requires root\n");
> + /* Check dmem cgroup controller is available before doing anything else */
> + igt_require_f(igt_cgroup_dmem_available(),
> + "dmem cgroup controller not available (no cgroup v2 or no registered regions)\n");
> +
> + }
> +
> + for (int d = 0; drivers[d].driver; d++) {
> + igt_subtest_group() {
> + int fd = -1;
> + char *cg_region;
> + igt_fixture() {
> + fd = drm_open_driver(drivers[d].driver_flag);
> + igt_require_f(fd >= 0,
> + "No %s device found, skipping\n",
> + drivers[d].driver->name);
> + cg_region = drivers[d].driver->get_region_name(fd);
> + igt_require_f(cg_region, "Region not tracked by dmem cgroup controller\n");
> + }
> +
> + for (int i = 0; subtests[i].name; i++)
> + igt_subtest_f("%s-%s", drivers[d].driver->name, subtests[i].name)
> + subtests[i].test_fn(fd, cg_region, subtests[i].flags, drivers[d].driver);
> +
> + igt_fixture() {
> + if (fd >= 0)
> + drm_close_driver(fd);
> + free(cg_region);
> + }
> + }
> + }
> +}
> diff --git a/tests/meson.build b/tests/meson.build
> index 88a0ce224432..dfdaab41825a 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -11,6 +11,7 @@ test_progs = [
> 'core_sysfs',
> 'dmabuf',
> 'dmabuf_sync_file',
> + 'dmem_cgroups',
> 'device_reset',
> 'dumb_buffer',
> 'drm_buddy',
> --
> 2.47.3
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* RE: [PATCH i-g-t v3 0/7] add dmem_cgroups test
2026-07-02 13:00 [PATCH i-g-t v3 0/7] add dmem_cgroups test Thadeu Lima de Souza Cascardo
` (6 preceding siblings ...)
2026-07-02 13:00 ` [PATCH i-g-t v2 7/7] tests/dmem_cgroups: add test for dmem.current Thadeu Lima de Souza Cascardo
@ 2026-07-03 9:54 ` Sokolowski, Jan
2026-07-03 11:18 ` Thadeu Lima de Souza Cascardo
2026-07-06 16:48 ` Rodrigo Siqueira
8 siblings, 1 reply; 13+ messages in thread
From: Sokolowski, Jan @ 2026-07-03 9:54 UTC (permalink / raw)
To: Thadeu Lima de Souza Cascardo, igt-dev@lists.freedesktop.org
Cc: siqueira@igalia.com, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
Christian Koenig, maarten.lankhorst@linux.intel.com,
Thomas Hellström, Kamil Konieczny, Janusz Krzysztofik,
Vitaly Prosyak, Natalie Vock, Tvrtko Ursulin,
kernel-dev@igalia.com
I don't know if that's a problem or not, but your patches in patch series are titled as v2 instead of v3, at least that's how I see them.
Jan
> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Thadeu
> Lima de Souza Cascardo
> Sent: Thursday, July 2, 2026 3:01 PM
> To: igt-dev@lists.freedesktop.org
> Cc: siqueira@igalia.com; Thadeu Lima de Souza Cascardo
> <cascardo@igalia.com>; dri-devel@lists.freedesktop.org; amd-
> gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org; Christian Koenig
> <christian.koenig@amd.com>; maarten.lankhorst@linux.intel.com; Thomas
> Hellström <thomas.hellstrom@linux.intel.com>; Kamil Konieczny
> <kamil.konieczny@linux.intel.com>; Janusz Krzysztofik
> <janusz.krzysztofik@linux.intel.com>; Vitaly Prosyak
> <vitaly.prosyak@amd.com>; Natalie Vock <natalie.vock@gmx.de>; Tvrtko
> Ursulin <tvrtko.ursulin@igalia.com>; kernel-dev@igalia.com
> Subject: [PATCH i-g-t v3 0/7] add dmem_cgroups test
>
> v3 TLDR:
> Sending again for fixes when running on top of Xe.
>
> This patchset is based on the work of Thomas Hellström at [1] and a
> followup I have submitted at [2]. This is now a v3, since I submitted [6].
>
> With this version, I reverted the order in which to apply the patchsets, as
> this one adds the infrastructure and the drivers mechanisms, and a test for
> dmem.current and its behavior around dmem.max that is currently
> supported
> in the kernel.
>
> As for the new dmem.max eviction behavior, introduced by [3], it has been
> pushed to a branch at [4]. If preferred, I can submit the two patches
> independently.
>
> I have run the tests, including the ones that test dmem.max eviction
> behavior on a system with a 1GiB VRAM amdgpu card. Rodrigo Siqueira
> helped
> me run it on a Xe system. We have applied the patchset at [3] on top of
> current linux origin/master [5], with a fixup for the amdgpu driver.
>
> Now, for the changes since v1 [2]:
> - Changed the test name from drv_dmem_cgroups to dmem_cgroups.
> - Have system includes before igt ones.
> - Documented the current SUBTEST.
> - Changed free_vram driver hook to only release a given BO. This allows for
> the eviction trigger by a new allocation added by write_eviction_nonblock
> subtest.
> - Changed allocate_vram to keep more state necessary for releasing a single
> BO.
> - Added a global free_vram helper to free all allocated VRAM.
>
> Compared to v3 of [1]:
> - I have kept wait_for_usage_drop as release can be lazy and we test for it
> on test_current SUBTEST, but had USAGE_DROP_TIMEOUT_MS be a little
> longer.
> - Changed BO_SIZE and EVICT_STEP to allow for more than two eviction steps
> on a 1GiB VRAM system.
> - Reduced USAGE_SLACK to avoid false positives, but still allow for some
> page table accounting.
>
> Compared to v2 of this one [6]:
>
> - Ignore -ENOMEM and -ENOSPC when trying to fill VRAM.
> - When limiting max memory, allow for some slack, as there might be some
> overhead.
> - On Xe, allocate GEM object with no deferred backing, and skip binding.
>
> [1] https://patchwork.freedesktop.org/series/163935/#rev3
> [2] https://patchwork.freedesktop.org/series/166496/
> [3] https://lore.kernel.org/dri-devel/20260611173301.17473-1-
> thomas.hellstrom@linux.intel.com/
> [4] https://gitlab.freedesktop.org/cascardo/igt-gpu-tools/-
> /commits/dmem_max?ref_type=heads
> [5] 502d801f0ab0 ("Merge tag 'erofs-for-7.2-rc1' of
> git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs")
> [6] https://lore.kernel.org/dri-devel/20260623174319.4138648-1-
> cascardo@igalia.com/
>
>
> Thadeu Lima de Souza Cascardo (4):
> lib/xe: Introduce dmem driver and implement Xe support
> lib/amdgpu: add amdgpu_cgroup_region_name
> lib/amdgpu: add amdgpu support to igt_dmem_driver
> tests/dmem_cgroups: add test for dmem.current
>
> Thomas Hellström (3):
> lib/igt_cgroup: add cgroup v2 and dmem controller helpers
> tests/cgroup_dmem: add dmem cgroup controller test
> lib/xe: add xe_cgroup_region_name() helper
>
> lib/amdgpu/amd_dmem.c | 99 +++++++
> lib/amdgpu/amd_memory.c | 25 ++
> lib/amdgpu/amd_memory.h | 2 +
> lib/igt.h | 1 +
> lib/igt_cgroup.c | 638 ++++++++++++++++++++++++++++++++++++++++
> lib/igt_cgroup.h | 56 ++++
> lib/igt_dmem_driver.h | 25 ++
> lib/meson.build | 3 +
> lib/xe/xe_dmem.c | 143 +++++++++
> lib/xe/xe_query.c | 32 ++
> lib/xe/xe_query.h | 2 +
> tests/cgroup_dmem.c | 92 ++++++
> tests/dmem_cgroups.c | 245 +++++++++++++++
> tests/meson.build | 2 +
> 14 files changed, 1365 insertions(+)
> create mode 100644 lib/amdgpu/amd_dmem.c
> create mode 100644 lib/igt_cgroup.c
> create mode 100644 lib/igt_cgroup.h
> create mode 100644 lib/igt_dmem_driver.h
> create mode 100644 lib/xe/xe_dmem.c
> create mode 100644 tests/cgroup_dmem.c
> create mode 100644 tests/dmem_cgroups.c
>
> --
> 2.47.3
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH i-g-t v3 0/7] add dmem_cgroups test
2026-07-03 9:54 ` [PATCH i-g-t v3 0/7] add dmem_cgroups test Sokolowski, Jan
@ 2026-07-03 11:18 ` Thadeu Lima de Souza Cascardo
2026-07-07 10:42 ` Kamil Konieczny
0 siblings, 1 reply; 13+ messages in thread
From: Thadeu Lima de Souza Cascardo @ 2026-07-03 11:18 UTC (permalink / raw)
To: Sokolowski, Jan
Cc: igt-dev@lists.freedesktop.org, siqueira@igalia.com,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org, Christian Koenig,
maarten.lankhorst@linux.intel.com, Thomas Hellström,
Kamil Konieczny, Janusz Krzysztofik, Vitaly Prosyak, Natalie Vock,
Tvrtko Ursulin, kernel-dev@igalia.com
On Fri, Jul 03, 2026 at 09:54:14AM +0000, Sokolowski, Jan wrote:
> I don't know if that's a problem or not, but your patches in patch series are titled as v2 instead of v3, at least that's how I see them.
>
> Jan
>
I decided to name this one v3, though I did not call the previous one v2,
because I have submitted a patchset earlier that was on top of Thomas
Hellström patchset.
I think it tracks the history of the patchset better. I am sorry if this
got confusing.
Cascardo.
> > -----Original Message-----
> > From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Thadeu
> > Lima de Souza Cascardo
> > Sent: Thursday, July 2, 2026 3:01 PM
> > To: igt-dev@lists.freedesktop.org
> > Cc: siqueira@igalia.com; Thadeu Lima de Souza Cascardo
> > <cascardo@igalia.com>; dri-devel@lists.freedesktop.org; amd-
> > gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org; Christian Koenig
> > <christian.koenig@amd.com>; maarten.lankhorst@linux.intel.com; Thomas
> > Hellström <thomas.hellstrom@linux.intel.com>; Kamil Konieczny
> > <kamil.konieczny@linux.intel.com>; Janusz Krzysztofik
> > <janusz.krzysztofik@linux.intel.com>; Vitaly Prosyak
> > <vitaly.prosyak@amd.com>; Natalie Vock <natalie.vock@gmx.de>; Tvrtko
> > Ursulin <tvrtko.ursulin@igalia.com>; kernel-dev@igalia.com
> > Subject: [PATCH i-g-t v3 0/7] add dmem_cgroups test
> >
> > v3 TLDR:
> > Sending again for fixes when running on top of Xe.
> >
> > This patchset is based on the work of Thomas Hellström at [1] and a
> > followup I have submitted at [2]. This is now a v3, since I submitted [6].
> >
> > With this version, I reverted the order in which to apply the patchsets, as
> > this one adds the infrastructure and the drivers mechanisms, and a test for
> > dmem.current and its behavior around dmem.max that is currently
> > supported
> > in the kernel.
> >
> > As for the new dmem.max eviction behavior, introduced by [3], it has been
> > pushed to a branch at [4]. If preferred, I can submit the two patches
> > independently.
> >
> > I have run the tests, including the ones that test dmem.max eviction
> > behavior on a system with a 1GiB VRAM amdgpu card. Rodrigo Siqueira
> > helped
> > me run it on a Xe system. We have applied the patchset at [3] on top of
> > current linux origin/master [5], with a fixup for the amdgpu driver.
> >
> > Now, for the changes since v1 [2]:
> > - Changed the test name from drv_dmem_cgroups to dmem_cgroups.
> > - Have system includes before igt ones.
> > - Documented the current SUBTEST.
> > - Changed free_vram driver hook to only release a given BO. This allows for
> > the eviction trigger by a new allocation added by write_eviction_nonblock
> > subtest.
> > - Changed allocate_vram to keep more state necessary for releasing a single
> > BO.
> > - Added a global free_vram helper to free all allocated VRAM.
> >
> > Compared to v3 of [1]:
> > - I have kept wait_for_usage_drop as release can be lazy and we test for it
> > on test_current SUBTEST, but had USAGE_DROP_TIMEOUT_MS be a little
> > longer.
> > - Changed BO_SIZE and EVICT_STEP to allow for more than two eviction steps
> > on a 1GiB VRAM system.
> > - Reduced USAGE_SLACK to avoid false positives, but still allow for some
> > page table accounting.
> >
> > Compared to v2 of this one [6]:
> >
> > - Ignore -ENOMEM and -ENOSPC when trying to fill VRAM.
> > - When limiting max memory, allow for some slack, as there might be some
> > overhead.
> > - On Xe, allocate GEM object with no deferred backing, and skip binding.
> >
> > [1] https://patchwork.freedesktop.org/series/163935/#rev3
> > [2] https://patchwork.freedesktop.org/series/166496/
> > [3] https://lore.kernel.org/dri-devel/20260611173301.17473-1-
> > thomas.hellstrom@linux.intel.com/
> > [4] https://gitlab.freedesktop.org/cascardo/igt-gpu-tools/-
> > /commits/dmem_max?ref_type=heads
> > [5] 502d801f0ab0 ("Merge tag 'erofs-for-7.2-rc1' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs")
> > [6] https://lore.kernel.org/dri-devel/20260623174319.4138648-1-
> > cascardo@igalia.com/
> >
> >
> > Thadeu Lima de Souza Cascardo (4):
> > lib/xe: Introduce dmem driver and implement Xe support
> > lib/amdgpu: add amdgpu_cgroup_region_name
> > lib/amdgpu: add amdgpu support to igt_dmem_driver
> > tests/dmem_cgroups: add test for dmem.current
> >
> > Thomas Hellström (3):
> > lib/igt_cgroup: add cgroup v2 and dmem controller helpers
> > tests/cgroup_dmem: add dmem cgroup controller test
> > lib/xe: add xe_cgroup_region_name() helper
> >
> > lib/amdgpu/amd_dmem.c | 99 +++++++
> > lib/amdgpu/amd_memory.c | 25 ++
> > lib/amdgpu/amd_memory.h | 2 +
> > lib/igt.h | 1 +
> > lib/igt_cgroup.c | 638 ++++++++++++++++++++++++++++++++++++++++
> > lib/igt_cgroup.h | 56 ++++
> > lib/igt_dmem_driver.h | 25 ++
> > lib/meson.build | 3 +
> > lib/xe/xe_dmem.c | 143 +++++++++
> > lib/xe/xe_query.c | 32 ++
> > lib/xe/xe_query.h | 2 +
> > tests/cgroup_dmem.c | 92 ++++++
> > tests/dmem_cgroups.c | 245 +++++++++++++++
> > tests/meson.build | 2 +
> > 14 files changed, 1365 insertions(+)
> > create mode 100644 lib/amdgpu/amd_dmem.c
> > create mode 100644 lib/igt_cgroup.c
> > create mode 100644 lib/igt_cgroup.h
> > create mode 100644 lib/igt_dmem_driver.h
> > create mode 100644 lib/xe/xe_dmem.c
> > create mode 100644 tests/cgroup_dmem.c
> > create mode 100644 tests/dmem_cgroups.c
> >
> > --
> > 2.47.3
>
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH i-g-t v3 0/7] add dmem_cgroups test
2026-07-03 11:18 ` Thadeu Lima de Souza Cascardo
@ 2026-07-07 10:42 ` Kamil Konieczny
0 siblings, 0 replies; 13+ messages in thread
From: Kamil Konieczny @ 2026-07-07 10:42 UTC (permalink / raw)
To: Thadeu Lima de Souza Cascardo
Cc: Sokolowski, Jan, igt-dev@lists.freedesktop.org,
siqueira@igalia.com, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
Christian Koenig, maarten.lankhorst@linux.intel.com,
Thomas Hellström, Janusz Krzysztofik, Vitaly Prosyak,
Natalie Vock, Tvrtko Ursulin, kernel-dev@igalia.com
Hi Thadeu,
On 2026-07-03 at 08:18:48 -0300, Thadeu Lima de Souza Cascardo wrote:
> On Fri, Jul 03, 2026 at 09:54:14AM +0000, Sokolowski, Jan wrote:
> > I don't know if that's a problem or not, but your patches in patch series are titled as v2 instead of v3, at least that's how I see them.
> >
> > Jan
> >
>
> I decided to name this one v3, though I did not call the previous one v2,
> because I have submitted a patchset earlier that was on top of Thomas
> Hellström patchset.
>
> I think it tracks the history of the patchset better. I am sorry if this
> got confusing.
>
> Cascardo.
>
Please keep versioning the same across series, if your cover letter
has v3, all patches in series should also have v3.
Regards,
Kamil
> > > -----Original Message-----
> > > From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Thadeu
> > > Lima de Souza Cascardo
> > > Sent: Thursday, July 2, 2026 3:01 PM
> > > To: igt-dev@lists.freedesktop.org
> > > Cc: siqueira@igalia.com; Thadeu Lima de Souza Cascardo
> > > <cascardo@igalia.com>; dri-devel@lists.freedesktop.org; amd-
> > > gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org; Christian Koenig
> > > <christian.koenig@amd.com>; maarten.lankhorst@linux.intel.com; Thomas
> > > Hellström <thomas.hellstrom@linux.intel.com>; Kamil Konieczny
> > > <kamil.konieczny@linux.intel.com>; Janusz Krzysztofik
> > > <janusz.krzysztofik@linux.intel.com>; Vitaly Prosyak
> > > <vitaly.prosyak@amd.com>; Natalie Vock <natalie.vock@gmx.de>; Tvrtko
> > > Ursulin <tvrtko.ursulin@igalia.com>; kernel-dev@igalia.com
> > > Subject: [PATCH i-g-t v3 0/7] add dmem_cgroups test
> > >
> > > v3 TLDR:
> > > Sending again for fixes when running on top of Xe.
> > >
> > > This patchset is based on the work of Thomas Hellström at [1] and a
> > > followup I have submitted at [2]. This is now a v3, since I submitted [6].
> > >
> > > With this version, I reverted the order in which to apply the patchsets, as
> > > this one adds the infrastructure and the drivers mechanisms, and a test for
> > > dmem.current and its behavior around dmem.max that is currently
> > > supported
> > > in the kernel.
> > >
> > > As for the new dmem.max eviction behavior, introduced by [3], it has been
> > > pushed to a branch at [4]. If preferred, I can submit the two patches
> > > independently.
> > >
> > > I have run the tests, including the ones that test dmem.max eviction
> > > behavior on a system with a 1GiB VRAM amdgpu card. Rodrigo Siqueira
> > > helped
> > > me run it on a Xe system. We have applied the patchset at [3] on top of
> > > current linux origin/master [5], with a fixup for the amdgpu driver.
> > >
> > > Now, for the changes since v1 [2]:
> > > - Changed the test name from drv_dmem_cgroups to dmem_cgroups.
> > > - Have system includes before igt ones.
> > > - Documented the current SUBTEST.
> > > - Changed free_vram driver hook to only release a given BO. This allows for
> > > the eviction trigger by a new allocation added by write_eviction_nonblock
> > > subtest.
> > > - Changed allocate_vram to keep more state necessary for releasing a single
> > > BO.
> > > - Added a global free_vram helper to free all allocated VRAM.
> > >
> > > Compared to v3 of [1]:
> > > - I have kept wait_for_usage_drop as release can be lazy and we test for it
> > > on test_current SUBTEST, but had USAGE_DROP_TIMEOUT_MS be a little
> > > longer.
> > > - Changed BO_SIZE and EVICT_STEP to allow for more than two eviction steps
> > > on a 1GiB VRAM system.
> > > - Reduced USAGE_SLACK to avoid false positives, but still allow for some
> > > page table accounting.
> > >
> > > Compared to v2 of this one [6]:
> > >
> > > - Ignore -ENOMEM and -ENOSPC when trying to fill VRAM.
> > > - When limiting max memory, allow for some slack, as there might be some
> > > overhead.
> > > - On Xe, allocate GEM object with no deferred backing, and skip binding.
> > >
> > > [1] https://patchwork.freedesktop.org/series/163935/#rev3
> > > [2] https://patchwork.freedesktop.org/series/166496/
> > > [3] https://lore.kernel.org/dri-devel/20260611173301.17473-1-
> > > thomas.hellstrom@linux.intel.com/
> > > [4] https://gitlab.freedesktop.org/cascardo/igt-gpu-tools/-
> > > /commits/dmem_max?ref_type=heads
> > > [5] 502d801f0ab0 ("Merge tag 'erofs-for-7.2-rc1' of
> > > git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs")
> > > [6] https://lore.kernel.org/dri-devel/20260623174319.4138648-1-
> > > cascardo@igalia.com/
> > >
> > >
> > > Thadeu Lima de Souza Cascardo (4):
> > > lib/xe: Introduce dmem driver and implement Xe support
> > > lib/amdgpu: add amdgpu_cgroup_region_name
> > > lib/amdgpu: add amdgpu support to igt_dmem_driver
> > > tests/dmem_cgroups: add test for dmem.current
> > >
> > > Thomas Hellström (3):
> > > lib/igt_cgroup: add cgroup v2 and dmem controller helpers
> > > tests/cgroup_dmem: add dmem cgroup controller test
> > > lib/xe: add xe_cgroup_region_name() helper
> > >
> > > lib/amdgpu/amd_dmem.c | 99 +++++++
> > > lib/amdgpu/amd_memory.c | 25 ++
> > > lib/amdgpu/amd_memory.h | 2 +
> > > lib/igt.h | 1 +
> > > lib/igt_cgroup.c | 638 ++++++++++++++++++++++++++++++++++++++++
> > > lib/igt_cgroup.h | 56 ++++
> > > lib/igt_dmem_driver.h | 25 ++
> > > lib/meson.build | 3 +
> > > lib/xe/xe_dmem.c | 143 +++++++++
> > > lib/xe/xe_query.c | 32 ++
> > > lib/xe/xe_query.h | 2 +
> > > tests/cgroup_dmem.c | 92 ++++++
> > > tests/dmem_cgroups.c | 245 +++++++++++++++
> > > tests/meson.build | 2 +
> > > 14 files changed, 1365 insertions(+)
> > > create mode 100644 lib/amdgpu/amd_dmem.c
> > > create mode 100644 lib/igt_cgroup.c
> > > create mode 100644 lib/igt_cgroup.h
> > > create mode 100644 lib/igt_dmem_driver.h
> > > create mode 100644 lib/xe/xe_dmem.c
> > > create mode 100644 tests/cgroup_dmem.c
> > > create mode 100644 tests/dmem_cgroups.c
> > >
> > > --
> > > 2.47.3
> >
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH i-g-t v3 0/7] add dmem_cgroups test
2026-07-02 13:00 [PATCH i-g-t v3 0/7] add dmem_cgroups test Thadeu Lima de Souza Cascardo
` (7 preceding siblings ...)
2026-07-03 9:54 ` [PATCH i-g-t v3 0/7] add dmem_cgroups test Sokolowski, Jan
@ 2026-07-06 16:48 ` Rodrigo Siqueira
8 siblings, 0 replies; 13+ messages in thread
From: Rodrigo Siqueira @ 2026-07-06 16:48 UTC (permalink / raw)
To: Thadeu Lima de Souza Cascardo
Cc: igt-dev, dri-devel, amd-gfx, intel-xe, Christian Koenig,
maarten.lankhorst, Thomas Hellström, Kamil Konieczny,
Janusz Krzysztofik, Vitaly Prosyak, Natalie Vock, Tvrtko Ursulin,
kernel-dev
On 07/02, Thadeu Lima de Souza Cascardo wrote:
> v3 TLDR:
> Sending again for fixes when running on top of Xe.
>
> This patchset is based on the work of Thomas Hellström at [1] and a
> followup I have submitted at [2]. This is now a v3, since I submitted [6].
>
> With this version, I reverted the order in which to apply the patchsets, as
> this one adds the infrastructure and the drivers mechanisms, and a test for
> dmem.current and its behavior around dmem.max that is currently supported
> in the kernel.
>
> As for the new dmem.max eviction behavior, introduced by [3], it has been
> pushed to a branch at [4]. If preferred, I can submit the two patches
> independently.
>
> I have run the tests, including the ones that test dmem.max eviction
> behavior on a system with a 1GiB VRAM amdgpu card. Rodrigo Siqueira helped
> me run it on a Xe system. We have applied the patchset at [3] on top of
> current linux origin/master [5], with a fixup for the amdgpu driver.
>
> Now, for the changes since v1 [2]:
> - Changed the test name from drv_dmem_cgroups to dmem_cgroups.
> - Have system includes before igt ones.
> - Documented the current SUBTEST.
> - Changed free_vram driver hook to only release a given BO. This allows for
> the eviction trigger by a new allocation added by write_eviction_nonblock
> subtest.
> - Changed allocate_vram to keep more state necessary for releasing a single BO.
> - Added a global free_vram helper to free all allocated VRAM.
>
> Compared to v3 of [1]:
> - I have kept wait_for_usage_drop as release can be lazy and we test for it
> on test_current SUBTEST, but had USAGE_DROP_TIMEOUT_MS be a little
> longer.
> - Changed BO_SIZE and EVICT_STEP to allow for more than two eviction steps
> on a 1GiB VRAM system.
> - Reduced USAGE_SLACK to avoid false positives, but still allow for some
> page table accounting.
>
> Compared to v2 of this one [6]:
>
> - Ignore -ENOMEM and -ENOSPC when trying to fill VRAM.
> - When limiting max memory, allow for some slack, as there might be some
> overhead.
> - On Xe, allocate GEM object with no deferred backing, and skip binding.
Hi,
I tested this series with the following hardware:
- RX9060XT
- RX570
- Intel ARC B580
Based on that, this series was:
Tested-by: Rodrigo Siqueira <siqueira@igalia.com>
Thanks
>
> [1] https://patchwork.freedesktop.org/series/163935/#rev3
> [2] https://patchwork.freedesktop.org/series/166496/
> [3] https://lore.kernel.org/dri-devel/20260611173301.17473-1-thomas.hellstrom@linux.intel.com/
> [4] https://gitlab.freedesktop.org/cascardo/igt-gpu-tools/-/commits/dmem_max?ref_type=heads
> [5] 502d801f0ab0 ("Merge tag 'erofs-for-7.2-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs")
> [6] https://lore.kernel.org/dri-devel/20260623174319.4138648-1-cascardo@igalia.com/
>
>
> Thadeu Lima de Souza Cascardo (4):
> lib/xe: Introduce dmem driver and implement Xe support
> lib/amdgpu: add amdgpu_cgroup_region_name
> lib/amdgpu: add amdgpu support to igt_dmem_driver
> tests/dmem_cgroups: add test for dmem.current
>
> Thomas Hellström (3):
> lib/igt_cgroup: add cgroup v2 and dmem controller helpers
> tests/cgroup_dmem: add dmem cgroup controller test
> lib/xe: add xe_cgroup_region_name() helper
>
> lib/amdgpu/amd_dmem.c | 99 +++++++
> lib/amdgpu/amd_memory.c | 25 ++
> lib/amdgpu/amd_memory.h | 2 +
> lib/igt.h | 1 +
> lib/igt_cgroup.c | 638 ++++++++++++++++++++++++++++++++++++++++
> lib/igt_cgroup.h | 56 ++++
> lib/igt_dmem_driver.h | 25 ++
> lib/meson.build | 3 +
> lib/xe/xe_dmem.c | 143 +++++++++
> lib/xe/xe_query.c | 32 ++
> lib/xe/xe_query.h | 2 +
> tests/cgroup_dmem.c | 92 ++++++
> tests/dmem_cgroups.c | 245 +++++++++++++++
> tests/meson.build | 2 +
> 14 files changed, 1365 insertions(+)
> create mode 100644 lib/amdgpu/amd_dmem.c
> create mode 100644 lib/igt_cgroup.c
> create mode 100644 lib/igt_cgroup.h
> create mode 100644 lib/igt_dmem_driver.h
> create mode 100644 lib/xe/xe_dmem.c
> create mode 100644 tests/cgroup_dmem.c
> create mode 100644 tests/dmem_cgroups.c
>
> --
> 2.47.3
>
--
Rodrigo Siqueira
https://siqueira.tech
^ permalink raw reply [flat|nested] 13+ messages in thread