* [PATCH] drm/xe/xe_drm_ras: Enable CONFIG_DRM_RAS
@ 2026-08-18 7:54 Balasubramani Vivekanandan
2026-08-18 7:52 ` ✗ CI.KUnit: failure for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Balasubramani Vivekanandan @ 2026-08-18 7:54 UTC (permalink / raw)
To: intel-xe
Cc: Rodrigo Vivi, raag.jadav, riana.tauro, Balasubramani Vivekanandan
Xe RAS functionality needs DRM RAS support. Enable it.
Fixes: b40db12b542f5 ("drm/xe/xe_drm_ras: Add support for XE DRM RAS")
Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
---
drivers/gpu/drm/xe/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
index 4d7dcaff2b915..6c584f918edf2 100644
--- a/drivers/gpu/drm/xe/Kconfig
+++ b/drivers/gpu/drm/xe/Kconfig
@@ -42,6 +42,7 @@ config DRM_XE
select DRM_GPUSVM if !UML
select DRM_GPUVM
select DRM_SCHED
+ select DRM_RAS
select MMU_NOTIFIER
select WANT_DEV_COREDUMP
select AUXILIARY_BUS
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* ✗ CI.KUnit: failure for drm/xe/xe_drm_ras: Enable CONFIG_DRM_RAS
2026-08-18 7:54 [PATCH] drm/xe/xe_drm_ras: Enable CONFIG_DRM_RAS Balasubramani Vivekanandan
@ 2026-08-18 7:52 ` Patchwork
2026-08-18 7:53 ` [PATCH] " sashiko-bot
2026-08-18 7:59 ` Raag Jadav
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2026-08-18 7:52 UTC (permalink / raw)
To: Balasubramani Vivekanandan; +Cc: intel-xe
== Series Details ==
Series: drm/xe/xe_drm_ras: Enable CONFIG_DRM_RAS
URL : https://patchwork.freedesktop.org/series/172374/
State : failure
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig
ERROR:root:/usr/bin/ld: drivers/gpu/drm/drm_ras.o: in function `msg_reply_value':
drm_ras.c:(.text+0x182): undefined reference to `nla_put'
/usr/bin/ld: drivers/gpu/drm/drm_ras.o: in function `drm_ras_nl_error_event':
drm_ras.c:(.text+0x2ca): undefined reference to `__alloc_skb'
/usr/bin/ld: drm_ras.c:(.text+0x303): undefined reference to `genlmsg_put'
/usr/bin/ld: drm_ras.c:(.text+0x33b): undefined reference to `nla_put'
/usr/bin/ld: drm_ras.c:(.text+0x377): undefined reference to `skb_trim'
/usr/bin/ld: drm_ras.c:(.text+0x38d): undefined reference to `sk_skb_reason_drop'
/usr/bin/ld: drm_ras.c:(.text+0x4c3): undefined reference to `genlmsg_multicast_allns'
/usr/bin/ld: drivers/gpu/drm/drm_ras.o: in function `drm_ras_nl_list_nodes_dumpit':
drm_ras.c:(.text+0x5b9): undefined reference to `nla_put'
/usr/bin/ld: drm_ras.c:(.text+0x6f1): undefined reference to `genlmsg_put'
/usr/bin/ld: drm_ras.c:(.text+0x74f): undefined reference to `skb_trim'
/usr/bin/ld: drivers/gpu/drm/drm_ras.o: in function `drm_ras_nl_get_error_counter_dumpit':
drm_ras.c:(.text+0x888): undefined reference to `genlmsg_put'
/usr/bin/ld: drm_ras.c:(.text+0x920): undefined reference to `skb_trim'
/usr/bin/ld: drivers/gpu/drm/drm_ras.o: in function `drm_ras_nl_get_error_counter_doit':
drm_ras.c:(.text+0xa2d): undefined reference to `__alloc_skb'
/usr/bin/ld: drm_ras.c:(.text+0xa64): undefined reference to `genlmsg_put'
/usr/bin/ld: drm_ras.c:(.text+0xaf9): undefined reference to `init_net'
/usr/bin/ld: drm_ras.c:(.text+0xb06): undefined reference to `netlink_unicast'
/usr/bin/ld: drm_ras.c:(.text+0xb4c): undefined reference to `skb_trim'
/usr/bin/ld: drm_ras.c:(.text+0xb62): undefined reference to `sk_skb_reason_drop'
/usr/bin/ld: drm_ras.c:(.text+0xc0a): undefined reference to `sk_skb_reason_drop'
/usr/bin/ld: drivers/gpu/drm/drm_ras_genl_family.o: in function `drm_ras_genl_family_register':
drm_ras_genl_family.c:(.text+0x1b): undefined reference to `genl_register_family'
/usr/bin/ld: drivers/gpu/drm/drm_ras_genl_family.o: in function `drm_ras_genl_family_unregister':
drm_ras_genl_family.c:(.text+0x68): undefined reference to `genl_unregister_family'
collect2: error: ld returned 1 exit status
make[3]: *** [../scripts/Makefile.vmlinux:72: vmlinux.unstripped] Error 1
make[2]: *** [/kernel/Makefile:1370: vmlinux] Error 2
make[1]: *** [/kernel/Makefile:248: __sub-make] Error 2
make: *** [Makefile:248: __sub-make] Error 2
[07:52:13] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[07:52:18] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/xe/xe_drm_ras: Enable CONFIG_DRM_RAS
2026-08-18 7:54 [PATCH] drm/xe/xe_drm_ras: Enable CONFIG_DRM_RAS Balasubramani Vivekanandan
2026-08-18 7:52 ` ✗ CI.KUnit: failure for " Patchwork
@ 2026-08-18 7:53 ` sashiko-bot
2026-08-18 7:59 ` Raag Jadav
2 siblings, 0 replies; 6+ messages in thread
From: sashiko-bot @ 2026-08-18 7:53 UTC (permalink / raw)
To: Balasubramani Vivekanandan; +Cc: intel-xe
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Selecting DRM_RAS in DRM_XE without inheriting its dependency on NET causes Kconfig warnings and potential build failures.
--
--- Patch [1]: [PATCH] drm/xe/xe_drm_ras: Enable CONFIG_DRM_RAS ---
commit 591f0eb274f545521022c1143984b07f3d4b5395
Author: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
drm/xe/xe_drm_ras: Enable CONFIG_DRM_RAS
This commit enables DRM RAS support for the Xe driver by adding a select
statement for DRM_RAS in the DRM_XE Kconfig entry.
> diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
> index 4d7dcaff2b915..6c584f918edf2 100644
> --- a/drivers/gpu/drm/xe/Kconfig
> +++ b/drivers/gpu/drm/xe/Kconfig
> @@ -42,6 +42,7 @@ config DRM_XE
> select DRM_GPUSVM if !UML
> select DRM_GPUVM
> select DRM_SCHED
> + select DRM_RAS
[Severity: Low]
Does this select statement need to inherit the dependencies of DRM_RAS?
DRM_RAS depends on NET. Since DRM_XE selects DRM_RAS without inheriting
this dependency, it can cause Kconfig unmet direct dependency warnings and
potential build failures if the kernel is configured with CONFIG_NET
disabled.
> select MMU_NOTIFIER
> select WANT_DEV_COREDUMP
> select AUXILIARY_BUS
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260818075454.1508724-2-balasubramani.vivekanandan@intel.com?part=1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/xe/xe_drm_ras: Enable CONFIG_DRM_RAS
2026-08-18 7:54 [PATCH] drm/xe/xe_drm_ras: Enable CONFIG_DRM_RAS Balasubramani Vivekanandan
2026-08-18 7:52 ` ✗ CI.KUnit: failure for " Patchwork
2026-08-18 7:53 ` [PATCH] " sashiko-bot
@ 2026-08-18 7:59 ` Raag Jadav
2026-08-18 8:18 ` Tauro, Riana
2 siblings, 1 reply; 6+ messages in thread
From: Raag Jadav @ 2026-08-18 7:59 UTC (permalink / raw)
To: Balasubramani Vivekanandan; +Cc: intel-xe, Rodrigo Vivi, riana.tauro
On Tue, Aug 18, 2026 at 01:24:55PM +0530, Balasubramani Vivekanandan wrote:
> Xe RAS functionality needs DRM RAS support. Enable it.
>
> Fixes: b40db12b542f5 ("drm/xe/xe_drm_ras: Add support for XE DRM RAS")
> Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
> ---
> drivers/gpu/drm/xe/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
> index 4d7dcaff2b915..6c584f918edf2 100644
> --- a/drivers/gpu/drm/xe/Kconfig
> +++ b/drivers/gpu/drm/xe/Kconfig
> @@ -42,6 +42,7 @@ config DRM_XE
> select DRM_GPUSVM if !UML
> select DRM_GPUVM
> select DRM_SCHED
> + select DRM_RAS
Nack, this was an internal workaround. It's upto the user to decide.
Raag
> select MMU_NOTIFIER
> select WANT_DEV_COREDUMP
> select AUXILIARY_BUS
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/xe/xe_drm_ras: Enable CONFIG_DRM_RAS
2026-08-18 7:59 ` Raag Jadav
@ 2026-08-18 8:18 ` Tauro, Riana
2026-08-18 13:44 ` Rodrigo Vivi
0 siblings, 1 reply; 6+ messages in thread
From: Tauro, Riana @ 2026-08-18 8:18 UTC (permalink / raw)
To: Raag Jadav, Balasubramani Vivekanandan; +Cc: intel-xe, Rodrigo Vivi
On 18-08-2026 13:29, Raag Jadav wrote:
> On Tue, Aug 18, 2026 at 01:24:55PM +0530, Balasubramani Vivekanandan wrote:
>> Xe RAS functionality needs DRM RAS support. Enable it.
>>
>> Fixes: b40db12b542f5 ("drm/xe/xe_drm_ras: Add support for XE DRM RAS")
>> Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
>> ---
>> drivers/gpu/drm/xe/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
>> index 4d7dcaff2b915..6c584f918edf2 100644
>> --- a/drivers/gpu/drm/xe/Kconfig
>> +++ b/drivers/gpu/drm/xe/Kconfig
>> @@ -42,6 +42,7 @@ config DRM_XE
>> select DRM_GPUSVM if !UML
>> select DRM_GPUVM
>> select DRM_SCHED
>> + select DRM_RAS
> Nack, this was an internal workaround. It's upto the user to decide.
Agreed. This should be upto the user. We can add it in CI config but not
select it from xe.
Thanks
Riana
>
> Raag
>
>> select MMU_NOTIFIER
>> select WANT_DEV_COREDUMP
>> select AUXILIARY_BUS
>> --
>> 2.43.0
>>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/xe/xe_drm_ras: Enable CONFIG_DRM_RAS
2026-08-18 8:18 ` Tauro, Riana
@ 2026-08-18 13:44 ` Rodrigo Vivi
0 siblings, 0 replies; 6+ messages in thread
From: Rodrigo Vivi @ 2026-08-18 13:44 UTC (permalink / raw)
To: Tauro, Riana; +Cc: Raag Jadav, Balasubramani Vivekanandan, intel-xe
On Tue, Aug 18, 2026 at 01:48:34PM +0530, Tauro, Riana wrote:
>
> On 18-08-2026 13:29, Raag Jadav wrote:
> > On Tue, Aug 18, 2026 at 01:24:55PM +0530, Balasubramani Vivekanandan wrote:
> > > Xe RAS functionality needs DRM RAS support. Enable it.
> > >
> > > Fixes: b40db12b542f5 ("drm/xe/xe_drm_ras: Add support for XE DRM RAS")
> > > Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
> > > ---
> > > drivers/gpu/drm/xe/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
> > > index 4d7dcaff2b915..6c584f918edf2 100644
> > > --- a/drivers/gpu/drm/xe/Kconfig
> > > +++ b/drivers/gpu/drm/xe/Kconfig
> > > @@ -42,6 +42,7 @@ config DRM_XE
> > > select DRM_GPUSVM if !UML
> > > select DRM_GPUVM
> > > select DRM_SCHED
> > > + select DRM_RAS
> > Nack, this was an internal workaround. It's upto the user to decide.
>
> Agreed. This should be upto the user. We can add it in CI config but not
> select it from xe.
+1.
And actually, even on internal we should remove this right? There should be
a proper way to enable this on CI itself, without an extra patch.
Please Bala, check that.
Thanks,
Rodrigo.
>
> Thanks
> Riana
>
> >
> > Raag
> >
> > > select MMU_NOTIFIER
> > > select WANT_DEV_COREDUMP
> > > select AUXILIARY_BUS
> > > --
> > > 2.43.0
> > >
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-08-18 13:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-18 7:54 [PATCH] drm/xe/xe_drm_ras: Enable CONFIG_DRM_RAS Balasubramani Vivekanandan
2026-08-18 7:52 ` ✗ CI.KUnit: failure for " Patchwork
2026-08-18 7:53 ` [PATCH] " sashiko-bot
2026-08-18 7:59 ` Raag Jadav
2026-08-18 8:18 ` Tauro, Riana
2026-08-18 13:44 ` Rodrigo Vivi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox