From: Raag Jadav <raag.jadav@intel.com>
To: "Laguna, Lukasz" <lukasz.laguna@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>,
intel-xe@lists.freedesktop.org, rodrigo.vivi@intel.com,
thomas.hellstrom@linux.intel.com, riana.tauro@intel.com,
michal.wajdeczko@intel.com, matthew.d.roper@intel.com,
michal.winiarski@intel.com, matthew.auld@intel.com,
dev@lankhorst.se, jani.nikula@intel.com, zhanjun.dong@intel.com,
lukas@wunner.de, daniele.ceraolospurio@intel.com,
badal.nilawar@intel.com
Subject: Re: [PATCH v9 08/10] drm/xe: Improve wedged state management
Date: Fri, 21 Aug 2026 14:27:01 +0200 [thread overview]
Message-ID: <aohEFbWxak1-vNBD@black.igk.intel.com> (raw)
In-Reply-To: <aogaeU6a5i1kyaMg@black.igk.intel.com>
On Fri, Aug 21, 2026 at 11:29:35AM +0200, Raag Jadav wrote:
> On Fri, Aug 21, 2026 at 10:26:58AM +0200, Laguna, Lukasz wrote:
> > On 7/10/2026 07:01, Raag Jadav wrote:
>
> ...
>
> > > +bool xe_device_wedged(struct xe_device *xe)
> > > +{
> > > + return atomic_read(&xe->wedged.ref);
> > > +}
> >
> > __guc_ct_send_locked() and g2h_read() return -ENOTRECOVERABLE when
> > xe_device_wedged() is true, but with the new refcount approach device may
> > only be temporarily wedged.
>
> Good catch. I was expecting this path to not be hit during FLR as we're
> tearing down exec queues and disabling interrupts, but fully agree that
> there's a whole lot of TODOs we need to revisit as a follow up. I'll add
> this one too.
I've sent a standalone fix[1] for this. However, I'm unsure about it's
correctness, so please weigh in.
Raag
[1] https://lore.kernel.org/intel-xe/20260821122114.567725-1-raag.jadav@intel.com
next prev parent reply other threads:[~2026-08-21 12:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 8:29 [PATCH v9 00/10] Introduce Xe PCIe FLR Raag Jadav
2026-07-01 8:29 ` [PATCH v9 01/10] drm/xe/uc_fw: Allow re-initializing firmware Raag Jadav
2026-07-01 8:29 ` [PATCH v9 02/10] drm/xe/guc_submit: Introduce guc_exec_queue_reinit_kernel() Raag Jadav
2026-07-01 8:29 ` [PATCH v9 03/10] drm/xe/gt: Introduce FLR helpers Raag Jadav
2026-08-05 5:25 ` Matthew Brost
2026-07-01 8:29 ` [PATCH v9 04/10] drm/xe/bo_evict: Introduce xe_bo_restore_map() Raag Jadav
2026-07-01 8:29 ` [PATCH v9 05/10] drm/xe/exec_queue: Introduce xe_exec_queue_reinit() Raag Jadav
2026-07-01 8:29 ` [PATCH v9 06/10] drm/xe/migrate: Introduce xe_migrate_reinit() Raag Jadav
2026-07-01 8:29 ` [PATCH v9 07/10] drm/xe/pm: Introduce xe_device_suspend/resume() Raag Jadav
2026-07-01 8:29 ` [PATCH v9 08/10] drm/xe: Improve wedged state management Raag Jadav
2026-07-09 21:27 ` Matthew Brost
2026-07-10 5:01 ` Raag Jadav
2026-08-21 8:26 ` Laguna, Lukasz
2026-08-21 9:29 ` Raag Jadav
2026-08-21 12:27 ` Raag Jadav [this message]
2026-07-01 8:29 ` [PATCH v9 09/10] drm/xe/pci: Introduce PCIe FLR Raag Jadav
2026-08-21 8:32 ` [v9,09/10] " Laguna, Lukasz
2026-07-01 8:29 ` [PATCH v9 10/10] drm/xe/doc: Wire up PCI Error Handling Raag Jadav
2026-08-21 8:34 ` [v9,10/10] " Laguna, Lukasz
2026-07-01 8:42 ` ✗ CI.checkpatch: warning for Introduce Xe PCIe FLR (rev9) Patchwork
2026-07-01 8:43 ` ✓ CI.KUnit: success " Patchwork
2026-07-01 9:41 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-01 23:59 ` ✓ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aohEFbWxak1-vNBD@black.igk.intel.com \
--to=raag.jadav@intel.com \
--cc=badal.nilawar@intel.com \
--cc=daniele.ceraolospurio@intel.com \
--cc=dev@lankhorst.se \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=lukas@wunner.de \
--cc=lukasz.laguna@intel.com \
--cc=matthew.auld@intel.com \
--cc=matthew.brost@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=michal.winiarski@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=zhanjun.dong@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox