Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Varun Gupta <varun.gupta@intel.com>
Cc: <intel-xe@lists.freedesktop.org>, <zhanjun.dong@intel.com>,
	<daniele.ceraolospurio@intel.com>,
	<himal.prasad.ghimiray@intel.com>
Subject: Re: [PATCH] drm/xe/guc: Demote uncorrectable local error log to info
Date: Fri, 18 Sep 2026 08:53:52 -0400	[thread overview]
Message-ID: <aq00YEXsjHSSU3Gh@intel.com> (raw)
In-Reply-To: <20260917135121.3590045-2-varun.gupta@intel.com>

On Thu, Sep 17, 2026 at 07:21:22PM +0530, Varun Gupta wrote:
> The UNCORRECTABLE_LOCAL_ERROR notification sent by the GuC indicates a
> local, queue-level context termination rather than a global device or
> driver failure. This can be triggered as part of expected recovery flows,
> including intentional fault-injection tests.
> 
> Printing this at ERROR level is too noisy and causes false-positive
> dmesg-warn failures in CI. Switch the log level to INFO, matching the
> adjacent CAT error handler.

wait what?!

If it is fault injection case it is an actual error.
Add instrumentation in the test tool or CI to deal with it.

> 
> Fixes: 4e57574fa3a3 ("drm/xe/guc: Handle GuC local uncorrectable error notifications")
> Signed-off-by: Varun Gupta <varun.gupta@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index f3ba8abfc228..23ccec0adc8c 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -3495,7 +3495,7 @@ int xe_guc_uncorrectable_error_handler(struct xe_guc *guc, u32 *msg, u32 len)
>  	if (unlikely(!q))
>  		return -EPROTO;
>  
> -	xe_gt_err(gt,
> +	xe_gt_info(gt,
> 		   "GuC: Uncorrectable local error! guc_id=%d class=%s, logical_mask=0x%x",
> 		   guc_id, xe_hw_engine_class_to_str(q->class), q->logical_mask);
>  
> -- 
> 2.43.0
> 

  parent reply	other threads:[~2026-09-18 12:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17 13:51 [PATCH] drm/xe/guc: Demote uncorrectable local error log to info Varun Gupta
2026-09-17 13:53 ` Gupta, Varun
2026-09-18 12:53 ` Rodrigo Vivi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-09-10  4:59 Varun Gupta
2026-09-17 11:10 ` Ghimiray, Himal Prasad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aq00YEXsjHSSU3Gh@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=daniele.ceraolospurio@intel.com \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=varun.gupta@intel.com \
    --cc=zhanjun.dong@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox