Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/guc: Demote uncorrectable local error log to info
@ 2026-09-10  4:59 Varun Gupta
  2026-09-17 11:10 ` Ghimiray, Himal Prasad
  0 siblings, 1 reply; 5+ messages in thread
From: Varun Gupta @ 2026-09-10  4:59 UTC (permalink / raw)
  To: intel-xe; +Cc: zhanjun.dong, daniele.ceraolospurio, michal.wajdeczko

The UNCORRECTABLE_LOCAL_ERROR notification sent by the GuC indicates a
local, queue-level context termination rather than a global device or
driver failure. This can be triggered as part of expected recovery flows,
including intentional fault-injection tests.

Printing this at ERROR level is too noisy and causes false-positive
dmesg-warn failures in CI. Switch the log level to INFO, matching the
adjacent CAT error handler.

Fixes: 4e57574fa3a3 ("drm/xe/guc: Handle GuC local uncorrectable error notifications")
Signed-off-by: Varun Gupta <varun.gupta@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_submit.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index f3ba8abfc228..e0662bd9154b 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -3495,9 +3495,9 @@ int xe_guc_uncorrectable_error_handler(struct xe_guc *guc, u32 *msg, u32 len)
 	if (unlikely(!q))
 		return -EPROTO;
 
-	xe_gt_err(gt,
-		  "GuC: Uncorrectable local error! guc_id=%d class=%s, logical_mask=0x%x",
-		  guc_id, xe_hw_engine_class_to_str(q->class), q->logical_mask);
+	xe_gt_info(gt,
+		   "GuC: Uncorrectable local error! guc_id=%d class=%s, logical_mask=0x%x",
+		   guc_id, xe_hw_engine_class_to_str(q->class), q->logical_mask);
 
 	trace_xe_guc_uncorrectable_error(q);
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/xe/guc: Demote uncorrectable local error log to info
  2026-09-10  4:59 Varun Gupta
@ 2026-09-17 11:10 ` Ghimiray, Himal Prasad
  0 siblings, 0 replies; 5+ messages in thread
From: Ghimiray, Himal Prasad @ 2026-09-17 11:10 UTC (permalink / raw)
  To: Varun Gupta, intel-xe
  Cc: zhanjun.dong, daniele.ceraolospurio, michal.wajdeczko



On 10-09-2026 10:29, Varun Gupta wrote:
> The UNCORRECTABLE_LOCAL_ERROR notification sent by the GuC indicates a
> local, queue-level context termination rather than a global device or
> driver failure. This can be triggered as part of expected recovery flows,
> including intentional fault-injection tests.
> 
> Printing this at ERROR level is too noisy and causes false-positive
> dmesg-warn failures in CI. Switch the log level to INFO, matching the
> adjacent CAT error handler.
> 
> Fixes: 4e57574fa3a3 ("drm/xe/guc: Handle GuC local uncorrectable error notifications")
> Signed-off-by: Varun Gupta <varun.gupta@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_guc_submit.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index f3ba8abfc228..e0662bd9154b 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -3495,9 +3495,9 @@ int xe_guc_uncorrectable_error_handler(struct xe_guc *guc, u32 *msg, u32 len)
>   	if (unlikely(!q))
>   		return -EPROTO;
>   
> -	xe_gt_err(gt,
> -		  "GuC: Uncorrectable local error! guc_id=%d class=%s, logical_mask=0x%x",
> -		  guc_id, xe_hw_engine_class_to_str(q->class), q->logical_mask);
> +	xe_gt_info(gt,
> +		   "GuC: Uncorrectable local error! guc_id=%d class=%s, logical_mask=0x%x",
> +		   guc_id, xe_hw_engine_class_to_str(q->class), q->logical_mask);

Sounds sane and matches the CAT error handler.

Could we ratelimit the GUC_ID_UNKNOWN branch too? keeping both paths 
consistent with the CAT handler.



>   
>   	trace_xe_guc_uncorrectable_error(q);
>   


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] drm/xe/guc: Demote uncorrectable local error log to info
@ 2026-09-17 13:51 Varun Gupta
  2026-09-17 13:53 ` Gupta, Varun
  2026-09-18 12:53 ` Rodrigo Vivi
  0 siblings, 2 replies; 5+ messages in thread
From: Varun Gupta @ 2026-09-17 13:51 UTC (permalink / raw)
  To: intel-xe; +Cc: zhanjun.dong, daniele.ceraolospurio, himal.prasad.ghimiray

The UNCORRECTABLE_LOCAL_ERROR notification sent by the GuC indicates a
local, queue-level context termination rather than a global device or
driver failure. This can be triggered as part of expected recovery flows,
including intentional fault-injection tests.

Printing this at ERROR level is too noisy and causes false-positive
dmesg-warn failures in CI. Switch the log level to INFO, matching the
adjacent CAT error handler.

Fixes: 4e57574fa3a3 ("drm/xe/guc: Handle GuC local uncorrectable error notifications")
Signed-off-by: Varun Gupta <varun.gupta@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_submit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index f3ba8abfc228..23ccec0adc8c 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -3495,7 +3495,7 @@ int xe_guc_uncorrectable_error_handler(struct xe_guc *guc, u32 *msg, u32 len)
 	if (unlikely(!q))
 		return -EPROTO;
 
-	xe_gt_err(gt,
+	xe_gt_info(gt,
		   "GuC: Uncorrectable local error! guc_id=%d class=%s, logical_mask=0x%x",
		   guc_id, xe_hw_engine_class_to_str(q->class), q->logical_mask);
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* RE: [PATCH] drm/xe/guc: Demote uncorrectable local error log to info
  2026-09-17 13:51 [PATCH] drm/xe/guc: Demote uncorrectable local error log to info Varun Gupta
@ 2026-09-17 13:53 ` Gupta, Varun
  2026-09-18 12:53 ` Rodrigo Vivi
  1 sibling, 0 replies; 5+ messages in thread
From: Gupta, Varun @ 2026-09-17 13:53 UTC (permalink / raw)
  To: Gupta, Varun, intel-xe@lists.freedesktop.org
  Cc: Dong, Zhanjun, Ceraolo Spurio, Daniele, Ghimiray, Himal Prasad

Sent V1 again by accident, pls ignore this.

Thanks

-----Original Message-----
From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf Of Varun Gupta
Sent: Thursday, September 17, 2026 7:21 PM
To: intel-xe@lists.freedesktop.org
Cc: Dong, Zhanjun <zhanjun.dong@intel.com>; Ceraolo Spurio, Daniele <daniele.ceraolospurio@intel.com>; Ghimiray, Himal Prasad <himal.prasad.ghimiray@intel.com>
Subject: [PATCH] drm/xe/guc: Demote uncorrectable local error log to info

The UNCORRECTABLE_LOCAL_ERROR notification sent by the GuC indicates a local, queue-level context termination rather than a global device or driver failure. This can be triggered as part of expected recovery flows, including intentional fault-injection tests.

Printing this at ERROR level is too noisy and causes false-positive dmesg-warn failures in CI. Switch the log level to INFO, matching the adjacent CAT error handler.

Fixes: 4e57574fa3a3 ("drm/xe/guc: Handle GuC local uncorrectable error notifications")
Signed-off-by: Varun Gupta <varun.gupta@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_submit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index f3ba8abfc228..23ccec0adc8c 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -3495,7 +3495,7 @@ int xe_guc_uncorrectable_error_handler(struct xe_guc *guc, u32 *msg, u32 len)
 	if (unlikely(!q))
 		return -EPROTO;
 
-	xe_gt_err(gt,
+	xe_gt_info(gt,
		   "GuC: Uncorrectable local error! guc_id=%d class=%s, logical_mask=0x%x",
		   guc_id, xe_hw_engine_class_to_str(q->class), q->logical_mask);
 
--
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/xe/guc: Demote uncorrectable local error log to info
  2026-09-17 13:51 [PATCH] drm/xe/guc: Demote uncorrectable local error log to info Varun Gupta
  2026-09-17 13:53 ` Gupta, Varun
@ 2026-09-18 12:53 ` Rodrigo Vivi
  1 sibling, 0 replies; 5+ messages in thread
From: Rodrigo Vivi @ 2026-09-18 12:53 UTC (permalink / raw)
  To: Varun Gupta
  Cc: intel-xe, zhanjun.dong, daniele.ceraolospurio,
	himal.prasad.ghimiray

On Thu, Sep 17, 2026 at 07:21:22PM +0530, Varun Gupta wrote:
> The UNCORRECTABLE_LOCAL_ERROR notification sent by the GuC indicates a
> local, queue-level context termination rather than a global device or
> driver failure. This can be triggered as part of expected recovery flows,
> including intentional fault-injection tests.
> 
> Printing this at ERROR level is too noisy and causes false-positive
> dmesg-warn failures in CI. Switch the log level to INFO, matching the
> adjacent CAT error handler.

wait what?!

If it is fault injection case it is an actual error.
Add instrumentation in the test tool or CI to deal with it.

> 
> Fixes: 4e57574fa3a3 ("drm/xe/guc: Handle GuC local uncorrectable error notifications")
> Signed-off-by: Varun Gupta <varun.gupta@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc_submit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index f3ba8abfc228..23ccec0adc8c 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -3495,7 +3495,7 @@ int xe_guc_uncorrectable_error_handler(struct xe_guc *guc, u32 *msg, u32 len)
>  	if (unlikely(!q))
>  		return -EPROTO;
>  
> -	xe_gt_err(gt,
> +	xe_gt_info(gt,
> 		   "GuC: Uncorrectable local error! guc_id=%d class=%s, logical_mask=0x%x",
> 		   guc_id, xe_hw_engine_class_to_str(q->class), q->logical_mask);
>  
> -- 
> 2.43.0
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-09-18 12:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-17 13:51 [PATCH] drm/xe/guc: Demote uncorrectable local error log to info Varun Gupta
2026-09-17 13:53 ` Gupta, Varun
2026-09-18 12:53 ` Rodrigo Vivi
  -- strict thread matches above, loose matches on Subject: below --
2026-09-10  4:59 Varun Gupta
2026-09-17 11:10 ` Ghimiray, Himal Prasad

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox