Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Alan Previn <alan.previn.teres.alexis@intel.com>
Cc: intel-xe@lists.freedesktop.org, julia.filipchuk@intel.com,
	matthew.brost@intel.com, "Zhanjun Dong" <zhanjun.dong@intel.com>,
	"José Roberto de Souza" <jose.souza@intel.com>
Subject: Re: [PATCH v11 0/3] drm/xe/guc: Compress GuC log and CTB dump with zstd
Date: Wed, 14 Oct 2026 14:20:11 -0400	[thread overview]
Message-ID: <as_H29n4po3u1v6O@intel.com> (raw)
In-Reply-To: <20261013222846.308259-5-alan.previn.teres.alexis@intel.com>

On Tue, Oct 13, 2026 at 03:28:44PM -0700, Alan Previn wrote:
> GuC snapshot output is currently expensive in both size and latency: large
> log buffers are emitted as raw ascii85, and the surrounding dump text
> includes a bit of avoidable noise. This series makes xe snapshot dumps more
> compact and easier to handle by compressing the large binary payloads,
> tightening the textual output.
> 
> Select ZSTD_COMPRESS in DRM_XE so the xe module pulls in the zstd
> compressor when built.
> 
> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
> Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>

pushed to drm-xe-next, thank you!

> 
> ---
> History:
> V11: Patch3: In ct_dead_worker_func, call xe_guc_log/ct_snapshot_free
>      after xe_guc_ct_snapshot_free (Sashiko).
> v10: Add a new patch to introduce dump_cache to optimize GuC CT/ Log
>      compression e2e flows and manage errors across parses. (Sashiko
>      and Rodrigo).
>      Patch2: Reorder Kconfig compression dependency (Rodrigo) and round
>      up buffer size to dword as per final output-dump expectation.
> v9: Rebase to latest drm-tip, no functional changes, added Signed-
>     off by Alan on 2nd patch. (Rodrigo)
> v8: Improve patch #2 description on clarity and wording (Rodrigo)
> v7: Add *why* to the commit message (Rodrigo)
> v6: Remove intermediate build files(Julia)
>     Remvoe unnecessary comment(Julia)
> v5: Update cover letter messages to remove shrink log size.
>     Fix kernel-doc warning.
> v4: Remove ZSTD_DECOMPRESS dependency.
> v3: Add Kconfig option to control compression of GuC log and CTB dumps,
>     allowing users to choose between reduced dump sizes or lower memory
>     usage.
>     Remove "reduce GuC log size from 8MB to 2MB" patch, to be added later
>     if needed.
>     Replace pr_err with xe_gt_err and add more error print.
> v2: Fix Kunit test error by selecting ZSTD_DECOMPRESS in DRM_XE config,
>     required by zstd_is_error/zstd_get_error_name.
> 
> Alan Previn (1):
>   drm/xe/guc: Add dump_cache to optimize GuC CT/Log compression flow
> 
> Zhanjun Dong (2):
>   drm/xe: Remove extra newlines from LRC snapshot dump
>   drm/xe/guc: Compress GuC log and CTB dump with zstd
> 
>  drivers/gpu/drm/xe/Kconfig            |  15 ++
>  drivers/gpu/drm/xe/xe_devcoredump.c   |   4 +-
>  drivers/gpu/drm/xe/xe_guc_ct.c        |  31 ++--
>  drivers/gpu/drm/xe/xe_guc_ct.h        |   4 +-
>  drivers/gpu/drm/xe/xe_guc_ct_types.h  |   3 +
>  drivers/gpu/drm/xe/xe_guc_log.c       | 222 ++++++++++++++++++++++++--
>  drivers/gpu/drm/xe/xe_guc_log.h       |  11 +-
>  drivers/gpu/drm/xe/xe_guc_log_types.h |  20 +++
>  drivers/gpu/drm/xe/xe_lrc.c           |   4 +-
>  9 files changed, 281 insertions(+), 33 deletions(-)
> 
> 
> base-commit: 83b6bc1390606facc1c0426727905f9fcd75836d
> -- 
> 2.43.0
> 

  parent reply	other threads:[~2026-10-14 18:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13 22:28 [PATCH v11 0/3] drm/xe/guc: Compress GuC log and CTB dump with zstd Alan Previn
2026-10-13 22:28 ` [PATCH v11 1/3] drm/xe: Remove extra newlines from LRC snapshot dump Alan Previn
2026-10-13 22:28 ` [PATCH v11 2/3] drm/xe/guc: Compress GuC log and CTB dump with zstd Alan Previn
2026-10-13 22:28 ` [PATCH v11 3/3] drm/xe/guc: Add dump_cache to optimize GuC CT/Log compression flow Alan Previn
2026-10-14 18:16   ` Rodrigo Vivi
2026-10-13 23:29 ` ✗ CI.checkpatch: warning for drm/xe/guc: Compress GuC log and CTB dump with zstd (rev7) Patchwork
2026-10-13 23:31 ` ✓ CI.KUnit: success " Patchwork
2026-10-13 23:47 ` ✗ CI.checksparse: warning " Patchwork
2026-10-14  4:41 ` ✓ Xe.CI.BAT: success " Patchwork
2026-10-14 18:20 ` Rodrigo Vivi [this message]
2026-10-14 18:34 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=as_H29n4po3u1v6O@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=alan.previn.teres.alexis@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jose.souza@intel.com \
    --cc=julia.filipchuk@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=zhanjun.dong@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox