Re: [PATCH v6 05/10] drm/xe/cper: Log CPER records for aggregate counter retrieval

[Raag Jadav <raag.jadav@intel.com>]

On Wed, Oct 28, 2026 at 03:27:29PM +0530, Badal Nilawar wrote:
> Log CPER records for aggregate counter retrieval from userspace when
> cper_on_query sysfs is enabled.

...

> +void xe_cper_emit_counter(struct xe_device *xe, int cper_sev, enum xe_sigid sigid,
> +			  const struct xe_ras_error_class *counter,
> +			  const struct xe_ras_get_counter_response *response)

[1] This is good.

>  {
>  	struct xe_cper_intel_hdr ihdr = {};
>  
> +	xe_assert(xe, is_hw_sigid(sigid));
> +
>  	cper_init_intel_hdr(xe, counter, response->timestamp,
>  			    sigid, response->value, &ihdr);
>  	cper_record_emit(xe, cper_sev, &INTEL_CPER_NOTIFY_GPU_ERROR, &ihdr, NULL, 0);
> @@ -217,7 +231,7 @@ static void cper_emit_hw_err(struct xe_device *xe, int cper_sev, enum xe_sigid s
>  		return;
>  	}
>  
> -	cper_emit_counter(xe, cper_sev, sigid, counter, &response);
> +	xe_cper_emit_counter(xe, cper_sev, sigid, counter, &response);
>  }

...

> +void xe_cper_emit_counter(struct xe_device *xe, int cper_sev, enum xe_sigid sigid,
> +			  const struct xe_ras_error_class *error_class,
> +			  const struct xe_ras_get_counter_response *resp);

Please make the parameter naming consistent with above[1].

> +int xe_cper_sysfs_init(struct xe_device *xe);
>  #else
>  static inline void xe_cper_emit(struct xe_device *xe, int cper_sev, enum xe_sigid sigid,
>  				u32 component, u32 location, const void *data, size_t len,
>  				struct va_format *vaf) {}
> +static inline void xe_cper_emit_counter(struct xe_device *xe, int cper_sev,
> +					enum xe_sigid sigid,
> +					const struct xe_ras_error_class *error_class,
> +					const struct xe_ras_get_counter_response *resp) {}

Ditto.

And with that

Reviewed-by: Raag Jadav <raag.jadav@intel.com>

> +static inline int xe_cper_sysfs_init(struct xe_device *xe) { return 0; }
>  #endif