From: Raag Jadav <raag.jadav@intel.com>
To: Riana Tauro <riana.tauro@intel.com>
Cc: intel-xe@lists.freedesktop.org, anshuman.gupta@intel.com,
rodrigo.vivi@intel.com, aravind.iddamsetty@linux.intel.com,
mallesh.koujalagi@intel.com, badal.nilawar@intel.com
Subject: Re: [PATCH v4 3/8] drm/xe/survivability: Guard runtime survivability enable against unbind
Date: Tue, 10 Nov 2026 13:51:27 +0100 [thread overview]
Message-ID: <avMTTzrY0kPJRChS@black.igk.intel.com> (raw)
In-Reply-To: <20261106071944.2693854-13-riana.tauro@intel.com>
On Fri, Nov 06, 2026 at 12:49:48PM +0530, Riana Tauro wrote:
> Runtime surivability mode creates sysfs and declares the device as
> wedged in a worker thread. This can race with unbind.
>
> During unbind, devres actions such as disabling the worker run as part of
> teardown. A runtime survivability enable that is still in flight or gets
> scheduled in that window can create the survivability sysfs entries while
> the device is being removed. This is incorrect, as runtime survivability mode
> must not be entered once during devres teardown.
>
> Use the DRM device enter/exit protection so that the enable path
> synchronizes with device unplug and returns early if the device is
> already being unbound.
I'm a bit lost here. Doesn't disable_work_sync() already guarantee this?
Raag
next prev parent reply other threads:[~2026-11-10 12:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 7:19 [PATCH v4 0/8] Handle non-fatal errors routed via IRQ Riana Tauro
2026-11-06 7:19 ` [PATCH v4 1/8] drm/xe/hw_error: Reuse CSC worker for generic error handling Riana Tauro
2026-11-06 7:19 ` [PATCH v4 2/8] drm/xe/hw_error: Initialize hw_error_work per tile Riana Tauro
2026-11-10 5:48 ` Mallesh, Koujalagi
2026-11-10 12:40 ` Raag Jadav
2026-11-11 4:45 ` Tauro, Riana
2026-11-11 5:40 ` Raag Jadav
2026-11-11 5:51 ` Tauro, Riana
2026-11-06 7:19 ` [PATCH v4 3/8] drm/xe/survivability: Guard runtime survivability enable against unbind Riana Tauro
2026-11-10 6:19 ` Mallesh, Koujalagi
2026-11-10 12:51 ` Raag Jadav [this message]
2026-11-11 4:43 ` Tauro, Riana
2026-11-11 5:39 ` Raag Jadav
2026-11-11 5:50 ` Tauro, Riana
2026-11-11 7:09 ` Raag Jadav
2026-11-11 7:17 ` Tauro, Riana
2026-11-06 7:19 ` [PATCH v4 4/8] drm/xe/ras: Treat non-fatal PCIe errors as recovered Riana Tauro
2026-11-06 7:19 ` [PATCH v4 5/8] drm/xe/pci: Add upstream switch port lookup helper Riana Tauro
2026-11-06 7:19 ` [PATCH v4 6/8] drm/xe/xe_ras: Add a flag for uncorrectable internal error Riana Tauro
2026-11-10 13:07 ` Raag Jadav
2026-11-11 4:47 ` Tauro, Riana
2026-11-06 7:19 ` [PATCH v4 7/8] drm/xe: Add support for wa_14028434957 Riana Tauro
2026-11-10 6:41 ` Mallesh, Koujalagi
2026-11-10 13:18 ` Raag Jadav
2026-11-11 4:50 ` Tauro, Riana
2026-11-11 6:15 ` Raag Jadav
2026-11-11 6:22 ` Tauro, Riana
2026-11-06 7:19 ` [PATCH v4 8/8] drm/xe/xe_ras: Skip double-bit ECC page offlining on AER path Riana Tauro
2026-11-06 7:27 ` ✗ CI.checkpatch: warning for Handle non-fatal errors routed via IRQ (rev4) Patchwork
2026-11-06 7:29 ` ✓ CI.KUnit: success " Patchwork
2026-11-06 8:13 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-07 7:38 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avMTTzrY0kPJRChS@black.igk.intel.com \
--to=raag.jadav@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=aravind.iddamsetty@linux.intel.com \
--cc=badal.nilawar@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=mallesh.koujalagi@intel.com \
--cc=riana.tauro@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox