Re: [PATCH v4 2/8] drm/xe/hw_error: Initialize hw_error_work per tile

[Raag Jadav <raag.jadav@intel.com>]

On Wed, Nov 11, 2026 at 10:15:26AM +0530, Tauro, Riana wrote:
> On 10-11-2026 18:10, Raag Jadav wrote:
> > On Fri, Nov 06, 2026 at 12:49:47PM +0530, Riana Tauro wrote:
> > > From: Raag Jadav <raag.jadav@intel.com>
> > > 
> > > Since hw_error_work is now being reused generically, initialize it per tile
> > > so that we don't hit uninitialized work for non-root tile. While at it,
> > > disable hw_error_work on fini to prevent UAF during unwind.
> > > 
> > > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > > Reviewed-by: Riana Tauro <riana.tauro@intel.com>
> > > Signed-off-by: Riana Tauro <riana.tauro@intel.com>
> > > ---
> > > v2: add dgfx and sriov check (Sashiko)
> > > 
> > > v3: retain original patch and fix unload issue in later patches
> > > ---
> > >   drivers/gpu/drm/xe/xe_hw_error.c | 20 ++++++++++++++++++--
> > >   1 file changed, 18 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/xe/xe_hw_error.c b/drivers/gpu/drm/xe/xe_hw_error.c
> > > index a934b649575c..f7031b341ce0 100644
> > > --- a/drivers/gpu/drm/xe/xe_hw_error.c
> > > +++ b/drivers/gpu/drm/xe/xe_hw_error.c
> > > @@ -537,6 +537,19 @@ static void process_hw_errors(struct xe_device *xe)
> > >   	}
> > >   }
> > > +static void hw_error_fini(void *arg)
> > > +{
> > > +	struct xe_device *xe = arg;
> > > +	struct xe_tile *tile;
> > > +	u8 id;
> > > +
> > > +	if (!IS_DGFX(xe) || IS_SRIOV_VF(xe))
> > Why is this needed? fini is not even registered for these cases.
> > Not everything is a bug because AI says so :)
> 
> This is added so that it can be re-used in error_detected in patch [7/8]

Which sounds like this should be introduced in the patch which reuses it.

Raag

> > > +		return;
> > > +
> > > +	for_each_tile(tile, xe, id)
> > > +		disable_work_sync(&tile->hw_error_work);
> > > +}
> > > +
> > >   /**
> > >    * xe_hw_error_init - Initialize hw errors
> > >    * @xe: xe device instance
> > > @@ -546,12 +559,15 @@ static void process_hw_errors(struct xe_device *xe)
> > >    */
> > >   void xe_hw_error_init(struct xe_device *xe)
> > >   {
> > > -	struct xe_tile *tile = xe_device_get_root_tile(xe);
> > > +	struct xe_tile *tile;
> > > +	u8 id;
> > >   	if (!IS_DGFX(xe) || IS_SRIOV_VF(xe))
> > >   		return;
> > > -	INIT_WORK(&tile->hw_error_work, hw_error_work);
> > > +	for_each_tile(tile, xe, id)
> > > +		INIT_WORK(&tile->hw_error_work, hw_error_work);
> > >   	process_hw_errors(xe);
> > > +	devm_add_action_or_reset(xe->drm.dev, hw_error_fini, xe);
> > >   }
> > > -- 
> > > 2.47.1
> > >