From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <dev@lankhorst.se>
Cc: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
Matthew Brost <matthew.brost@intel.com>
Subject: Re: [PATCH v5 3/5] drm/xe: Raise gt frequency slightly earlier.
Date: Fri, 13 Nov 2026 15:30:02 +0200 [thread overview]
Message-ID: <avcQ2n9X3uYWUizr@intel.com> (raw)
In-Reply-To: <20261113124453.144408-10-dev@lankhorst.se>
On Fri, Nov 13, 2026 at 01:44:57PM +0100, Maarten Lankhorst wrote:
> Move raising the gt frequency to before display_register, so the
> blit that's potentially performed to copy stolen memory to system
> memory will run at full speed.
Is this the thing that drops the media frequency after init?
I've been pondering if we should also be doing the frequency
pumping at runtime around display commits because MMIO
performance is apparently tied in with the media frequency.
Even with media at high frequency MMIO is glacial on MTL+,
and becomes even more so after the media frequency drops :/
>
> Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
> ---
> drivers/gpu/drm/xe/xe_device.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index 6911c2ac39f82..616e02066ae6d 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -1069,6 +1069,9 @@ int xe_device_probe(struct xe_device *xe)
> if (err)
> return err;
>
> + for_each_gt(gt, xe, id)
> + xe_gt_sanitize_freq(gt);
> +
> xe_display_register(xe);
>
> err = xe_oa_register(xe);
> @@ -1093,9 +1096,6 @@ int xe_device_probe(struct xe_device *xe)
> if (err)
> goto err_unregister_display;
>
> - for_each_gt(gt, xe, id)
> - xe_gt_sanitize_freq(gt);
> -
> xe_vsec_init(xe);
>
> err = xe_sriov_init_late(xe);
> --
> 2.55.0
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2026-11-13 13:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 12:44 [PATCH v5 0/5] drm/xe/display: Transparant fallback from stolen to sysmem Maarten Lankhorst
2026-11-13 12:44 ` [PATCH v5 1/5] drm/xe/display: Avoid using stolen memory for framebuffer when media gt exists Maarten Lankhorst
2026-11-13 12:44 ` [PATCH v5 2/5] drm/xe/migrate: Support copying between sysmem and stolen Maarten Lankhorst
2026-11-13 13:05 ` sashiko-bot
2026-11-13 12:44 ` [PATCH v5 3/5] drm/xe: Raise gt frequency slightly earlier Maarten Lankhorst
2026-11-13 13:30 ` Ville Syrjälä [this message]
2026-11-13 12:44 ` [PATCH v5 4/5] HACK: Always fallback Maarten Lankhorst
2026-11-13 12:50 ` sashiko-bot
2026-11-13 12:44 ` [PATCH v5 5/5] drm/i915: Introduce intel_bo_fbdev_bios_fb_takeover() Maarten Lankhorst
2026-11-13 13:21 ` Ville Syrjälä
2026-11-13 13:22 ` sashiko-bot
2026-11-13 13:22 ` ✗ CI.checkpatch: warning for drm/xe/display: Transparant fallback from stolen to sysmem. (rev5) Patchwork
2026-11-13 13:24 ` ✓ CI.KUnit: success " Patchwork
2026-11-13 13:56 ` ✗ Xe.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avcQ2n9X3uYWUizr@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dev@lankhorst.se \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox