Re: [PATCH 1/5] drm/xe: Keep all defaults in single header

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 2/3/2026 12:13 PM, Jani Nikula wrote:
> On Wed, 21 Jan 2026, Michal Wajdeczko <michal.wajdeczko@intel.com> wrote:
>> We already have most of Xe defaults defined in xe_module.c,
>> where we use them for the modparam initializations, but some
>> were defined elsewhere, which breaks the consistency.
>>
>> Introduce xe_defaults.h file, that will act as a placeholder
>> for all our default values, and can be used from other places.
>>
>> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> ---
>>  drivers/gpu/drm/xe/xe_defaults.h     | 25 +++++++++++++++++
>>  drivers/gpu/drm/xe/xe_device.c       |  3 +-
>>  drivers/gpu/drm/xe/xe_device_types.h |  3 --
>>  drivers/gpu/drm/xe/xe_module.c       | 42 ++++++++++------------------
>>  4 files changed, 41 insertions(+), 32 deletions(-)
>>  create mode 100644 drivers/gpu/drm/xe/xe_defaults.h
>>
>> diff --git a/drivers/gpu/drm/xe/xe_defaults.h b/drivers/gpu/drm/xe/xe_defaults.h
>> new file mode 100644
>> index 000000000000..9183d05b96e1
>> --- /dev/null
>> +++ b/drivers/gpu/drm/xe/xe_defaults.h
>> @@ -0,0 +1,25 @@
>> +/* SPDX-License-Identifier: MIT */
>> +/*
>> + * Copyright © 2026 Intel Corporation
>> + */
>> +#ifndef _XE_DEFAULTS_H_
>> +#define _XE_DEFAULTS_H_
>> +
>> +#include "xe_device_types.h"
> 
> What part of this header depends on xe_device_types.h?

enumerator XE_WEDGED_MODE_UPON_CRITICAL_ERROR

and yes, since it is used inside define, in theory we can skip this include

but then it will be a responsibility of XE_DEFAULT_WEDGED_MODE user to include separately
to avoid that I decided to have explicit include here

note that I plan to do some refactoring of the wedge related code, see [1]
so this might go away, or be replaced, in the near future

[1] https://patchwork.freedesktop.org/patch/694454/?series=148214&rev=11#comment_1278190

> 
>> +
>> +#if IS_ENABLED(CONFIG_DRM_XE_DEBUG)
>> +#define XE_DEFAULT_GUC_LOG_LEVEL		3
>> +#else
>> +#define XE_DEFAULT_GUC_LOG_LEVEL		1
>> +#endif
>> +
>> +#define XE_DEFAULT_PROBE_DISPLAY		true
>> +#define XE_DEFAULT_VRAM_BAR_SIZE		0
>> +#define XE_DEFAULT_FORCE_PROBE			CONFIG_DRM_XE_FORCE_PROBE
>> +#define XE_DEFAULT_MAX_VFS			~0
>> +#define XE_DEFAULT_MAX_VFS_STR			"unlimited"
>> +#define XE_DEFAULT_WEDGED_MODE			XE_WEDGED_MODE_UPON_CRITICAL_ERROR
>> +#define XE_DEFAULT_WEDGED_MODE_STR		"upon-critical-error"
>> +#define XE_DEFAULT_SVM_NOTIFIER_SIZE		512
>> +
>> +#endif