Re: [PATCH] drm/i915: free _DSM package when no connectors

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 09 Jan 2026, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> Subject prefix "drm/i915/acpi:"
>
> On Fri, 09 Jan 2026, Kaushlendra Kumar <kaushlendra.kumar@intel.com> wrote:
>> acpi_evaluate_dsm_typed() returns an ACPI package in pkg.
>> When pkg->package.count == 0, we returned without freeing pkg,
>> leaking memory. Free pkg before returning on the empty case.
>
> Fixes: 337d7a1621c7 ("drm/i915: Fix invalid access to ACPI _DSM objects")
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: <stable@vger.kernel.org> # v5.14+
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Pushed to drm-intel-next, thanks for the patch.

BR,
Jani.



>
>> Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
>> ---
>>  drivers/gpu/drm/i915/display/intel_acpi.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c
>> index 68c01932f7b4..e06f324027be 100644
>> --- a/drivers/gpu/drm/i915/display/intel_acpi.c
>> +++ b/drivers/gpu/drm/i915/display/intel_acpi.c
>> @@ -96,6 +96,7 @@ static void intel_dsm_platform_mux_info(acpi_handle dhandle)
>>  
>>  	if (!pkg->package.count) {
>>  		DRM_DEBUG_DRIVER("no connection in _DSM\n");
>> +		ACPI_FREE(pkg);
>>  		return;
>>  	}

-- 
Jani Nikula, Intel