Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Kaushlendra Kumar <kaushlendra.kumar@intel.com>,
	rodrigo.vivi@intel.com, joonas.lahtinen@linux.intel.com,
	tursulin@ursulin.net, airlied@gmail.com, simona@ffwll.ch
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Subject: Re: [PATCH] drm/i915: free _DSM package when no connectors
Date: Fri, 09 Jan 2026 10:57:42 +0200	[thread overview]
Message-ID: <fcef7bb595e9197eec717a3876d8bc0c869a4b25@intel.com> (raw)
In-Reply-To: <20260109032549.1826303-1-kaushlendra.kumar@intel.com>


Subject prefix "drm/i915/acpi:"

On Fri, 09 Jan 2026, Kaushlendra Kumar <kaushlendra.kumar@intel.com> wrote:
> acpi_evaluate_dsm_typed() returns an ACPI package in pkg.
> When pkg->package.count == 0, we returned without freeing pkg,
> leaking memory. Free pkg before returning on the empty case.

Fixes: 337d7a1621c7 ("drm/i915: Fix invalid access to ACPI _DSM objects")
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: <stable@vger.kernel.org> # v5.14+
Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_acpi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_acpi.c b/drivers/gpu/drm/i915/display/intel_acpi.c
> index 68c01932f7b4..e06f324027be 100644
> --- a/drivers/gpu/drm/i915/display/intel_acpi.c
> +++ b/drivers/gpu/drm/i915/display/intel_acpi.c
> @@ -96,6 +96,7 @@ static void intel_dsm_platform_mux_info(acpi_handle dhandle)
>  
>  	if (!pkg->package.count) {
>  		DRM_DEBUG_DRIVER("no connection in _DSM\n");
> +		ACPI_FREE(pkg);
>  		return;
>  	}

-- 
Jani Nikula, Intel

  parent reply	other threads:[~2026-01-09  8:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-09  3:25 [PATCH] drm/i915: free _DSM package when no connectors Kaushlendra Kumar
2026-01-09  3:35 ` ✓ CI.KUnit: success for " Patchwork
2026-01-09  4:08 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-09  6:37 ` ✓ Xe.CI.Full: " Patchwork
2026-01-09  8:57 ` Jani Nikula [this message]
2026-02-11 12:03   ` [PATCH] " Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fcef7bb595e9197eec717a3876d8bc0c869a4b25@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=kaushlendra.kumar@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox