From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 11/13] drm/xe/pf: Use GuC Buffer Cache during VFs provisioning
Date: Thu, 12 Dec 2024 23:02:22 +0100 [thread overview]
Message-ID: <c0334820-0d7c-44ea-8192-4362c5916b77@intel.com> (raw)
In-Reply-To: <Z1pZvUzL08Z8zzNH@lstrano-desk.jf.intel.com>
On 12.12.2024 04:34, Matthew Brost wrote:
> On Thu, Dec 12, 2024 at 02:01:39AM +0100, Michal Wajdeczko wrote:
...
>> num_dwords += encode_config_ggtt(cfg + num_dwords, other, true);
>> }
>> xe_gt_assert(gt, num_dwords <= max_cfg_dwords);
>> + xe_guc_buf_flush(buf);
>
> Nit: It doesn't look like the return of xe_guc_buf_flush is ever used, maybe drop it.
actually it supposed to be called from within pf_send_vf_buf_klvs()
instead of xe_guc_buf_gpu_addr() - fixed in v3
next prev parent reply other threads:[~2024-12-12 22:02 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 1:01 [PATCH 00/13] The xe_sa_manager based GuC Buffer Cache Michal Wajdeczko
2024-12-12 1:01 ` [PATCH 01/13] drm/xe/sa: Always call drm_suballoc_manager_fini() Michal Wajdeczko
2024-12-12 3:03 ` Matthew Brost
2024-12-12 1:01 ` [PATCH 02/13] drm/xe/sa: Drop redundant NULL assignments Michal Wajdeczko
2024-12-12 3:03 ` Matthew Brost
2024-12-12 1:01 ` [PATCH 03/13] drm/xe/sa: Cleanup internal BO data at device removal Michal Wajdeczko
2024-12-12 3:07 ` Matthew Brost
2024-12-12 1:01 ` [PATCH 04/13] drm/xe/sa: Drop useless is_iomem member Michal Wajdeczko
2024-12-12 3:09 ` Matthew Brost
2024-12-18 20:53 ` Michal Wajdeczko
2024-12-12 1:01 ` [PATCH 05/13] drm/xe/sa: Improve error message on init failure Michal Wajdeczko
2024-12-12 3:10 ` Matthew Brost
2024-12-12 1:01 ` [PATCH 06/13] drm/xe/sa: Tidy up coding style in init() Michal Wajdeczko
2024-12-12 3:11 ` Matthew Brost
2024-12-12 1:01 ` [PATCH 07/13] drm/xe/sa: Allow making suballocations using custom gfp flags Michal Wajdeczko
2024-12-12 3:12 ` Matthew Brost
2024-12-12 1:01 ` [PATCH 08/13] drm/xe/sa: Allow creating suballocator with custom guard size Michal Wajdeczko
2024-12-12 3:23 ` Matthew Brost
2024-12-12 21:57 ` Michal Wajdeczko
2024-12-12 22:48 ` Matthew Brost
2024-12-12 1:01 ` [PATCH 09/13] drm/xe/sa: Minor header cleanups Michal Wajdeczko
2024-12-12 3:14 ` Matthew Brost
2024-12-12 1:01 ` [PATCH 10/13] drm/xe/guc: Introduce the GuC Buffer Cache Michal Wajdeczko
2024-12-12 3:30 ` Matthew Brost
2024-12-12 21:48 ` Michal Wajdeczko
2024-12-13 18:38 ` Matthew Brost
2024-12-13 20:13 ` Rodrigo Vivi
2024-12-18 21:03 ` Michal Wajdeczko
2024-12-19 20:28 ` Rodrigo Vivi
2024-12-12 1:01 ` [PATCH 11/13] drm/xe/pf: Use GuC Buffer Cache during VFs provisioning Michal Wajdeczko
2024-12-12 3:34 ` Matthew Brost
2024-12-12 22:02 ` Michal Wajdeczko [this message]
2024-12-12 1:01 ` [PATCH 12/13] drm/xe/kunit: Allow to replace xe_managed_bo_create_pin_map() Michal Wajdeczko
2024-12-12 1:01 ` [PATCH 13/13] drm/xe/kunit: Add KUnit tests for GuC Buffer Cache Michal Wajdeczko
2024-12-12 3:36 ` Matthew Brost
2024-12-18 21:06 ` Michal Wajdeczko
2024-12-12 2:20 ` ✓ CI.Patch_applied: success for The xe_sa_manager based " Patchwork
2024-12-12 2:20 ` ✗ CI.checkpatch: warning " Patchwork
2024-12-12 2:21 ` ✓ CI.KUnit: success " Patchwork
2024-12-12 2:41 ` ✓ CI.Build: " Patchwork
2024-12-12 2:45 ` ✓ CI.Hooks: " Patchwork
2024-12-12 2:48 ` ✓ CI.checksparse: " Patchwork
2024-12-12 3:14 ` ✗ Xe.CI.BAT: failure " Patchwork
2024-12-12 8:50 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0334820-0d7c-44ea-8192-4362c5916b77@intel.com \
--to=michal.wajdeczko@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox