Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Use dma_fence_chain_free in chain fence unused as a sync
@ 2024-07-27  1:22 Matthew Brost
  2024-07-27  1:26 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: Matthew Brost @ 2024-07-27  1:22 UTC (permalink / raw)
  To: intel-xe; +Cc: paulo.r.zanoni

A chain fence is uninitialized if not installed in a drm sync obj. Thus
if xe_sync_entry_cleanup is called and sync->chain_fence is non-NULL the
proper cleanup is dma_fence_chain_free rather than a dma-fence put.

Reported-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2411
Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
 drivers/gpu/drm/xe/xe_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_sync.c b/drivers/gpu/drm/xe/xe_sync.c
index 533246f42256..3aa6270e5dd7 100644
--- a/drivers/gpu/drm/xe/xe_sync.c
+++ b/drivers/gpu/drm/xe/xe_sync.c
@@ -259,7 +259,7 @@ void xe_sync_entry_cleanup(struct xe_sync_entry *sync)
 	if (sync->fence)
 		dma_fence_put(sync->fence);
 	if (sync->chain_fence)
-		dma_fence_put(&sync->chain_fence->base);
+		dma_fence_chain_free(sync->chain_fence);
 	if (sync->ufence)
 		user_fence_put(sync->ufence);
 }
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-07-29  8:46 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-27  1:22 [PATCH] drm/xe: Use dma_fence_chain_free in chain fence unused as a sync Matthew Brost
2024-07-27  1:26 ` ✓ CI.Patch_applied: success for " Patchwork
2024-07-27  1:27 ` ✓ CI.checkpatch: " Patchwork
2024-07-27  1:28 ` ✓ CI.KUnit: " Patchwork
2024-07-27  1:40 ` ✓ CI.Build: " Patchwork
2024-07-27  1:42 ` ✓ CI.Hooks: " Patchwork
2024-07-27  1:43 ` ✓ CI.checksparse: " Patchwork
2024-07-27  2:04 ` ✓ CI.BAT: " Patchwork
2024-07-27 10:52 ` ✗ CI.FULL: failure " Patchwork
2024-07-29  8:46 ` [PATCH] " Matthew Auld

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox