Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/4] drm/client: Implement free callback for fbdev and log
@ 2025-10-09 13:16 Thomas Zimmermann
  2025-10-09 13:16 ` [PATCH 1/4] drm/client: Add client free callback to unprepare fb_helper Thomas Zimmermann
                   ` (6 more replies)
  0 siblings, 7 replies; 16+ messages in thread
From: Thomas Zimmermann @ 2025-10-09 13:16 UTC (permalink / raw)
  To: jfalempe, javierm, mripard, maarten.lankhorst
  Cc: dri-devel, linux-arm-kernel, linux-samsung-soc, intel-gfx,
	intel-xe, linux-arm-msm, freedreno, amd-gfx, linux-tegra,
	Thomas Zimmermann

Add struct drm_client_funcs.free and release the memory fbdev and
log clients from its implementations. Also fix the locking in the
log's unregister code.

Resolves several corner cases in the current clients and avoids
duplicated code.

Thomas Zimmermann (4):
  drm/client: Add client free callback to unprepare fb_helper
  drm/log: Do not hold lock across drm_client_release()
  drm/log: Add free callback
  drm/client: Do not free client memory by default

 drivers/gpu/drm/armada/armada_fbdev.c      |  2 --
 drivers/gpu/drm/clients/drm_fbdev_client.c | 17 +++++++++++++++--
 drivers/gpu/drm/clients/drm_log.c          | 16 ++++++++++++----
 drivers/gpu/drm/drm_client.c               |  4 ++++
 drivers/gpu/drm/drm_client_event.c         |  9 +++++----
 drivers/gpu/drm/drm_fbdev_dma.c            |  4 ----
 drivers/gpu/drm/drm_fbdev_shmem.c          |  2 --
 drivers/gpu/drm/drm_fbdev_ttm.c            |  2 --
 drivers/gpu/drm/exynos/exynos_drm_fbdev.c  |  2 --
 drivers/gpu/drm/gma500/fbdev.c             |  3 ---
 drivers/gpu/drm/i915/display/intel_fbdev.c |  2 --
 drivers/gpu/drm/msm/msm_fbdev.c            |  2 --
 drivers/gpu/drm/omapdrm/omap_fbdev.c       |  2 --
 drivers/gpu/drm/radeon/radeon_fbdev.c      |  2 --
 drivers/gpu/drm/tegra/fbdev.c              |  2 --
 include/drm/drm_client.h                   | 10 ++++++++++
 16 files changed, 46 insertions(+), 35 deletions(-)

-- 
2.51.0


^ permalink raw reply	[flat|nested] 16+ messages in thread

* [PATCH 1/4] drm/client: Add client free callback to unprepare fb_helper
  2025-10-09 13:16 [PATCH 0/4] drm/client: Implement free callback for fbdev and log Thomas Zimmermann
@ 2025-10-09 13:16 ` Thomas Zimmermann
  2025-10-09 13:32   ` Dmitry Baryshkov
                     ` (4 more replies)
  2025-10-09 13:16 ` [PATCH 2/4] drm/log: Do not hold lock across drm_client_release() Thomas Zimmermann
                   ` (5 subsequent siblings)
  6 siblings, 5 replies; 16+ messages in thread
From: Thomas Zimmermann @ 2025-10-09 13:16 UTC (permalink / raw)
  To: jfalempe, javierm, mripard, maarten.lankhorst
  Cc: dri-devel, linux-arm-kernel, linux-samsung-soc, intel-gfx,
	intel-xe, linux-arm-msm, freedreno, amd-gfx, linux-tegra,
	Thomas Zimmermann

Add free callback to struct drm_client_funcs. Invoke function to
free the client memory as part of the release process. Implement
free for fbdev emulation.

Fbdev emulation allocates and prepares client memory in
drm_fbdev_client_setup(). The release happens in fb_destroy from
struct fb_ops. Multiple implementations of this callback exist in
the various drivers that provide fbdev implementation. Each of them
needs to follow the implementation details of the fbdev setup code.

Adding a free callback for the client puts the unprepare and release
of the fbdev client in a single place.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/armada/armada_fbdev.c      |  2 --
 drivers/gpu/drm/clients/drm_fbdev_client.c | 17 +++++++++++++++--
 drivers/gpu/drm/drm_client.c               |  4 ++++
 drivers/gpu/drm/drm_fbdev_dma.c            |  4 ----
 drivers/gpu/drm/drm_fbdev_shmem.c          |  2 --
 drivers/gpu/drm/drm_fbdev_ttm.c            |  2 --
 drivers/gpu/drm/exynos/exynos_drm_fbdev.c  |  2 --
 drivers/gpu/drm/gma500/fbdev.c             |  3 ---
 drivers/gpu/drm/i915/display/intel_fbdev.c |  2 --
 drivers/gpu/drm/msm/msm_fbdev.c            |  2 --
 drivers/gpu/drm/omapdrm/omap_fbdev.c       |  2 --
 drivers/gpu/drm/radeon/radeon_fbdev.c      |  2 --
 drivers/gpu/drm/tegra/fbdev.c              |  2 --
 include/drm/drm_client.h                   | 10 ++++++++++
 14 files changed, 29 insertions(+), 27 deletions(-)

diff --git a/drivers/gpu/drm/armada/armada_fbdev.c b/drivers/gpu/drm/armada/armada_fbdev.c
index cb53cc91bafb..22e2081bfa04 100644
--- a/drivers/gpu/drm/armada/armada_fbdev.c
+++ b/drivers/gpu/drm/armada/armada_fbdev.c
@@ -28,8 +28,6 @@ static void armada_fbdev_fb_destroy(struct fb_info *info)
 	fbh->fb->funcs->destroy(fbh->fb);
 
 	drm_client_release(&fbh->client);
-	drm_fb_helper_unprepare(fbh);
-	kfree(fbh);
 }
 
 static const struct fb_ops armada_fb_ops = {
diff --git a/drivers/gpu/drm/clients/drm_fbdev_client.c b/drivers/gpu/drm/clients/drm_fbdev_client.c
index f894ba52bdb5..5336accab1b6 100644
--- a/drivers/gpu/drm/clients/drm_fbdev_client.c
+++ b/drivers/gpu/drm/clients/drm_fbdev_client.c
@@ -13,16 +13,28 @@
  * struct drm_client_funcs
  */
 
+static void drm_fbdev_client_free(struct drm_client_dev *client)
+{
+	struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
+
+	drm_fb_helper_unprepare(fb_helper);
+	kfree(fb_helper);
+}
+
 static void drm_fbdev_client_unregister(struct drm_client_dev *client)
 {
 	struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
 
 	if (fb_helper->info) {
+		/*
+		 * Fully probed framebuffer device
+		 */
 		drm_fb_helper_unregister_info(fb_helper);
 	} else {
+		/*
+		 * Partially initialized client, no framebuffer device yet
+		 */
 		drm_client_release(&fb_helper->client);
-		drm_fb_helper_unprepare(fb_helper);
-		kfree(fb_helper);
 	}
 }
 
@@ -88,6 +100,7 @@ static int drm_fbdev_client_resume(struct drm_client_dev *client, bool holds_con
 
 static const struct drm_client_funcs drm_fbdev_client_funcs = {
 	.owner		= THIS_MODULE,
+	.free		= drm_fbdev_client_free,
 	.unregister	= drm_fbdev_client_unregister,
 	.restore	= drm_fbdev_client_restore,
 	.hotplug	= drm_fbdev_client_hotplug,
diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
index 3fa38d4ac70b..fe9c6d7083ea 100644
--- a/drivers/gpu/drm/drm_client.c
+++ b/drivers/gpu/drm/drm_client.c
@@ -168,6 +168,10 @@ void drm_client_release(struct drm_client_dev *client)
 
 	drm_client_modeset_free(client);
 	drm_client_close(client);
+
+	if (client->funcs && client->funcs->free)
+		client->funcs->free(client);
+
 	drm_dev_put(dev);
 }
 EXPORT_SYMBOL(drm_client_release);
diff --git a/drivers/gpu/drm/drm_fbdev_dma.c b/drivers/gpu/drm/drm_fbdev_dma.c
index 8bd626ef16c7..c6196293e424 100644
--- a/drivers/gpu/drm/drm_fbdev_dma.c
+++ b/drivers/gpu/drm/drm_fbdev_dma.c
@@ -57,8 +57,6 @@ static void drm_fbdev_dma_fb_destroy(struct fb_info *info)
 	drm_client_buffer_vunmap(fb_helper->buffer);
 	drm_client_framebuffer_delete(fb_helper->buffer);
 	drm_client_release(&fb_helper->client);
-	drm_fb_helper_unprepare(fb_helper);
-	kfree(fb_helper);
 }
 
 static const struct fb_ops drm_fbdev_dma_fb_ops = {
@@ -92,8 +90,6 @@ static void drm_fbdev_dma_shadowed_fb_destroy(struct fb_info *info)
 	drm_client_buffer_vunmap(fb_helper->buffer);
 	drm_client_framebuffer_delete(fb_helper->buffer);
 	drm_client_release(&fb_helper->client);
-	drm_fb_helper_unprepare(fb_helper);
-	kfree(fb_helper);
 }
 
 static const struct fb_ops drm_fbdev_dma_shadowed_fb_ops = {
diff --git a/drivers/gpu/drm/drm_fbdev_shmem.c b/drivers/gpu/drm/drm_fbdev_shmem.c
index 1e827bf8b815..51573058df6f 100644
--- a/drivers/gpu/drm/drm_fbdev_shmem.c
+++ b/drivers/gpu/drm/drm_fbdev_shmem.c
@@ -65,8 +65,6 @@ static void drm_fbdev_shmem_fb_destroy(struct fb_info *info)
 	drm_client_buffer_vunmap(fb_helper->buffer);
 	drm_client_framebuffer_delete(fb_helper->buffer);
 	drm_client_release(&fb_helper->client);
-	drm_fb_helper_unprepare(fb_helper);
-	kfree(fb_helper);
 }
 
 static const struct fb_ops drm_fbdev_shmem_fb_ops = {
diff --git a/drivers/gpu/drm/drm_fbdev_ttm.c b/drivers/gpu/drm/drm_fbdev_ttm.c
index 85feb55bba11..ccf460fbc1f0 100644
--- a/drivers/gpu/drm/drm_fbdev_ttm.c
+++ b/drivers/gpu/drm/drm_fbdev_ttm.c
@@ -53,8 +53,6 @@ static void drm_fbdev_ttm_fb_destroy(struct fb_info *info)
 	drm_client_framebuffer_delete(fb_helper->buffer);
 
 	drm_client_release(&fb_helper->client);
-	drm_fb_helper_unprepare(fb_helper);
-	kfree(fb_helper);
 }
 
 static const struct fb_ops drm_fbdev_ttm_fb_ops = {
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
index 93de25b77e68..a3bd21a827ad 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
@@ -42,8 +42,6 @@ static void exynos_drm_fb_destroy(struct fb_info *info)
 	drm_framebuffer_remove(fb);
 
 	drm_client_release(&fb_helper->client);
-	drm_fb_helper_unprepare(fb_helper);
-	kfree(fb_helper);
 }
 
 static const struct fb_ops exynos_drm_fb_ops = {
diff --git a/drivers/gpu/drm/gma500/fbdev.c b/drivers/gpu/drm/gma500/fbdev.c
index a6af21514cff..bc92fa24a1e2 100644
--- a/drivers/gpu/drm/gma500/fbdev.c
+++ b/drivers/gpu/drm/gma500/fbdev.c
@@ -84,9 +84,6 @@ static void psb_fbdev_fb_destroy(struct fb_info *info)
 	drm_gem_object_put(obj);
 
 	drm_client_release(&fb_helper->client);
-
-	drm_fb_helper_unprepare(fb_helper);
-	kfree(fb_helper);
 }
 
 static const struct fb_ops psb_fbdev_fb_ops = {
diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
index 3fbdf75415cc..d5f26c8bb102 100644
--- a/drivers/gpu/drm/i915/display/intel_fbdev.c
+++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
@@ -146,8 +146,6 @@ static void intel_fbdev_fb_destroy(struct fb_info *info)
 	drm_framebuffer_remove(fb_helper->fb);
 
 	drm_client_release(&fb_helper->client);
-	drm_fb_helper_unprepare(fb_helper);
-	kfree(fb_helper);
 }
 
 __diag_push();
diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
index b5969374d53f..aad6fb77f0de 100644
--- a/drivers/gpu/drm/msm/msm_fbdev.c
+++ b/drivers/gpu/drm/msm/msm_fbdev.c
@@ -52,8 +52,6 @@ static void msm_fbdev_fb_destroy(struct fb_info *info)
 	drm_framebuffer_remove(fb);
 
 	drm_client_release(&helper->client);
-	drm_fb_helper_unprepare(helper);
-	kfree(helper);
 }
 
 static const struct fb_ops msm_fb_ops = {
diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
index 948af7ec1130..b5df2923d2a6 100644
--- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
+++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
@@ -103,8 +103,6 @@ static void omap_fbdev_fb_destroy(struct fb_info *info)
 	drm_framebuffer_remove(fb);
 
 	drm_client_release(&helper->client);
-	drm_fb_helper_unprepare(helper);
-	kfree(helper);
 }
 
 /*
diff --git a/drivers/gpu/drm/radeon/radeon_fbdev.c b/drivers/gpu/drm/radeon/radeon_fbdev.c
index dc81b0c2dbff..4df6c9167bf0 100644
--- a/drivers/gpu/drm/radeon/radeon_fbdev.c
+++ b/drivers/gpu/drm/radeon/radeon_fbdev.c
@@ -184,8 +184,6 @@ static void radeon_fbdev_fb_destroy(struct fb_info *info)
 	radeon_fbdev_destroy_pinned_object(gobj);
 
 	drm_client_release(&fb_helper->client);
-	drm_fb_helper_unprepare(fb_helper);
-	kfree(fb_helper);
 }
 
 static const struct fb_ops radeon_fbdev_fb_ops = {
diff --git a/drivers/gpu/drm/tegra/fbdev.c b/drivers/gpu/drm/tegra/fbdev.c
index 1b70f5e164af..91aece6f34e0 100644
--- a/drivers/gpu/drm/tegra/fbdev.c
+++ b/drivers/gpu/drm/tegra/fbdev.c
@@ -53,8 +53,6 @@ static void tegra_fbdev_fb_destroy(struct fb_info *info)
 	drm_framebuffer_remove(fb);
 
 	drm_client_release(&helper->client);
-	drm_fb_helper_unprepare(helper);
-	kfree(helper);
 }
 
 static const struct fb_ops tegra_fb_ops = {
diff --git a/include/drm/drm_client.h b/include/drm/drm_client.h
index bdd845e383ef..eecb8d6e15c7 100644
--- a/include/drm/drm_client.h
+++ b/include/drm/drm_client.h
@@ -28,6 +28,16 @@ struct drm_client_funcs {
 	 */
 	struct module *owner;
 
+	/**
+	 * @free:
+	 *
+	 * Called when the client gets unregistered. Implementations should
+	 * release all client-specific data and free the memory.
+	 *
+	 * This callback is optional.
+	 */
+	void (*free)(struct drm_client_dev *client);
+
 	/**
 	 * @unregister:
 	 *
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 2/4] drm/log: Do not hold lock across drm_client_release()
  2025-10-09 13:16 [PATCH 0/4] drm/client: Implement free callback for fbdev and log Thomas Zimmermann
  2025-10-09 13:16 ` [PATCH 1/4] drm/client: Add client free callback to unprepare fb_helper Thomas Zimmermann
@ 2025-10-09 13:16 ` Thomas Zimmermann
  2025-10-15  7:52   ` Jocelyn Falempe
  2025-10-09 13:16 ` [PATCH 3/4] drm/log: Add free callback Thomas Zimmermann
                   ` (4 subsequent siblings)
  6 siblings, 1 reply; 16+ messages in thread
From: Thomas Zimmermann @ 2025-10-09 13:16 UTC (permalink / raw)
  To: jfalempe, javierm, mripard, maarten.lankhorst
  Cc: dri-devel, linux-arm-kernel, linux-samsung-soc, intel-gfx,
	intel-xe, linux-arm-msm, freedreno, amd-gfx, linux-tegra,
	Thomas Zimmermann

When calling drm_client_release(), the client is already quiescent.
Internal locks should therefore be dropped before the caller releases
the client.

In the case of the DRM log, concurrency originates from the console or
from client events. The console has been unregistered in the previous
line. The caller of the unregister callback, drm_log_client_unregister(),
holds clientlist_mutex from struct drm_device to protect against concurrent
client events. It is therefore safe to release the client without holding
locks.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/clients/drm_log.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/clients/drm_log.c b/drivers/gpu/drm/clients/drm_log.c
index d239f1e3c456..116e0ef9ae5d 100644
--- a/drivers/gpu/drm/clients/drm_log.c
+++ b/drivers/gpu/drm/clients/drm_log.c
@@ -302,8 +302,8 @@ static void drm_log_client_unregister(struct drm_client_dev *client)
 
 	mutex_lock(&dlog->lock);
 	drm_log_free_scanout(client);
-	drm_client_release(client);
 	mutex_unlock(&dlog->lock);
+	drm_client_release(client);
 	kfree(dlog);
 	drm_dbg(dev, "Unregistered with drm log\n");
 }
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 3/4] drm/log: Add free callback
  2025-10-09 13:16 [PATCH 0/4] drm/client: Implement free callback for fbdev and log Thomas Zimmermann
  2025-10-09 13:16 ` [PATCH 1/4] drm/client: Add client free callback to unprepare fb_helper Thomas Zimmermann
  2025-10-09 13:16 ` [PATCH 2/4] drm/log: Do not hold lock across drm_client_release() Thomas Zimmermann
@ 2025-10-09 13:16 ` Thomas Zimmermann
  2025-10-15  7:53   ` Jocelyn Falempe
  2025-10-09 13:16 ` [PATCH 4/4] drm/client: Do not free client memory by default Thomas Zimmermann
                   ` (3 subsequent siblings)
  6 siblings, 1 reply; 16+ messages in thread
From: Thomas Zimmermann @ 2025-10-09 13:16 UTC (permalink / raw)
  To: jfalempe, javierm, mripard, maarten.lankhorst
  Cc: dri-devel, linux-arm-kernel, linux-samsung-soc, intel-gfx,
	intel-xe, linux-arm-msm, freedreno, amd-gfx, linux-tegra,
	Thomas Zimmermann

Free the client memory in the client free callback. Also move the
debugging output into the free callback: drm_client_release() puts
the reference on the DRM device, so pointers to the device should
be considered dangling afterwards.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/clients/drm_log.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/clients/drm_log.c b/drivers/gpu/drm/clients/drm_log.c
index 116e0ef9ae5d..470df4148e96 100644
--- a/drivers/gpu/drm/clients/drm_log.c
+++ b/drivers/gpu/drm/clients/drm_log.c
@@ -293,19 +293,26 @@ static void drm_log_free_scanout(struct drm_client_dev *client)
 	}
 }
 
-static void drm_log_client_unregister(struct drm_client_dev *client)
+static void drm_log_client_free(struct drm_client_dev *client)
 {
 	struct drm_log *dlog = client_to_drm_log(client);
 	struct drm_device *dev = client->dev;
 
+	kfree(dlog);
+
+	drm_dbg(dev, "Unregistered with drm log\n");
+}
+
+static void drm_log_client_unregister(struct drm_client_dev *client)
+{
+	struct drm_log *dlog = client_to_drm_log(client);
+
 	unregister_console(&dlog->con);
 
 	mutex_lock(&dlog->lock);
 	drm_log_free_scanout(client);
 	mutex_unlock(&dlog->lock);
 	drm_client_release(client);
-	kfree(dlog);
-	drm_dbg(dev, "Unregistered with drm log\n");
 }
 
 static int drm_log_client_hotplug(struct drm_client_dev *client)
@@ -339,6 +346,7 @@ static int drm_log_client_resume(struct drm_client_dev *client, bool _console_lo
 
 static const struct drm_client_funcs drm_log_client_funcs = {
 	.owner		= THIS_MODULE,
+	.free		= drm_log_client_free,
 	.unregister	= drm_log_client_unregister,
 	.hotplug	= drm_log_client_hotplug,
 	.suspend	= drm_log_client_suspend,
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH 4/4] drm/client: Do not free client memory by default
  2025-10-09 13:16 [PATCH 0/4] drm/client: Implement free callback for fbdev and log Thomas Zimmermann
                   ` (2 preceding siblings ...)
  2025-10-09 13:16 ` [PATCH 3/4] drm/log: Add free callback Thomas Zimmermann
@ 2025-10-09 13:16 ` Thomas Zimmermann
  2025-10-15  8:20   ` Jocelyn Falempe
  2025-10-09 14:52 ` ✓ CI.KUnit: success for drm/client: Implement free callback for fbdev and log Patchwork
                   ` (2 subsequent siblings)
  6 siblings, 1 reply; 16+ messages in thread
From: Thomas Zimmermann @ 2025-10-09 13:16 UTC (permalink / raw)
  To: jfalempe, javierm, mripard, maarten.lankhorst
  Cc: dri-devel, linux-arm-kernel, linux-samsung-soc, intel-gfx,
	intel-xe, linux-arm-msm, freedreno, amd-gfx, linux-tegra,
	Thomas Zimmermann

Make no assumption on the allocation of the client's memory. For
example, amdgpu stores a client within another data structures,
where it cannot be freed by itself.

The correct place to free the client's memory is the client's free
callback. All existing clients implement this.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/drm_client_event.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/drm_client_event.c b/drivers/gpu/drm/drm_client_event.c
index c83196ad8b59..f36fe0392ce6 100644
--- a/drivers/gpu/drm/drm_client_event.c
+++ b/drivers/gpu/drm/drm_client_event.c
@@ -39,12 +39,13 @@ void drm_client_dev_unregister(struct drm_device *dev)
 	mutex_lock(&dev->clientlist_mutex);
 	list_for_each_entry_safe(client, tmp, &dev->clientlist, list) {
 		list_del(&client->list);
-		if (client->funcs && client->funcs->unregister) {
+		/*
+		 * Unregistering consumes and frees the client.
+		 */
+		if (client->funcs && client->funcs->unregister)
 			client->funcs->unregister(client);
-		} else {
+		else
 			drm_client_release(client);
-			kfree(client);
-		}
 	}
 	mutex_unlock(&dev->clientlist_mutex);
 }
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 16+ messages in thread

* Re: [PATCH 1/4] drm/client: Add client free callback to unprepare fb_helper
  2025-10-09 13:16 ` [PATCH 1/4] drm/client: Add client free callback to unprepare fb_helper Thomas Zimmermann
@ 2025-10-09 13:32   ` Dmitry Baryshkov
  2025-10-21 13:29   ` Tomi Valkeinen
                     ` (3 subsequent siblings)
  4 siblings, 0 replies; 16+ messages in thread
From: Dmitry Baryshkov @ 2025-10-09 13:32 UTC (permalink / raw)
  To: Thomas Zimmermann
  Cc: jfalempe, javierm, mripard, maarten.lankhorst, dri-devel,
	linux-arm-kernel, linux-samsung-soc, intel-gfx, intel-xe,
	linux-arm-msm, freedreno, amd-gfx, linux-tegra

On Thu, Oct 09, 2025 at 03:16:28PM +0200, Thomas Zimmermann wrote:
> Add free callback to struct drm_client_funcs. Invoke function to
> free the client memory as part of the release process. Implement
> free for fbdev emulation.
> 
> Fbdev emulation allocates and prepares client memory in
> drm_fbdev_client_setup(). The release happens in fb_destroy from
> struct fb_ops. Multiple implementations of this callback exist in
> the various drivers that provide fbdev implementation. Each of them
> needs to follow the implementation details of the fbdev setup code.
> 
> Adding a free callback for the client puts the unprepare and release
> of the fbdev client in a single place.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>  drivers/gpu/drm/armada/armada_fbdev.c      |  2 --
>  drivers/gpu/drm/clients/drm_fbdev_client.c | 17 +++++++++++++++--
>  drivers/gpu/drm/drm_client.c               |  4 ++++
>  drivers/gpu/drm/drm_fbdev_dma.c            |  4 ----
>  drivers/gpu/drm/drm_fbdev_shmem.c          |  2 --
>  drivers/gpu/drm/drm_fbdev_ttm.c            |  2 --
>  drivers/gpu/drm/exynos/exynos_drm_fbdev.c  |  2 --
>  drivers/gpu/drm/gma500/fbdev.c             |  3 ---
>  drivers/gpu/drm/i915/display/intel_fbdev.c |  2 --
>  drivers/gpu/drm/msm/msm_fbdev.c            |  2 --

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> # core, msm

>  drivers/gpu/drm/omapdrm/omap_fbdev.c       |  2 --
>  drivers/gpu/drm/radeon/radeon_fbdev.c      |  2 --
>  drivers/gpu/drm/tegra/fbdev.c              |  2 --
>  include/drm/drm_client.h                   | 10 ++++++++++
>  14 files changed, 29 insertions(+), 27 deletions(-)
> 

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 16+ messages in thread

* ✓ CI.KUnit: success for drm/client: Implement free callback for fbdev and log
  2025-10-09 13:16 [PATCH 0/4] drm/client: Implement free callback for fbdev and log Thomas Zimmermann
                   ` (3 preceding siblings ...)
  2025-10-09 13:16 ` [PATCH 4/4] drm/client: Do not free client memory by default Thomas Zimmermann
@ 2025-10-09 14:52 ` Patchwork
  2025-10-09 15:27 ` ✓ Xe.CI.BAT: " Patchwork
  2025-10-09 21:17 ` ✗ Xe.CI.Full: failure " Patchwork
  6 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2025-10-09 14:52 UTC (permalink / raw)
  To: Thomas Zimmermann; +Cc: intel-xe

== Series Details ==

Series: drm/client: Implement free callback for fbdev and log
URL   : https://patchwork.freedesktop.org/series/155689/
State : success

== Summary ==

+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig
[14:51:27] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[14:51:31] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[14:52:00] Starting KUnit Kernel (1/1)...
[14:52:00] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[14:52:00] ================== guc_buf (11 subtests) ===================
[14:52:00] [PASSED] test_smallest
[14:52:00] [PASSED] test_largest
[14:52:00] [PASSED] test_granular
[14:52:00] [PASSED] test_unique
[14:52:00] [PASSED] test_overlap
[14:52:00] [PASSED] test_reusable
[14:52:00] [PASSED] test_too_big
[14:52:00] [PASSED] test_flush
[14:52:00] [PASSED] test_lookup
[14:52:00] [PASSED] test_data
[14:52:00] [PASSED] test_class
[14:52:00] ===================== [PASSED] guc_buf =====================
[14:52:00] =================== guc_dbm (7 subtests) ===================
[14:52:00] [PASSED] test_empty
[14:52:00] [PASSED] test_default
[14:52:00] ======================== test_size  ========================
[14:52:00] [PASSED] 4
[14:52:00] [PASSED] 8
[14:52:00] [PASSED] 32
[14:52:00] [PASSED] 256
[14:52:00] ==================== [PASSED] test_size ====================
[14:52:00] ======================= test_reuse  ========================
[14:52:00] [PASSED] 4
[14:52:00] [PASSED] 8
[14:52:00] [PASSED] 32
[14:52:00] [PASSED] 256
[14:52:00] =================== [PASSED] test_reuse ====================
[14:52:00] =================== test_range_overlap  ====================
[14:52:00] [PASSED] 4
[14:52:00] [PASSED] 8
[14:52:00] [PASSED] 32
[14:52:00] [PASSED] 256
[14:52:00] =============== [PASSED] test_range_overlap ================
[14:52:00] =================== test_range_compact  ====================
[14:52:00] [PASSED] 4
[14:52:00] [PASSED] 8
[14:52:00] [PASSED] 32
[14:52:00] [PASSED] 256
[14:52:00] =============== [PASSED] test_range_compact ================
[14:52:00] ==================== test_range_spare  =====================
[14:52:00] [PASSED] 4
[14:52:00] [PASSED] 8
[14:52:00] [PASSED] 32
[14:52:00] [PASSED] 256
[14:52:00] ================ [PASSED] test_range_spare =================
[14:52:00] ===================== [PASSED] guc_dbm =====================
[14:52:00] =================== guc_idm (6 subtests) ===================
[14:52:00] [PASSED] bad_init
[14:52:00] [PASSED] no_init
[14:52:00] [PASSED] init_fini
[14:52:00] [PASSED] check_used
[14:52:00] [PASSED] check_quota
[14:52:00] [PASSED] check_all
[14:52:00] ===================== [PASSED] guc_idm =====================
[14:52:00] ================== no_relay (3 subtests) ===================
[14:52:00] [PASSED] xe_drops_guc2pf_if_not_ready
[14:52:00] [PASSED] xe_drops_guc2vf_if_not_ready
[14:52:00] [PASSED] xe_rejects_send_if_not_ready
[14:52:00] ==================== [PASSED] no_relay =====================
[14:52:00] ================== pf_relay (14 subtests) ==================
[14:52:00] [PASSED] pf_rejects_guc2pf_too_short
[14:52:00] [PASSED] pf_rejects_guc2pf_too_long
[14:52:00] [PASSED] pf_rejects_guc2pf_no_payload
[14:52:00] [PASSED] pf_fails_no_payload
[14:52:00] [PASSED] pf_fails_bad_origin
[14:52:00] [PASSED] pf_fails_bad_type
[14:52:00] [PASSED] pf_txn_reports_error
[14:52:00] [PASSED] pf_txn_sends_pf2guc
[14:52:00] [PASSED] pf_sends_pf2guc
[14:52:00] [SKIPPED] pf_loopback_nop
[14:52:00] [SKIPPED] pf_loopback_echo
[14:52:00] [SKIPPED] pf_loopback_fail
[14:52:00] [SKIPPED] pf_loopback_busy
[14:52:00] [SKIPPED] pf_loopback_retry
[14:52:00] ==================== [PASSED] pf_relay =====================
[14:52:00] ================== vf_relay (3 subtests) ===================
[14:52:00] [PASSED] vf_rejects_guc2vf_too_short
[14:52:00] [PASSED] vf_rejects_guc2vf_too_long
[14:52:00] [PASSED] vf_rejects_guc2vf_no_payload
[14:52:00] ==================== [PASSED] vf_relay =====================
[14:52:00] ===================== lmtt (1 subtest) =====================
[14:52:00] ======================== test_ops  =========================
[14:52:00] [PASSED] 2-level
[14:52:00] [PASSED] multi-level
[14:52:00] ==================== [PASSED] test_ops =====================
[14:52:00] ====================== [PASSED] lmtt =======================
[14:52:00] ================= pf_service (11 subtests) =================
[14:52:00] [PASSED] pf_negotiate_any
[14:52:00] [PASSED] pf_negotiate_base_match
[14:52:00] [PASSED] pf_negotiate_base_newer
[14:52:00] [PASSED] pf_negotiate_base_next
[14:52:00] [SKIPPED] pf_negotiate_base_older
[14:52:00] [PASSED] pf_negotiate_base_prev
[14:52:00] [PASSED] pf_negotiate_latest_match
[14:52:00] [PASSED] pf_negotiate_latest_newer
[14:52:00] [PASSED] pf_negotiate_latest_next
[14:52:00] [SKIPPED] pf_negotiate_latest_older
[14:52:00] [SKIPPED] pf_negotiate_latest_prev
[14:52:00] =================== [PASSED] pf_service ====================
[14:52:00] ================= xe_guc_g2g (2 subtests) ==================
[14:52:00] ============== xe_live_guc_g2g_kunit_default  ==============
[14:52:00] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ==========
[14:52:00] ============== xe_live_guc_g2g_kunit_allmem  ===============
[14:52:00] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ==========
[14:52:00] =================== [SKIPPED] xe_guc_g2g ===================
[14:52:00] =================== xe_mocs (2 subtests) ===================
[14:52:00] ================ xe_live_mocs_kernel_kunit  ================
[14:52:00] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============
[14:52:00] ================ xe_live_mocs_reset_kunit  =================
[14:52:00] ============ [SKIPPED] xe_live_mocs_reset_kunit ============
[14:52:00] ==================== [SKIPPED] xe_mocs =====================
[14:52:00] ================= xe_migrate (2 subtests) ==================
[14:52:00] ================= xe_migrate_sanity_kunit  =================
[14:52:00] ============ [SKIPPED] xe_migrate_sanity_kunit =============
[14:52:00] ================== xe_validate_ccs_kunit  ==================
[14:52:00] ============= [SKIPPED] xe_validate_ccs_kunit ==============
[14:52:00] =================== [SKIPPED] xe_migrate ===================
[14:52:00] ================== xe_dma_buf (1 subtest) ==================
[14:52:00] ==================== xe_dma_buf_kunit  =====================
[14:52:00] ================ [SKIPPED] xe_dma_buf_kunit ================
[14:52:00] =================== [SKIPPED] xe_dma_buf ===================
[14:52:00] ================= xe_bo_shrink (1 subtest) =================
[14:52:00] =================== xe_bo_shrink_kunit  ====================
[14:52:00] =============== [SKIPPED] xe_bo_shrink_kunit ===============
[14:52:00] ================== [SKIPPED] xe_bo_shrink ==================
[14:52:00] ==================== xe_bo (2 subtests) ====================
[14:52:00] ================== xe_ccs_migrate_kunit  ===================
[14:52:00] ============== [SKIPPED] xe_ccs_migrate_kunit ==============
[14:52:00] ==================== xe_bo_evict_kunit  ====================
[14:52:00] =============== [SKIPPED] xe_bo_evict_kunit ================
[14:52:00] ===================== [SKIPPED] xe_bo ======================
[14:52:00] ==================== args (11 subtests) ====================
[14:52:00] [PASSED] count_args_test
[14:52:00] [PASSED] call_args_example
[14:52:00] [PASSED] call_args_test
[14:52:00] [PASSED] drop_first_arg_example
[14:52:00] [PASSED] drop_first_arg_test
[14:52:00] [PASSED] first_arg_example
[14:52:00] [PASSED] first_arg_test
[14:52:00] [PASSED] last_arg_example
[14:52:00] [PASSED] last_arg_test
[14:52:00] [PASSED] pick_arg_example
[14:52:00] [PASSED] sep_comma_example
[14:52:00] ====================== [PASSED] args =======================
[14:52:00] =================== xe_pci (3 subtests) ====================
[14:52:00] ==================== check_graphics_ip  ====================
[14:52:00] [PASSED] 12.00 Xe_LP
[14:52:00] [PASSED] 12.10 Xe_LP+
[14:52:00] [PASSED] 12.55 Xe_HPG
[14:52:00] [PASSED] 12.60 Xe_HPC
[14:52:00] [PASSED] 12.70 Xe_LPG
[14:52:00] [PASSED] 12.71 Xe_LPG
[14:52:00] [PASSED] 12.74 Xe_LPG+
[14:52:00] [PASSED] 20.01 Xe2_HPG
[14:52:00] [PASSED] 20.02 Xe2_HPG
[14:52:00] [PASSED] 20.04 Xe2_LPG
[14:52:00] [PASSED] 30.00 Xe3_LPG
[14:52:00] [PASSED] 30.01 Xe3_LPG
[14:52:00] [PASSED] 30.03 Xe3_LPG
[14:52:00] ================ [PASSED] check_graphics_ip ================
[14:52:00] ===================== check_media_ip  ======================
[14:52:00] [PASSED] 12.00 Xe_M
[14:52:00] [PASSED] 12.55 Xe_HPM
[14:52:00] [PASSED] 13.00 Xe_LPM+
[14:52:00] [PASSED] 13.01 Xe2_HPM
[14:52:00] [PASSED] 20.00 Xe2_LPM
[14:52:00] [PASSED] 30.00 Xe3_LPM
[14:52:00] [PASSED] 30.02 Xe3_LPM
[14:52:00] ================= [PASSED] check_media_ip ==================
[14:52:00] ================= check_platform_gt_count  =================
[14:52:00] [PASSED] 0x9A60 (TIGERLAKE)
[14:52:00] [PASSED] 0x9A68 (TIGERLAKE)
[14:52:00] [PASSED] 0x9A70 (TIGERLAKE)
[14:52:00] [PASSED] 0x9A40 (TIGERLAKE)
[14:52:00] [PASSED] 0x9A49 (TIGERLAKE)
[14:52:00] [PASSED] 0x9A59 (TIGERLAKE)
[14:52:00] [PASSED] 0x9A78 (TIGERLAKE)
[14:52:00] [PASSED] 0x9AC0 (TIGERLAKE)
[14:52:00] [PASSED] 0x9AC9 (TIGERLAKE)
[14:52:00] [PASSED] 0x9AD9 (TIGERLAKE)
[14:52:00] [PASSED] 0x9AF8 (TIGERLAKE)
[14:52:00] [PASSED] 0x4C80 (ROCKETLAKE)
[14:52:00] [PASSED] 0x4C8A (ROCKETLAKE)
[14:52:00] [PASSED] 0x4C8B (ROCKETLAKE)
[14:52:00] [PASSED] 0x4C8C (ROCKETLAKE)
[14:52:00] [PASSED] 0x4C90 (ROCKETLAKE)
[14:52:00] [PASSED] 0x4C9A (ROCKETLAKE)
[14:52:00] [PASSED] 0x4680 (ALDERLAKE_S)
[14:52:00] [PASSED] 0x4682 (ALDERLAKE_S)
[14:52:00] [PASSED] 0x4688 (ALDERLAKE_S)
[14:52:00] [PASSED] 0x468A (ALDERLAKE_S)
[14:52:00] [PASSED] 0x468B (ALDERLAKE_S)
[14:52:00] [PASSED] 0x4690 (ALDERLAKE_S)
[14:52:00] [PASSED] 0x4692 (ALDERLAKE_S)
[14:52:00] [PASSED] 0x4693 (ALDERLAKE_S)
[14:52:00] [PASSED] 0x46A0 (ALDERLAKE_P)
[14:52:00] [PASSED] 0x46A1 (ALDERLAKE_P)
[14:52:00] [PASSED] 0x46A2 (ALDERLAKE_P)
[14:52:00] [PASSED] 0x46A3 (ALDERLAKE_P)
[14:52:00] [PASSED] 0x46A6 (ALDERLAKE_P)
[14:52:00] [PASSED] 0x46A8 (ALDERLAKE_P)
[14:52:00] [PASSED] 0x46AA (ALDERLAKE_P)
[14:52:00] [PASSED] 0x462A (ALDERLAKE_P)
[14:52:00] [PASSED] 0x4626 (ALDERLAKE_P)
[14:52:00] [PASSED] 0x4628 (ALDERLAKE_P)
[14:52:00] [PASSED] 0x46B0 (ALDERLAKE_P)
[14:52:00] [PASSED] 0x46B1 (ALDERLAKE_P)
[14:52:00] [PASSED] 0x46B2 (ALDERLAKE_P)
[14:52:00] [PASSED] 0x46B3 (ALDERLAKE_P)
[14:52:00] [PASSED] 0x46C0 (ALDERLAKE_P)
[14:52:00] [PASSED] 0x46C1 (ALDERLAKE_P)
[14:52:00] [PASSED] 0x46C2 (ALDERLAKE_P)
[14:52:00] [PASSED] 0x46C3 (ALDERLAKE_P)
[14:52:00] [PASSED] 0x46D0 (ALDERLAKE_N)
[14:52:00] [PASSED] 0x46D1 (ALDERLAKE_N)
[14:52:00] [PASSED] 0x46D2 (ALDERLAKE_N)
[14:52:00] [PASSED] 0x46D3 (ALDERLAKE_N)
[14:52:00] [PASSED] 0x46D4 (ALDERLAKE_N)
[14:52:00] [PASSED] 0xA721 (ALDERLAKE_P)
[14:52:00] [PASSED] 0xA7A1 (ALDERLAKE_P)
[14:52:00] [PASSED] 0xA7A9 (ALDERLAKE_P)
[14:52:00] [PASSED] 0xA7AC (ALDERLAKE_P)
[14:52:00] [PASSED] 0xA7AD (ALDERLAKE_P)
[14:52:00] [PASSED] 0xA720 (ALDERLAKE_P)
[14:52:00] [PASSED] 0xA7A0 (ALDERLAKE_P)
[14:52:00] [PASSED] 0xA7A8 (ALDERLAKE_P)
[14:52:00] [PASSED] 0xA7AA (ALDERLAKE_P)
[14:52:00] [PASSED] 0xA7AB (ALDERLAKE_P)
[14:52:00] [PASSED] 0xA780 (ALDERLAKE_S)
[14:52:00] [PASSED] 0xA781 (ALDERLAKE_S)
[14:52:00] [PASSED] 0xA782 (ALDERLAKE_S)
[14:52:00] [PASSED] 0xA783 (ALDERLAKE_S)
[14:52:00] [PASSED] 0xA788 (ALDERLAKE_S)
[14:52:00] [PASSED] 0xA789 (ALDERLAKE_S)
[14:52:00] [PASSED] 0xA78A (ALDERLAKE_S)
[14:52:00] [PASSED] 0xA78B (ALDERLAKE_S)
[14:52:00] [PASSED] 0x4905 (DG1)
[14:52:00] [PASSED] 0x4906 (DG1)
[14:52:00] [PASSED] 0x4907 (DG1)
[14:52:00] [PASSED] 0x4908 (DG1)
[14:52:00] [PASSED] 0x4909 (DG1)
[14:52:00] [PASSED] 0x56C0 (DG2)
[14:52:00] [PASSED] 0x56C2 (DG2)
[14:52:00] [PASSED] 0x56C1 (DG2)
[14:52:00] [PASSED] 0x7D51 (METEORLAKE)
[14:52:00] [PASSED] 0x7DD1 (METEORLAKE)
[14:52:00] [PASSED] 0x7D41 (METEORLAKE)
[14:52:00] [PASSED] 0x7D67 (METEORLAKE)
[14:52:00] [PASSED] 0xB640 (METEORLAKE)
[14:52:00] [PASSED] 0x56A0 (DG2)
[14:52:00] [PASSED] 0x56A1 (DG2)
[14:52:00] [PASSED] 0x56A2 (DG2)
[14:52:00] [PASSED] 0x56BE (DG2)
[14:52:00] [PASSED] 0x56BF (DG2)
[14:52:00] [PASSED] 0x5690 (DG2)
[14:52:00] [PASSED] 0x5691 (DG2)
[14:52:00] [PASSED] 0x5692 (DG2)
[14:52:00] [PASSED] 0x56A5 (DG2)
[14:52:00] [PASSED] 0x56A6 (DG2)
[14:52:00] [PASSED] 0x56B0 (DG2)
[14:52:00] [PASSED] 0x56B1 (DG2)
[14:52:00] [PASSED] 0x56BA (DG2)
[14:52:00] [PASSED] 0x56BB (DG2)
[14:52:00] [PASSED] 0x56BC (DG2)
[14:52:00] [PASSED] 0x56BD (DG2)
[14:52:00] [PASSED] 0x5693 (DG2)
[14:52:00] [PASSED] 0x5694 (DG2)
[14:52:00] [PASSED] 0x5695 (DG2)
[14:52:00] [PASSED] 0x56A3 (DG2)
[14:52:00] [PASSED] 0x56A4 (DG2)
[14:52:00] [PASSED] 0x56B2 (DG2)
[14:52:00] [PASSED] 0x56B3 (DG2)
[14:52:00] [PASSED] 0x5696 (DG2)
[14:52:00] [PASSED] 0x5697 (DG2)
[14:52:00] [PASSED] 0xB69 (PVC)
[14:52:00] [PASSED] 0xB6E (PVC)
[14:52:00] [PASSED] 0xBD4 (PVC)
[14:52:00] [PASSED] 0xBD5 (PVC)
[14:52:00] [PASSED] 0xBD6 (PVC)
[14:52:00] [PASSED] 0xBD7 (PVC)
[14:52:00] [PASSED] 0xBD8 (PVC)
[14:52:00] [PASSED] 0xBD9 (PVC)
[14:52:00] [PASSED] 0xBDA (PVC)
[14:52:00] [PASSED] 0xBDB (PVC)
[14:52:00] [PASSED] 0xBE0 (PVC)
[14:52:00] [PASSED] 0xBE1 (PVC)
[14:52:00] [PASSED] 0xBE5 (PVC)
[14:52:00] [PASSED] 0x7D40 (METEORLAKE)
[14:52:00] [PASSED] 0x7D45 (METEORLAKE)
[14:52:00] [PASSED] 0x7D55 (METEORLAKE)
[14:52:00] [PASSED] 0x7D60 (METEORLAKE)
[14:52:00] [PASSED] 0x7DD5 (METEORLAKE)
[14:52:00] [PASSED] 0x6420 (LUNARLAKE)
[14:52:00] [PASSED] 0x64A0 (LUNARLAKE)
[14:52:00] [PASSED] 0x64B0 (LUNARLAKE)
[14:52:00] [PASSED] 0xE202 (BATTLEMAGE)
[14:52:00] [PASSED] 0xE209 (BATTLEMAGE)
[14:52:00] [PASSED] 0xE20B (BATTLEMAGE)
[14:52:00] [PASSED] 0xE20C (BATTLEMAGE)
[14:52:00] [PASSED] 0xE20D (BATTLEMAGE)
[14:52:00] [PASSED] 0xE210 (BATTLEMAGE)
[14:52:00] [PASSED] 0xE211 (BATTLEMAGE)
[14:52:00] [PASSED] 0xE212 (BATTLEMAGE)
[14:52:00] [PASSED] 0xE216 (BATTLEMAGE)
[14:52:00] [PASSED] 0xE220 (BATTLEMAGE)
[14:52:00] [PASSED] 0xE221 (BATTLEMAGE)
[14:52:00] [PASSED] 0xE222 (BATTLEMAGE)
[14:52:00] [PASSED] 0xE223 (BATTLEMAGE)
[14:52:00] [PASSED] 0xB080 (PANTHERLAKE)
[14:52:00] [PASSED] 0xB081 (PANTHERLAKE)
[14:52:00] [PASSED] 0xB082 (PANTHERLAKE)
[14:52:00] [PASSED] 0xB083 (PANTHERLAKE)
[14:52:00] [PASSED] 0xB084 (PANTHERLAKE)
[14:52:00] [PASSED] 0xB085 (PANTHERLAKE)
[14:52:00] [PASSED] 0xB086 (PANTHERLAKE)
[14:52:00] [PASSED] 0xB087 (PANTHERLAKE)
[14:52:00] [PASSED] 0xB08F (PANTHERLAKE)
[14:52:00] [PASSED] 0xB090 (PANTHERLAKE)
[14:52:00] [PASSED] 0xB0A0 (PANTHERLAKE)
[14:52:00] [PASSED] 0xB0B0 (PANTHERLAKE)
[14:52:00] [PASSED] 0xFD80 (PANTHERLAKE)
[14:52:00] [PASSED] 0xFD81 (PANTHERLAKE)
[14:52:00] ============= [PASSED] check_platform_gt_count =============
[14:52:00] ===================== [PASSED] xe_pci ======================
[14:52:00] =================== xe_rtp (2 subtests) ====================
[14:52:00] =============== xe_rtp_process_to_sr_tests  ================
[14:52:00] [PASSED] coalesce-same-reg
[14:52:00] [PASSED] no-match-no-add
[14:52:00] [PASSED] match-or
[14:52:00] [PASSED] match-or-xfail
[14:52:00] [PASSED] no-match-no-add-multiple-rules
[14:52:00] [PASSED] two-regs-two-entries
[14:52:00] [PASSED] clr-one-set-other
[14:52:00] [PASSED] set-field
[14:52:00] [PASSED] conflict-duplicate
[14:52:00] [PASSED] conflict-not-disjoint
[14:52:00] [PASSED] conflict-reg-type
[14:52:00] =========== [PASSED] xe_rtp_process_to_sr_tests ============
[14:52:00] ================== xe_rtp_process_tests  ===================
[14:52:00] [PASSED] active1
[14:52:00] [PASSED] active2
[14:52:00] [PASSED] active-inactive
[14:52:00] [PASSED] inactive-active
[14:52:00] [PASSED] inactive-1st_or_active-inactive
[14:52:00] [PASSED] inactive-2nd_or_active-inactive
[14:52:00] [PASSED] inactive-last_or_active-inactive
[14:52:00] [PASSED] inactive-no_or_active-inactive
[14:52:00] ============== [PASSED] xe_rtp_process_tests ===============
[14:52:00] ===================== [PASSED] xe_rtp ======================
[14:52:00] ==================== xe_wa (1 subtest) =====================
[14:52:00] ======================== xe_wa_gt  =========================
[14:52:00] [PASSED] TIGERLAKE B0
[14:52:00] [PASSED] DG1 A0
[14:52:00] [PASSED] DG1 B0
[14:52:00] [PASSED] ALDERLAKE_S A0
[14:52:00] [PASSED] ALDERLAKE_S B0
stty: 'standard input': Inappropriate ioctl for device
[14:52:00] [PASSED] ALDERLAKE_S C0
[14:52:00] [PASSED] ALDERLAKE_S D0
[14:52:00] [PASSED] ALDERLAKE_P A0
[14:52:00] [PASSED] ALDERLAKE_P B0
[14:52:00] [PASSED] ALDERLAKE_P C0
[14:52:00] [PASSED] ALDERLAKE_S RPLS D0
[14:52:00] [PASSED] ALDERLAKE_P RPLU E0
[14:52:00] [PASSED] DG2 G10 C0
[14:52:00] [PASSED] DG2 G11 B1
[14:52:00] [PASSED] DG2 G12 A1
[14:52:00] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0
[14:52:00] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0
[14:52:00] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0
[14:52:00] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0
[14:52:00] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0
[14:52:00] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1
[14:52:00] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0
[14:52:00] ==================== [PASSED] xe_wa_gt =====================
[14:52:00] ====================== [PASSED] xe_wa ======================
[14:52:00] ============================================================
[14:52:00] Testing complete. Ran 306 tests: passed: 288, skipped: 18
[14:52:00] Elapsed time: 33.707s total, 4.294s configuring, 29.046s building, 0.320s running

+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig
[14:52:00] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[14:52:02] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[14:52:26] Starting KUnit Kernel (1/1)...
[14:52:26] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[14:52:26] ============ drm_test_pick_cmdline (2 subtests) ============
[14:52:26] [PASSED] drm_test_pick_cmdline_res_1920_1080_60
[14:52:26] =============== drm_test_pick_cmdline_named  ===============
[14:52:26] [PASSED] NTSC
[14:52:26] [PASSED] NTSC-J
[14:52:26] [PASSED] PAL
[14:52:26] [PASSED] PAL-M
[14:52:26] =========== [PASSED] drm_test_pick_cmdline_named ===========
[14:52:26] ============== [PASSED] drm_test_pick_cmdline ==============
[14:52:26] == drm_test_atomic_get_connector_for_encoder (1 subtest) ===
[14:52:26] [PASSED] drm_test_drm_atomic_get_connector_for_encoder
[14:52:26] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ====
[14:52:26] =========== drm_validate_clone_mode (2 subtests) ===========
[14:52:26] ============== drm_test_check_in_clone_mode  ===============
[14:52:26] [PASSED] in_clone_mode
[14:52:26] [PASSED] not_in_clone_mode
[14:52:26] ========== [PASSED] drm_test_check_in_clone_mode ===========
[14:52:26] =============== drm_test_check_valid_clones  ===============
[14:52:26] [PASSED] not_in_clone_mode
[14:52:26] [PASSED] valid_clone
[14:52:26] [PASSED] invalid_clone
[14:52:26] =========== [PASSED] drm_test_check_valid_clones ===========
[14:52:26] ============= [PASSED] drm_validate_clone_mode =============
[14:52:26] ============= drm_validate_modeset (1 subtest) =============
[14:52:26] [PASSED] drm_test_check_connector_changed_modeset
[14:52:26] ============== [PASSED] drm_validate_modeset ===============
[14:52:26] ====== drm_test_bridge_get_current_state (2 subtests) ======
[14:52:26] [PASSED] drm_test_drm_bridge_get_current_state_atomic
[14:52:26] [PASSED] drm_test_drm_bridge_get_current_state_legacy
[14:52:26] ======== [PASSED] drm_test_bridge_get_current_state ========
[14:52:26] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ======
[14:52:26] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic
[14:52:26] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled
[14:52:26] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy
[14:52:26] ======== [PASSED] drm_test_bridge_helper_reset_crtc ========
[14:52:26] ============== drm_bridge_alloc (2 subtests) ===============
[14:52:26] [PASSED] drm_test_drm_bridge_alloc_basic
[14:52:26] [PASSED] drm_test_drm_bridge_alloc_get_put
[14:52:26] ================ [PASSED] drm_bridge_alloc =================
[14:52:26] ================== drm_buddy (8 subtests) ==================
[14:52:26] [PASSED] drm_test_buddy_alloc_limit
[14:52:26] [PASSED] drm_test_buddy_alloc_optimistic
[14:52:26] [PASSED] drm_test_buddy_alloc_pessimistic
[14:52:26] [PASSED] drm_test_buddy_alloc_pathological
[14:52:26] [PASSED] drm_test_buddy_alloc_contiguous
[14:52:26] [PASSED] drm_test_buddy_alloc_clear
[14:52:26] [PASSED] drm_test_buddy_alloc_range_bias
[14:52:26] [PASSED] drm_test_buddy_fragmentation_performance
[14:52:26] ==================== [PASSED] drm_buddy ====================
[14:52:26] ============= drm_cmdline_parser (40 subtests) =============
[14:52:26] [PASSED] drm_test_cmdline_force_d_only
[14:52:26] [PASSED] drm_test_cmdline_force_D_only_dvi
[14:52:26] [PASSED] drm_test_cmdline_force_D_only_hdmi
[14:52:26] [PASSED] drm_test_cmdline_force_D_only_not_digital
[14:52:26] [PASSED] drm_test_cmdline_force_e_only
[14:52:26] [PASSED] drm_test_cmdline_res
[14:52:26] [PASSED] drm_test_cmdline_res_vesa
[14:52:26] [PASSED] drm_test_cmdline_res_vesa_rblank
[14:52:26] [PASSED] drm_test_cmdline_res_rblank
[14:52:26] [PASSED] drm_test_cmdline_res_bpp
[14:52:26] [PASSED] drm_test_cmdline_res_refresh
[14:52:26] [PASSED] drm_test_cmdline_res_bpp_refresh
[14:52:26] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[14:52:26] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[14:52:26] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[14:52:26] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[14:52:26] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[14:52:26] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[14:52:26] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[14:52:26] [PASSED] drm_test_cmdline_res_margins_force_on
[14:52:26] [PASSED] drm_test_cmdline_res_vesa_margins
[14:52:26] [PASSED] drm_test_cmdline_name
[14:52:26] [PASSED] drm_test_cmdline_name_bpp
[14:52:26] [PASSED] drm_test_cmdline_name_option
[14:52:26] [PASSED] drm_test_cmdline_name_bpp_option
[14:52:26] [PASSED] drm_test_cmdline_rotate_0
[14:52:26] [PASSED] drm_test_cmdline_rotate_90
[14:52:26] [PASSED] drm_test_cmdline_rotate_180
[14:52:26] [PASSED] drm_test_cmdline_rotate_270
[14:52:26] [PASSED] drm_test_cmdline_hmirror
[14:52:26] [PASSED] drm_test_cmdline_vmirror
[14:52:26] [PASSED] drm_test_cmdline_margin_options
[14:52:26] [PASSED] drm_test_cmdline_multiple_options
[14:52:26] [PASSED] drm_test_cmdline_bpp_extra_and_option
[14:52:26] [PASSED] drm_test_cmdline_extra_and_option
[14:52:26] [PASSED] drm_test_cmdline_freestanding_options
[14:52:26] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[14:52:26] [PASSED] drm_test_cmdline_panel_orientation
[14:52:26] ================ drm_test_cmdline_invalid  =================
[14:52:26] [PASSED] margin_only
[14:52:26] [PASSED] interlace_only
[14:52:26] [PASSED] res_missing_x
[14:52:26] [PASSED] res_missing_y
[14:52:26] [PASSED] res_bad_y
[14:52:26] [PASSED] res_missing_y_bpp
[14:52:26] [PASSED] res_bad_bpp
[14:52:26] [PASSED] res_bad_refresh
[14:52:26] [PASSED] res_bpp_refresh_force_on_off
[14:52:26] [PASSED] res_invalid_mode
[14:52:26] [PASSED] res_bpp_wrong_place_mode
[14:52:26] [PASSED] name_bpp_refresh
[14:52:26] [PASSED] name_refresh
[14:52:26] [PASSED] name_refresh_wrong_mode
[14:52:26] [PASSED] name_refresh_invalid_mode
[14:52:26] [PASSED] rotate_multiple
[14:52:26] [PASSED] rotate_invalid_val
[14:52:26] [PASSED] rotate_truncated
[14:52:26] [PASSED] invalid_option
[14:52:26] [PASSED] invalid_tv_option
[14:52:26] [PASSED] truncated_tv_option
[14:52:26] ============ [PASSED] drm_test_cmdline_invalid =============
[14:52:26] =============== drm_test_cmdline_tv_options  ===============
[14:52:26] [PASSED] NTSC
[14:52:26] [PASSED] NTSC_443
[14:52:26] [PASSED] NTSC_J
[14:52:26] [PASSED] PAL
[14:52:26] [PASSED] PAL_M
[14:52:26] [PASSED] PAL_N
[14:52:26] [PASSED] SECAM
[14:52:26] [PASSED] MONO_525
[14:52:26] [PASSED] MONO_625
[14:52:26] =========== [PASSED] drm_test_cmdline_tv_options ===========
[14:52:26] =============== [PASSED] drm_cmdline_parser ================
[14:52:26] ========== drmm_connector_hdmi_init (20 subtests) ==========
[14:52:26] [PASSED] drm_test_connector_hdmi_init_valid
[14:52:26] [PASSED] drm_test_connector_hdmi_init_bpc_8
[14:52:26] [PASSED] drm_test_connector_hdmi_init_bpc_10
[14:52:26] [PASSED] drm_test_connector_hdmi_init_bpc_12
[14:52:26] [PASSED] drm_test_connector_hdmi_init_bpc_invalid
[14:52:26] [PASSED] drm_test_connector_hdmi_init_bpc_null
[14:52:26] [PASSED] drm_test_connector_hdmi_init_formats_empty
[14:52:26] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb
[14:52:26] === drm_test_connector_hdmi_init_formats_yuv420_allowed  ===
[14:52:26] [PASSED] supported_formats=0x9 yuv420_allowed=1
[14:52:26] [PASSED] supported_formats=0x9 yuv420_allowed=0
[14:52:26] [PASSED] supported_formats=0x3 yuv420_allowed=1
[14:52:26] [PASSED] supported_formats=0x3 yuv420_allowed=0
[14:52:26] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[14:52:26] [PASSED] drm_test_connector_hdmi_init_null_ddc
[14:52:26] [PASSED] drm_test_connector_hdmi_init_null_product
[14:52:26] [PASSED] drm_test_connector_hdmi_init_null_vendor
[14:52:26] [PASSED] drm_test_connector_hdmi_init_product_length_exact
[14:52:26] [PASSED] drm_test_connector_hdmi_init_product_length_too_long
[14:52:26] [PASSED] drm_test_connector_hdmi_init_product_valid
[14:52:26] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact
[14:52:26] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long
[14:52:26] [PASSED] drm_test_connector_hdmi_init_vendor_valid
[14:52:26] ========= drm_test_connector_hdmi_init_type_valid  =========
[14:52:26] [PASSED] HDMI-A
[14:52:26] [PASSED] HDMI-B
[14:52:26] ===== [PASSED] drm_test_connector_hdmi_init_type_valid =====
[14:52:26] ======== drm_test_connector_hdmi_init_type_invalid  ========
[14:52:26] [PASSED] Unknown
[14:52:26] [PASSED] VGA
[14:52:26] [PASSED] DVI-I
[14:52:26] [PASSED] DVI-D
[14:52:26] [PASSED] DVI-A
[14:52:26] [PASSED] Composite
[14:52:26] [PASSED] SVIDEO
[14:52:26] [PASSED] LVDS
[14:52:26] [PASSED] Component
[14:52:26] [PASSED] DIN
[14:52:26] [PASSED] DP
[14:52:26] [PASSED] TV
[14:52:26] [PASSED] eDP
[14:52:26] [PASSED] Virtual
[14:52:26] [PASSED] DSI
[14:52:26] [PASSED] DPI
[14:52:26] [PASSED] Writeback
[14:52:26] [PASSED] SPI
[14:52:26] [PASSED] USB
[14:52:26] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ====
[14:52:26] ============ [PASSED] drmm_connector_hdmi_init =============
[14:52:26] ============= drmm_connector_init (3 subtests) =============
[14:52:26] [PASSED] drm_test_drmm_connector_init
[14:52:26] [PASSED] drm_test_drmm_connector_init_null_ddc
[14:52:26] ========= drm_test_drmm_connector_init_type_valid  =========
[14:52:26] [PASSED] Unknown
[14:52:26] [PASSED] VGA
[14:52:26] [PASSED] DVI-I
[14:52:26] [PASSED] DVI-D
[14:52:26] [PASSED] DVI-A
[14:52:26] [PASSED] Composite
[14:52:26] [PASSED] SVIDEO
[14:52:26] [PASSED] LVDS
[14:52:26] [PASSED] Component
[14:52:26] [PASSED] DIN
[14:52:26] [PASSED] DP
[14:52:26] [PASSED] HDMI-A
[14:52:26] [PASSED] HDMI-B
[14:52:26] [PASSED] TV
[14:52:26] [PASSED] eDP
[14:52:26] [PASSED] Virtual
[14:52:26] [PASSED] DSI
[14:52:26] [PASSED] DPI
[14:52:26] [PASSED] Writeback
[14:52:26] [PASSED] SPI
[14:52:26] [PASSED] USB
[14:52:26] ===== [PASSED] drm_test_drmm_connector_init_type_valid =====
[14:52:26] =============== [PASSED] drmm_connector_init ===============
[14:52:26] ========= drm_connector_dynamic_init (6 subtests) ==========
[14:52:26] [PASSED] drm_test_drm_connector_dynamic_init
[14:52:26] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc
[14:52:26] [PASSED] drm_test_drm_connector_dynamic_init_not_added
[14:52:26] [PASSED] drm_test_drm_connector_dynamic_init_properties
[14:52:26] ===== drm_test_drm_connector_dynamic_init_type_valid  ======
[14:52:26] [PASSED] Unknown
[14:52:26] [PASSED] VGA
[14:52:26] [PASSED] DVI-I
[14:52:26] [PASSED] DVI-D
[14:52:26] [PASSED] DVI-A
[14:52:26] [PASSED] Composite
[14:52:26] [PASSED] SVIDEO
[14:52:26] [PASSED] LVDS
[14:52:26] [PASSED] Component
[14:52:26] [PASSED] DIN
[14:52:26] [PASSED] DP
[14:52:26] [PASSED] HDMI-A
[14:52:26] [PASSED] HDMI-B
[14:52:26] [PASSED] TV
[14:52:26] [PASSED] eDP
[14:52:26] [PASSED] Virtual
[14:52:26] [PASSED] DSI
[14:52:26] [PASSED] DPI
[14:52:26] [PASSED] Writeback
[14:52:26] [PASSED] SPI
[14:52:26] [PASSED] USB
[14:52:26] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid ==
[14:52:26] ======== drm_test_drm_connector_dynamic_init_name  =========
[14:52:26] [PASSED] Unknown
[14:52:26] [PASSED] VGA
[14:52:26] [PASSED] DVI-I
[14:52:26] [PASSED] DVI-D
[14:52:26] [PASSED] DVI-A
[14:52:26] [PASSED] Composite
[14:52:26] [PASSED] SVIDEO
[14:52:26] [PASSED] LVDS
[14:52:26] [PASSED] Component
[14:52:26] [PASSED] DIN
[14:52:26] [PASSED] DP
[14:52:26] [PASSED] HDMI-A
[14:52:26] [PASSED] HDMI-B
[14:52:26] [PASSED] TV
[14:52:26] [PASSED] eDP
[14:52:26] [PASSED] Virtual
[14:52:26] [PASSED] DSI
[14:52:26] [PASSED] DPI
[14:52:26] [PASSED] Writeback
[14:52:26] [PASSED] SPI
[14:52:26] [PASSED] USB
[14:52:26] ==== [PASSED] drm_test_drm_connector_dynamic_init_name =====
[14:52:26] =========== [PASSED] drm_connector_dynamic_init ============
[14:52:26] ==== drm_connector_dynamic_register_early (4 subtests) =====
[14:52:26] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list
[14:52:26] [PASSED] drm_test_drm_connector_dynamic_register_early_defer
[14:52:26] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init
[14:52:26] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object
[14:52:26] ====== [PASSED] drm_connector_dynamic_register_early =======
[14:52:26] ======= drm_connector_dynamic_register (7 subtests) ========
[14:52:26] [PASSED] drm_test_drm_connector_dynamic_register_on_list
[14:52:26] [PASSED] drm_test_drm_connector_dynamic_register_no_defer
[14:52:26] [PASSED] drm_test_drm_connector_dynamic_register_no_init
[14:52:26] [PASSED] drm_test_drm_connector_dynamic_register_mode_object
[14:52:26] [PASSED] drm_test_drm_connector_dynamic_register_sysfs
[14:52:26] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name
[14:52:26] [PASSED] drm_test_drm_connector_dynamic_register_debugfs
[14:52:26] ========= [PASSED] drm_connector_dynamic_register ==========
[14:52:26] = drm_connector_attach_broadcast_rgb_property (2 subtests) =
[14:52:26] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property
[14:52:26] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector
[14:52:26] === [PASSED] drm_connector_attach_broadcast_rgb_property ===
[14:52:26] ========== drm_get_tv_mode_from_name (2 subtests) ==========
[14:52:26] ========== drm_test_get_tv_mode_from_name_valid  ===========
[14:52:26] [PASSED] NTSC
[14:52:26] [PASSED] NTSC-443
[14:52:26] [PASSED] NTSC-J
[14:52:26] [PASSED] PAL
[14:52:26] [PASSED] PAL-M
[14:52:26] [PASSED] PAL-N
[14:52:26] [PASSED] SECAM
[14:52:26] [PASSED] Mono
[14:52:26] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[14:52:26] [PASSED] drm_test_get_tv_mode_from_name_truncated
[14:52:26] ============ [PASSED] drm_get_tv_mode_from_name ============
[14:52:26] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) =
[14:52:26] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb
[14:52:26] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc
[14:52:26] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1
[14:52:26] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc
[14:52:26] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1
[14:52:26] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double
[14:52:26] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid  =
[14:52:26] [PASSED] VIC 96
[14:52:26] [PASSED] VIC 97
[14:52:26] [PASSED] VIC 101
[14:52:26] [PASSED] VIC 102
[14:52:26] [PASSED] VIC 106
[14:52:26] [PASSED] VIC 107
[14:52:26] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid ===
[14:52:26] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc
[14:52:26] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc
[14:52:26] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc
[14:52:26] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc
[14:52:26] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc
[14:52:26] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ====
[14:52:26] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) ==
[14:52:26] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name  ====
[14:52:26] [PASSED] Automatic
[14:52:26] [PASSED] Full
[14:52:26] [PASSED] Limited 16:235
[14:52:26] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name ===
[14:52:26] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid
[14:52:26] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ====
[14:52:26] == drm_hdmi_connector_get_output_format_name (2 subtests) ==
[14:52:26] === drm_test_drm_hdmi_connector_get_output_format_name  ====
[14:52:26] [PASSED] RGB
[14:52:26] [PASSED] YUV 4:2:0
[14:52:26] [PASSED] YUV 4:2:2
[14:52:26] [PASSED] YUV 4:4:4
[14:52:26] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name ===
[14:52:26] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid
[14:52:26] ==== [PASSED] drm_hdmi_connector_get_output_format_name ====
[14:52:26] ============= drm_damage_helper (21 subtests) ==============
[14:52:26] [PASSED] drm_test_damage_iter_no_damage
[14:52:26] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[14:52:26] [PASSED] drm_test_damage_iter_no_damage_src_moved
[14:52:26] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[14:52:26] [PASSED] drm_test_damage_iter_no_damage_not_visible
[14:52:26] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[14:52:26] [PASSED] drm_test_damage_iter_no_damage_no_fb
[14:52:26] [PASSED] drm_test_damage_iter_simple_damage
[14:52:26] [PASSED] drm_test_damage_iter_single_damage
[14:52:26] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[14:52:26] [PASSED] drm_test_damage_iter_single_damage_outside_src
[14:52:26] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[14:52:26] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[14:52:26] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[14:52:26] [PASSED] drm_test_damage_iter_single_damage_src_moved
[14:52:26] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[14:52:26] [PASSED] drm_test_damage_iter_damage
[14:52:26] [PASSED] drm_test_damage_iter_damage_one_intersect
[14:52:26] [PASSED] drm_test_damage_iter_damage_one_outside
[14:52:26] [PASSED] drm_test_damage_iter_damage_src_moved
[14:52:26] [PASSED] drm_test_damage_iter_damage_not_visible
[14:52:26] ================ [PASSED] drm_damage_helper ================
[14:52:26] ============== drm_dp_mst_helper (3 subtests) ==============
[14:52:26] ============== drm_test_dp_mst_calc_pbn_mode  ==============
[14:52:26] [PASSED] Clock 154000 BPP 30 DSC disabled
[14:52:26] [PASSED] Clock 234000 BPP 30 DSC disabled
[14:52:26] [PASSED] Clock 297000 BPP 24 DSC disabled
[14:52:26] [PASSED] Clock 332880 BPP 24 DSC enabled
[14:52:26] [PASSED] Clock 324540 BPP 24 DSC enabled
[14:52:26] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[14:52:26] ============== drm_test_dp_mst_calc_pbn_div  ===============
[14:52:26] [PASSED] Link rate 2000000 lane count 4
[14:52:26] [PASSED] Link rate 2000000 lane count 2
[14:52:26] [PASSED] Link rate 2000000 lane count 1
[14:52:26] [PASSED] Link rate 1350000 lane count 4
[14:52:26] [PASSED] Link rate 1350000 lane count 2
[14:52:26] [PASSED] Link rate 1350000 lane count 1
[14:52:26] [PASSED] Link rate 1000000 lane count 4
[14:52:26] [PASSED] Link rate 1000000 lane count 2
[14:52:26] [PASSED] Link rate 1000000 lane count 1
[14:52:26] [PASSED] Link rate 810000 lane count 4
[14:52:26] [PASSED] Link rate 810000 lane count 2
[14:52:26] [PASSED] Link rate 810000 lane count 1
[14:52:26] [PASSED] Link rate 540000 lane count 4
[14:52:26] [PASSED] Link rate 540000 lane count 2
[14:52:26] [PASSED] Link rate 540000 lane count 1
[14:52:26] [PASSED] Link rate 270000 lane count 4
[14:52:26] [PASSED] Link rate 270000 lane count 2
[14:52:26] [PASSED] Link rate 270000 lane count 1
[14:52:26] [PASSED] Link rate 162000 lane count 4
[14:52:26] [PASSED] Link rate 162000 lane count 2
[14:52:26] [PASSED] Link rate 162000 lane count 1
[14:52:26] ========== [PASSED] drm_test_dp_mst_calc_pbn_div ===========
[14:52:26] ========= drm_test_dp_mst_sideband_msg_req_decode  =========
[14:52:26] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[14:52:26] [PASSED] DP_POWER_UP_PHY with port number
[14:52:26] [PASSED] DP_POWER_DOWN_PHY with port number
[14:52:26] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[14:52:26] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[14:52:26] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[14:52:26] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[14:52:26] [PASSED] DP_QUERY_PAYLOAD with port number
[14:52:26] [PASSED] DP_QUERY_PAYLOAD with VCPI
[14:52:26] [PASSED] DP_REMOTE_DPCD_READ with port number
[14:52:26] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[14:52:26] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[14:52:26] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[14:52:26] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[14:52:26] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[14:52:26] [PASSED] DP_REMOTE_I2C_READ with port number
[14:52:26] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[14:52:26] [PASSED] DP_REMOTE_I2C_READ with transactions array
[14:52:26] [PASSED] DP_REMOTE_I2C_WRITE with port number
[14:52:26] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[14:52:26] [PASSED] DP_REMOTE_I2C_WRITE with data array
[14:52:26] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[14:52:26] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[14:52:26] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[14:52:26] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[14:52:26] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[14:52:26] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[14:52:26] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[14:52:26] ================ [PASSED] drm_dp_mst_helper ================
[14:52:26] ================== drm_exec (7 subtests) ===================
[14:52:26] [PASSED] sanitycheck
[14:52:26] [PASSED] test_lock
[14:52:26] [PASSED] test_lock_unlock
[14:52:26] [PASSED] test_duplicates
[14:52:26] [PASSED] test_prepare
[14:52:26] [PASSED] test_prepare_array
[14:52:26] [PASSED] test_multiple_loops
[14:52:26] ==================== [PASSED] drm_exec =====================
[14:52:26] =========== drm_format_helper_test (17 subtests) ===========
[14:52:26] ============== drm_test_fb_xrgb8888_to_gray8  ==============
[14:52:26] [PASSED] single_pixel_source_buffer
[14:52:26] [PASSED] single_pixel_clip_rectangle
[14:52:26] [PASSED] well_known_colors
[14:52:26] [PASSED] destination_pitch
[14:52:26] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ==========
[14:52:26] ============= drm_test_fb_xrgb8888_to_rgb332  ==============
[14:52:26] [PASSED] single_pixel_source_buffer
[14:52:26] [PASSED] single_pixel_clip_rectangle
[14:52:26] [PASSED] well_known_colors
[14:52:26] [PASSED] destination_pitch
[14:52:26] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[14:52:26] ============= drm_test_fb_xrgb8888_to_rgb565  ==============
[14:52:26] [PASSED] single_pixel_source_buffer
[14:52:26] [PASSED] single_pixel_clip_rectangle
[14:52:26] [PASSED] well_known_colors
[14:52:26] [PASSED] destination_pitch
[14:52:26] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[14:52:26] ============ drm_test_fb_xrgb8888_to_xrgb1555  =============
[14:52:26] [PASSED] single_pixel_source_buffer
[14:52:26] [PASSED] single_pixel_clip_rectangle
[14:52:26] [PASSED] well_known_colors
[14:52:26] [PASSED] destination_pitch
[14:52:26] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[14:52:26] ============ drm_test_fb_xrgb8888_to_argb1555  =============
[14:52:26] [PASSED] single_pixel_source_buffer
[14:52:26] [PASSED] single_pixel_clip_rectangle
[14:52:26] [PASSED] well_known_colors
[14:52:26] [PASSED] destination_pitch
[14:52:26] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[14:52:26] ============ drm_test_fb_xrgb8888_to_rgba5551  =============
[14:52:26] [PASSED] single_pixel_source_buffer
[14:52:26] [PASSED] single_pixel_clip_rectangle
[14:52:26] [PASSED] well_known_colors
[14:52:26] [PASSED] destination_pitch
[14:52:26] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[14:52:26] ============= drm_test_fb_xrgb8888_to_rgb888  ==============
[14:52:26] [PASSED] single_pixel_source_buffer
[14:52:26] [PASSED] single_pixel_clip_rectangle
[14:52:26] [PASSED] well_known_colors
[14:52:26] [PASSED] destination_pitch
[14:52:26] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[14:52:26] ============= drm_test_fb_xrgb8888_to_bgr888  ==============
[14:52:26] [PASSED] single_pixel_source_buffer
[14:52:26] [PASSED] single_pixel_clip_rectangle
[14:52:26] [PASSED] well_known_colors
[14:52:26] [PASSED] destination_pitch
[14:52:26] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ==========
[14:52:26] ============ drm_test_fb_xrgb8888_to_argb8888  =============
[14:52:26] [PASSED] single_pixel_source_buffer
[14:52:26] [PASSED] single_pixel_clip_rectangle
[14:52:26] [PASSED] well_known_colors
[14:52:26] [PASSED] destination_pitch
[14:52:26] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[14:52:26] =========== drm_test_fb_xrgb8888_to_xrgb2101010  ===========
[14:52:26] [PASSED] single_pixel_source_buffer
[14:52:26] [PASSED] single_pixel_clip_rectangle
[14:52:26] [PASSED] well_known_colors
[14:52:26] [PASSED] destination_pitch
[14:52:26] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[14:52:26] =========== drm_test_fb_xrgb8888_to_argb2101010  ===========
[14:52:26] [PASSED] single_pixel_source_buffer
[14:52:26] [PASSED] single_pixel_clip_rectangle
[14:52:26] [PASSED] well_known_colors
[14:52:26] [PASSED] destination_pitch
[14:52:26] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[14:52:26] ============== drm_test_fb_xrgb8888_to_mono  ===============
[14:52:26] [PASSED] single_pixel_source_buffer
[14:52:26] [PASSED] single_pixel_clip_rectangle
[14:52:26] [PASSED] well_known_colors
[14:52:26] [PASSED] destination_pitch
[14:52:26] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[14:52:26] ==================== drm_test_fb_swab  =====================
[14:52:26] [PASSED] single_pixel_source_buffer
[14:52:26] [PASSED] single_pixel_clip_rectangle
[14:52:26] [PASSED] well_known_colors
[14:52:26] [PASSED] destination_pitch
[14:52:26] ================ [PASSED] drm_test_fb_swab =================
[14:52:26] ============ drm_test_fb_xrgb8888_to_xbgr8888  =============
[14:52:26] [PASSED] single_pixel_source_buffer
[14:52:26] [PASSED] single_pixel_clip_rectangle
[14:52:26] [PASSED] well_known_colors
[14:52:26] [PASSED] destination_pitch
[14:52:26] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 =========
[14:52:26] ============ drm_test_fb_xrgb8888_to_abgr8888  =============
[14:52:26] [PASSED] single_pixel_source_buffer
[14:52:26] [PASSED] single_pixel_clip_rectangle
[14:52:26] [PASSED] well_known_colors
[14:52:26] [PASSED] destination_pitch
[14:52:26] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 =========
[14:52:26] ================= drm_test_fb_clip_offset  =================
[14:52:26] [PASSED] pass through
[14:52:26] [PASSED] horizontal offset
[14:52:26] [PASSED] vertical offset
[14:52:26] [PASSED] horizontal and vertical offset
[14:52:26] [PASSED] horizontal offset (custom pitch)
[14:52:26] [PASSED] vertical offset (custom pitch)
[14:52:26] [PASSED] horizontal and vertical offset (custom pitch)
[14:52:26] ============= [PASSED] drm_test_fb_clip_offset =============
[14:52:26] =================== drm_test_fb_memcpy  ====================
[14:52:26] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[14:52:26] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[14:52:26] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[14:52:26] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[14:52:26] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[14:52:26] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[14:52:26] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[14:52:26] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[14:52:26] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[14:52:26] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[14:52:26] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[14:52:26] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[14:52:26] =============== [PASSED] drm_test_fb_memcpy ================
[14:52:26] ============= [PASSED] drm_format_helper_test ==============
[14:52:26] ================= drm_format (18 subtests) =================
[14:52:26] [PASSED] drm_test_format_block_width_invalid
[14:52:26] [PASSED] drm_test_format_block_width_one_plane
[14:52:26] [PASSED] drm_test_format_block_width_two_plane
[14:52:26] [PASSED] drm_test_format_block_width_three_plane
[14:52:26] [PASSED] drm_test_format_block_width_tiled
[14:52:26] [PASSED] drm_test_format_block_height_invalid
[14:52:26] [PASSED] drm_test_format_block_height_one_plane
[14:52:26] [PASSED] drm_test_format_block_height_two_plane
[14:52:26] [PASSED] drm_test_format_block_height_three_plane
[14:52:26] [PASSED] drm_test_format_block_height_tiled
[14:52:26] [PASSED] drm_test_format_min_pitch_invalid
[14:52:26] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[14:52:26] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[14:52:26] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[14:52:26] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[14:52:26] [PASSED] drm_test_format_min_pitch_two_plane
[14:52:26] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[14:52:26] [PASSED] drm_test_format_min_pitch_tiled
[14:52:26] =================== [PASSED] drm_format ====================
[14:52:26] ============== drm_framebuffer (10 subtests) ===============
[14:52:26] ========== drm_test_framebuffer_check_src_coords  ==========
[14:52:26] [PASSED] Success: source fits into fb
[14:52:26] [PASSED] Fail: overflowing fb with x-axis coordinate
[14:52:26] [PASSED] Fail: overflowing fb with y-axis coordinate
[14:52:26] [PASSED] Fail: overflowing fb with source width
[14:52:26] [PASSED] Fail: overflowing fb with source height
[14:52:26] ====== [PASSED] drm_test_framebuffer_check_src_coords ======
[14:52:26] [PASSED] drm_test_framebuffer_cleanup
[14:52:26] =============== drm_test_framebuffer_create  ===============
[14:52:26] [PASSED] ABGR8888 normal sizes
[14:52:26] [PASSED] ABGR8888 max sizes
[14:52:26] [PASSED] ABGR8888 pitch greater than min required
[14:52:26] [PASSED] ABGR8888 pitch less than min required
[14:52:26] [PASSED] ABGR8888 Invalid width
[14:52:26] [PASSED] ABGR8888 Invalid buffer handle
[14:52:26] [PASSED] No pixel format
[14:52:26] [PASSED] ABGR8888 Width 0
[14:52:26] [PASSED] ABGR8888 Height 0
[14:52:26] [PASSED] ABGR8888 Out of bound height * pitch combination
[14:52:26] [PASSED] ABGR8888 Large buffer offset
[14:52:26] [PASSED] ABGR8888 Buffer offset for inexistent plane
[14:52:26] [PASSED] ABGR8888 Invalid flag
[14:52:26] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[14:52:26] [PASSED] ABGR8888 Valid buffer modifier
[14:52:26] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[14:52:26] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[14:52:26] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[14:52:26] [PASSED] NV12 Normal sizes
[14:52:26] [PASSED] NV12 Max sizes
[14:52:26] [PASSED] NV12 Invalid pitch
[14:52:26] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[14:52:26] [PASSED] NV12 different  modifier per-plane
[14:52:26] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[14:52:26] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[14:52:26] [PASSED] NV12 Modifier for inexistent plane
[14:52:26] [PASSED] NV12 Handle for inexistent plane
[14:52:26] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[14:52:26] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[14:52:26] [PASSED] YVU420 Normal sizes
[14:52:26] [PASSED] YVU420 Max sizes
[14:52:26] [PASSED] YVU420 Invalid pitch
[14:52:26] [PASSED] YVU420 Different pitches
[14:52:26] [PASSED] YVU420 Different buffer offsets/pitches
[14:52:26] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[14:52:26] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[14:52:26] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[14:52:26] [PASSED] YVU420 Valid modifier
[14:52:26] [PASSED] YVU420 Different modifiers per plane
[14:52:26] [PASSED] YVU420 Modifier for inexistent plane
[14:52:26] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)
[14:52:26] [PASSED] X0L2 Normal sizes
[14:52:26] [PASSED] X0L2 Max sizes
[14:52:26] [PASSED] X0L2 Invalid pitch
[14:52:26] [PASSED] X0L2 Pitch greater than minimum required
[14:52:26] [PASSED] X0L2 Handle for inexistent plane
[14:52:26] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[14:52:26] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[14:52:26] [PASSED] X0L2 Valid modifier
[14:52:26] [PASSED] X0L2 Modifier for inexistent plane
[14:52:26] =========== [PASSED] drm_test_framebuffer_create ===========
[14:52:26] [PASSED] drm_test_framebuffer_free
[14:52:26] [PASSED] drm_test_framebuffer_init
[14:52:26] [PASSED] drm_test_framebuffer_init_bad_format
[14:52:26] [PASSED] drm_test_framebuffer_init_dev_mismatch
[14:52:26] [PASSED] drm_test_framebuffer_lookup
[14:52:26] [PASSED] drm_test_framebuffer_lookup_inexistent
[14:52:26] [PASSED] drm_test_framebuffer_modifiers_not_supported
[14:52:26] ================= [PASSED] drm_framebuffer =================
[14:52:26] ================ drm_gem_shmem (8 subtests) ================
[14:52:26] [PASSED] drm_gem_shmem_test_obj_create
[14:52:26] [PASSED] drm_gem_shmem_test_obj_create_private
[14:52:26] [PASSED] drm_gem_shmem_test_pin_pages
[14:52:26] [PASSED] drm_gem_shmem_test_vmap
[14:52:26] [PASSED] drm_gem_shmem_test_get_pages_sgt
[14:52:26] [PASSED] drm_gem_shmem_test_get_sg_table
[14:52:26] [PASSED] drm_gem_shmem_test_madvise
[14:52:26] [PASSED] drm_gem_shmem_test_purge
[14:52:26] ================== [PASSED] drm_gem_shmem ==================
[14:52:26] === drm_atomic_helper_connector_hdmi_check (27 subtests) ===
[14:52:26] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode
[14:52:26] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1
[14:52:26] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode
[14:52:26] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1
[14:52:26] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode
[14:52:26] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1
[14:52:26] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420  =======
[14:52:26] [PASSED] Automatic
[14:52:26] [PASSED] Full
[14:52:26] [PASSED] Limited 16:235
[14:52:26] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 ===
[14:52:26] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed
[14:52:26] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed
[14:52:26] [PASSED] drm_test_check_disable_connector
[14:52:26] [PASSED] drm_test_check_hdmi_funcs_reject_rate
[14:52:26] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb
[14:52:26] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420
[14:52:26] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422
[14:52:26] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420
[14:52:26] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420
[14:52:26] [PASSED] drm_test_check_output_bpc_crtc_mode_changed
[14:52:26] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed
[14:52:26] [PASSED] drm_test_check_output_bpc_dvi
[14:52:26] [PASSED] drm_test_check_output_bpc_format_vic_1
[14:52:26] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only
[14:52:26] [PASSED] drm_test_check_output_bpc_format_display_rgb_only
[14:52:26] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only
[14:52:26] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only
[14:52:26] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc
[14:52:26] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc
[14:52:26] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc
[14:52:26] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ======
[14:52:26] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ====
[14:52:26] [PASSED] drm_test_check_broadcast_rgb_value
[14:52:26] [PASSED] drm_test_check_bpc_8_value
[14:52:26] [PASSED] drm_test_check_bpc_10_value
[14:52:26] [PASSED] drm_test_check_bpc_12_value
[14:52:26] [PASSED] drm_test_check_format_value
[14:52:26] [PASSED] drm_test_check_tmds_char_value
[14:52:26] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ======
[14:52:26] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) =
[14:52:26] [PASSED] drm_test_check_mode_valid
[14:52:26] [PASSED] drm_test_check_mode_valid_reject
[14:52:26] [PASSED] drm_test_check_mode_valid_reject_rate
[14:52:26] [PASSED] drm_test_check_mode_valid_reject_max_clock
[14:52:26] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid ===
[14:52:26] ================= drm_managed (2 subtests) =================
[14:52:26] [PASSED] drm_test_managed_release_action
[14:52:26] [PASSED] drm_test_managed_run_action
[14:52:26] =================== [PASSED] drm_managed ===================
[14:52:26] =================== drm_mm (6 subtests) ====================
[14:52:26] [PASSED] drm_test_mm_init
[14:52:26] [PASSED] drm_test_mm_debug
[14:52:26] [PASSED] drm_test_mm_align32
[14:52:26] [PASSED] drm_test_mm_align64
[14:52:26] [PASSED] drm_test_mm_lowest
[14:52:26] [PASSED] drm_test_mm_highest
[14:52:26] ===================== [PASSED] drm_mm ======================
[14:52:26] ============= drm_modes_analog_tv (5 subtests) =============
[14:52:26] [PASSED] drm_test_modes_analog_tv_mono_576i
[14:52:26] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[14:52:26] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[14:52:26] [PASSED] drm_test_modes_analog_tv_pal_576i
[14:52:26] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[14:52:26] =============== [PASSED] drm_modes_analog_tv ===============
[14:52:26] ============== drm_plane_helper (2 subtests) ===============
[14:52:26] =============== drm_test_check_plane_state  ================
[14:52:26] [PASSED] clipping_simple
[14:52:26] [PASSED] clipping_rotate_reflect
[14:52:26] [PASSED] positioning_simple
[14:52:26] [PASSED] upscaling
[14:52:26] [PASSED] downscaling
[14:52:26] [PASSED] rounding1
[14:52:26] [PASSED] rounding2
[14:52:26] [PASSED] rounding3
[14:52:26] [PASSED] rounding4
[14:52:26] =========== [PASSED] drm_test_check_plane_state ============
[14:52:26] =========== drm_test_check_invalid_plane_state  ============
[14:52:26] [PASSED] positioning_invalid
[14:52:26] [PASSED] upscaling_invalid
[14:52:26] [PASSED] downscaling_invalid
[14:52:26] ======= [PASSED] drm_test_check_invalid_plane_state ========
[14:52:26] ================ [PASSED] drm_plane_helper =================
[14:52:26] ====== drm_connector_helper_tv_get_modes (1 subtest) =======
[14:52:26] ====== drm_test_connector_helper_tv_get_modes_check  =======
[14:52:26] [PASSED] None
[14:52:26] [PASSED] PAL
[14:52:26] [PASSED] NTSC
[14:52:26] [PASSED] Both, NTSC Default
[14:52:26] [PASSED] Both, PAL Default
[14:52:26] [PASSED] Both, NTSC Default, with PAL on command-line
[14:52:26] [PASSED] Both, PAL Default, with NTSC on command-line
[14:52:26] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[14:52:26] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[14:52:26] ================== drm_rect (9 subtests) ===================
[14:52:26] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[14:52:26] [PASSED] drm_test_rect_clip_scaled_not_clipped
[14:52:26] [PASSED] drm_test_rect_clip_scaled_clipped
[14:52:26] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[14:52:26] ================= drm_test_rect_intersect  =================
[14:52:26] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[14:52:26] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[14:52:26] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[14:52:26] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[14:52:26] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[14:52:26] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[14:52:26] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[14:52:26] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[14:52:26] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[14:52:26] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[14:52:26] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[14:52:26] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
[14:52:26] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[14:52:26] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[14:52:26] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
[14:52:26] ============= [PASSED] drm_test_rect_intersect =============
[14:52:26] ================ drm_test_rect_calc_hscale  ================
[14:52:26] [PASSED] normal use
[14:52:26] [PASSED] out of max range
[14:52:26] [PASSED] out of min range
[14:52:26] [PASSED] zero dst
[14:52:26] [PASSED] negative src
[14:52:26] [PASSED] negative dst
[14:52:26] ============ [PASSED] drm_test_rect_calc_hscale ============
[14:52:26] ================ drm_test_rect_calc_vscale  ================
[14:52:26] [PASSED] normal use
stty: 'standard input': Inappropriate ioctl for device
[14:52:26] [PASSED] out of max range
[14:52:26] [PASSED] out of min range
[14:52:26] [PASSED] zero dst
[14:52:26] [PASSED] negative src
[14:52:26] [PASSED] negative dst
[14:52:26] ============ [PASSED] drm_test_rect_calc_vscale ============
[14:52:26] ================== drm_test_rect_rotate  ===================
[14:52:26] [PASSED] reflect-x
[14:52:26] [PASSED] reflect-y
[14:52:26] [PASSED] rotate-0
[14:52:26] [PASSED] rotate-90
[14:52:26] [PASSED] rotate-180
[14:52:26] [PASSED] rotate-270
[14:52:26] ============== [PASSED] drm_test_rect_rotate ===============
[14:52:26] ================ drm_test_rect_rotate_inv  =================
[14:52:26] [PASSED] reflect-x
[14:52:26] [PASSED] reflect-y
[14:52:26] [PASSED] rotate-0
[14:52:26] [PASSED] rotate-90
[14:52:26] [PASSED] rotate-180
[14:52:26] [PASSED] rotate-270
[14:52:26] ============ [PASSED] drm_test_rect_rotate_inv =============
[14:52:26] ==================== [PASSED] drm_rect =====================
[14:52:26] ============ drm_sysfb_modeset_test (1 subtest) ============
[14:52:26] ============ drm_test_sysfb_build_fourcc_list  =============
[14:52:26] [PASSED] no native formats
[14:52:26] [PASSED] XRGB8888 as native format
[14:52:26] [PASSED] remove duplicates
[14:52:26] [PASSED] convert alpha formats
[14:52:26] [PASSED] random formats
[14:52:26] ======== [PASSED] drm_test_sysfb_build_fourcc_list =========
[14:52:26] ============= [PASSED] drm_sysfb_modeset_test ==============
[14:52:26] ============================================================
[14:52:26] Testing complete. Ran 622 tests: passed: 622
[14:52:27] Elapsed time: 26.140s total, 1.729s configuring, 23.995s building, 0.369s running

+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig
[14:52:27] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
[14:52:28] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[14:52:38] Starting KUnit Kernel (1/1)...
[14:52:38] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[14:52:38] ================= ttm_device (5 subtests) ==================
[14:52:38] [PASSED] ttm_device_init_basic
[14:52:38] [PASSED] ttm_device_init_multiple
[14:52:38] [PASSED] ttm_device_fini_basic
[14:52:38] [PASSED] ttm_device_init_no_vma_man
[14:52:38] ================== ttm_device_init_pools  ==================
[14:52:38] [PASSED] No DMA allocations, no DMA32 required
[14:52:38] [PASSED] DMA allocations, DMA32 required
[14:52:38] [PASSED] No DMA allocations, DMA32 required
[14:52:38] [PASSED] DMA allocations, no DMA32 required
[14:52:38] ============== [PASSED] ttm_device_init_pools ==============
[14:52:38] =================== [PASSED] ttm_device ====================
[14:52:38] ================== ttm_pool (8 subtests) ===================
[14:52:38] ================== ttm_pool_alloc_basic  ===================
[14:52:38] [PASSED] One page
[14:52:38] [PASSED] More than one page
[14:52:38] [PASSED] Above the allocation limit
[14:52:38] [PASSED] One page, with coherent DMA mappings enabled
[14:52:38] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[14:52:38] ============== [PASSED] ttm_pool_alloc_basic ===============
[14:52:38] ============== ttm_pool_alloc_basic_dma_addr  ==============
[14:52:38] [PASSED] One page
[14:52:38] [PASSED] More than one page
[14:52:38] [PASSED] Above the allocation limit
[14:52:38] [PASSED] One page, with coherent DMA mappings enabled
[14:52:38] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[14:52:38] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ==========
[14:52:38] [PASSED] ttm_pool_alloc_order_caching_match
[14:52:38] [PASSED] ttm_pool_alloc_caching_mismatch
[14:52:38] [PASSED] ttm_pool_alloc_order_mismatch
[14:52:38] [PASSED] ttm_pool_free_dma_alloc
[14:52:38] [PASSED] ttm_pool_free_no_dma_alloc
[14:52:38] [PASSED] ttm_pool_fini_basic
[14:52:38] ==================== [PASSED] ttm_pool =====================
[14:52:38] ================ ttm_resource (8 subtests) =================
[14:52:38] ================= ttm_resource_init_basic  =================
[14:52:38] [PASSED] Init resource in TTM_PL_SYSTEM
[14:52:38] [PASSED] Init resource in TTM_PL_VRAM
[14:52:38] [PASSED] Init resource in a private placement
[14:52:38] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags
[14:52:38] ============= [PASSED] ttm_resource_init_basic =============
[14:52:38] [PASSED] ttm_resource_init_pinned
[14:52:38] [PASSED] ttm_resource_fini_basic
[14:52:38] [PASSED] ttm_resource_manager_init_basic
[14:52:38] [PASSED] ttm_resource_manager_usage_basic
[14:52:38] [PASSED] ttm_resource_manager_set_used_basic
[14:52:38] [PASSED] ttm_sys_man_alloc_basic
[14:52:38] [PASSED] ttm_sys_man_free_basic
[14:52:38] ================== [PASSED] ttm_resource ===================
[14:52:38] =================== ttm_tt (15 subtests) ===================
[14:52:38] ==================== ttm_tt_init_basic  ====================
[14:52:38] [PASSED] Page-aligned size
[14:52:38] [PASSED] Extra pages requested
[14:52:38] ================ [PASSED] ttm_tt_init_basic ================
[14:52:38] [PASSED] ttm_tt_init_misaligned
[14:52:38] [PASSED] ttm_tt_fini_basic
[14:52:38] [PASSED] ttm_tt_fini_sg
[14:52:38] [PASSED] ttm_tt_fini_shmem
[14:52:38] [PASSED] ttm_tt_create_basic
[14:52:38] [PASSED] ttm_tt_create_invalid_bo_type
[14:52:38] [PASSED] ttm_tt_create_ttm_exists
[14:52:38] [PASSED] ttm_tt_create_failed
[14:52:38] [PASSED] ttm_tt_destroy_basic
[14:52:38] [PASSED] ttm_tt_populate_null_ttm
[14:52:38] [PASSED] ttm_tt_populate_populated_ttm
[14:52:38] [PASSED] ttm_tt_unpopulate_basic
[14:52:38] [PASSED] ttm_tt_unpopulate_empty_ttm
[14:52:38] [PASSED] ttm_tt_swapin_basic
[14:52:38] ===================== [PASSED] ttm_tt ======================
[14:52:38] =================== ttm_bo (14 subtests) ===================
[14:52:38] =========== ttm_bo_reserve_optimistic_no_ticket  ===========
[14:52:38] [PASSED] Cannot be interrupted and sleeps
[14:52:38] [PASSED] Cannot be interrupted, locks straight away
[14:52:38] [PASSED] Can be interrupted, sleeps
[14:52:38] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket =======
[14:52:38] [PASSED] ttm_bo_reserve_locked_no_sleep
[14:52:38] [PASSED] ttm_bo_reserve_no_wait_ticket
[14:52:38] [PASSED] ttm_bo_reserve_double_resv
[14:52:38] [PASSED] ttm_bo_reserve_interrupted
[14:52:38] [PASSED] ttm_bo_reserve_deadlock
[14:52:38] [PASSED] ttm_bo_unreserve_basic
[14:52:38] [PASSED] ttm_bo_unreserve_pinned
[14:52:38] [PASSED] ttm_bo_unreserve_bulk
[14:52:38] [PASSED] ttm_bo_fini_basic
[14:52:38] [PASSED] ttm_bo_fini_shared_resv
[14:52:38] [PASSED] ttm_bo_pin_basic
[14:52:38] [PASSED] ttm_bo_pin_unpin_resource
[14:52:38] [PASSED] ttm_bo_multiple_pin_one_unpin
[14:52:38] ===================== [PASSED] ttm_bo ======================
[14:52:38] ============== ttm_bo_validate (21 subtests) ===============
[14:52:38] ============== ttm_bo_init_reserved_sys_man  ===============
[14:52:38] [PASSED] Buffer object for userspace
[14:52:38] [PASSED] Kernel buffer object
[14:52:38] [PASSED] Shared buffer object
[14:52:38] ========== [PASSED] ttm_bo_init_reserved_sys_man ===========
[14:52:38] ============== ttm_bo_init_reserved_mock_man  ==============
[14:52:38] [PASSED] Buffer object for userspace
[14:52:38] [PASSED] Kernel buffer object
[14:52:38] [PASSED] Shared buffer object
[14:52:38] ========== [PASSED] ttm_bo_init_reserved_mock_man ==========
[14:52:38] [PASSED] ttm_bo_init_reserved_resv
[14:52:38] ================== ttm_bo_validate_basic  ==================
[14:52:38] [PASSED] Buffer object for userspace
[14:52:38] [PASSED] Kernel buffer object
[14:52:38] [PASSED] Shared buffer object
[14:52:38] ============== [PASSED] ttm_bo_validate_basic ==============
[14:52:38] [PASSED] ttm_bo_validate_invalid_placement
[14:52:38] ============= ttm_bo_validate_same_placement  ==============
[14:52:38] [PASSED] System manager
[14:52:38] [PASSED] VRAM manager
[14:52:38] ========= [PASSED] ttm_bo_validate_same_placement ==========
[14:52:38] [PASSED] ttm_bo_validate_failed_alloc
[14:52:38] [PASSED] ttm_bo_validate_pinned
[14:52:38] [PASSED] ttm_bo_validate_busy_placement
[14:52:38] ================ ttm_bo_validate_multihop  =================
[14:52:38] [PASSED] Buffer object for userspace
[14:52:38] [PASSED] Kernel buffer object
[14:52:38] [PASSED] Shared buffer object
[14:52:38] ============ [PASSED] ttm_bo_validate_multihop =============
[14:52:38] ========== ttm_bo_validate_no_placement_signaled  ==========
[14:52:38] [PASSED] Buffer object in system domain, no page vector
[14:52:38] [PASSED] Buffer object in system domain with an existing page vector
[14:52:38] ====== [PASSED] ttm_bo_validate_no_placement_signaled ======
[14:52:38] ======== ttm_bo_validate_no_placement_not_signaled  ========
[14:52:38] [PASSED] Buffer object for userspace
[14:52:38] [PASSED] Kernel buffer object
[14:52:38] [PASSED] Shared buffer object
[14:52:38] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ====
[14:52:38] [PASSED] ttm_bo_validate_move_fence_signaled
[14:52:38] ========= ttm_bo_validate_move_fence_not_signaled  =========
[14:52:38] [PASSED] Waits for GPU
[14:52:38] [PASSED] Tries to lock straight away
[14:52:38] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled =====
[14:52:38] [PASSED] ttm_bo_validate_happy_evict
[14:52:38] [PASSED] ttm_bo_validate_all_pinned_evict
[14:52:38] [PASSED] ttm_bo_validate_allowed_only_evict
[14:52:38] [PASSED] ttm_bo_validate_deleted_evict
[14:52:38] [PASSED] ttm_bo_validate_busy_domain_evict
[14:52:38] [PASSED] ttm_bo_validate_evict_gutting
[14:52:38] [PASSED] ttm_bo_validate_recrusive_evict
stty: 'standard input': Inappropriate ioctl for device
[14:52:38] ================= [PASSED] ttm_bo_validate =================
[14:52:38] ============================================================
[14:52:38] Testing complete. Ran 101 tests: passed: 101
[14:52:38] Elapsed time: 11.232s total, 1.792s configuring, 9.224s building, 0.181s running

+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel



^ permalink raw reply	[flat|nested] 16+ messages in thread

* ✓ Xe.CI.BAT: success for drm/client: Implement free callback for fbdev and log
  2025-10-09 13:16 [PATCH 0/4] drm/client: Implement free callback for fbdev and log Thomas Zimmermann
                   ` (4 preceding siblings ...)
  2025-10-09 14:52 ` ✓ CI.KUnit: success for drm/client: Implement free callback for fbdev and log Patchwork
@ 2025-10-09 15:27 ` Patchwork
  2025-10-09 21:17 ` ✗ Xe.CI.Full: failure " Patchwork
  6 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2025-10-09 15:27 UTC (permalink / raw)
  To: Thomas Zimmermann; +Cc: intel-xe

[-- Attachment #1: Type: text/plain, Size: 1480 bytes --]

== Series Details ==

Series: drm/client: Implement free callback for fbdev and log
URL   : https://patchwork.freedesktop.org/series/155689/
State : success

== Summary ==

CI Bug Log - changes from xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b_BAT -> xe-pw-155689v1_BAT
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Participating hosts (10 -> 10)
------------------------------

  No changes in participating hosts

Known issues
------------

  Here are the changes found in xe-pw-155689v1_BAT that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_flip@basic-plain-flip@a-edp1:
    - bat-adlp-7:         [PASS][1] -> [DMESG-WARN][2] ([Intel XE#4543]) +1 other test dmesg-warn
   [1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/bat-adlp-7/igt@kms_flip@basic-plain-flip@a-edp1.html
   [2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/bat-adlp-7/igt@kms_flip@basic-plain-flip@a-edp1.html

  
  [Intel XE#4543]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4543


Build changes
-------------

  * Linux: xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b -> xe-pw-155689v1

  IGT_8581: 8581
  xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b: 9bc7e2556e75bf5eb4f219b4e246a607699c1d6b
  xe-pw-155689v1: 155689v1

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/index.html

[-- Attachment #2: Type: text/html, Size: 2045 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* ✗ Xe.CI.Full: failure for drm/client: Implement free callback for fbdev and log
  2025-10-09 13:16 [PATCH 0/4] drm/client: Implement free callback for fbdev and log Thomas Zimmermann
                   ` (5 preceding siblings ...)
  2025-10-09 15:27 ` ✓ Xe.CI.BAT: " Patchwork
@ 2025-10-09 21:17 ` Patchwork
  6 siblings, 0 replies; 16+ messages in thread
From: Patchwork @ 2025-10-09 21:17 UTC (permalink / raw)
  To: Thomas Zimmermann; +Cc: intel-xe

[-- Attachment #1: Type: text/plain, Size: 39693 bytes --]

== Series Details ==

Series: drm/client: Implement free callback for fbdev and log
URL   : https://patchwork.freedesktop.org/series/155689/
State : failure

== Summary ==

CI Bug Log - changes from xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b_FULL -> xe-pw-155689v1_FULL
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with xe-pw-155689v1_FULL absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in xe-pw-155689v1_FULL, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Participating hosts (4 -> 4)
------------------------------

  No changes in participating hosts

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in xe-pw-155689v1_FULL:

### IGT changes ###

#### Possible regressions ####

  * igt@xe_evict@evict-beng-mixed-many-threads-small:
    - shard-bmg:          [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-bmg-6/igt@xe_evict@evict-beng-mixed-many-threads-small.html
   [2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-1/igt@xe_evict@evict-beng-mixed-many-threads-small.html

  
Known issues
------------

  Here are the changes found in xe-pw-155689v1_FULL that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_big_fb@4-tiled-32bpp-rotate-90:
    - shard-dg2-set2:     NOTRUN -> [SKIP][3] ([Intel XE#316])
   [3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-434/igt@kms_big_fb@4-tiled-32bpp-rotate-90.html

  * igt@kms_big_fb@x-tiled-32bpp-rotate-90:
    - shard-bmg:          NOTRUN -> [SKIP][4] ([Intel XE#2327]) +1 other test skip
   [4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-4/igt@kms_big_fb@x-tiled-32bpp-rotate-90.html

  * igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip:
    - shard-dg2-set2:     NOTRUN -> [SKIP][5] ([Intel XE#1124]) +2 other tests skip
   [5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-434/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip.html

  * igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip:
    - shard-bmg:          NOTRUN -> [SKIP][6] ([Intel XE#1124]) +1 other test skip
   [6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-4/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip.html

  * igt@kms_bw@connected-linear-tiling-3-displays-1920x1080p:
    - shard-dg2-set2:     NOTRUN -> [SKIP][7] ([Intel XE#2191])
   [7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-434/igt@kms_bw@connected-linear-tiling-3-displays-1920x1080p.html

  * igt@kms_ccs@ccs-on-another-bo-y-tiled-gen12-mc-ccs:
    - shard-bmg:          NOTRUN -> [SKIP][8] ([Intel XE#2887]) +3 other tests skip
   [8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-4/igt@kms_ccs@ccs-on-another-bo-y-tiled-gen12-mc-ccs.html

  * igt@kms_ccs@crc-primary-suspend-4-tiled-mtl-mc-ccs@pipe-c-dp-4:
    - shard-dg2-set2:     NOTRUN -> [SKIP][9] ([Intel XE#787]) +13 other tests skip
   [9]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-434/igt@kms_ccs@crc-primary-suspend-4-tiled-mtl-mc-ccs@pipe-c-dp-4.html

  * igt@kms_ccs@crc-primary-suspend-4-tiled-mtl-mc-ccs@pipe-d-dp-4:
    - shard-dg2-set2:     NOTRUN -> [SKIP][10] ([Intel XE#455] / [Intel XE#787]) +3 other tests skip
   [10]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-434/igt@kms_ccs@crc-primary-suspend-4-tiled-mtl-mc-ccs@pipe-d-dp-4.html

  * igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc@pipe-d-dp-4:
    - shard-dg2-set2:     NOTRUN -> [INCOMPLETE][11] ([Intel XE#1727] / [Intel XE#2705] / [Intel XE#3113] / [Intel XE#4212] / [Intel XE#4522])
   [11]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-464/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc@pipe-d-dp-4.html

  * igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs@pipe-c-hdmi-a-6:
    - shard-dg2-set2:     NOTRUN -> [INCOMPLETE][12] ([Intel XE#1727] / [Intel XE#3113] / [Intel XE#6168])
   [12]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-463/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs@pipe-c-hdmi-a-6.html

  * igt@kms_chamelium_hpd@vga-hpd-fast:
    - shard-dg2-set2:     NOTRUN -> [SKIP][13] ([Intel XE#373]) +2 other tests skip
   [13]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-434/igt@kms_chamelium_hpd@vga-hpd-fast.html

  * igt@kms_content_protection@lic-type-0@pipe-a-dp-2:
    - shard-bmg:          NOTRUN -> [FAIL][14] ([Intel XE#1178])
   [14]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-1/igt@kms_content_protection@lic-type-0@pipe-a-dp-2.html

  * igt@kms_content_protection@srm@pipe-a-dp-4:
    - shard-dg2-set2:     NOTRUN -> [FAIL][15] ([Intel XE#1178]) +1 other test fail
   [15]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-434/igt@kms_content_protection@srm@pipe-a-dp-4.html

  * igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions-varying-size:
    - shard-bmg:          [PASS][16] -> [SKIP][17] ([Intel XE#2291]) +3 other tests skip
   [16]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-bmg-1/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions-varying-size.html
   [17]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-6/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions-varying-size.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
    - shard-bmg:          [PASS][18] -> [DMESG-WARN][19] ([Intel XE#5354])
   [18]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-bmg-6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
   [19]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

  * igt@kms_flip@2x-flip-vs-dpms-on-nop:
    - shard-bmg:          [PASS][20] -> [SKIP][21] ([Intel XE#2316]) +1 other test skip
   [20]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-bmg-5/igt@kms_flip@2x-flip-vs-dpms-on-nop.html
   [21]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-6/igt@kms_flip@2x-flip-vs-dpms-on-nop.html

  * igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-hdmi-a1:
    - shard-adlp:         [PASS][22] -> [FAIL][23] ([Intel XE#5408])
   [22]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-adlp-9/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-hdmi-a1.html
   [23]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-adlp-2/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-hdmi-a1.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-dg2-set2:     [PASS][24] -> [FAIL][25] ([Intel XE#301]) +1 other test fail
   [24]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-dg2-466/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
   [25]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-463/igt@kms_flip@flip-vs-expired-vblank-interruptible.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
    - shard-lnl:          [PASS][26] -> [FAIL][27] ([Intel XE#301]) +1 other test fail
   [26]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-lnl-5/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
   [27]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-lnl-5/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html

  * igt@kms_flip@flip-vs-suspend-interruptible:
    - shard-dg2-set2:     [PASS][28] -> [INCOMPLETE][29] ([Intel XE#2049] / [Intel XE#2597]) +1 other test incomplete
   [28]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-dg2-466/igt@kms_flip@flip-vs-suspend-interruptible.html
   [29]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-433/igt@kms_flip@flip-vs-suspend-interruptible.html

  * igt@kms_flip@plain-flip-interruptible@b-hdmi-a1:
    - shard-adlp:         [PASS][30] -> [DMESG-WARN][31] ([Intel XE#4543]) +6 other tests dmesg-warn
   [30]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-adlp-3/igt@kms_flip@plain-flip-interruptible@b-hdmi-a1.html
   [31]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-adlp-1/igt@kms_flip@plain-flip-interruptible@b-hdmi-a1.html

  * igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling:
    - shard-bmg:          NOTRUN -> [SKIP][32] ([Intel XE#2293] / [Intel XE#2380])
   [32]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-4/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling.html

  * igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling@pipe-a-valid-mode:
    - shard-bmg:          NOTRUN -> [SKIP][33] ([Intel XE#2293])
   [33]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-4/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-downscaling@pipe-a-valid-mode.html

  * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling:
    - shard-dg2-set2:     NOTRUN -> [SKIP][34] ([Intel XE#455]) +2 other tests skip
   [34]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-434/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling.html

  * igt@kms_flip_tiling@flip-change-tiling@pipe-b-hdmi-a-1-y-to-y:
    - shard-adlp:         [PASS][35] -> [DMESG-FAIL][36] ([Intel XE#4543])
   [35]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-adlp-4/igt@kms_flip_tiling@flip-change-tiling@pipe-b-hdmi-a-1-y-to-y.html
   [36]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-adlp-4/igt@kms_flip_tiling@flip-change-tiling@pipe-b-hdmi-a-1-y-to-y.html

  * igt@kms_flip_tiling@flip-change-tiling@pipe-d-hdmi-a-1-y-to-y:
    - shard-adlp:         [PASS][37] -> [FAIL][38] ([Intel XE#1874])
   [37]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-adlp-4/igt@kms_flip_tiling@flip-change-tiling@pipe-d-hdmi-a-1-y-to-y.html
   [38]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-adlp-4/igt@kms_flip_tiling@flip-change-tiling@pipe-d-hdmi-a-1-y-to-y.html

  * igt@kms_frontbuffer_tracking@drrs-1p-primscrn-shrfb-pgflip-blt:
    - shard-bmg:          NOTRUN -> [SKIP][39] ([Intel XE#2311]) +3 other tests skip
   [39]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-4/igt@kms_frontbuffer_tracking@drrs-1p-primscrn-shrfb-pgflip-blt.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt:
    - shard-bmg:          NOTRUN -> [SKIP][40] ([Intel XE#5390]) +1 other test skip
   [40]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-4/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-indfb-plflip-blt.html

  * igt@kms_frontbuffer_tracking@fbcdrrs-2p-scndscrn-indfb-plflip-blt:
    - shard-dg2-set2:     NOTRUN -> [SKIP][41] ([Intel XE#651]) +7 other tests skip
   [41]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-434/igt@kms_frontbuffer_tracking@fbcdrrs-2p-scndscrn-indfb-plflip-blt.html

  * igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-onoff:
    - shard-dg2-set2:     NOTRUN -> [SKIP][42] ([Intel XE#653]) +4 other tests skip
   [42]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-434/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-onoff.html

  * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-plflip-blt:
    - shard-bmg:          NOTRUN -> [SKIP][43] ([Intel XE#2313]) +1 other test skip
   [43]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-4/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-indfb-plflip-blt.html

  * igt@kms_hdr@static-toggle-suspend:
    - shard-bmg:          [PASS][44] -> [SKIP][45] ([Intel XE#1503])
   [44]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-bmg-5/igt@kms_hdr@static-toggle-suspend.html
   [45]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-6/igt@kms_hdr@static-toggle-suspend.html

  * igt@kms_plane_multiple@tiling-yf:
    - shard-bmg:          NOTRUN -> [SKIP][46] ([Intel XE#5020])
   [46]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-4/igt@kms_plane_multiple@tiling-yf.html

  * igt@kms_psr2_sf@fbc-pr-cursor-plane-move-continuous-exceed-sf:
    - shard-dg2-set2:     NOTRUN -> [SKIP][47] ([Intel XE#1406] / [Intel XE#1489]) +1 other test skip
   [47]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-466/igt@kms_psr2_sf@fbc-pr-cursor-plane-move-continuous-exceed-sf.html

  * igt@kms_psr2_sf@fbc-psr2-cursor-plane-move-continuous-exceed-fully-sf:
    - shard-bmg:          NOTRUN -> [SKIP][48] ([Intel XE#1406] / [Intel XE#1489])
   [48]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-4/igt@kms_psr2_sf@fbc-psr2-cursor-plane-move-continuous-exceed-fully-sf.html

  * igt@kms_psr@psr2-primary-render:
    - shard-dg2-set2:     NOTRUN -> [SKIP][49] ([Intel XE#1406] / [Intel XE#2850] / [Intel XE#929]) +1 other test skip
   [49]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-434/igt@kms_psr@psr2-primary-render.html

  * igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
    - shard-dg2-set2:     NOTRUN -> [SKIP][50] ([Intel XE#1406] / [Intel XE#2939])
   [50]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-434/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html

  * igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0:
    - shard-dg2-set2:     NOTRUN -> [SKIP][51] ([Intel XE#1127])
   [51]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-434/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0.html

  * igt@xe_copy_basic@mem-copy-linear-0x3fff:
    - shard-dg2-set2:     NOTRUN -> [SKIP][52] ([Intel XE#1123])
   [52]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-434/igt@xe_copy_basic@mem-copy-linear-0x3fff.html

  * igt@xe_copy_basic@mem-set-linear-0x3fff:
    - shard-dg2-set2:     NOTRUN -> [SKIP][53] ([Intel XE#1126])
   [53]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-435/igt@xe_copy_basic@mem-set-linear-0x3fff.html

  * igt@xe_eudebug@basic-vm-bind-ufence-sigint-client:
    - shard-bmg:          NOTRUN -> [SKIP][54] ([Intel XE#4837])
   [54]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-4/igt@xe_eudebug@basic-vm-bind-ufence-sigint-client.html

  * igt@xe_exec_basic@multigpu-once-bindexecqueue-rebind:
    - shard-bmg:          NOTRUN -> [SKIP][55] ([Intel XE#2322]) +1 other test skip
   [55]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-4/igt@xe_exec_basic@multigpu-once-bindexecqueue-rebind.html

  * igt@xe_exec_fault_mode@many-basic:
    - shard-dg2-set2:     NOTRUN -> [SKIP][56] ([Intel XE#288]) +4 other tests skip
   [56]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-434/igt@xe_exec_fault_mode@many-basic.html

  * igt@xe_exec_system_allocator@many-stride-malloc-race:
    - shard-dg2-set2:     NOTRUN -> [SKIP][57] ([Intel XE#4915]) +44 other tests skip
   [57]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-434/igt@xe_exec_system_allocator@many-stride-malloc-race.html

  * igt@xe_exec_system_allocator@threads-many-execqueues-mmap-new-huge:
    - shard-bmg:          NOTRUN -> [SKIP][58] ([Intel XE#4943]) +3 other tests skip
   [58]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-4/igt@xe_exec_system_allocator@threads-many-execqueues-mmap-new-huge.html

  * igt@xe_pm@d3cold-i2c:
    - shard-dg2-set2:     NOTRUN -> [SKIP][59] ([Intel XE#5694])
   [59]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-434/igt@xe_pm@d3cold-i2c.html

  * igt@xe_pmu@gt-frequency:
    - shard-dg2-set2:     [PASS][60] -> [FAIL][61] ([Intel XE#4819]) +1 other test fail
   [60]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-dg2-464/igt@xe_pmu@gt-frequency.html
   [61]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-435/igt@xe_pmu@gt-frequency.html

  * igt@xe_pxp@pxp-optout:
    - shard-bmg:          NOTRUN -> [SKIP][62] ([Intel XE#4733])
   [62]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-4/igt@xe_pxp@pxp-optout.html

  * igt@xe_query@multigpu-query-uc-fw-version-guc:
    - shard-dg2-set2:     NOTRUN -> [SKIP][63] ([Intel XE#944])
   [63]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-434/igt@xe_query@multigpu-query-uc-fw-version-guc.html

  
#### Possible fixes ####

  * igt@kms_bw@connected-linear-tiling-2-displays-2560x1440p:
    - shard-bmg:          [SKIP][64] ([Intel XE#2314] / [Intel XE#2894]) -> [PASS][65]
   [64]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-bmg-6/igt@kms_bw@connected-linear-tiling-2-displays-2560x1440p.html
   [65]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-1/igt@kms_bw@connected-linear-tiling-2-displays-2560x1440p.html

  * igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc@pipe-a-hdmi-a-6:
    - shard-dg2-set2:     [INCOMPLETE][66] ([Intel XE#2705] / [Intel XE#3113] / [Intel XE#4212]) -> [PASS][67]
   [66]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-dg2-463/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc@pipe-a-hdmi-a-6.html
   [67]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-464/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc@pipe-a-hdmi-a-6.html

  * igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs@pipe-b-hdmi-a-6:
    - shard-dg2-set2:     [INCOMPLETE][68] ([Intel XE#1727] / [Intel XE#2705] / [Intel XE#3113] / [Intel XE#4212] / [Intel XE#4522]) -> [PASS][69]
   [68]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-dg2-463/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs@pipe-b-hdmi-a-6.html
   [69]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-463/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs@pipe-b-hdmi-a-6.html

  * igt@kms_cursor_legacy@cursorb-vs-flipa-legacy:
    - shard-bmg:          [SKIP][70] ([Intel XE#2291]) -> [PASS][71] +6 other tests pass
   [70]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-bmg-6/igt@kms_cursor_legacy@cursorb-vs-flipa-legacy.html
   [71]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-1/igt@kms_cursor_legacy@cursorb-vs-flipa-legacy.html

  * igt@kms_cursor_legacy@cursorb-vs-flipb-varying-size:
    - shard-dg2-set2:     [INCOMPLETE][72] ([Intel XE#3226]) -> [PASS][73]
   [72]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-dg2-434/igt@kms_cursor_legacy@cursorb-vs-flipb-varying-size.html
   [73]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-435/igt@kms_cursor_legacy@cursorb-vs-flipb-varying-size.html

  * igt@kms_cursor_legacy@single-bo:
    - shard-adlp:         [DMESG-WARN][74] ([Intel XE#2953] / [Intel XE#4173]) -> [PASS][75] +9 other tests pass
   [74]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-adlp-2/igt@kms_cursor_legacy@single-bo.html
   [75]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-adlp-9/igt@kms_cursor_legacy@single-bo.html

  * igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
    - shard-bmg:          [SKIP][76] ([Intel XE#2316]) -> [PASS][77] +5 other tests pass
   [76]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-bmg-6/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible.html
   [77]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-2/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible.html

  * igt@kms_flip@flip-vs-rmfb-interruptible:
    - shard-adlp:         [DMESG-WARN][78] ([Intel XE#4543] / [Intel XE#5208]) -> [PASS][79]
   [78]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-adlp-1/igt@kms_flip@flip-vs-rmfb-interruptible.html
   [79]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-adlp-1/igt@kms_flip@flip-vs-rmfb-interruptible.html

  * igt@kms_flip@flip-vs-rmfb-interruptible@b-hdmi-a1:
    - shard-adlp:         [DMESG-WARN][80] ([Intel XE#4543]) -> [PASS][81] +16 other tests pass
   [80]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-adlp-1/igt@kms_flip@flip-vs-rmfb-interruptible@b-hdmi-a1.html
   [81]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-adlp-1/igt@kms_flip@flip-vs-rmfb-interruptible@b-hdmi-a1.html

  * igt@kms_flip_tiling@flip-change-tiling@pipe-b-hdmi-a-1-x-to-y:
    - shard-adlp:         [DMESG-FAIL][82] ([Intel XE#4543]) -> [PASS][83]
   [82]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-adlp-4/igt@kms_flip_tiling@flip-change-tiling@pipe-b-hdmi-a-1-x-to-y.html
   [83]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-adlp-4/igt@kms_flip_tiling@flip-change-tiling@pipe-b-hdmi-a-1-x-to-y.html

  * igt@kms_flip_tiling@flip-change-tiling@pipe-c-hdmi-a-1-x-to-x:
    - shard-adlp:         [FAIL][84] ([Intel XE#1874]) -> [PASS][85] +2 other tests pass
   [84]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-adlp-4/igt@kms_flip_tiling@flip-change-tiling@pipe-c-hdmi-a-1-x-to-x.html
   [85]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-adlp-4/igt@kms_flip_tiling@flip-change-tiling@pipe-c-hdmi-a-1-x-to-x.html

  * igt@kms_hdr@static-swap:
    - shard-bmg:          [SKIP][86] ([Intel XE#1503]) -> [PASS][87]
   [86]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-bmg-6/igt@kms_hdr@static-swap.html
   [87]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-2/igt@kms_hdr@static-swap.html

  * igt@kms_plane_multiple@2x-tiling-none:
    - shard-bmg:          [SKIP][88] ([Intel XE#4596]) -> [PASS][89]
   [88]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-bmg-6/igt@kms_plane_multiple@2x-tiling-none.html
   [89]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-2/igt@kms_plane_multiple@2x-tiling-none.html

  * igt@xe_evict@evict-mixed-many-threads-small:
    - shard-bmg:          [INCOMPLETE][90] -> [PASS][91]
   [90]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-bmg-1/igt@xe_evict@evict-mixed-many-threads-small.html
   [91]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-3/igt@xe_evict@evict-mixed-many-threads-small.html

  * igt@xe_exec_system_allocator@evict-malloc:
    - shard-bmg:          [ABORT][92] ([Intel XE#3970]) -> [PASS][93]
   [92]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-bmg-5/igt@xe_exec_system_allocator@evict-malloc.html
   [93]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-4/igt@xe_exec_system_allocator@evict-malloc.html

  * {igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-single-vma}:
    - shard-lnl:          [FAIL][94] ([Intel XE#6267]) -> [PASS][95]
   [94]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-lnl-3/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-single-vma.html
   [95]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-lnl-1/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-single-vma.html

  * igt@xe_fault_injection@probe-fail-guc-xe_guc_mmio_send_recv:
    - shard-dg2-set2:     [DMESG-WARN][96] ([Intel XE#5893]) -> [PASS][97]
   [96]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-dg2-466/igt@xe_fault_injection@probe-fail-guc-xe_guc_mmio_send_recv.html
   [97]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-434/igt@xe_fault_injection@probe-fail-guc-xe_guc_mmio_send_recv.html

  * igt@xe_pm@s2idle-multiple-execs:
    - shard-dg2-set2:     [TIMEOUT][98] -> [PASS][99]
   [98]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-dg2-466/igt@xe_pm@s2idle-multiple-execs.html
   [99]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-434/igt@xe_pm@s2idle-multiple-execs.html

  
#### Warnings ####

  * igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs:
    - shard-dg2-set2:     [INCOMPLETE][100] ([Intel XE#1727] / [Intel XE#2705] / [Intel XE#3113] / [Intel XE#4212] / [Intel XE#4345] / [Intel XE#4522]) -> [INCOMPLETE][101] ([Intel XE#1727] / [Intel XE#3113] / [Intel XE#4345] / [Intel XE#6168])
   [100]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-dg2-463/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs.html
   [101]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-463/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs.html

  * igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc:
    - shard-dg2-set2:     [INCOMPLETE][102] ([Intel XE#2705] / [Intel XE#3113] / [Intel XE#4212] / [Intel XE#4345]) -> [INCOMPLETE][103] ([Intel XE#1727] / [Intel XE#2705] / [Intel XE#3113] / [Intel XE#4212] / [Intel XE#4345] / [Intel XE#4522])
   [102]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-dg2-463/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc.html
   [103]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-464/igt@kms_ccs@random-ccs-data-4-tiled-dg2-rc-ccs-cc.html

  * igt@kms_content_protection@lic-type-0:
    - shard-bmg:          [SKIP][104] ([Intel XE#2341]) -> [FAIL][105] ([Intel XE#1178])
   [104]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-bmg-6/igt@kms_content_protection@lic-type-0.html
   [105]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-1/igt@kms_content_protection@lic-type-0.html

  * igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible:
    - shard-adlp:         [DMESG-WARN][106] ([Intel XE#4543]) -> [FAIL][107] ([Intel XE#5408])
   [106]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-adlp-9/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible.html
   [107]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-adlp-2/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible.html

  * igt@kms_flip@flip-vs-rmfb:
    - shard-adlp:         [DMESG-WARN][108] ([Intel XE#5208]) -> [DMESG-WARN][109] ([Intel XE#4543] / [Intel XE#5208])
   [108]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-adlp-2/igt@kms_flip@flip-vs-rmfb.html
   [109]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-adlp-9/igt@kms_flip@flip-vs-rmfb.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-adlp:         [DMESG-WARN][110] ([Intel XE#4543]) -> [DMESG-WARN][111] ([Intel XE#2953] / [Intel XE#4173] / [Intel XE#4543]) +1 other test dmesg-warn
   [110]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-adlp-2/igt@kms_flip@flip-vs-suspend.html
   [111]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-adlp-9/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_flip@flip-vs-suspend-interruptible:
    - shard-adlp:         [DMESG-WARN][112] ([Intel XE#2953] / [Intel XE#4173]) -> [DMESG-WARN][113] ([Intel XE#4543]) +1 other test dmesg-warn
   [112]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-adlp-6/igt@kms_flip@flip-vs-suspend-interruptible.html
   [113]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-adlp-3/igt@kms_flip@flip-vs-suspend-interruptible.html

  * igt@kms_frontbuffer_tracking@drrs-2p-primscrn-cur-indfb-draw-render:
    - shard-bmg:          [SKIP][114] ([Intel XE#2312]) -> [SKIP][115] ([Intel XE#2311]) +14 other tests skip
   [114]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-bmg-6/igt@kms_frontbuffer_tracking@drrs-2p-primscrn-cur-indfb-draw-render.html
   [115]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-1/igt@kms_frontbuffer_tracking@drrs-2p-primscrn-cur-indfb-draw-render.html

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt:
    - shard-bmg:          [SKIP][116] ([Intel XE#2312]) -> [SKIP][117] ([Intel XE#5390]) +5 other tests skip
   [116]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-bmg-6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt.html
   [117]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-2/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt:
    - shard-bmg:          [SKIP][118] ([Intel XE#5390]) -> [SKIP][119] ([Intel XE#2312]) +2 other tests skip
   [118]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-bmg-5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt.html
   [119]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-blt.html

  * igt@kms_frontbuffer_tracking@fbcdrrs-2p-scndscrn-cur-indfb-draw-mmap-wc:
    - shard-bmg:          [SKIP][120] ([Intel XE#2311]) -> [SKIP][121] ([Intel XE#2312]) +7 other tests skip
   [120]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-bmg-5/igt@kms_frontbuffer_tracking@fbcdrrs-2p-scndscrn-cur-indfb-draw-mmap-wc.html
   [121]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-6/igt@kms_frontbuffer_tracking@fbcdrrs-2p-scndscrn-cur-indfb-draw-mmap-wc.html

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-pri-indfb-multidraw:
    - shard-bmg:          [SKIP][122] ([Intel XE#2313]) -> [SKIP][123] ([Intel XE#2312]) +6 other tests skip
   [122]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-bmg-1/igt@kms_frontbuffer_tracking@fbcpsr-2p-pri-indfb-multidraw.html
   [123]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-6/igt@kms_frontbuffer_tracking@fbcpsr-2p-pri-indfb-multidraw.html

  * igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-blt:
    - shard-bmg:          [SKIP][124] ([Intel XE#2312]) -> [SKIP][125] ([Intel XE#2313]) +14 other tests skip
   [124]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-bmg-6/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-blt.html
   [125]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-2/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-blt.html

  * igt@kms_plane_multiple@2x-tiling-y:
    - shard-bmg:          [SKIP][126] ([Intel XE#5021]) -> [SKIP][127] ([Intel XE#4596])
   [126]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-bmg-1/igt@kms_plane_multiple@2x-tiling-y.html
   [127]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-6/igt@kms_plane_multiple@2x-tiling-y.html

  * igt@kms_plane_multiple@2x-tiling-yf:
    - shard-bmg:          [SKIP][128] ([Intel XE#4596]) -> [SKIP][129] ([Intel XE#5021])
   [128]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-bmg-6/igt@kms_plane_multiple@2x-tiling-yf.html
   [129]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-bmg-1/igt@kms_plane_multiple@2x-tiling-yf.html

  * igt@kms_tiled_display@basic-test-pattern:
    - shard-dg2-set2:     [FAIL][130] ([Intel XE#1729]) -> [SKIP][131] ([Intel XE#362])
   [130]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-dg2-466/igt@kms_tiled_display@basic-test-pattern.html
   [131]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-463/igt@kms_tiled_display@basic-test-pattern.html

  * igt@xe_fault_injection@probe-fail-guc-xe_guc_ct_send_recv:
    - shard-dg2-set2:     [ABORT][132] ([Intel XE#5466]) -> [ABORT][133] ([Intel XE#4917] / [Intel XE#5466])
   [132]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-dg2-434/igt@xe_fault_injection@probe-fail-guc-xe_guc_ct_send_recv.html
   [133]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-dg2-434/igt@xe_fault_injection@probe-fail-guc-xe_guc_ct_send_recv.html
    - shard-adlp:         [ABORT][134] ([Intel XE#4917] / [Intel XE#5530]) -> [ABORT][135] ([Intel XE#5530])
   [134]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b/shard-adlp-3/igt@xe_fault_injection@probe-fail-guc-xe_guc_ct_send_recv.html
   [135]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/shard-adlp-2/igt@xe_fault_injection@probe-fail-guc-xe_guc_ct_send_recv.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [Intel XE#1123]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1123
  [Intel XE#1124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1124
  [Intel XE#1126]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1126
  [Intel XE#1127]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1127
  [Intel XE#1178]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1178
  [Intel XE#1406]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1406
  [Intel XE#1489]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1489
  [Intel XE#1503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1503
  [Intel XE#1727]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1727
  [Intel XE#1729]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1729
  [Intel XE#1874]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1874
  [Intel XE#2049]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2049
  [Intel XE#2191]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2191
  [Intel XE#2291]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2291
  [Intel XE#2293]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2293
  [Intel XE#2311]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2311
  [Intel XE#2312]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2312
  [Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313
  [Intel XE#2314]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2314
  [Intel XE#2316]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2316
  [Intel XE#2322]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2322
  [Intel XE#2327]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2327
  [Intel XE#2341]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2341
  [Intel XE#2380]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2380
  [Intel XE#2597]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2597
  [Intel XE#2705]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2705
  [Intel XE#2850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2850
  [Intel XE#288]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/288
  [Intel XE#2887]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2887
  [Intel XE#2894]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2894
  [Intel XE#2939]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2939
  [Intel XE#2953]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2953
  [Intel XE#301]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/301
  [Intel XE#3113]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3113
  [Intel XE#316]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/316
  [Intel XE#3226]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3226
  [Intel XE#362]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/362
  [Intel XE#373]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/373
  [Intel XE#3970]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3970
  [Intel XE#4173]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4173
  [Intel XE#4212]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4212
  [Intel XE#4345]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4345
  [Intel XE#4522]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4522
  [Intel XE#4543]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4543
  [Intel XE#455]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/455
  [Intel XE#4596]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4596
  [Intel XE#4733]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4733
  [Intel XE#4819]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4819
  [Intel XE#4837]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4837
  [Intel XE#4915]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4915
  [Intel XE#4917]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4917
  [Intel XE#4943]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4943
  [Intel XE#5020]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5020
  [Intel XE#5021]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5021
  [Intel XE#5208]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5208
  [Intel XE#5354]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5354
  [Intel XE#5390]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5390
  [Intel XE#5408]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5408
  [Intel XE#5466]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5466
  [Intel XE#5530]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5530
  [Intel XE#5694]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5694
  [Intel XE#5893]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5893
  [Intel XE#6168]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6168
  [Intel XE#6267]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6267
  [Intel XE#6312]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6312
  [Intel XE#651]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/651
  [Intel XE#653]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/653
  [Intel XE#787]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/787
  [Intel XE#929]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/929
  [Intel XE#944]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/944


Build changes
-------------

  * Linux: xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b -> xe-pw-155689v1

  IGT_8581: 8581
  xe-3890-9bc7e2556e75bf5eb4f219b4e246a607699c1d6b: 9bc7e2556e75bf5eb4f219b4e246a607699c1d6b
  xe-pw-155689v1: 155689v1

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-155689v1/index.html

[-- Attachment #2: Type: text/html, Size: 47975 bytes --]

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 2/4] drm/log: Do not hold lock across drm_client_release()
  2025-10-09 13:16 ` [PATCH 2/4] drm/log: Do not hold lock across drm_client_release() Thomas Zimmermann
@ 2025-10-15  7:52   ` Jocelyn Falempe
  0 siblings, 0 replies; 16+ messages in thread
From: Jocelyn Falempe @ 2025-10-15  7:52 UTC (permalink / raw)
  To: Thomas Zimmermann, javierm, mripard, maarten.lankhorst
  Cc: dri-devel, linux-arm-kernel, linux-samsung-soc, intel-gfx,
	intel-xe, linux-arm-msm, freedreno, amd-gfx, linux-tegra

On 09/10/2025 15:16, Thomas Zimmermann wrote:
> When calling drm_client_release(), the client is already quiescent.
> Internal locks should therefore be dropped before the caller releases
> the client.
> 
> In the case of the DRM log, concurrency originates from the console or
> from client events. The console has been unregistered in the previous
> line. The caller of the unregister callback, drm_log_client_unregister(),
> holds clientlist_mutex from struct drm_device to protect against concurrent
> client events. It is therefore safe to release the client without holding
> locks.

Thanks, I agree, it should be safe to move drm_client_release() after 
the lock.

Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>   drivers/gpu/drm/clients/drm_log.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/clients/drm_log.c b/drivers/gpu/drm/clients/drm_log.c
> index d239f1e3c456..116e0ef9ae5d 100644
> --- a/drivers/gpu/drm/clients/drm_log.c
> +++ b/drivers/gpu/drm/clients/drm_log.c
> @@ -302,8 +302,8 @@ static void drm_log_client_unregister(struct drm_client_dev *client)
>   
>   	mutex_lock(&dlog->lock);
>   	drm_log_free_scanout(client);
> -	drm_client_release(client);
>   	mutex_unlock(&dlog->lock);
> +	drm_client_release(client);
>   	kfree(dlog);
>   	drm_dbg(dev, "Unregistered with drm log\n");
>   }


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 3/4] drm/log: Add free callback
  2025-10-09 13:16 ` [PATCH 3/4] drm/log: Add free callback Thomas Zimmermann
@ 2025-10-15  7:53   ` Jocelyn Falempe
  0 siblings, 0 replies; 16+ messages in thread
From: Jocelyn Falempe @ 2025-10-15  7:53 UTC (permalink / raw)
  To: Thomas Zimmermann, javierm, mripard, maarten.lankhorst
  Cc: dri-devel, linux-arm-kernel, linux-samsung-soc, intel-gfx,
	intel-xe, linux-arm-msm, freedreno, amd-gfx, linux-tegra

On 09/10/2025 15:16, Thomas Zimmermann wrote:
> Free the client memory in the client free callback. Also move the
> debugging output into the free callback: drm_client_release() puts
> the reference on the DRM device, so pointers to the device should
> be considered dangling afterwards.

Thanks, it looks good to me.

Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>   drivers/gpu/drm/clients/drm_log.c | 14 +++++++++++---
>   1 file changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/clients/drm_log.c b/drivers/gpu/drm/clients/drm_log.c
> index 116e0ef9ae5d..470df4148e96 100644
> --- a/drivers/gpu/drm/clients/drm_log.c
> +++ b/drivers/gpu/drm/clients/drm_log.c
> @@ -293,19 +293,26 @@ static void drm_log_free_scanout(struct drm_client_dev *client)
>   	}
>   }
>   
> -static void drm_log_client_unregister(struct drm_client_dev *client)
> +static void drm_log_client_free(struct drm_client_dev *client)
>   {
>   	struct drm_log *dlog = client_to_drm_log(client);
>   	struct drm_device *dev = client->dev;
>   
> +	kfree(dlog);
> +
> +	drm_dbg(dev, "Unregistered with drm log\n");
> +}
> +
> +static void drm_log_client_unregister(struct drm_client_dev *client)
> +{
> +	struct drm_log *dlog = client_to_drm_log(client);
> +
>   	unregister_console(&dlog->con);
>   
>   	mutex_lock(&dlog->lock);
>   	drm_log_free_scanout(client);
>   	mutex_unlock(&dlog->lock);
>   	drm_client_release(client);
> -	kfree(dlog);
> -	drm_dbg(dev, "Unregistered with drm log\n");
>   }
>   
>   static int drm_log_client_hotplug(struct drm_client_dev *client)
> @@ -339,6 +346,7 @@ static int drm_log_client_resume(struct drm_client_dev *client, bool _console_lo
>   
>   static const struct drm_client_funcs drm_log_client_funcs = {
>   	.owner		= THIS_MODULE,
> +	.free		= drm_log_client_free,
>   	.unregister	= drm_log_client_unregister,
>   	.hotplug	= drm_log_client_hotplug,
>   	.suspend	= drm_log_client_suspend,


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 4/4] drm/client: Do not free client memory by default
  2025-10-09 13:16 ` [PATCH 4/4] drm/client: Do not free client memory by default Thomas Zimmermann
@ 2025-10-15  8:20   ` Jocelyn Falempe
  0 siblings, 0 replies; 16+ messages in thread
From: Jocelyn Falempe @ 2025-10-15  8:20 UTC (permalink / raw)
  To: Thomas Zimmermann, javierm, mripard, maarten.lankhorst
  Cc: dri-devel, linux-arm-kernel, linux-samsung-soc, intel-gfx,
	intel-xe, linux-arm-msm, freedreno, amd-gfx, linux-tegra

On 09/10/2025 15:16, Thomas Zimmermann wrote:
> Make no assumption on the allocation of the client's memory. For
> example, amdgpu stores a client within another data structures,
> where it cannot be freed by itself.
> 
> The correct place to free the client's memory is the client's free
> callback. All existing clients implement this.

Thanks, it looks good to me.

Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>


> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>   drivers/gpu/drm/drm_client_event.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_client_event.c b/drivers/gpu/drm/drm_client_event.c
> index c83196ad8b59..f36fe0392ce6 100644
> --- a/drivers/gpu/drm/drm_client_event.c
> +++ b/drivers/gpu/drm/drm_client_event.c
> @@ -39,12 +39,13 @@ void drm_client_dev_unregister(struct drm_device *dev)
>   	mutex_lock(&dev->clientlist_mutex);
>   	list_for_each_entry_safe(client, tmp, &dev->clientlist, list) {
>   		list_del(&client->list);
> -		if (client->funcs && client->funcs->unregister) {
> +		/*
> +		 * Unregistering consumes and frees the client.
> +		 */
> +		if (client->funcs && client->funcs->unregister)
>   			client->funcs->unregister(client);
> -		} else {
> +		else
>   			drm_client_release(client);
> -			kfree(client);
> -		}
>   	}
>   	mutex_unlock(&dev->clientlist_mutex);
>   }


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 1/4] drm/client: Add client free callback to unprepare fb_helper
  2025-10-09 13:16 ` [PATCH 1/4] drm/client: Add client free callback to unprepare fb_helper Thomas Zimmermann
  2025-10-09 13:32   ` Dmitry Baryshkov
@ 2025-10-21 13:29   ` Tomi Valkeinen
  2025-10-21 13:54   ` Patrik Jakobsson
                     ` (2 subsequent siblings)
  4 siblings, 0 replies; 16+ messages in thread
From: Tomi Valkeinen @ 2025-10-21 13:29 UTC (permalink / raw)
  To: Thomas Zimmermann, jfalempe, javierm, mripard, maarten.lankhorst
  Cc: dri-devel, linux-arm-kernel, linux-samsung-soc, intel-gfx,
	intel-xe, linux-arm-msm, freedreno, amd-gfx, linux-tegra

On 09/10/2025 16:16, Thomas Zimmermann wrote:
> Add free callback to struct drm_client_funcs. Invoke function to
> free the client memory as part of the release process. Implement
> free for fbdev emulation.
> 
> Fbdev emulation allocates and prepares client memory in
> drm_fbdev_client_setup(). The release happens in fb_destroy from
> struct fb_ops. Multiple implementations of this callback exist in
> the various drivers that provide fbdev implementation. Each of them
> needs to follow the implementation details of the fbdev setup code.
> 
> Adding a free callback for the client puts the unprepare and release
> of the fbdev client in a single place.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>  drivers/gpu/drm/armada/armada_fbdev.c      |  2 --
>  drivers/gpu/drm/clients/drm_fbdev_client.c | 17 +++++++++++++++--
>  drivers/gpu/drm/drm_client.c               |  4 ++++
>  drivers/gpu/drm/drm_fbdev_dma.c            |  4 ----
>  drivers/gpu/drm/drm_fbdev_shmem.c          |  2 --
>  drivers/gpu/drm/drm_fbdev_ttm.c            |  2 --
>  drivers/gpu/drm/exynos/exynos_drm_fbdev.c  |  2 --
>  drivers/gpu/drm/gma500/fbdev.c             |  3 ---
>  drivers/gpu/drm/i915/display/intel_fbdev.c |  2 --
>  drivers/gpu/drm/msm/msm_fbdev.c            |  2 --
>  drivers/gpu/drm/omapdrm/omap_fbdev.c       |  2 --

For omapdrm:

Acked-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

 Tomi

>  drivers/gpu/drm/radeon/radeon_fbdev.c      |  2 --
>  drivers/gpu/drm/tegra/fbdev.c              |  2 --
>  include/drm/drm_client.h                   | 10 ++++++++++
>  14 files changed, 29 insertions(+), 27 deletions(-)
> 
> diff --git a/drivers/gpu/drm/armada/armada_fbdev.c b/drivers/gpu/drm/armada/armada_fbdev.c
> index cb53cc91bafb..22e2081bfa04 100644
> --- a/drivers/gpu/drm/armada/armada_fbdev.c
> +++ b/drivers/gpu/drm/armada/armada_fbdev.c
> @@ -28,8 +28,6 @@ static void armada_fbdev_fb_destroy(struct fb_info *info)
>  	fbh->fb->funcs->destroy(fbh->fb);
>  
>  	drm_client_release(&fbh->client);
> -	drm_fb_helper_unprepare(fbh);
> -	kfree(fbh);
>  }
>  
>  static const struct fb_ops armada_fb_ops = {
> diff --git a/drivers/gpu/drm/clients/drm_fbdev_client.c b/drivers/gpu/drm/clients/drm_fbdev_client.c
> index f894ba52bdb5..5336accab1b6 100644
> --- a/drivers/gpu/drm/clients/drm_fbdev_client.c
> +++ b/drivers/gpu/drm/clients/drm_fbdev_client.c
> @@ -13,16 +13,28 @@
>   * struct drm_client_funcs
>   */
>  
> +static void drm_fbdev_client_free(struct drm_client_dev *client)
> +{
> +	struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
> +
> +	drm_fb_helper_unprepare(fb_helper);
> +	kfree(fb_helper);
> +}
> +
>  static void drm_fbdev_client_unregister(struct drm_client_dev *client)
>  {
>  	struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
>  
>  	if (fb_helper->info) {
> +		/*
> +		 * Fully probed framebuffer device
> +		 */
>  		drm_fb_helper_unregister_info(fb_helper);
>  	} else {
> +		/*
> +		 * Partially initialized client, no framebuffer device yet
> +		 */
>  		drm_client_release(&fb_helper->client);
> -		drm_fb_helper_unprepare(fb_helper);
> -		kfree(fb_helper);
>  	}
>  }
>  
> @@ -88,6 +100,7 @@ static int drm_fbdev_client_resume(struct drm_client_dev *client, bool holds_con
>  
>  static const struct drm_client_funcs drm_fbdev_client_funcs = {
>  	.owner		= THIS_MODULE,
> +	.free		= drm_fbdev_client_free,
>  	.unregister	= drm_fbdev_client_unregister,
>  	.restore	= drm_fbdev_client_restore,
>  	.hotplug	= drm_fbdev_client_hotplug,
> diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
> index 3fa38d4ac70b..fe9c6d7083ea 100644
> --- a/drivers/gpu/drm/drm_client.c
> +++ b/drivers/gpu/drm/drm_client.c
> @@ -168,6 +168,10 @@ void drm_client_release(struct drm_client_dev *client)
>  
>  	drm_client_modeset_free(client);
>  	drm_client_close(client);
> +
> +	if (client->funcs && client->funcs->free)
> +		client->funcs->free(client);
> +
>  	drm_dev_put(dev);
>  }
>  EXPORT_SYMBOL(drm_client_release);
> diff --git a/drivers/gpu/drm/drm_fbdev_dma.c b/drivers/gpu/drm/drm_fbdev_dma.c
> index 8bd626ef16c7..c6196293e424 100644
> --- a/drivers/gpu/drm/drm_fbdev_dma.c
> +++ b/drivers/gpu/drm/drm_fbdev_dma.c
> @@ -57,8 +57,6 @@ static void drm_fbdev_dma_fb_destroy(struct fb_info *info)
>  	drm_client_buffer_vunmap(fb_helper->buffer);
>  	drm_client_framebuffer_delete(fb_helper->buffer);
>  	drm_client_release(&fb_helper->client);
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>  }
>  
>  static const struct fb_ops drm_fbdev_dma_fb_ops = {
> @@ -92,8 +90,6 @@ static void drm_fbdev_dma_shadowed_fb_destroy(struct fb_info *info)
>  	drm_client_buffer_vunmap(fb_helper->buffer);
>  	drm_client_framebuffer_delete(fb_helper->buffer);
>  	drm_client_release(&fb_helper->client);
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>  }
>  
>  static const struct fb_ops drm_fbdev_dma_shadowed_fb_ops = {
> diff --git a/drivers/gpu/drm/drm_fbdev_shmem.c b/drivers/gpu/drm/drm_fbdev_shmem.c
> index 1e827bf8b815..51573058df6f 100644
> --- a/drivers/gpu/drm/drm_fbdev_shmem.c
> +++ b/drivers/gpu/drm/drm_fbdev_shmem.c
> @@ -65,8 +65,6 @@ static void drm_fbdev_shmem_fb_destroy(struct fb_info *info)
>  	drm_client_buffer_vunmap(fb_helper->buffer);
>  	drm_client_framebuffer_delete(fb_helper->buffer);
>  	drm_client_release(&fb_helper->client);
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>  }
>  
>  static const struct fb_ops drm_fbdev_shmem_fb_ops = {
> diff --git a/drivers/gpu/drm/drm_fbdev_ttm.c b/drivers/gpu/drm/drm_fbdev_ttm.c
> index 85feb55bba11..ccf460fbc1f0 100644
> --- a/drivers/gpu/drm/drm_fbdev_ttm.c
> +++ b/drivers/gpu/drm/drm_fbdev_ttm.c
> @@ -53,8 +53,6 @@ static void drm_fbdev_ttm_fb_destroy(struct fb_info *info)
>  	drm_client_framebuffer_delete(fb_helper->buffer);
>  
>  	drm_client_release(&fb_helper->client);
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>  }
>  
>  static const struct fb_ops drm_fbdev_ttm_fb_ops = {
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> index 93de25b77e68..a3bd21a827ad 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> @@ -42,8 +42,6 @@ static void exynos_drm_fb_destroy(struct fb_info *info)
>  	drm_framebuffer_remove(fb);
>  
>  	drm_client_release(&fb_helper->client);
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>  }
>  
>  static const struct fb_ops exynos_drm_fb_ops = {
> diff --git a/drivers/gpu/drm/gma500/fbdev.c b/drivers/gpu/drm/gma500/fbdev.c
> index a6af21514cff..bc92fa24a1e2 100644
> --- a/drivers/gpu/drm/gma500/fbdev.c
> +++ b/drivers/gpu/drm/gma500/fbdev.c
> @@ -84,9 +84,6 @@ static void psb_fbdev_fb_destroy(struct fb_info *info)
>  	drm_gem_object_put(obj);
>  
>  	drm_client_release(&fb_helper->client);
> -
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>  }
>  
>  static const struct fb_ops psb_fbdev_fb_ops = {
> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
> index 3fbdf75415cc..d5f26c8bb102 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
> @@ -146,8 +146,6 @@ static void intel_fbdev_fb_destroy(struct fb_info *info)
>  	drm_framebuffer_remove(fb_helper->fb);
>  
>  	drm_client_release(&fb_helper->client);
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>  }
>  
>  __diag_push();
> diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
> index b5969374d53f..aad6fb77f0de 100644
> --- a/drivers/gpu/drm/msm/msm_fbdev.c
> +++ b/drivers/gpu/drm/msm/msm_fbdev.c
> @@ -52,8 +52,6 @@ static void msm_fbdev_fb_destroy(struct fb_info *info)
>  	drm_framebuffer_remove(fb);
>  
>  	drm_client_release(&helper->client);
> -	drm_fb_helper_unprepare(helper);
> -	kfree(helper);
>  }
>  
>  static const struct fb_ops msm_fb_ops = {
> diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> index 948af7ec1130..b5df2923d2a6 100644
> --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
> +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> @@ -103,8 +103,6 @@ static void omap_fbdev_fb_destroy(struct fb_info *info)
>  	drm_framebuffer_remove(fb);
>  
>  	drm_client_release(&helper->client);
> -	drm_fb_helper_unprepare(helper);
> -	kfree(helper);
>  }
>  
>  /*
> diff --git a/drivers/gpu/drm/radeon/radeon_fbdev.c b/drivers/gpu/drm/radeon/radeon_fbdev.c
> index dc81b0c2dbff..4df6c9167bf0 100644
> --- a/drivers/gpu/drm/radeon/radeon_fbdev.c
> +++ b/drivers/gpu/drm/radeon/radeon_fbdev.c
> @@ -184,8 +184,6 @@ static void radeon_fbdev_fb_destroy(struct fb_info *info)
>  	radeon_fbdev_destroy_pinned_object(gobj);
>  
>  	drm_client_release(&fb_helper->client);
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>  }
>  
>  static const struct fb_ops radeon_fbdev_fb_ops = {
> diff --git a/drivers/gpu/drm/tegra/fbdev.c b/drivers/gpu/drm/tegra/fbdev.c
> index 1b70f5e164af..91aece6f34e0 100644
> --- a/drivers/gpu/drm/tegra/fbdev.c
> +++ b/drivers/gpu/drm/tegra/fbdev.c
> @@ -53,8 +53,6 @@ static void tegra_fbdev_fb_destroy(struct fb_info *info)
>  	drm_framebuffer_remove(fb);
>  
>  	drm_client_release(&helper->client);
> -	drm_fb_helper_unprepare(helper);
> -	kfree(helper);
>  }
>  
>  static const struct fb_ops tegra_fb_ops = {
> diff --git a/include/drm/drm_client.h b/include/drm/drm_client.h
> index bdd845e383ef..eecb8d6e15c7 100644
> --- a/include/drm/drm_client.h
> +++ b/include/drm/drm_client.h
> @@ -28,6 +28,16 @@ struct drm_client_funcs {
>  	 */
>  	struct module *owner;
>  
> +	/**
> +	 * @free:
> +	 *
> +	 * Called when the client gets unregistered. Implementations should
> +	 * release all client-specific data and free the memory.
> +	 *
> +	 * This callback is optional.
> +	 */
> +	void (*free)(struct drm_client_dev *client);
> +
>  	/**
>  	 * @unregister:
>  	 *


^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 1/4] drm/client: Add client free callback to unprepare fb_helper
  2025-10-09 13:16 ` [PATCH 1/4] drm/client: Add client free callback to unprepare fb_helper Thomas Zimmermann
  2025-10-09 13:32   ` Dmitry Baryshkov
  2025-10-21 13:29   ` Tomi Valkeinen
@ 2025-10-21 13:54   ` Patrik Jakobsson
  2025-10-23 13:13   ` Thomas Zimmermann
  2025-10-23 15:39   ` Thomas Zimmermann
  4 siblings, 0 replies; 16+ messages in thread
From: Patrik Jakobsson @ 2025-10-21 13:54 UTC (permalink / raw)
  To: Thomas Zimmermann
  Cc: jfalempe, javierm, mripard, maarten.lankhorst, dri-devel,
	linux-arm-kernel, linux-samsung-soc, intel-gfx, intel-xe,
	linux-arm-msm, freedreno, amd-gfx, linux-tegra

On Thu, Oct 9, 2025 at 3:31 PM Thomas Zimmermann <tzimmermann@suse.de> wrote:
>
> Add free callback to struct drm_client_funcs. Invoke function to
> free the client memory as part of the release process. Implement
> free for fbdev emulation.
>
> Fbdev emulation allocates and prepares client memory in
> drm_fbdev_client_setup(). The release happens in fb_destroy from
> struct fb_ops. Multiple implementations of this callback exist in
> the various drivers that provide fbdev implementation. Each of them
> needs to follow the implementation details of the fbdev setup code.
>
> Adding a free callback for the client puts the unprepare and release
> of the fbdev client in a single place.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>

For gma500:
Acked-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>

> ---
>  drivers/gpu/drm/armada/armada_fbdev.c      |  2 --
>  drivers/gpu/drm/clients/drm_fbdev_client.c | 17 +++++++++++++++--
>  drivers/gpu/drm/drm_client.c               |  4 ++++
>  drivers/gpu/drm/drm_fbdev_dma.c            |  4 ----
>  drivers/gpu/drm/drm_fbdev_shmem.c          |  2 --
>  drivers/gpu/drm/drm_fbdev_ttm.c            |  2 --
>  drivers/gpu/drm/exynos/exynos_drm_fbdev.c  |  2 --
>  drivers/gpu/drm/gma500/fbdev.c             |  3 ---
>  drivers/gpu/drm/i915/display/intel_fbdev.c |  2 --
>  drivers/gpu/drm/msm/msm_fbdev.c            |  2 --
>  drivers/gpu/drm/omapdrm/omap_fbdev.c       |  2 --
>  drivers/gpu/drm/radeon/radeon_fbdev.c      |  2 --
>  drivers/gpu/drm/tegra/fbdev.c              |  2 --
>  include/drm/drm_client.h                   | 10 ++++++++++
>  14 files changed, 29 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/gpu/drm/armada/armada_fbdev.c b/drivers/gpu/drm/armada/armada_fbdev.c
> index cb53cc91bafb..22e2081bfa04 100644
> --- a/drivers/gpu/drm/armada/armada_fbdev.c
> +++ b/drivers/gpu/drm/armada/armada_fbdev.c
> @@ -28,8 +28,6 @@ static void armada_fbdev_fb_destroy(struct fb_info *info)
>         fbh->fb->funcs->destroy(fbh->fb);
>
>         drm_client_release(&fbh->client);
> -       drm_fb_helper_unprepare(fbh);
> -       kfree(fbh);
>  }
>
>  static const struct fb_ops armada_fb_ops = {
> diff --git a/drivers/gpu/drm/clients/drm_fbdev_client.c b/drivers/gpu/drm/clients/drm_fbdev_client.c
> index f894ba52bdb5..5336accab1b6 100644
> --- a/drivers/gpu/drm/clients/drm_fbdev_client.c
> +++ b/drivers/gpu/drm/clients/drm_fbdev_client.c
> @@ -13,16 +13,28 @@
>   * struct drm_client_funcs
>   */
>
> +static void drm_fbdev_client_free(struct drm_client_dev *client)
> +{
> +       struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
> +
> +       drm_fb_helper_unprepare(fb_helper);
> +       kfree(fb_helper);
> +}
> +
>  static void drm_fbdev_client_unregister(struct drm_client_dev *client)
>  {
>         struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
>
>         if (fb_helper->info) {
> +               /*
> +                * Fully probed framebuffer device
> +                */
>                 drm_fb_helper_unregister_info(fb_helper);
>         } else {
> +               /*
> +                * Partially initialized client, no framebuffer device yet
> +                */
>                 drm_client_release(&fb_helper->client);
> -               drm_fb_helper_unprepare(fb_helper);
> -               kfree(fb_helper);
>         }
>  }
>
> @@ -88,6 +100,7 @@ static int drm_fbdev_client_resume(struct drm_client_dev *client, bool holds_con
>
>  static const struct drm_client_funcs drm_fbdev_client_funcs = {
>         .owner          = THIS_MODULE,
> +       .free           = drm_fbdev_client_free,
>         .unregister     = drm_fbdev_client_unregister,
>         .restore        = drm_fbdev_client_restore,
>         .hotplug        = drm_fbdev_client_hotplug,
> diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
> index 3fa38d4ac70b..fe9c6d7083ea 100644
> --- a/drivers/gpu/drm/drm_client.c
> +++ b/drivers/gpu/drm/drm_client.c
> @@ -168,6 +168,10 @@ void drm_client_release(struct drm_client_dev *client)
>
>         drm_client_modeset_free(client);
>         drm_client_close(client);
> +
> +       if (client->funcs && client->funcs->free)
> +               client->funcs->free(client);
> +
>         drm_dev_put(dev);
>  }
>  EXPORT_SYMBOL(drm_client_release);
> diff --git a/drivers/gpu/drm/drm_fbdev_dma.c b/drivers/gpu/drm/drm_fbdev_dma.c
> index 8bd626ef16c7..c6196293e424 100644
> --- a/drivers/gpu/drm/drm_fbdev_dma.c
> +++ b/drivers/gpu/drm/drm_fbdev_dma.c
> @@ -57,8 +57,6 @@ static void drm_fbdev_dma_fb_destroy(struct fb_info *info)
>         drm_client_buffer_vunmap(fb_helper->buffer);
>         drm_client_framebuffer_delete(fb_helper->buffer);
>         drm_client_release(&fb_helper->client);
> -       drm_fb_helper_unprepare(fb_helper);
> -       kfree(fb_helper);
>  }
>
>  static const struct fb_ops drm_fbdev_dma_fb_ops = {
> @@ -92,8 +90,6 @@ static void drm_fbdev_dma_shadowed_fb_destroy(struct fb_info *info)
>         drm_client_buffer_vunmap(fb_helper->buffer);
>         drm_client_framebuffer_delete(fb_helper->buffer);
>         drm_client_release(&fb_helper->client);
> -       drm_fb_helper_unprepare(fb_helper);
> -       kfree(fb_helper);
>  }
>
>  static const struct fb_ops drm_fbdev_dma_shadowed_fb_ops = {
> diff --git a/drivers/gpu/drm/drm_fbdev_shmem.c b/drivers/gpu/drm/drm_fbdev_shmem.c
> index 1e827bf8b815..51573058df6f 100644
> --- a/drivers/gpu/drm/drm_fbdev_shmem.c
> +++ b/drivers/gpu/drm/drm_fbdev_shmem.c
> @@ -65,8 +65,6 @@ static void drm_fbdev_shmem_fb_destroy(struct fb_info *info)
>         drm_client_buffer_vunmap(fb_helper->buffer);
>         drm_client_framebuffer_delete(fb_helper->buffer);
>         drm_client_release(&fb_helper->client);
> -       drm_fb_helper_unprepare(fb_helper);
> -       kfree(fb_helper);
>  }
>
>  static const struct fb_ops drm_fbdev_shmem_fb_ops = {
> diff --git a/drivers/gpu/drm/drm_fbdev_ttm.c b/drivers/gpu/drm/drm_fbdev_ttm.c
> index 85feb55bba11..ccf460fbc1f0 100644
> --- a/drivers/gpu/drm/drm_fbdev_ttm.c
> +++ b/drivers/gpu/drm/drm_fbdev_ttm.c
> @@ -53,8 +53,6 @@ static void drm_fbdev_ttm_fb_destroy(struct fb_info *info)
>         drm_client_framebuffer_delete(fb_helper->buffer);
>
>         drm_client_release(&fb_helper->client);
> -       drm_fb_helper_unprepare(fb_helper);
> -       kfree(fb_helper);
>  }
>
>  static const struct fb_ops drm_fbdev_ttm_fb_ops = {
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> index 93de25b77e68..a3bd21a827ad 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> @@ -42,8 +42,6 @@ static void exynos_drm_fb_destroy(struct fb_info *info)
>         drm_framebuffer_remove(fb);
>
>         drm_client_release(&fb_helper->client);
> -       drm_fb_helper_unprepare(fb_helper);
> -       kfree(fb_helper);
>  }
>
>  static const struct fb_ops exynos_drm_fb_ops = {
> diff --git a/drivers/gpu/drm/gma500/fbdev.c b/drivers/gpu/drm/gma500/fbdev.c
> index a6af21514cff..bc92fa24a1e2 100644
> --- a/drivers/gpu/drm/gma500/fbdev.c
> +++ b/drivers/gpu/drm/gma500/fbdev.c
> @@ -84,9 +84,6 @@ static void psb_fbdev_fb_destroy(struct fb_info *info)
>         drm_gem_object_put(obj);
>
>         drm_client_release(&fb_helper->client);
> -
> -       drm_fb_helper_unprepare(fb_helper);
> -       kfree(fb_helper);
>  }
>
>  static const struct fb_ops psb_fbdev_fb_ops = {
> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
> index 3fbdf75415cc..d5f26c8bb102 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
> @@ -146,8 +146,6 @@ static void intel_fbdev_fb_destroy(struct fb_info *info)
>         drm_framebuffer_remove(fb_helper->fb);
>
>         drm_client_release(&fb_helper->client);
> -       drm_fb_helper_unprepare(fb_helper);
> -       kfree(fb_helper);
>  }
>
>  __diag_push();
> diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
> index b5969374d53f..aad6fb77f0de 100644
> --- a/drivers/gpu/drm/msm/msm_fbdev.c
> +++ b/drivers/gpu/drm/msm/msm_fbdev.c
> @@ -52,8 +52,6 @@ static void msm_fbdev_fb_destroy(struct fb_info *info)
>         drm_framebuffer_remove(fb);
>
>         drm_client_release(&helper->client);
> -       drm_fb_helper_unprepare(helper);
> -       kfree(helper);
>  }
>
>  static const struct fb_ops msm_fb_ops = {
> diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> index 948af7ec1130..b5df2923d2a6 100644
> --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
> +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> @@ -103,8 +103,6 @@ static void omap_fbdev_fb_destroy(struct fb_info *info)
>         drm_framebuffer_remove(fb);
>
>         drm_client_release(&helper->client);
> -       drm_fb_helper_unprepare(helper);
> -       kfree(helper);
>  }
>
>  /*
> diff --git a/drivers/gpu/drm/radeon/radeon_fbdev.c b/drivers/gpu/drm/radeon/radeon_fbdev.c
> index dc81b0c2dbff..4df6c9167bf0 100644
> --- a/drivers/gpu/drm/radeon/radeon_fbdev.c
> +++ b/drivers/gpu/drm/radeon/radeon_fbdev.c
> @@ -184,8 +184,6 @@ static void radeon_fbdev_fb_destroy(struct fb_info *info)
>         radeon_fbdev_destroy_pinned_object(gobj);
>
>         drm_client_release(&fb_helper->client);
> -       drm_fb_helper_unprepare(fb_helper);
> -       kfree(fb_helper);
>  }
>
>  static const struct fb_ops radeon_fbdev_fb_ops = {
> diff --git a/drivers/gpu/drm/tegra/fbdev.c b/drivers/gpu/drm/tegra/fbdev.c
> index 1b70f5e164af..91aece6f34e0 100644
> --- a/drivers/gpu/drm/tegra/fbdev.c
> +++ b/drivers/gpu/drm/tegra/fbdev.c
> @@ -53,8 +53,6 @@ static void tegra_fbdev_fb_destroy(struct fb_info *info)
>         drm_framebuffer_remove(fb);
>
>         drm_client_release(&helper->client);
> -       drm_fb_helper_unprepare(helper);
> -       kfree(helper);
>  }
>
>  static const struct fb_ops tegra_fb_ops = {
> diff --git a/include/drm/drm_client.h b/include/drm/drm_client.h
> index bdd845e383ef..eecb8d6e15c7 100644
> --- a/include/drm/drm_client.h
> +++ b/include/drm/drm_client.h
> @@ -28,6 +28,16 @@ struct drm_client_funcs {
>          */
>         struct module *owner;
>
> +       /**
> +        * @free:
> +        *
> +        * Called when the client gets unregistered. Implementations should
> +        * release all client-specific data and free the memory.
> +        *
> +        * This callback is optional.
> +        */
> +       void (*free)(struct drm_client_dev *client);
> +
>         /**
>          * @unregister:
>          *
> --
> 2.51.0
>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 1/4] drm/client: Add client free callback to unprepare fb_helper
  2025-10-09 13:16 ` [PATCH 1/4] drm/client: Add client free callback to unprepare fb_helper Thomas Zimmermann
                     ` (2 preceding siblings ...)
  2025-10-21 13:54   ` Patrik Jakobsson
@ 2025-10-23 13:13   ` Thomas Zimmermann
  2025-10-23 15:39   ` Thomas Zimmermann
  4 siblings, 0 replies; 16+ messages in thread
From: Thomas Zimmermann @ 2025-10-23 13:13 UTC (permalink / raw)
  To: jfalempe, javierm, mripard, maarten.lankhorst
  Cc: dri-devel, linux-arm-kernel, linux-samsung-soc, intel-gfx,
	intel-xe, linux-arm-msm, freedreno, amd-gfx, linux-tegra

Acked by Jani via irc to go through  drm-misc

Am 09.10.25 um 15:16 schrieb Thomas Zimmermann:
> Add free callback to struct drm_client_funcs. Invoke function to
> free the client memory as part of the release process. Implement
> free for fbdev emulation.
>
> Fbdev emulation allocates and prepares client memory in
> drm_fbdev_client_setup(). The release happens in fb_destroy from
> struct fb_ops. Multiple implementations of this callback exist in
> the various drivers that provide fbdev implementation. Each of them
> needs to follow the implementation details of the fbdev setup code.
>
> Adding a free callback for the client puts the unprepare and release
> of the fbdev client in a single place.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>   drivers/gpu/drm/armada/armada_fbdev.c      |  2 --
>   drivers/gpu/drm/clients/drm_fbdev_client.c | 17 +++++++++++++++--
>   drivers/gpu/drm/drm_client.c               |  4 ++++
>   drivers/gpu/drm/drm_fbdev_dma.c            |  4 ----
>   drivers/gpu/drm/drm_fbdev_shmem.c          |  2 --
>   drivers/gpu/drm/drm_fbdev_ttm.c            |  2 --
>   drivers/gpu/drm/exynos/exynos_drm_fbdev.c  |  2 --
>   drivers/gpu/drm/gma500/fbdev.c             |  3 ---
>   drivers/gpu/drm/i915/display/intel_fbdev.c |  2 --
>   drivers/gpu/drm/msm/msm_fbdev.c            |  2 --
>   drivers/gpu/drm/omapdrm/omap_fbdev.c       |  2 --
>   drivers/gpu/drm/radeon/radeon_fbdev.c      |  2 --
>   drivers/gpu/drm/tegra/fbdev.c              |  2 --
>   include/drm/drm_client.h                   | 10 ++++++++++
>   14 files changed, 29 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/gpu/drm/armada/armada_fbdev.c b/drivers/gpu/drm/armada/armada_fbdev.c
> index cb53cc91bafb..22e2081bfa04 100644
> --- a/drivers/gpu/drm/armada/armada_fbdev.c
> +++ b/drivers/gpu/drm/armada/armada_fbdev.c
> @@ -28,8 +28,6 @@ static void armada_fbdev_fb_destroy(struct fb_info *info)
>   	fbh->fb->funcs->destroy(fbh->fb);
>   
>   	drm_client_release(&fbh->client);
> -	drm_fb_helper_unprepare(fbh);
> -	kfree(fbh);
>   }
>   
>   static const struct fb_ops armada_fb_ops = {
> diff --git a/drivers/gpu/drm/clients/drm_fbdev_client.c b/drivers/gpu/drm/clients/drm_fbdev_client.c
> index f894ba52bdb5..5336accab1b6 100644
> --- a/drivers/gpu/drm/clients/drm_fbdev_client.c
> +++ b/drivers/gpu/drm/clients/drm_fbdev_client.c
> @@ -13,16 +13,28 @@
>    * struct drm_client_funcs
>    */
>   
> +static void drm_fbdev_client_free(struct drm_client_dev *client)
> +{
> +	struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
> +
> +	drm_fb_helper_unprepare(fb_helper);
> +	kfree(fb_helper);
> +}
> +
>   static void drm_fbdev_client_unregister(struct drm_client_dev *client)
>   {
>   	struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
>   
>   	if (fb_helper->info) {
> +		/*
> +		 * Fully probed framebuffer device
> +		 */
>   		drm_fb_helper_unregister_info(fb_helper);
>   	} else {
> +		/*
> +		 * Partially initialized client, no framebuffer device yet
> +		 */
>   		drm_client_release(&fb_helper->client);
> -		drm_fb_helper_unprepare(fb_helper);
> -		kfree(fb_helper);
>   	}
>   }
>   
> @@ -88,6 +100,7 @@ static int drm_fbdev_client_resume(struct drm_client_dev *client, bool holds_con
>   
>   static const struct drm_client_funcs drm_fbdev_client_funcs = {
>   	.owner		= THIS_MODULE,
> +	.free		= drm_fbdev_client_free,
>   	.unregister	= drm_fbdev_client_unregister,
>   	.restore	= drm_fbdev_client_restore,
>   	.hotplug	= drm_fbdev_client_hotplug,
> diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
> index 3fa38d4ac70b..fe9c6d7083ea 100644
> --- a/drivers/gpu/drm/drm_client.c
> +++ b/drivers/gpu/drm/drm_client.c
> @@ -168,6 +168,10 @@ void drm_client_release(struct drm_client_dev *client)
>   
>   	drm_client_modeset_free(client);
>   	drm_client_close(client);
> +
> +	if (client->funcs && client->funcs->free)
> +		client->funcs->free(client);
> +
>   	drm_dev_put(dev);
>   }
>   EXPORT_SYMBOL(drm_client_release);
> diff --git a/drivers/gpu/drm/drm_fbdev_dma.c b/drivers/gpu/drm/drm_fbdev_dma.c
> index 8bd626ef16c7..c6196293e424 100644
> --- a/drivers/gpu/drm/drm_fbdev_dma.c
> +++ b/drivers/gpu/drm/drm_fbdev_dma.c
> @@ -57,8 +57,6 @@ static void drm_fbdev_dma_fb_destroy(struct fb_info *info)
>   	drm_client_buffer_vunmap(fb_helper->buffer);
>   	drm_client_framebuffer_delete(fb_helper->buffer);
>   	drm_client_release(&fb_helper->client);
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>   }
>   
>   static const struct fb_ops drm_fbdev_dma_fb_ops = {
> @@ -92,8 +90,6 @@ static void drm_fbdev_dma_shadowed_fb_destroy(struct fb_info *info)
>   	drm_client_buffer_vunmap(fb_helper->buffer);
>   	drm_client_framebuffer_delete(fb_helper->buffer);
>   	drm_client_release(&fb_helper->client);
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>   }
>   
>   static const struct fb_ops drm_fbdev_dma_shadowed_fb_ops = {
> diff --git a/drivers/gpu/drm/drm_fbdev_shmem.c b/drivers/gpu/drm/drm_fbdev_shmem.c
> index 1e827bf8b815..51573058df6f 100644
> --- a/drivers/gpu/drm/drm_fbdev_shmem.c
> +++ b/drivers/gpu/drm/drm_fbdev_shmem.c
> @@ -65,8 +65,6 @@ static void drm_fbdev_shmem_fb_destroy(struct fb_info *info)
>   	drm_client_buffer_vunmap(fb_helper->buffer);
>   	drm_client_framebuffer_delete(fb_helper->buffer);
>   	drm_client_release(&fb_helper->client);
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>   }
>   
>   static const struct fb_ops drm_fbdev_shmem_fb_ops = {
> diff --git a/drivers/gpu/drm/drm_fbdev_ttm.c b/drivers/gpu/drm/drm_fbdev_ttm.c
> index 85feb55bba11..ccf460fbc1f0 100644
> --- a/drivers/gpu/drm/drm_fbdev_ttm.c
> +++ b/drivers/gpu/drm/drm_fbdev_ttm.c
> @@ -53,8 +53,6 @@ static void drm_fbdev_ttm_fb_destroy(struct fb_info *info)
>   	drm_client_framebuffer_delete(fb_helper->buffer);
>   
>   	drm_client_release(&fb_helper->client);
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>   }
>   
>   static const struct fb_ops drm_fbdev_ttm_fb_ops = {
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> index 93de25b77e68..a3bd21a827ad 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> @@ -42,8 +42,6 @@ static void exynos_drm_fb_destroy(struct fb_info *info)
>   	drm_framebuffer_remove(fb);
>   
>   	drm_client_release(&fb_helper->client);
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>   }
>   
>   static const struct fb_ops exynos_drm_fb_ops = {
> diff --git a/drivers/gpu/drm/gma500/fbdev.c b/drivers/gpu/drm/gma500/fbdev.c
> index a6af21514cff..bc92fa24a1e2 100644
> --- a/drivers/gpu/drm/gma500/fbdev.c
> +++ b/drivers/gpu/drm/gma500/fbdev.c
> @@ -84,9 +84,6 @@ static void psb_fbdev_fb_destroy(struct fb_info *info)
>   	drm_gem_object_put(obj);
>   
>   	drm_client_release(&fb_helper->client);
> -
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>   }
>   
>   static const struct fb_ops psb_fbdev_fb_ops = {
> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
> index 3fbdf75415cc..d5f26c8bb102 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
> @@ -146,8 +146,6 @@ static void intel_fbdev_fb_destroy(struct fb_info *info)
>   	drm_framebuffer_remove(fb_helper->fb);
>   
>   	drm_client_release(&fb_helper->client);
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>   }
>   
>   __diag_push();
> diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
> index b5969374d53f..aad6fb77f0de 100644
> --- a/drivers/gpu/drm/msm/msm_fbdev.c
> +++ b/drivers/gpu/drm/msm/msm_fbdev.c
> @@ -52,8 +52,6 @@ static void msm_fbdev_fb_destroy(struct fb_info *info)
>   	drm_framebuffer_remove(fb);
>   
>   	drm_client_release(&helper->client);
> -	drm_fb_helper_unprepare(helper);
> -	kfree(helper);
>   }
>   
>   static const struct fb_ops msm_fb_ops = {
> diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> index 948af7ec1130..b5df2923d2a6 100644
> --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
> +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> @@ -103,8 +103,6 @@ static void omap_fbdev_fb_destroy(struct fb_info *info)
>   	drm_framebuffer_remove(fb);
>   
>   	drm_client_release(&helper->client);
> -	drm_fb_helper_unprepare(helper);
> -	kfree(helper);
>   }
>   
>   /*
> diff --git a/drivers/gpu/drm/radeon/radeon_fbdev.c b/drivers/gpu/drm/radeon/radeon_fbdev.c
> index dc81b0c2dbff..4df6c9167bf0 100644
> --- a/drivers/gpu/drm/radeon/radeon_fbdev.c
> +++ b/drivers/gpu/drm/radeon/radeon_fbdev.c
> @@ -184,8 +184,6 @@ static void radeon_fbdev_fb_destroy(struct fb_info *info)
>   	radeon_fbdev_destroy_pinned_object(gobj);
>   
>   	drm_client_release(&fb_helper->client);
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>   }
>   
>   static const struct fb_ops radeon_fbdev_fb_ops = {
> diff --git a/drivers/gpu/drm/tegra/fbdev.c b/drivers/gpu/drm/tegra/fbdev.c
> index 1b70f5e164af..91aece6f34e0 100644
> --- a/drivers/gpu/drm/tegra/fbdev.c
> +++ b/drivers/gpu/drm/tegra/fbdev.c
> @@ -53,8 +53,6 @@ static void tegra_fbdev_fb_destroy(struct fb_info *info)
>   	drm_framebuffer_remove(fb);
>   
>   	drm_client_release(&helper->client);
> -	drm_fb_helper_unprepare(helper);
> -	kfree(helper);
>   }
>   
>   static const struct fb_ops tegra_fb_ops = {
> diff --git a/include/drm/drm_client.h b/include/drm/drm_client.h
> index bdd845e383ef..eecb8d6e15c7 100644
> --- a/include/drm/drm_client.h
> +++ b/include/drm/drm_client.h
> @@ -28,6 +28,16 @@ struct drm_client_funcs {
>   	 */
>   	struct module *owner;
>   
> +	/**
> +	 * @free:
> +	 *
> +	 * Called when the client gets unregistered. Implementations should
> +	 * release all client-specific data and free the memory.
> +	 *
> +	 * This callback is optional.
> +	 */
> +	void (*free)(struct drm_client_dev *client);
> +
>   	/**
>   	 * @unregister:
>   	 *

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH 1/4] drm/client: Add client free callback to unprepare fb_helper
  2025-10-09 13:16 ` [PATCH 1/4] drm/client: Add client free callback to unprepare fb_helper Thomas Zimmermann
                     ` (3 preceding siblings ...)
  2025-10-23 13:13   ` Thomas Zimmermann
@ 2025-10-23 15:39   ` Thomas Zimmermann
  4 siblings, 0 replies; 16+ messages in thread
From: Thomas Zimmermann @ 2025-10-23 15:39 UTC (permalink / raw)
  To: jfalempe, javierm, mripard, maarten.lankhorst
  Cc: dri-devel, linux-arm-kernel, linux-samsung-soc, intel-gfx,
	intel-xe, linux-arm-msm, freedreno, amd-gfx, linux-tegra



Am 09.10.25 um 15:16 schrieb Thomas Zimmermann:
> Add free callback to struct drm_client_funcs. Invoke function to
> free the client memory as part of the release process. Implement
> free for fbdev emulation.
>
> Fbdev emulation allocates and prepares client memory in
> drm_fbdev_client_setup(). The release happens in fb_destroy from
> struct fb_ops. Multiple implementations of this callback exist in
> the various drivers that provide fbdev implementation. Each of them
> needs to follow the implementation details of the fbdev setup code.
>
> Adding a free callback for the client puts the unprepare and release
> of the fbdev client in a single place.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>

Acked-by: Alex Deucher <alexander.deucher@amd.com>

via irc

https://people.freedesktop.org/~cbrill/dri-log/?channel=radeon&highlight_names=&date=2025-10-23&show_html=true

> ---
>   drivers/gpu/drm/armada/armada_fbdev.c      |  2 --
>   drivers/gpu/drm/clients/drm_fbdev_client.c | 17 +++++++++++++++--
>   drivers/gpu/drm/drm_client.c               |  4 ++++
>   drivers/gpu/drm/drm_fbdev_dma.c            |  4 ----
>   drivers/gpu/drm/drm_fbdev_shmem.c          |  2 --
>   drivers/gpu/drm/drm_fbdev_ttm.c            |  2 --
>   drivers/gpu/drm/exynos/exynos_drm_fbdev.c  |  2 --
>   drivers/gpu/drm/gma500/fbdev.c             |  3 ---
>   drivers/gpu/drm/i915/display/intel_fbdev.c |  2 --
>   drivers/gpu/drm/msm/msm_fbdev.c            |  2 --
>   drivers/gpu/drm/omapdrm/omap_fbdev.c       |  2 --
>   drivers/gpu/drm/radeon/radeon_fbdev.c      |  2 --
>   drivers/gpu/drm/tegra/fbdev.c              |  2 --
>   include/drm/drm_client.h                   | 10 ++++++++++
>   14 files changed, 29 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/gpu/drm/armada/armada_fbdev.c b/drivers/gpu/drm/armada/armada_fbdev.c
> index cb53cc91bafb..22e2081bfa04 100644
> --- a/drivers/gpu/drm/armada/armada_fbdev.c
> +++ b/drivers/gpu/drm/armada/armada_fbdev.c
> @@ -28,8 +28,6 @@ static void armada_fbdev_fb_destroy(struct fb_info *info)
>   	fbh->fb->funcs->destroy(fbh->fb);
>   
>   	drm_client_release(&fbh->client);
> -	drm_fb_helper_unprepare(fbh);
> -	kfree(fbh);
>   }
>   
>   static const struct fb_ops armada_fb_ops = {
> diff --git a/drivers/gpu/drm/clients/drm_fbdev_client.c b/drivers/gpu/drm/clients/drm_fbdev_client.c
> index f894ba52bdb5..5336accab1b6 100644
> --- a/drivers/gpu/drm/clients/drm_fbdev_client.c
> +++ b/drivers/gpu/drm/clients/drm_fbdev_client.c
> @@ -13,16 +13,28 @@
>    * struct drm_client_funcs
>    */
>   
> +static void drm_fbdev_client_free(struct drm_client_dev *client)
> +{
> +	struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
> +
> +	drm_fb_helper_unprepare(fb_helper);
> +	kfree(fb_helper);
> +}
> +
>   static void drm_fbdev_client_unregister(struct drm_client_dev *client)
>   {
>   	struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
>   
>   	if (fb_helper->info) {
> +		/*
> +		 * Fully probed framebuffer device
> +		 */
>   		drm_fb_helper_unregister_info(fb_helper);
>   	} else {
> +		/*
> +		 * Partially initialized client, no framebuffer device yet
> +		 */
>   		drm_client_release(&fb_helper->client);
> -		drm_fb_helper_unprepare(fb_helper);
> -		kfree(fb_helper);
>   	}
>   }
>   
> @@ -88,6 +100,7 @@ static int drm_fbdev_client_resume(struct drm_client_dev *client, bool holds_con
>   
>   static const struct drm_client_funcs drm_fbdev_client_funcs = {
>   	.owner		= THIS_MODULE,
> +	.free		= drm_fbdev_client_free,
>   	.unregister	= drm_fbdev_client_unregister,
>   	.restore	= drm_fbdev_client_restore,
>   	.hotplug	= drm_fbdev_client_hotplug,
> diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
> index 3fa38d4ac70b..fe9c6d7083ea 100644
> --- a/drivers/gpu/drm/drm_client.c
> +++ b/drivers/gpu/drm/drm_client.c
> @@ -168,6 +168,10 @@ void drm_client_release(struct drm_client_dev *client)
>   
>   	drm_client_modeset_free(client);
>   	drm_client_close(client);
> +
> +	if (client->funcs && client->funcs->free)
> +		client->funcs->free(client);
> +
>   	drm_dev_put(dev);
>   }
>   EXPORT_SYMBOL(drm_client_release);
> diff --git a/drivers/gpu/drm/drm_fbdev_dma.c b/drivers/gpu/drm/drm_fbdev_dma.c
> index 8bd626ef16c7..c6196293e424 100644
> --- a/drivers/gpu/drm/drm_fbdev_dma.c
> +++ b/drivers/gpu/drm/drm_fbdev_dma.c
> @@ -57,8 +57,6 @@ static void drm_fbdev_dma_fb_destroy(struct fb_info *info)
>   	drm_client_buffer_vunmap(fb_helper->buffer);
>   	drm_client_framebuffer_delete(fb_helper->buffer);
>   	drm_client_release(&fb_helper->client);
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>   }
>   
>   static const struct fb_ops drm_fbdev_dma_fb_ops = {
> @@ -92,8 +90,6 @@ static void drm_fbdev_dma_shadowed_fb_destroy(struct fb_info *info)
>   	drm_client_buffer_vunmap(fb_helper->buffer);
>   	drm_client_framebuffer_delete(fb_helper->buffer);
>   	drm_client_release(&fb_helper->client);
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>   }
>   
>   static const struct fb_ops drm_fbdev_dma_shadowed_fb_ops = {
> diff --git a/drivers/gpu/drm/drm_fbdev_shmem.c b/drivers/gpu/drm/drm_fbdev_shmem.c
> index 1e827bf8b815..51573058df6f 100644
> --- a/drivers/gpu/drm/drm_fbdev_shmem.c
> +++ b/drivers/gpu/drm/drm_fbdev_shmem.c
> @@ -65,8 +65,6 @@ static void drm_fbdev_shmem_fb_destroy(struct fb_info *info)
>   	drm_client_buffer_vunmap(fb_helper->buffer);
>   	drm_client_framebuffer_delete(fb_helper->buffer);
>   	drm_client_release(&fb_helper->client);
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>   }
>   
>   static const struct fb_ops drm_fbdev_shmem_fb_ops = {
> diff --git a/drivers/gpu/drm/drm_fbdev_ttm.c b/drivers/gpu/drm/drm_fbdev_ttm.c
> index 85feb55bba11..ccf460fbc1f0 100644
> --- a/drivers/gpu/drm/drm_fbdev_ttm.c
> +++ b/drivers/gpu/drm/drm_fbdev_ttm.c
> @@ -53,8 +53,6 @@ static void drm_fbdev_ttm_fb_destroy(struct fb_info *info)
>   	drm_client_framebuffer_delete(fb_helper->buffer);
>   
>   	drm_client_release(&fb_helper->client);
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>   }
>   
>   static const struct fb_ops drm_fbdev_ttm_fb_ops = {
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> index 93de25b77e68..a3bd21a827ad 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> @@ -42,8 +42,6 @@ static void exynos_drm_fb_destroy(struct fb_info *info)
>   	drm_framebuffer_remove(fb);
>   
>   	drm_client_release(&fb_helper->client);
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>   }
>   
>   static const struct fb_ops exynos_drm_fb_ops = {
> diff --git a/drivers/gpu/drm/gma500/fbdev.c b/drivers/gpu/drm/gma500/fbdev.c
> index a6af21514cff..bc92fa24a1e2 100644
> --- a/drivers/gpu/drm/gma500/fbdev.c
> +++ b/drivers/gpu/drm/gma500/fbdev.c
> @@ -84,9 +84,6 @@ static void psb_fbdev_fb_destroy(struct fb_info *info)
>   	drm_gem_object_put(obj);
>   
>   	drm_client_release(&fb_helper->client);
> -
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>   }
>   
>   static const struct fb_ops psb_fbdev_fb_ops = {
> diff --git a/drivers/gpu/drm/i915/display/intel_fbdev.c b/drivers/gpu/drm/i915/display/intel_fbdev.c
> index 3fbdf75415cc..d5f26c8bb102 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbdev.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbdev.c
> @@ -146,8 +146,6 @@ static void intel_fbdev_fb_destroy(struct fb_info *info)
>   	drm_framebuffer_remove(fb_helper->fb);
>   
>   	drm_client_release(&fb_helper->client);
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>   }
>   
>   __diag_push();
> diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
> index b5969374d53f..aad6fb77f0de 100644
> --- a/drivers/gpu/drm/msm/msm_fbdev.c
> +++ b/drivers/gpu/drm/msm/msm_fbdev.c
> @@ -52,8 +52,6 @@ static void msm_fbdev_fb_destroy(struct fb_info *info)
>   	drm_framebuffer_remove(fb);
>   
>   	drm_client_release(&helper->client);
> -	drm_fb_helper_unprepare(helper);
> -	kfree(helper);
>   }
>   
>   static const struct fb_ops msm_fb_ops = {
> diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> index 948af7ec1130..b5df2923d2a6 100644
> --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
> +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> @@ -103,8 +103,6 @@ static void omap_fbdev_fb_destroy(struct fb_info *info)
>   	drm_framebuffer_remove(fb);
>   
>   	drm_client_release(&helper->client);
> -	drm_fb_helper_unprepare(helper);
> -	kfree(helper);
>   }
>   
>   /*
> diff --git a/drivers/gpu/drm/radeon/radeon_fbdev.c b/drivers/gpu/drm/radeon/radeon_fbdev.c
> index dc81b0c2dbff..4df6c9167bf0 100644
> --- a/drivers/gpu/drm/radeon/radeon_fbdev.c
> +++ b/drivers/gpu/drm/radeon/radeon_fbdev.c
> @@ -184,8 +184,6 @@ static void radeon_fbdev_fb_destroy(struct fb_info *info)
>   	radeon_fbdev_destroy_pinned_object(gobj);
>   
>   	drm_client_release(&fb_helper->client);
> -	drm_fb_helper_unprepare(fb_helper);
> -	kfree(fb_helper);
>   }
>   
>   static const struct fb_ops radeon_fbdev_fb_ops = {
> diff --git a/drivers/gpu/drm/tegra/fbdev.c b/drivers/gpu/drm/tegra/fbdev.c
> index 1b70f5e164af..91aece6f34e0 100644
> --- a/drivers/gpu/drm/tegra/fbdev.c
> +++ b/drivers/gpu/drm/tegra/fbdev.c
> @@ -53,8 +53,6 @@ static void tegra_fbdev_fb_destroy(struct fb_info *info)
>   	drm_framebuffer_remove(fb);
>   
>   	drm_client_release(&helper->client);
> -	drm_fb_helper_unprepare(helper);
> -	kfree(helper);
>   }
>   
>   static const struct fb_ops tegra_fb_ops = {
> diff --git a/include/drm/drm_client.h b/include/drm/drm_client.h
> index bdd845e383ef..eecb8d6e15c7 100644
> --- a/include/drm/drm_client.h
> +++ b/include/drm/drm_client.h
> @@ -28,6 +28,16 @@ struct drm_client_funcs {
>   	 */
>   	struct module *owner;
>   
> +	/**
> +	 * @free:
> +	 *
> +	 * Called when the client gets unregistered. Implementations should
> +	 * release all client-specific data and free the memory.
> +	 *
> +	 * This callback is optional.
> +	 */
> +	void (*free)(struct drm_client_dev *client);
> +
>   	/**
>   	 * @unregister:
>   	 *

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)



^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2025-10-23 15:39 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-09 13:16 [PATCH 0/4] drm/client: Implement free callback for fbdev and log Thomas Zimmermann
2025-10-09 13:16 ` [PATCH 1/4] drm/client: Add client free callback to unprepare fb_helper Thomas Zimmermann
2025-10-09 13:32   ` Dmitry Baryshkov
2025-10-21 13:29   ` Tomi Valkeinen
2025-10-21 13:54   ` Patrik Jakobsson
2025-10-23 13:13   ` Thomas Zimmermann
2025-10-23 15:39   ` Thomas Zimmermann
2025-10-09 13:16 ` [PATCH 2/4] drm/log: Do not hold lock across drm_client_release() Thomas Zimmermann
2025-10-15  7:52   ` Jocelyn Falempe
2025-10-09 13:16 ` [PATCH 3/4] drm/log: Add free callback Thomas Zimmermann
2025-10-15  7:53   ` Jocelyn Falempe
2025-10-09 13:16 ` [PATCH 4/4] drm/client: Do not free client memory by default Thomas Zimmermann
2025-10-15  8:20   ` Jocelyn Falempe
2025-10-09 14:52 ` ✓ CI.KUnit: success for drm/client: Implement free callback for fbdev and log Patchwork
2025-10-09 15:27 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-09 21:17 ` ✗ Xe.CI.Full: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox